March 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR2335: riched20/tests: Don't specify DT_WORDBREAK in _check_txgetnaturalsize(). (#54637) - approved
by Alexandre Julliard (＠julliard) March 7, 2023

March 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2335

1 0

Re: [PATCH v2 0/3] MR2333: win32u / winex11: Avoid invalid writes on WOW64 with kernel-side Nt syscalls. - approved
by Alexandre Julliard (＠julliard) March 7, 2023

March 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2333

1 0

Re: [PATCH v5 0/3] MR2331: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze. - approved
by Alexandre Julliard (＠julliard) March 7, 2023

March 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2331

1 0

[PATCH 0/2] MR2345: Close the bytestream in IMFMediaSource::Shutdown.
by Derek Lesho (＠dlesho) March 7, 2023

March 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2345

3 4

[PATCH v5 0/4] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) March 7, 2023

March 7, 2023

-- v5: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Better handle framerate. winegstreamer: Add format field to wmv wg_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

5 13

[PATCH v6 0/2] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) March 7, 2023

March 7, 2023

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v6: ntoskrnl.exe: Add FltBuildDefaultSecurityDescriptor test https://gitlab.winehq.org/wine/wine/-/merge_requests/414

3 3

[PATCH 0/3] MR2333: win32u / winex11: Avoid invalid writes on WOW64 with kernel-side Nt syscalls.
by Rémi Bernon March 7, 2023

March 7, 2023

On WOW64, Nt calls expect a 64-bit IO_STATUS_BLOCK with .Pointer pointing to the 32-bit IOSB. When Nt calls are made from the unix side we need to initialize the pointer to NULL to, at least, discard the IOSB results and avoid invalid writes. There's the same problem in wineandroid.drv `android_ioctl`, but it is more complicated. The IOSB result is actually read, so instead of a NULL pointer it will need to point to a 32-bit IOSB, and to check whether the process is WOW64 or not when reading the result. It's more complicated and I preferred to not make the change. Note that anything that needs the IOSB result from the unix side will face the same problem, and it would maybe be nice to have a general solution. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2333

3 7

[PATCH v2 0/1] MR2342: Revert "server: Don't invalidate the newly exposed child region on the parent...
by Jinoh Kang (＠iamahuman) March 7, 2023

March 7, 2023

Revert "server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children." This reverts commit 33617af8145b6fadfe41d48968a728ff57b3064b. Apparently, the aforementioned commit might cause the expose region to be incorrectly computed when a window transitions from invisible state to visible state. The commit also had caused regression in the following apps: - Wine regedit.exe (bug 54268) - Dn-FamiTracker (bug 52903) - Unity Assets Bundle Extractor (same cause behind bug 52903) It appears that the commit catalyzes discovery of hidden bugs in Wine's window repaint logic. It's also possible that the algorithm for computing the expose region is incomplete. For these reasons, revert this commit for now. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54268 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52903 -- v2: Revert "server: Don't invalidate the newly exposed child region on the parent if it doesn't clip children." https://gitlab.winehq.org/wine/wine/-/merge_requests/2342

3 2

[PATCH 0/3] MR2340: Assorted spelling fixes
by Francois Gouget (＠fgouget) March 7, 2023

March 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2340

3 5

[PATCH 0/1] MR2344: dbghelp/tests: Let the tests run on Windows 7, 8 and 10 <= 1607.
by Francois Gouget (＠fgouget) March 7, 2023

March 7, 2023

Provide a fallback if IsWow64Process2() is not available. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54605 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2344

2 1

[PATCH 0/3] MR2343: Draft: collection of small fixes for Fusion 360
by novenary * (＠novenary) March 7, 2023

March 7, 2023

This fixes various problems I've run into while trying to use Fusion 360 in wine. - stacking issues in unmanaged mode - I also attempted to apply the same fix for managed mode, but it looks difficult to do this in a way that plays well with window managers; I think it's best left up to them to keep override_redirect windows at the top of the stack) - when the window manager sets our state to withdrawn, tell the window that it's been minimized, since the semantics are very similar - the last one is a hack because I don't really know what to do about it, when clicking on the floating popups, they gain focus, which causes wine to incorrectly make them managed and that breaks everything -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2343

2 3

[PATCH 0/1] MR2339: t2embed/tests: Fix the TTGetEmbeddingType() test in UTF-8 locales.
by Francois Gouget (＠fgouget) March 7, 2023

March 7, 2023

A screen-compatible memory DC uses a TrueType font by default in UTF-8 locales. This fixes the tests on w10pro64-en-AE-u8 and w10pro64-hi-u8. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2339

2 1

[PATCH v2 0/1] MR2335: riched20/tests: Don't specify DT_WORDBREAK in _check_txgetnaturalsize(). (#54637)
by Jinoh Kang (＠iamahuman) March 7, 2023

March 7, 2023

Today, test_TxGetNaturalSize() creates a pop-up window with a fixed size (extent) of 100 x 100. The test function then proceeds to compute the natural size of rich edit control that fits the sample text "TestSomeText" and compare it to the RECT calculated by DrawText. It appears that this test fails if the text width exceeds the width of the test window's client area. In this case, DrawText() with DT_WORDBREAK breaks the text into the two lines due to text wrapping; however, Rich Edit's ITextServices::TxGetNaturalSize implementation does not seem to perform text wrapping on overflow. This results in extent mismatch. In conclusion, the test may fail if the rendered width of the sample text "TestSomeText" is larger than what the test expects. This depends on the current font used for DEFAULT_GUI_FONT. Fix this by omitting the DT_WORDBREAK flag for the DrawText() call in _check_txgetnaturalsize(). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54637 -- v2: riched20/tests: Don't specify DT_WORDBREAK in _check_txgetnaturalsize(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2335

2 2

[PATCH 0/2] MR2336: mshtml: Assume navigation can happen during callbacks.
by Gabriel Ivăncescu March 7, 2023

March 7, 2023

This should fix some rare crashes in e.g. FFXIV Launcher (requires Proton patches to have it working though). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2336

2 3

[PATCH 0/1] MR2335: riched20/tests: Don't specify DT_WORDBREAK in _check_txgetnaturalsize(). (#54637)
by Jinoh Kang (＠iamahuman) March 7, 2023

March 7, 2023

Today, test_TxGetNaturalSize() creates a pop-up window with a fixed size (extent) of 100 x 100. The test function then proceeds to compute the natural size of rich edit control that fits the sample text "TestSomeText" and compare it to the RECT calculated by DrawText. It appears that this test fails if the text width exceeds the width of the test window's client area. In this case, DrawText() with DT_WORDBREAK breaks the text into the two lines due to text wrapping; however, Rich Edit's ITextServices::TxGetNaturalSize implementation does not seem to perform text wrapping on overflow. This results in extent mismatch. In conclusion, the test may fail if the rendered width of the sample text "TestSomeText" is larger than what the test expects. This depends on the current font used for DEFAULT_GUI_FONT. Fix this by omitting the DT_WORDBREAK flag for the DrawText() call in _check_txgetnaturalsize(). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54637 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2335

3 2

[PATCH v4 0/3] MR2331: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze.
by Jinoh Kang (＠iamahuman) March 7, 2023

March 7, 2023

-- v4: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze. riched20: Don't assume that TxDraw preserves the device context's brush selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2331

3 4

[PATCH 0/2] MR2337: pdh: Implement PdhVbGetDoubleCounterValue().
by Mohamad Al-Jaf (＠maljaf) March 7, 2023

March 7, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54618 If the handle passed is `(void *)0xdeadbeef` it crashes in Wine, but not in Windows. I'm guessing this is not very important. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2337

3 4

[PATCH 0/1] MR2338: maintainers: Assume maintainership of IME support.
by Rémi Bernon March 7, 2023

March 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2338

1 1

[PATCH v2 0/8] MR2292: windows.perception.stub: Implement ISpatialSurfaceObserverStatics2::IsSupported()
by Mohamad Al-Jaf (＠maljaf) March 7, 2023

March 7, 2023

Needed by the VR games Forewarned and Überlaüfer. I had to put the parameters of the header functions on newlines because they're too long. Did the same for the other headers for consistency. windows.security.cryptography.idl uses a similar style. -- v2: windows.perception.stub: Implement ISpatialSurfaceObserverStatics2::IsSupported(). windows.perception.stub/tests: Add ISpatialSurfaceObserverStatics2::IsSupported() tests. windows.perception.stub: Add ISpatialSurfaceObserverStatics2 stub interface. windows.perception.stub: Add ISpatialSurfaceObserverStatics stub interface. windows.perception.stub: Add DLL. include: Add windows.perception.spatial.surfaces.idl file. include: Add windows.graphics.directx.idl file. include: Add windows.perception.spatial.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2292

3 12

[PATCH v5 0/2] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) March 7, 2023

March 7, 2023

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v5: ntoskrnl.exe: Add FltBuildDefaultSecurityDescriptor test https://gitlab.winehq.org/wine/wine/-/merge_requests/414

3 3

[PATCH v4 0/3] MR414: fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor
by Alistair Leslie-Hughes (＠alesliehughes) March 7, 2023

March 7, 2023

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v4: ntoskrnl.exe: Add FltBuildDefaultSecurityDescriptor test fltmgr.sys: Create import library fltmgr.sys: Implement FltBuildDefaultSecurityDescriptor https://gitlab.winehq.org/wine/wine/-/merge_requests/414

3 4

[PATCH v2 0/1] MR2326: kernelbase: Add DiscardVirtualMemory() stub.
by Brendan Shanks (＠bshanks) March 7, 2023

March 7, 2023

This is required by the latest versions of Chromium. -- v2: kernelbase: Implement DiscardVirtualMemory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2326

4 4

[PATCH v2 0/2] MR2314: user32/tests: Do not stop checking the message list when skipping an optional or unsupported message.
by Zebediah Figura (＠zfigura) March 6, 2023

March 6, 2023

This was either added by accident, or in an attempt to stop checking the message list once we hit a winevent hook todo [and accidentally given too wide of a scope]. However, the same commit also uses a global counter to ensure that only one winevent todo is printed, so we don't need to break here anyway. Fixes: a72bffe768c9fe462010d7e40e20226322fb82c7 -- v2: user32/tests: Do not stop checking the message list when skipping an optional or unsupported message. user32/tests: Do not dump the message sequence when a todo succeeds on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/2314

3 4

[PATCH v23 0/5] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v23: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

1 6

Re: [PATCH v2 0/5] MR2322: wined3d: move stubs out of state tables - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2322

1 0

Re: [PATCH v5 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

1 0

Re: [PATCH v2 0/1] MR2332: ir50_32: Handle 24-bit output media type. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2332

1 0

Re: [PATCH v6 0/8] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

1 0

Re: [PATCH v2 0/5] MR2328: winevulkan: Update to VK spec version 1.3.242. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2328

1 0

Re: [PATCH v2 0/1] MR2323: gdiplus: Use transparency instead of background color if transparent color flag is set in GIF GCE. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2323

1 0

Re: [PATCH v2 0/2] MR2329: loader: In macOS preloader, move the top-down allocations area down and stop using mincore() - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2329

1 0

Re: [PATCH v2 0/1] MR2327: kernel32: Implement GetFirmwareType(). - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2327

1 0

Re: [PATCH v2 0/1] MR2324: advapi32/tests: Fix the RegEnumValueA() tests in UTF-8 locales. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2324

1 0

[PATCH v3 0/9] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) March 6, 2023

March 6, 2023

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- v3: vkd3d-shader/hlsl: Consider register() as manual packing for resource fields. tests: Test packoffset() with resources inside cbuffers. vkd3d-shader/hlsl: Ignore packoffset() contents for SM1. vkd3d-shader/hlsl: Don't allow manual and automatic cbuffer offset packing. vkd3d-shader/hlsl: Detect overlaps in cbuffer offsets. vkd3d-shader/hlsl: Support packoffset(). vkd3d-shader/hlsl: Parse packoffset(). tests: Test packoffset(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

3 12

[PATCH 0/12] MR2292: windows.perception.stub: Implement ISpatialSurfaceObserverStatics2::IsSupported()
by Mohamad Al-Jaf (＠maljaf) March 6, 2023

March 6, 2023

Needed by the VR games Forewarned and Überlaüfer. I had to put the parameters of the header functions on newlines because they're too long. Did the same for the other headers for consistency. windows.security.cryptography.idl uses a similar style. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2292

3 18

[PATCH 0/5] MR2322: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 6, 2023

March 6, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2322

4 7

[PATCH v2 0/3] MR115: vkd3d-shader/hlsl: Write sample count for multisampled resources declarations.
by Nikolay Sivov (＠nsivov) March 6, 2023

March 6, 2023

-- v2: vkd3d-shader/sm4: Write sample count field for multisampled texture declaration. vkd3d-shader/hlsl: Parse multisample texture type names. vkd3d-shader/trace: Output sample count for multisampled resources. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/115

3 4

[PATCH 0/1] MR2332: ir50_32: Handle 24-bit output media type.
by Anton Baskanov (＠baskanov) March 6, 2023

March 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47407 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2332

3 2

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Zebediah Figura (＠zfigura) March 6, 2023

March 6, 2023

> Thinking of doing this x11 specific, I think that maybe we don't even need a special boolean flag if your MR !2217 gets in? Once we have a separate tracking of internal pixel format in WGL_WINE_pixel_format_passthrough we could just always fail setting internal pixel format once external is set. The extension itself will still work as if an app wants to use GL together with d3d it will be able to set GL pixel format (which will result in wined3d creating a backup context). I think that'd work, yeah. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_26227

1 0

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Paul Gofman (＠gofman) March 6, 2023

March 6, 2023

I looked a bit into winemac driver and some GL on Mac docs and I suppose that such an issue should not be happening on Mac. If I read that right pixel format is only bound to GL context and the pixel format set by Wine only influences the contexts created with the window. I don't have any Mac setup however to check that for sure. If anyone could check if that referenced games (Richman: Classic in opengl mode or Secondhand Lands or SPORE from Bug 51848 work now on Mac without issues that would be a good confirmation that set pixel format works fine there and doesn't impose issues like on winex11. Thinking of doing this x11 specific, I think that maybe we don't even need a special boolean flag if your MR !2217 gets in? Once we have a separate tracking of internal pixel format in WGL_WINE_pixel_format_passthrough we could just always fail setting internal pixel format once external is set. The extension itself will still work as if an app wants to use GL together with d3d it will be able to set GL pixel format (which will result in wined3d creating a backup context). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_26224

1 0

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

On Wed Mar 1 12:24:02 2023 +0000, Alexandros Frantzis wrote: > > The last patch looks worrying in terms of forward-compatibility. > Looking at your wayland branch, you use a few unstable files. What > happens if/when they get promoted to stable? Will those files be moved > in wayland-protocols causing your branch to fail to build? > TL;DR: Not a problem. > When a protocol is moved to stable, a new copy is placed in that > directory (details are different depending on whether this copy is done > from 'staging' or the legacy 'unstable'), while the old xml file(s) > remain in place for backward compatibility. If the new copy requires a > protocol name change (e.g., from unstable->stable, but not > staging->stable) compositors tend to have a long deprecation period > during which both old and new names are supported. As an example, it > took compositors several years to drop support for unstable/xdg-shell > after the introduction of stable/xdg-shell. > FWIW, the Wayland community is *very* conservative concerning promotions > to stable, so a lot of functionality is still in unstable/staging. > Compare: 3 stable protocols vs 27 staging/unstable, some of them having > been there for many years. > More information about these topics can be found at https://gitlab.freedesktop.org/wayland/wayland-protocols/ > > Also, it would be better to have commit adding build system support > for protocol files together with at least a simple use of it in the same MR. > Ack. Moved to the next MR. Thanks for explanation, staging backward compatibility guarantees should do the trick. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26223

1 0

[PATCH v4 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces.
by Connor McAdams (＠cmcadams) March 6, 2023

March 6, 2023

-- v4: uiautomationcore: Implement IUIAutomation::get_RawViewCondition. uiautomationcore: Implement IUIAutomation::get_ControlViewCondition. uiautomationcore: Implement IUIAutomation::CreateOrCondition. uiautomationcore: Implement IUIAutomation::CreateNotCondition. uiautomationcore: Implement IUIAutomation::CreatePropertyCondition. uiautomationcore: Implement IUIAutomation::Create{True,False}Condition. https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

3 9

[PATCH v2 0/1] MR113: vkd3d-shader/dxbc: Validate and skip the signature section header size.
by Conor McCarthy (＠cmccarthy) March 6, 2023

March 6, 2023

Silences a very common warning. -- v2: vkd3d-shader/dxbc: Validate and skip the signature section header size. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/113

4 5

[PATCH v22 0/5] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v22: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. windows.media.speech: Add Vosk checks to autoconf. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 6

[PATCH v21 0/7] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v21: windows.media.speech: Implement Vosk create and release functions in the unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 8

[PATCH v20 0/7] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v20: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. TEMP: Reconf. windows.media.speech: Add Vosk checks to autoconf. makedep: Better differentiate between compiling and linking commands. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 8

[PATCH v19 0/5] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v19: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. windows.media.speech: Add Vosk checks to autoconf. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

3 12

[PATCH v2 0/4] MR2334: user32: Add some ActivateKeyboardLayout tests and send WM_INPUTLANGCHANGE.
by Rémi Bernon March 6, 2023

March 6, 2023

-- v2: win32u: Send WM_INPUTLANGCHANGE when activating new layout. win32u: Move window query functions around. user32/tests: Add a WM_INPUTLANGCHANGE message test. user32/tests: Skip tests if layout failed to activate. https://gitlab.winehq.org/wine/wine/-/merge_requests/2334

2 6

[PATCH 0/4] MR2334: user32: Add some ActivateKeyboardLayout tests and send WM_INPUTLANGCHANGE.
by Rémi Bernon March 6, 2023

March 6, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2334

2 5

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about dlls/winewayland.drv/wayland.c: > +{ > + struct wl_display *wl_display_wrapper; > + > + TRACE("wayland=%p wl_display=%p\n", wayland, process_wl_display); > + > + wl_list_init(&wayland->thread_link); > + > + wayland->process_id = GetCurrentProcessId(); > + wayland->thread_id = GetCurrentThreadId(); > + wayland->wl_display = process_wl_display; > + > + if (!wayland->wl_display) > + { > + ERR("Failed to connect to wayland compositor\n"); > + return FALSE; > + } I think that this error condition can never happen, we fail to load the driver if process_wl_display is NULL. Also, if wl_display is always equal to process_wl_display, why do we need to store it in wayland struct? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26192

1 0

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about dlls/winewayland.drv/wayland.c: > + > +/********************************************************************** > + * wayland_init > + * > + * Initialise a wayland instance. > + */ > +BOOL wayland_init(struct wayland *wayland) > +{ > + struct wl_display *wl_display_wrapper; > + > + TRACE("wayland=%p wl_display=%p\n", wayland, process_wl_display); > + > + wl_list_init(&wayland->thread_link); > + > + wayland->process_id = GetCurrentProcessId(); > + wayland->thread_id = GetCurrentThreadId(); Those are redundant for this commit. It's trivial to add when needed and introducing it later would make things much easier to review, because reviewer would need to jump between MR and your branch much less. I would suggest to leave thread_link, thread_id, process_id and initialized out of this MR. (Also, if process_id is always equal to `GetCurrentProcessId()`, I don't think there is much point in storing it). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26191

1 0

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about configure.ac: > [enable_winex11_drv]) > fi > > +WINE_NOTICE_WITH(wayland, [false], > + [Wayland ${notice_platform}development files not found, the Wayland driver won't be supported.], > + [enable_winewayland_drv]) > + This chunk makes little sense on its own, it could just be added in a commit that introduces wayland-client checks. This commit doesn't really need to modify configure more than what tools/make_makefiles does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26190

1 0

[PATCH v5 0/5] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions
by Davide Beatrici (＠davidebeatrici) March 6, 2023

March 6, 2023

The goal is to eventually move all interfaces from each driver's `mmdevdrv.c` into `mmdevapi`. -- v5: wine{alsa,coreaudio,oss,pulse}: Move test_connect handling into mmdevapi. mmdevapi: Use UTF-16 for client name in "test_connect_params" and "create_stream_params" structs. winepulse: Move process_attach and process_detach handling into mmdevapi. mmdevapi: Query MemoryWineUnixFuncs virtual memory and store the resulting handle. wine{alsa,coreaudio,oss,pulse}: Return STATUS_SUCCESS for unused unixlib functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

3 6

[PATCH v5 0/2] MR2168: win32u: Match second name when enum fonts.
by Keming Liang (＠Keming) March 6, 2023

March 6, 2023

the patch can resolve the issue: https://bugs.winehq.org/show_bug.cgi?id=54483 and can also solve many crashed issue related to font(MS Shell Dlg etc.) -- v5: add font test for MS Shell Dlg when Language is Chinese. win32u: Match second name when enum fonts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2168

2 2

[PATCH v3 0/3] MR2331: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze.
by Jinoh Kang (＠iamahuman) March 4, 2023

March 4, 2023

-- v3: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze. https://gitlab.winehq.org/wine/wine/-/merge_requests/2331

3 4

[PATCH v2 0/3] MR2331: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze.
by Jinoh Kang (＠iamahuman) March 4, 2023

March 4, 2023

-- v2: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze. riched20: Don't assume that TxDraw preserves the device context's brush selection. riched20/tests: Test for ITextDocument::Freeze and ITextDocument::Unfreeze. https://gitlab.winehq.org/wine/wine/-/merge_requests/2331

3 4

[PATCH 0/3] MR2331: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze.
by Jinoh Kang (＠iamahuman) March 4, 2023

March 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2331

2 3

[PATCH 0/1] MR2326: kernelbase: Add DiscardVirtualMemory() stub.
by Brendan Shanks (＠bshanks) March 4, 2023

March 4, 2023

This is required by the latest versions of Chromium. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2326

4 4

[PATCH 0/1] MR115: vkd3d-shader/trace: Output sample count for multisampled resources.
by Nikolay Sivov (＠nsivov) March 4, 2023

March 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/115

2 1

[PATCH v3 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces.
by Connor McAdams (＠cmcadams) March 3, 2023

March 3, 2023

-- v3: uiautomationcore: Implement IUIAutomation::get_RawViewCondition. uiautomationcore: Implement IUIAutomation::get_ControlViewCondition. uiautomationcore: Implement IUIAutomation::CreateOrCondition. uiautomationcore: Implement IUIAutomation::CreateNotCondition. uiautomationcore: Implement IUIAutomation::CreatePropertyCondition. uiautomationcore: Implement IUIAutomation::Create{True,False}Condition. https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

3 12

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Zebediah Figura (＠zfigura) March 3, 2023

March 3, 2023

> Do you see any other way out of this? I mean specifically the case when an app sets GL pixel format itself on a window. I was thinking about whether it is possible to make setpixelformat quicker in winex11 instead and I don't see how. If keeping direct presentation it will require some X window reconfigure which is not going to be anywhere quick. Otherwise, it can be technically made to work like for GL child window redering (keeping composite redirected drawables for different pixel formats) but that requires essentially the same blitting on each present as done with wined3d backup context. > > The other different (but a bit complicated) way would be to: > > * count statistics of GL pixel format switches; > * introduce switching back from backup context and switch between resetting pixel format or switching to backup context or back based on that. Assuming that recreating the GLX drawable is always worse than a GDI blit, I think this patch is the right direction. I just don't want to regress performance in backends other than x11. So maybe the right approach here is to add some boolean flag saying "return an error if changing the pixel format would be expensive". Or maybe things are already broken on winemac and the right approach is just to punt. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_26147

1 0

[PATCH 0/1] MR2323: gdiplus: Use transparency instead of background color if transparent color flag is set in GIF GCE.
by Piotr Caban (＠piotr) March 3, 2023

March 3, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54563 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2323

3 5

Re: [PATCH v2 0/1] MR2321: windowscodecs: Don't reorder gif extension blocks in GetReaderByIndex. - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2321

1 0

Re: [PATCH v2 0/2] MR2319: explorer: Fix systray window creation failure with nulldrv. - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2319

1 0

Re: [PATCH v2 0/3] MR2318: win32u: Fix a few nulldrv failures in ToUnicode and GetDeviceCaps(dc, BITSPIXEL). - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2318

1 0

Re: [PATCH v2 0/2] MR2315: d3d8, d3d9: WM_SYSCOMMAND test fixes. - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2315

1 0

Re: [PATCH v2 0/1] MR2317: include: Add more Windows.Foundation.Numerics structs. - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2317

1 0

[PATCH 0/2] MR2329: loader: In macOS preloader, move the top-down allocations area down and stop using mincore()
by Brendan Shanks (＠bshanks) March 3, 2023

March 3, 2023

`mincore()` is not a reliable way to determine whether a region is empty. This could result in an already-in-use region being mapped with `MAP_FIXED`, and Wine conflicting with its original owner (i.e. dyld). With the `mincore()` check removed, a special case was added to allow zero-fill sections to be mapped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2329

2 2

[PATCH 0/5] MR2328: winevulkan: Update to VK spec version 1.3.242.
by Georg Lehmann (＠DadSchoorse) March 3, 2023

March 3, 2023

Not trivial this time because VulkanSC was added to the xml. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2328

2 5

[PATCH 0/1] MR2327: kernel32: Implement GetFirmwareType().
by Brendan Shanks (＠bshanks) March 3, 2023

March 3, 2023

Chromium used to resolve this function through GetProcAddress(), but now calls it directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2327

2 1

[PATCH 0/1] MR2321: windowscodecs: Don't reorder gif extension blocks in GetReaderByIndex.
by Piotr Caban (＠piotr) March 3, 2023

March 3, 2023

The code that reorders extension blocks is broken and causes some extensions to be not reported (when GCE is not the last extension block). This fixes GCE blocks reading from gifs attached in [bug 54563](https://bugs.winehq.org/show_bug.cgi?id=54563). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2321

3 2

[PATCH 0/2] MR2319: explorer: Fix systray window creation failure with nulldrv.
by Rémi Bernon March 3, 2023

March 3, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2319

2 3

[PATCH 0/3] MR2318: win32u: Fix a few nulldrv failures in ToUnicode and GetDeviceCaps(dc, BITSPIXEL).
by Rémi Bernon March 3, 2023

March 3, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2318

2 4

[PATCH v2 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces.
by Connor McAdams (＠cmcadams) March 3, 2023

March 3, 2023

-- v2: uiautomationcore: Implement IUIAutomation::get_RawViewCondition. uiautomationcore: Implement IUIAutomation::get_ControlViewCondition. uiautomationcore: Implement IUIAutomation::CreateOrCondition. uiautomationcore: Implement IUIAutomation::CreateNotCondition. uiautomationcore: Implement IUIAutomation::CreatePropertyCondition. uiautomationcore: Implement IUIAutomation::Create{True,False}Condition. https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

2 7

[PATCH 0/1] MR111: vkd3d-shader/hlsl: Improve handling of "technique" tokens.
by Nikolay Sivov (＠nsivov) March 3, 2023

March 3, 2023

This change only implements case-sensitivity of technique keywords and related checks when corresponding profile is used. My immediate plan is to add some synthetic type for technique variables, for example as {object, void}, then add named techniques as variables. This is useful because these names are participating in global scope, and should not collide with normal variables. After that "pass_list" will be split, at least in two variants because of how much d3d9 syntax differs. Some trivial changes will be need later to have some top level fx compilation helper that considers only fx objects and calls ps/vs/gs compiler to create inner shader blobs on same original source. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/111

4 17

[PATCH 0/1] MR2324: advapi32/tests: Fix the RegEnumValueA() tests in UTF-8 locales.
by Francois Gouget (＠fgouget) March 3, 2023

March 3, 2023

On Windows RegEnumValueA() is buggy such that when the value name buffer is too small, it may way overestimate the required data buffer size, sometimes returning more than the sufficiently large buffer it was provided, in which case that buffer is untouched and thus not NUL-terminated. So modify the tests to accept this broken result and avoid checking out-of-bounds data. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=53172 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2324

2 1

[PATCH 0/5] MR2316: ddraw: SetSurfaceDesc() refactoring, part 2.
by Zebediah Figura (＠zfigura) March 3, 2023

March 3, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2316

4 7

[PATCH 0/1] MR2312: nsi: Simplify and better document NsiAllocateAndGetTable().
by Francois Gouget (＠fgouget) March 3, 2023

March 3, 2023

Return directly in case of success so exiting the loop only happens in case of error. Better identify which statements prepare the next attempt / set things up in case the table allocation failed. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2312

3 4

[PATCH v5 0/1] MR1987: webservices/tests: Move firewall code to a common header.
by Hans Leidekker (＠hans) March 3, 2023

March 3, 2023

-- v5: webservices/tests: Move firewall code to a common header. https://gitlab.winehq.org/wine/wine/-/merge_requests/1987

3 2

[PATCH v4 0/2] MR2168: win32u: Match second name when enum fonts.
by Keming Liang (＠Keming) March 3, 2023

March 3, 2023

the patch can resolve the issue: https://bugs.winehq.org/show_bug.cgi?id=54483 and can also solve many crashed issue related to font(MS Shell Dlg etc.) -- v4: add font test for MS Shell Dlg when Language is Chinese. https://gitlab.winehq.org/wine/wine/-/merge_requests/2168

3 6

[PATCH 0/1] MR113: vkd3d-shader/dxbc: Validate and skip the signature section header size.
by Conor McCarthy (＠cmccarthy) March 3, 2023

March 3, 2023

Silences a very common warning. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/113

2 1

[PATCH v2 0/1] MR2320: ntdll: Handle aarch64 pointer authentication in unwind info
by Martin Storsjö March 3, 2023

March 3, 2023

These were docmented in [1] (with the user-facing name of the opcode adjusted later in [2]). Since MSVC 2022, the precompiled runtimes (both runtimes such as vcruntime140*.dll and the statically linked code from e.g. libcmt.lib) are built with pointer authentication enabled. To correctly handle unwinding through such functions, even on HW that don't support the pointer authentication mechanism itself, wine needs to at least be aware of it (for handling the cases with packed unwind info with CR==2 simiarly to CR==3). This patch has been tested on Linux on HW supporting pointer authentication too, with binaries built with MSVC. [1] https://github.com/MicrosoftDocs/cpp-docs/commit/f510c83085d9764b3c7b522219… [2] https://github.com/MicrosoftDocs/cpp-docs/commit/cac237d3f370a06b71f6c314a6… -- v2: ntdll: Handle aarch64 pointer authentication in unwind info https://gitlab.winehq.org/wine/wine/-/merge_requests/2320

1 1

[PATCH 0/1] MR2320: ntdll: Handle aarch64 pointer authentication in unwind info
by Martin Storsjö March 3, 2023

March 3, 2023

These were docmented in [1] (with the user-facing name of the opcode adjusted later in [2]). Since MSVC 2022, the precompiled runtimes (both runtimes such as vcruntime140*.dll and the statically linked code from e.g. libcmt.lib) are built with pointer authentication enabled. To correctly handle unwinding through such functions, even on HW that don't support the pointer authentication mechanism itself, wine needs to at least be aware of it (for handling the cases with packed unwind info with CR==2 simiarly to CR==3). This patch has been tested on Linux on HW supporting pointer authentication too, with binaries built with MSVC. [1] https://github.com/MicrosoftDocs/cpp-docs/commit/f510c83085d9764b3c7b522219… [2] https://github.com/MicrosoftDocs/cpp-docs/commit/cac237d3f370a06b71f6c314a6… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2320

1 1

[PATCH v3 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations.
by Alex Henrie (＠alexhenrie) March 3, 2023

March 3, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275 A version of this patch has been in Wine Staging since March 2020. -- v3: winemenubuilder: Skip desktop integration for certain associations. https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

3 2

[PATCH v4 0/8] MR1259: gitlab: Run some tests with nulldrv driver.
by Rémi Bernon March 3, 2023

March 3, 2023

Allowing the job to fail to avoid failing the pipeline. Some new tests are failing with it, and some are succeeding todo_wine. -- v4: gitlab: Run user32 32-bit tests with nulldrv driver. user32/tests: Update todos specific to the X11 display driver. user32/tests: Check graphics driver and add todos for nulldrv. win32u: Check GUID_NULL display device if desktop atom is missing. explorer: Use GUID_NULL display device GUID for nulldrv. win32u: Return the current display mode depth with nulldrv. win32u: Map VK_MENU / KBDALT in kbdus_tables pCharModifiers. user32/tests: Test VK_MENU effect on ToUnicode. https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

1 9

[PATCH v4 0/5] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions
by Davide Beatrici (＠davidebeatrici) March 3, 2023

March 3, 2023

The goal is to eventually move all interfaces from each driver's `mmdevdrv.c` into `mmdevapi`. -- v4: wine{alsa,coreaudio,oss,pulse}: Move test_connect handling into mmdevapi. mmdevapi: Use UTF-16 for client name in "test_connect_params" and "create_stream_params" structs. winepulse: Move process_attach and process_detach handling into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

3 6

[PATCH 0/2] MR2315: d3d8, d3d9: WM_SYSCOMMAND test fixes.
by Zebediah Figura (＠zfigura) March 3, 2023

March 3, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2315

3 3

[PATCH 0/1] MR2317: include: Add more Windows.Foundation.Numerics structs.
by Mohamad Al-Jaf (＠maljaf) March 3, 2023

March 3, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2317

3 4

[PATCH 0/1] MR2314: user32/tests: Do not stop checking the message list when skipping an optional or unsupported message.
by Zebediah Figura (＠zfigura) March 3, 2023

March 3, 2023

This was either added by accident, or in an attempt to stop checking the message list once we hit a winevent hook todo [and accidentally given too wide of a scope]. However, the same commit also uses a global counter to ensure that only one winevent todo is printed, so we don't need to break here anyway. Fixes: a72bffe768c9fe462010d7e40e20226322fb82c7 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2314

3 2

Re: [PATCH v11 0/1] MR1892: ntoskrnl.exe/tests: Add Driver Object Extension Tests. - approved
by Alexandre Julliard (＠julliard) March 2, 2023

March 2, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1892

1 0

Re: [PATCH v2 0/5] MR2309: ddraw: SetSurfaceDesc() refactoring, part 1. - approved
by Alexandre Julliard (＠julliard) March 2, 2023

March 2, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2309

1 0

Re: [PATCH v2 0/5] MR2310: wined3d: move stubs out of state tables - approved
by Alexandre Julliard (＠julliard) March 2, 2023

March 2, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2310

1 0

Re: [PATCH v2 0/2] MR2313: shlwapi/tests: Fix the date formatting tests when the locale does not match the code page. - approved
by Alexandre Julliard (＠julliard) March 2, 2023

March 2, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2313

1 0

Re: [PATCH v10 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing - approved
by Alexandre Julliard (＠julliard) March 2, 2023

March 2, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2282

1 0

Re: [PATCH v3 0/2] MR2302: gdiplus: Use FILE_SHARE_READ in GdipPrivateAddFontFile(). - approved
by Alexandre Julliard (＠julliard) March 2, 2023

March 2, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2302

1 0

Re: [PATCH v10 0/1] MR2153: win32u: Invalidate all cached keys after input. - approved
by Alexandre Julliard (＠julliard) March 2, 2023

March 2, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2153

1 0

[PATCH v2 0/9] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) March 2, 2023

March 2, 2023

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- v2: vkd3d-shader/hlsl: Consider register() as manual packing for resource fields. tests: Test packoffset() with resources inside cbuffers. vkd3d-shader/hlsl: Ignore packoffset() contents for SM1. vkd3d-shader/hlsl: Don't allow manual and automatic cbuffer offset packing. vkd3d-shader/hlsl: Detect overlaps in cbuffer offsets. vkd3d-shader/hlsl: Support packoffset(). vkd3d-shader/hlsl: Parse packoffset(). tests: Test packoffset(). tests: Test cbuffer element offsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

4 36

[PATCH v5 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Alex Henrie (＠alexhenrie) March 2, 2023

March 2, 2023

-- v5: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them. setupapi: Handle NULL in string allocation functions and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/1746

2 2

[PATCH 0/5] MR2309: ddraw: SetSurfaceDesc() refactoring, part 1.
by Zebediah Figura (＠zfigura) March 2, 2023

March 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2309

4 7

[PATCH 0/5] MR2310: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 2, 2023

March 2, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2310

4 7