March 2023 - Wine-GitLab - list.winehq.org

[PATCH v7 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) March 28, 2023

March 28, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by ~~only opening the file with write access where necessary~~ temporarily modifying file access permisions to allow the file to be opened. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v7: server: Allow to open files without permission bits. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

3 5

[PATCH 0/11] MR2522: wineps: Add support for more spool file records
by Piotr Caban (＠piotr) March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2522

3 12

[PATCH v5 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection
by Vijay Kiran Kamuju (＠infyquest) March 28, 2023

March 28, 2023

Add stub implementation for _UnrealizedChore::CheckTaskCollection https://bugs.winehq.org/show_bug.cgi?id=53794 -- v5: msvcr100: Add _UnrealizedChore::_CheckTaskCollection stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2429

3 3

[PATCH v3 0/1] MR2482: dwrite: Use cache when font transform matrix contains only translation offsets.
by Zhiyi Zhang (＠zhiyi) March 28, 2023

March 28, 2023

Word 2016 queries a lot of font glyph bounding boxes and bitmaps with translation matrices. The result of these queries is not cached because the transform matrix is not the identity matrix. However, the translation offsets don't affect FreeType font operations at all, which can be verified in ft_matrix_from_dwrite_matrix() called by get_glyph_transform(). So these results with translation matrices can be cached as well. With this patch, Word 2016 stuttering is reduced significantly. -- v3: dwrite: Use cache when font transform matrix contains only translation offsets. https://gitlab.winehq.org/wine/wine/-/merge_requests/2482

3 3

[PATCH 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Rémi Bernon March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520

3 14

[PATCH v6 0/4] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) March 28, 2023

March 28, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v6: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES server: Open files for writing with O_WRONLY not O_RDWR if FILE_READ_ATTRIBUTES is also requested https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

4 9

[PATCH v10 0/3] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) March 28, 2023

March 28, 2023

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. -- v10: ntdll: Add thread_get_register_pointer_values-based implementation of NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based implementation of NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based implementation of NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

2 3

[PATCH 0/1] MR2418: ucrtbase: adding CxxFrameHandler4 to spec
by James McDonnell (＠ElementalWarrior) March 28, 2023

March 28, 2023

Add missing function to spec for affinity photo -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2418

3 4

[PATCH 0/1] MR2519: wldap32: Stub out setting LDAP_OPT_REFERRAL_HOP_LIMIT.
by Alex Henrie (＠alexhenrie) March 28, 2023

March 28, 2023

https://bugs.winehq.org/show_bug.cgi?id=54727 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2519

3 2

[PATCH 0/1] MR2521: msado15: Handle DBTYPE_STR type when loading recordset data
by Alistair Leslie-Hughes (＠alesliehughes) March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2521

3 2

[PATCH v2 0/7] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) March 28, 2023

March 28, 2023

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and implementing GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own in the first commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR adds a shared memory region containing an authoritative version of the Wayland output information (see the "winewayland.drv: Implement GetCurrentDisplaySettings." commit for more details). Thanks! -- v2: winewayland.drv: Update desktop window size on display changes. winewayland.drv: Update registry settings after monitor changes. winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Handle wl_output objects only in the desktop process. winewayland.drv: Implement GetCurrentDisplaySettings. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

5 20

[PATCH v2 0/1] MR2521: msado15: Handle DBTYPE_STR type when loading recordset data
by Alistair Leslie-Hughes (＠alesliehughes) March 28, 2023

March 28, 2023

-- v2: msado15: Handle DBTYPE_STR type when loading recordset data https://gitlab.winehq.org/wine/wine/-/merge_requests/2521

2 1

[PATCH v11 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 28, 2023

March 28, 2023

This is what it looks like: ![Screenshot_20230310_015941](/uploads/99b3d279bcddbd40212808a045444a7b/Screenshot_20230310_015941.png) -- v11: winecfg: Add an option to set WinRT app dark theme. https://gitlab.winehq.org/wine/wine/-/merge_requests/2183

2 2

[PATCH v4 0/4] MR2387: winegstreamer: Use codec format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) March 28, 2023

March 28, 2023

According to the tests in 23b72ad, when we are reading a compressed stream, the type returned by `stream_props_GetMediaType()` should reflect compressed format even if we finnally output uncomressed data. For example, if we use wmvcore reader to read a WMV3 stream and output RGB24, the format information returned by `stream_props_GetMediaType()` should be WMV3, not RGB24. This patch set is marked as draft now, because PATCH 2 and PATCH 3 is affected by 3e8936a2 in MR !2258. So I'll submit a newer version of this after !2258 get merged. -- v4: winegstreamer: Use codec format in stream_props_GetMediaType. winegstreamer: Implement amt_from_wg_format_video_wmv. winegstreamer: Implement wg_format_from_caps_video_wmv. winegstreamer: Implement wg_parser_stream_get_codec_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/2387

3 5

[PATCH 0/6] MR2518: Fixes and improvements for taskschd:scheduler
by Francois Gouget (＠fgouget) March 28, 2023

March 28, 2023

* Deleting tasks & folders requires elevated privileges on Windows 7. * Elevated privileges are needed to connect using a hostname. * Use a winetest context in the scheduler loops. * Use wide character string literals in scheduler.c. * Store the xml definitions as wide string literals in scheduler.c. * Use __HRESULT_FROM_WIN32() to initialize constants. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2518

2 6

[PATCH v5 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) March 28, 2023

March 28, 2023

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v5: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. win32u: Set DEVPKEY_Device_BusNumber for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

3 4

[PATCH v2 0/3] MR2478: wined3d: Make video memory accounting a per-resource flag.
by Stefan Dösinger March 27, 2023

March 27, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54701 --- The private draw texture did not get evicted on reset(), causing us to try to read from a non-existent texture with the new contest. For more details see comment 9 on the bug. -- v2: ddraw/tests: Show that SYSMEM | 3DDEVICE surfaces don't consume vidmem. ddraw/tests: Native 64 bit ddraw has a video memory leak. wined3d: Make video memory accounting a per-resource flag. https://gitlab.winehq.org/wine/wine/-/merge_requests/2478

3 7

[PATCH v6 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) March 27, 2023

March 27, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v6: vkd3d-shader/hlsl: Evaluate index before array. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. vkd3d-shader/hlsl: Introduce hlsl_ir_index. tests: Test indexing of non-loads. tests: Test side effects on indexes. tests: Test matrix indexing on the lhs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

4 12

[PATCH v14 0/6] MR1145: kernel32: Implement various transacted file APIs.
by Etaash Mathamsetty (＠etaash.mathamsetty) March 27, 2023

March 27, 2023

a hotfix for the recent release of Persona 5 Royal. -- v14: kernel32: Add semi-stub for RemoveDirectoryTransactedA/W(). kernel32: Add semi-stub for GetFileAttributesTransactedA/W(). kernel32: Add semi-stub for FindFirstFileTransactedA/W(). kernel32: Add semi-stub for DeleteFileTransactedA/W(). kernel32: Add semi-stub for CreateDirectoryTransactedA/W(). kernel32: Add semi-stub for CreateFileTransactedA/W(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1145

2 6

[PATCH 0/1] MR2498: msado15: Implement _Recordset Find
by Alistair Leslie-Hughes (＠alesliehughes) March 27, 2023

March 27, 2023

Find only supports one Column to filter on. The parser for this will be the same for both Find/Filter with the only different is the Filter supports multiple columns. In trying to keep this patch small, only WSTR/BSTR/Integer have been supported. (The Common cases). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2498

3 22

Re: [PATCH v4 0/7] MR2511: dinput: More tests and fixes for BuildActionMap and EnumDevicesBySemantics. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2511

1 0

Re: [PATCH v3 0/4] MR2470: uiautomationcore: Fix/extend some tests, implement UIA_ProviderDescriptionPropertyId. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2470

1 0

Re: [PATCH v3 0/1] MR2508: wldap32: Implement setting LDAP_OPT_SSL and add tests. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2508

1 0

Re: [PATCH v2 0/5] MR2516: Fixes and improvements for schedsvc:rpcapi - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2516

1 0

Re: [PATCH v2 0/2] MR2517: schtasks/tests: Deleting folders requires elevated privileges on Windows 7 & 8. - approved
by Alexandre Julliard (＠julliard) March 27, 2023

March 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2517

1 0