March 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

1 0

Re: [PATCH v2 0/1] MR2332: ir50_32: Handle 24-bit output media type. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2332

1 0

Re: [PATCH v6 0/8] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

1 0

Re: [PATCH v2 0/5] MR2328: winevulkan: Update to VK spec version 1.3.242. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2328

1 0

Re: [PATCH v2 0/1] MR2323: gdiplus: Use transparency instead of background color if transparent color flag is set in GIF GCE. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2323

1 0

Re: [PATCH v2 0/2] MR2329: loader: In macOS preloader, move the top-down allocations area down and stop using mincore() - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2329

1 0

Re: [PATCH v2 0/1] MR2327: kernel32: Implement GetFirmwareType(). - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2327

1 0

Re: [PATCH v2 0/1] MR2324: advapi32/tests: Fix the RegEnumValueA() tests in UTF-8 locales. - approved
by Alexandre Julliard (＠julliard) March 6, 2023

March 6, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2324

1 0

[PATCH v3 0/9] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) March 6, 2023

March 6, 2023

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- v3: vkd3d-shader/hlsl: Consider register() as manual packing for resource fields. tests: Test packoffset() with resources inside cbuffers. vkd3d-shader/hlsl: Ignore packoffset() contents for SM1. vkd3d-shader/hlsl: Don't allow manual and automatic cbuffer offset packing. vkd3d-shader/hlsl: Detect overlaps in cbuffer offsets. vkd3d-shader/hlsl: Support packoffset(). vkd3d-shader/hlsl: Parse packoffset(). tests: Test packoffset(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

3 12

[PATCH 0/12] MR2292: windows.perception.stub: Implement ISpatialSurfaceObserverStatics2::IsSupported()
by Mohamad Al-Jaf (＠maljaf) March 6, 2023

March 6, 2023

Needed by the VR games Forewarned and Überlaüfer. I had to put the parameters of the header functions on newlines because they're too long. Did the same for the other headers for consistency. windows.security.cryptography.idl uses a similar style. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2292

3 18

[PATCH 0/5] MR2322: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) March 6, 2023

March 6, 2023

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2322

4 7

[PATCH v2 0/3] MR115: vkd3d-shader/hlsl: Write sample count for multisampled resources declarations.
by Nikolay Sivov (＠nsivov) March 6, 2023

March 6, 2023

-- v2: vkd3d-shader/sm4: Write sample count field for multisampled texture declaration. vkd3d-shader/hlsl: Parse multisample texture type names. vkd3d-shader/trace: Output sample count for multisampled resources. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/115

3 4

[PATCH 0/1] MR2332: ir50_32: Handle 24-bit output media type.
by Anton Baskanov (＠baskanov) March 6, 2023

March 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47407 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2332

3 2

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Zebediah Figura (＠zfigura) March 6, 2023

March 6, 2023

> Thinking of doing this x11 specific, I think that maybe we don't even need a special boolean flag if your MR !2217 gets in? Once we have a separate tracking of internal pixel format in WGL_WINE_pixel_format_passthrough we could just always fail setting internal pixel format once external is set. The extension itself will still work as if an app wants to use GL together with d3d it will be able to set GL pixel format (which will result in wined3d creating a backup context). I think that'd work, yeah. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_26227

1 0

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Paul Gofman (＠gofman) March 6, 2023

March 6, 2023

I looked a bit into winemac driver and some GL on Mac docs and I suppose that such an issue should not be happening on Mac. If I read that right pixel format is only bound to GL context and the pixel format set by Wine only influences the contexts created with the window. I don't have any Mac setup however to check that for sure. If anyone could check if that referenced games (Richman: Classic in opengl mode or Secondhand Lands or SPORE from Bug 51848 work now on Mac without issues that would be a good confirmation that set pixel format works fine there and doesn't impose issues like on winex11. Thinking of doing this x11 specific, I think that maybe we don't even need a special boolean flag if your MR !2217 gets in? Once we have a separate tracking of internal pixel format in WGL_WINE_pixel_format_passthrough we could just always fail setting internal pixel format once external is set. The extension itself will still work as if an app wants to use GL together with d3d it will be able to set GL pixel format (which will result in wined3d creating a backup context). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_26224

1 0

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

On Wed Mar 1 12:24:02 2023 +0000, Alexandros Frantzis wrote: > > The last patch looks worrying in terms of forward-compatibility. > Looking at your wayland branch, you use a few unstable files. What > happens if/when they get promoted to stable? Will those files be moved > in wayland-protocols causing your branch to fail to build? > TL;DR: Not a problem. > When a protocol is moved to stable, a new copy is placed in that > directory (details are different depending on whether this copy is done > from 'staging' or the legacy 'unstable'), while the old xml file(s) > remain in place for backward compatibility. If the new copy requires a > protocol name change (e.g., from unstable->stable, but not > staging->stable) compositors tend to have a long deprecation period > during which both old and new names are supported. As an example, it > took compositors several years to drop support for unstable/xdg-shell > after the introduction of stable/xdg-shell. > FWIW, the Wayland community is *very* conservative concerning promotions > to stable, so a lot of functionality is still in unstable/staging. > Compare: 3 stable protocols vs 27 staging/unstable, some of them having > been there for many years. > More information about these topics can be found at https://gitlab.freedesktop.org/wayland/wayland-protocols/ > > Also, it would be better to have commit adding build system support > for protocol files together with at least a simple use of it in the same MR. > Ack. Moved to the next MR. Thanks for explanation, staging backward compatibility guarantees should do the trick. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26223

1 0

[PATCH v4 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces.
by Connor McAdams (＠cmcadams) March 6, 2023

March 6, 2023

-- v4: uiautomationcore: Implement IUIAutomation::get_RawViewCondition. uiautomationcore: Implement IUIAutomation::get_ControlViewCondition. uiautomationcore: Implement IUIAutomation::CreateOrCondition. uiautomationcore: Implement IUIAutomation::CreateNotCondition. uiautomationcore: Implement IUIAutomation::CreatePropertyCondition. uiautomationcore: Implement IUIAutomation::Create{True,False}Condition. https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

3 9

[PATCH v2 0/1] MR113: vkd3d-shader/dxbc: Validate and skip the signature section header size.
by Conor McCarthy (＠cmccarthy) March 6, 2023

March 6, 2023

Silences a very common warning. -- v2: vkd3d-shader/dxbc: Validate and skip the signature section header size. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/113

4 5

[PATCH v22 0/5] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v22: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. windows.media.speech: Add Vosk checks to autoconf. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 6

[PATCH v21 0/7] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v21: windows.media.speech: Implement Vosk create and release functions in the unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 8

[PATCH v20 0/7] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v20: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. TEMP: Reconf. windows.media.speech: Add Vosk checks to autoconf. makedep: Better differentiate between compiling and linking commands. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 8

[PATCH v19 0/5] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v19: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. windows.media.speech: Add Vosk checks to autoconf. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

3 12

[PATCH v2 0/4] MR2334: user32: Add some ActivateKeyboardLayout tests and send WM_INPUTLANGCHANGE.
by Rémi Bernon March 6, 2023

March 6, 2023

-- v2: win32u: Send WM_INPUTLANGCHANGE when activating new layout. win32u: Move window query functions around. user32/tests: Add a WM_INPUTLANGCHANGE message test. user32/tests: Skip tests if layout failed to activate. https://gitlab.winehq.org/wine/wine/-/merge_requests/2334

2 6

[PATCH 0/4] MR2334: user32: Add some ActivateKeyboardLayout tests and send WM_INPUTLANGCHANGE.
by Rémi Bernon March 6, 2023

March 6, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2334

2 5

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about dlls/winewayland.drv/wayland.c: > +{ > + struct wl_display *wl_display_wrapper; > + > + TRACE("wayland=%p wl_display=%p\n", wayland, process_wl_display); > + > + wl_list_init(&wayland->thread_link); > + > + wayland->process_id = GetCurrentProcessId(); > + wayland->thread_id = GetCurrentThreadId(); > + wayland->wl_display = process_wl_display; > + > + if (!wayland->wl_display) > + { > + ERR("Failed to connect to wayland compositor\n"); > + return FALSE; > + } I think that this error condition can never happen, we fail to load the driver if process_wl_display is NULL. Also, if wl_display is always equal to process_wl_display, why do we need to store it in wayland struct? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26192

1 0