March 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about dlls/winewayland.drv/wayland.c: > + > +/********************************************************************** > + * wayland_init > + * > + * Initialise a wayland instance. > + */ > +BOOL wayland_init(struct wayland *wayland) > +{ > + struct wl_display *wl_display_wrapper; > + > + TRACE("wayland=%p wl_display=%p\n", wayland, process_wl_display); > + > + wl_list_init(&wayland->thread_link); > + > + wayland->process_id = GetCurrentProcessId(); > + wayland->thread_id = GetCurrentThreadId(); Those are redundant for this commit. It's trivial to add when needed and introducing it later would make things much easier to review, because reviewer would need to jump between MR and your branch much less. I would suggest to leave thread_link, thread_id, process_id and initialized out of this MR. (Also, if process_id is always equal to `GetCurrentProcessId()`, I don't think there is much point in storing it). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26191

1 0

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about configure.ac: > [enable_winex11_drv]) > fi > > +WINE_NOTICE_WITH(wayland, [false], > + [Wayland ${notice_platform}development files not found, the Wayland driver won't be supported.], > + [enable_winewayland_drv]) > + This chunk makes little sense on its own, it could just be added in a commit that introduces wayland-client checks. This commit doesn't really need to modify configure more than what tools/make_makefiles does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26190

1 0

[PATCH v5 0/5] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions
by Davide Beatrici (＠davidebeatrici) March 6, 2023

March 6, 2023

The goal is to eventually move all interfaces from each driver's `mmdevdrv.c` into `mmdevapi`. -- v5: wine{alsa,coreaudio,oss,pulse}: Move test_connect handling into mmdevapi. mmdevapi: Use UTF-16 for client name in "test_connect_params" and "create_stream_params" structs. winepulse: Move process_attach and process_detach handling into mmdevapi. mmdevapi: Query MemoryWineUnixFuncs virtual memory and store the resulting handle. wine{alsa,coreaudio,oss,pulse}: Return STATUS_SUCCESS for unused unixlib functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

3 6

[PATCH v5 0/2] MR2168: win32u: Match second name when enum fonts.
by Keming Liang (＠Keming) March 6, 2023

March 6, 2023

the patch can resolve the issue: https://bugs.winehq.org/show_bug.cgi?id=54483 and can also solve many crashed issue related to font(MS Shell Dlg etc.) -- v5: add font test for MS Shell Dlg when Language is Chinese. win32u: Match second name when enum fonts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2168

2 2

[PATCH v3 0/3] MR2331: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze.
by Jinoh Kang (＠iamahuman) March 4, 2023

March 4, 2023

-- v3: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze. https://gitlab.winehq.org/wine/wine/-/merge_requests/2331

3 4

[PATCH v2 0/3] MR2331: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze.
by Jinoh Kang (＠iamahuman) March 4, 2023

March 4, 2023

-- v2: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze. riched20: Don't assume that TxDraw preserves the device context's brush selection. riched20/tests: Test for ITextDocument::Freeze and ITextDocument::Unfreeze. https://gitlab.winehq.org/wine/wine/-/merge_requests/2331

3 4

[PATCH 0/3] MR2331: riched20: Implement ITextDocument::Freeze and ITextDocument::Unfreeze.
by Jinoh Kang (＠iamahuman) March 4, 2023

March 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2331

2 3

[PATCH 0/1] MR2326: kernelbase: Add DiscardVirtualMemory() stub.
by Brendan Shanks (＠bshanks) March 4, 2023

March 4, 2023

This is required by the latest versions of Chromium. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2326

4 4

[PATCH 0/1] MR115: vkd3d-shader/trace: Output sample count for multisampled resources.
by Nikolay Sivov (＠nsivov) March 4, 2023

March 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/115

2 1

[PATCH v3 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces.
by Connor McAdams (＠cmcadams) March 3, 2023

March 3, 2023

-- v3: uiautomationcore: Implement IUIAutomation::get_RawViewCondition. uiautomationcore: Implement IUIAutomation::get_ControlViewCondition. uiautomationcore: Implement IUIAutomation::CreateOrCondition. uiautomationcore: Implement IUIAutomation::CreateNotCondition. uiautomationcore: Implement IUIAutomation::CreatePropertyCondition. uiautomationcore: Implement IUIAutomation::Create{True,False}Condition. https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

3 12

Re: [PATCH v2 0/1] MR2299: wined3d: Do not switch pixel format on non-private GL contexts.
by Zebediah Figura (＠zfigura) March 3, 2023

March 3, 2023

> Do you see any other way out of this? I mean specifically the case when an app sets GL pixel format itself on a window. I was thinking about whether it is possible to make setpixelformat quicker in winex11 instead and I don't see how. If keeping direct presentation it will require some X window reconfigure which is not going to be anywhere quick. Otherwise, it can be technically made to work like for GL child window redering (keeping composite redirected drawables for different pixel formats) but that requires essentially the same blitting on each present as done with wined3d backup context. > > The other different (but a bit complicated) way would be to: > > * count statistics of GL pixel format switches; > * introduce switching back from backup context and switch between resetting pixel format or switching to backup context or back based on that. Assuming that recreating the GLX drawable is always worse than a GDI blit, I think this patch is the right direction. I just don't want to regress performance in backends other than x11. So maybe the right approach here is to add some boolean flag saying "return an error if changing the pixel format would be expensive". Or maybe things are already broken on winemac and the right approach is just to punt. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2299#note_26147

1 0

[PATCH 0/1] MR2323: gdiplus: Use transparency instead of background color if transparent color flag is set in GIF GCE.
by Piotr Caban (＠piotr) March 3, 2023

March 3, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54563 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2323

3 5

Re: [PATCH v2 0/1] MR2321: windowscodecs: Don't reorder gif extension blocks in GetReaderByIndex. - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2321

1 0

Re: [PATCH v2 0/2] MR2319: explorer: Fix systray window creation failure with nulldrv. - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2319

1 0

Re: [PATCH v2 0/3] MR2318: win32u: Fix a few nulldrv failures in ToUnicode and GetDeviceCaps(dc, BITSPIXEL). - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2318

1 0

Re: [PATCH v2 0/2] MR2315: d3d8, d3d9: WM_SYSCOMMAND test fixes. - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2315

1 0

Re: [PATCH v2 0/1] MR2317: include: Add more Windows.Foundation.Numerics structs. - approved
by Alexandre Julliard (＠julliard) March 3, 2023

March 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2317

1 0

[PATCH 0/2] MR2329: loader: In macOS preloader, move the top-down allocations area down and stop using mincore()
by Brendan Shanks (＠bshanks) March 3, 2023

March 3, 2023

`mincore()` is not a reliable way to determine whether a region is empty. This could result in an already-in-use region being mapped with `MAP_FIXED`, and Wine conflicting with its original owner (i.e. dyld). With the `mincore()` check removed, a special case was added to allow zero-fill sections to be mapped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2329

2 2

[PATCH 0/5] MR2328: winevulkan: Update to VK spec version 1.3.242.
by Georg Lehmann (＠DadSchoorse) March 3, 2023

March 3, 2023

Not trivial this time because VulkanSC was added to the xml. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2328

2 5

[PATCH 0/1] MR2327: kernel32: Implement GetFirmwareType().
by Brendan Shanks (＠bshanks) March 3, 2023

March 3, 2023

Chromium used to resolve this function through GetProcAddress(), but now calls it directly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2327

2 1

[PATCH 0/1] MR2321: windowscodecs: Don't reorder gif extension blocks in GetReaderByIndex.
by Piotr Caban (＠piotr) March 3, 2023

March 3, 2023

The code that reorders extension blocks is broken and causes some extensions to be not reported (when GCE is not the last extension block). This fixes GCE blocks reading from gifs attached in [bug 54563](https://bugs.winehq.org/show_bug.cgi?id=54563). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2321

3 2

[PATCH 0/2] MR2319: explorer: Fix systray window creation failure with nulldrv.
by Rémi Bernon March 3, 2023

March 3, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2319

2 3

[PATCH 0/3] MR2318: win32u: Fix a few nulldrv failures in ToUnicode and GetDeviceCaps(dc, BITSPIXEL).
by Rémi Bernon March 3, 2023

March 3, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2318

2 4

[PATCH v2 0/6] MR2303: uiautomationcore: Implement a few COM UI Automation condition interfaces.
by Connor McAdams (＠cmcadams) March 3, 2023

March 3, 2023

-- v2: uiautomationcore: Implement IUIAutomation::get_RawViewCondition. uiautomationcore: Implement IUIAutomation::get_ControlViewCondition. uiautomationcore: Implement IUIAutomation::CreateOrCondition. uiautomationcore: Implement IUIAutomation::CreateNotCondition. uiautomationcore: Implement IUIAutomation::CreatePropertyCondition. uiautomationcore: Implement IUIAutomation::Create{True,False}Condition. https://gitlab.winehq.org/wine/wine/-/merge_requests/2303

2 7

[PATCH 0/1] MR111: vkd3d-shader/hlsl: Improve handling of "technique" tokens.
by Nikolay Sivov (＠nsivov) March 3, 2023

March 3, 2023

This change only implements case-sensitivity of technique keywords and related checks when corresponding profile is used. My immediate plan is to add some synthetic type for technique variables, for example as {object, void}, then add named techniques as variables. This is useful because these names are participating in global scope, and should not collide with normal variables. After that "pass_list" will be split, at least in two variants because of how much d3d9 syntax differs. Some trivial changes will be need later to have some top level fx compilation helper that considers only fx objects and calls ps/vs/gs compiler to create inner shader blobs on same original source. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/111

4 17