March 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v7 0/3] MR2449: win32u: Add a few device GPU properties. - approved
by Zhiyi Zhang (＠zhiyi) March 29, 2023

March 29, 2023

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

1 0

[PATCH 0/7] MR2528: taskkill: Support terminating child processes.
by Paul Gofman (＠gofman) March 29, 2023

March 29, 2023

Needed for Epic Online Services updater which invokes taskkill with /T flag and fails to replace a file if that didn't actually killed the processes. There is apparently a bit of refactoring on the way, with most notably using toolhelp snapshot instead of EnumProcesses(). That is more convenient for finding child processes (instead of performing a separate query for parent pid), but I also think that is more consistent in general and gets rid of existing separate query for process name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2528

3 8

[PATCH 0/2] MR2526: Remove redundant NULL checks before free
by Michael Stefaniuc (＠mstefani) March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2526

3 3

[PATCH v5 0/2] MR2231: cfgmgr32: Implement CM_MapCrToWin32Err.
by Mohamad Al-Jaf (＠maljaf) March 28, 2023

March 28, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53781 The Matrix Awakens MegaCity Unreal Engine 5.1 demo and Hogwarts Legacy call this. Duplicate Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54513 -- v5: cfgmgr32/tests: Add CM_MapCrToWin32Err tests. cfgmgr32: Implement CM_MapCrToWin32Err. https://gitlab.winehq.org/wine/wine/-/merge_requests/2231

3 10

Re: [PATCH v6 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys. - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

1 0

Re: [PATCH v2 0/11] MR2522: wineps: Add support for more spool file records - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2522

1 0

Re: [PATCH v6 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2429

1 0

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC. - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520

1 0

Re: [PATCH v2 0/1] MR2519: wldap32: Stub out setting LDAP_OPT_REFERRAL_HOP_LIMIT. - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2519

1 0

Re: [PATCH v2 0/6] MR2518: Fixes and improvements for taskschd:scheduler - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2518

1 0

Re: [PATCH v3 0/3] MR2478: wined3d: Make video memory accounting a per-resource flag. - approved
by Alexandre Julliard (＠julliard) March 28, 2023

March 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2478

1 0

[PATCH 0/1] MR2525: wip
by Rémi Bernon March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2525

1 3

[PATCH 0/4] MR2523: uiautomationcore: Miscellaneous MSAA provider patches.
by Connor McAdams (＠cmcadams) March 28, 2023

March 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2523

4 6

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

I left a few comments on the tests. Otherwise, I quite like the patch series. Force-setting the extended attributes on visible-but-starting-with-a-dot files seems like a good compromise to fix the bug at hand without requiring a ton of attribute setting and I couldn't think of any better solution. This won't fix the case of Wine-created dot files when the show_dot_files option is enabled if the user then disables the option, which again seems like a good compromise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28247

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + > + status = pNtQueryInformationFile( h, &io, &info, sizeof(info), FileBasicInformation ); > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( info.FileAttributes & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", info.FileAttributes ); > + ok( !(info.FileAttributes & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", info.FileAttributes ); > + > + CloseHandle( h ); > + > + GetTempPathW( MAX_PATH, temppathW ); > + GetTempFileNameW( temppathW, L"foo", 0, filenameW ); > + h = CreateFileW( filenameW, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 ); > + ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" ); > + if (h == INVALID_HANDLE_VALUE) return; > + > + GetTempFileNameW( temppathW, L".foo", 0, filenameW ); > + if (!rename_file( h, filenameW )) return; ```suggestion:-0+0 winetest_push_context("foo -> .foo"); rename_file( h, filenameW ); winetest_pop_context(); ``` Or something like that. Similarly for the other rename_file() call below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28246

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + if (!ret) return FALSE; > + > + size = offsetof( FILE_RENAME_INFORMATION, FileName ) + ntpath.Length; > + fri = HeapAlloc( GetProcessHeap(), 0, size ); > + lok( fri != NULL, "HeapAlloc failed\n" ); > + if (!fri) return FALSE; > + fri->ReplaceIfExists = TRUE; > + fri->RootDirectory = NULL; > + fri->FileNameLength = ntpath.Length; > + memcpy( fri->FileName, ntpath.Buffer, ntpath.Length ); > + pRtlFreeUnicodeString( &ntpath ); > + > + status = pNtSetInformationFile( h, &io, fri, size, FileRenameInformation ); > + HeapFree( GetProcessHeap(), 0, fri ); > + lok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + return status == STATUS_SUCCESS; Let's get rid of the return and make the function void. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28245

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( attrs & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", attrs ); > + todo_wine ok( !(attrs & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", attrs ); > + > + status = pNtQueryInformationFile( h, &io, &info, sizeof(info), FileBasicInformation ); > + ok( status == STATUS_SUCCESS, "got %#lx\n", status ); > + ok( info.FileAttributes & FILE_ATTRIBUTE_SYSTEM, "got attributes %#lx\n", info.FileAttributes ); > + ok( !(info.FileAttributes & FILE_ATTRIBUTE_HIDDEN), "got attributes %#lx\n", info.FileAttributes ); > + > + CloseHandle( h ); > + > + GetTempPathW( MAX_PATH, temppathW ); > + GetTempFileNameW( temppathW, L"foo", 0, filenameW ); > + h = CreateFileW( filenameW, GENERIC_READ | GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_FLAG_DELETE_ON_CLOSE, 0 ); > + ok( h != INVALID_HANDLE_VALUE, "failed to create temp file\n" ); > + if (h == INVALID_HANDLE_VALUE) return; Similarly here, better to get rid of the return entirely. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28244

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > +{ > + FILE_RENAME_INFORMATION *fri; > + UNICODE_STRING ntpath; > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + BOOLEAN ret; > + ULONG size; > + > + ret = pRtlDosPathNameToNtPathName_U( filename, &ntpath, NULL, NULL ); > + lok( ret, "RtlDosPathNameToNtPathName_U failed\n" ); > + if (!ret) return FALSE; > + > + size = offsetof( FILE_RENAME_INFORMATION, FileName ) + ntpath.Length; > + fri = HeapAlloc( GetProcessHeap(), 0, size ); > + lok( fri != NULL, "HeapAlloc failed\n" ); > + if (!fri) return FALSE; Same here for this HeapAlloc() call with very small size. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28243

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > } > > +#define lok ok_(__FILE__, line) > +#define rename_file(h,f) rename_file_(__LINE__,(h),(f)) > +static BOOL rename_file_( int line, HANDLE h, const WCHAR *filename ) > +{ > + FILE_RENAME_INFORMATION *fri; > + UNICODE_STRING ntpath; > + IO_STATUS_BLOCK io; > + NTSTATUS status; > + BOOLEAN ret; > + ULONG size; > + > + ret = pRtlDosPathNameToNtPathName_U( filename, &ntpath, NULL, NULL ); > + lok( ret, "RtlDosPathNameToNtPathName_U failed\n" ); > + if (!ret) return FALSE; Please get rid of the ok() and if() {}, we can just assume that the RtlDosPathNameToNtPathName_U() call works correctly (i.e. if it fails we have bigger problems and arguably crashing and burning is better than reporting a failure and silently skipping the test). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28242

1 0

Re: [PATCH v21 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Matteo Bruni (＠Mystral) March 28, 2023

March 28, 2023

Matteo Bruni (@Mystral) commented about dlls/ntdll/tests/file.c: > CloseHandle( h ); > } > > +#define lok ok_(__FILE__, line) > +#define rename_file(h,f) rename_file_(__LINE__,(h),(f)) > +static BOOL rename_file_( int line, HANDLE h, const WCHAR *filename ) I'd avoid these line shenanigans, we now have test contexts to disambiguate ok() calls from different tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_28241

1 0

[PATCH 0/5] MR2524: msvcrt: _StructuredTaskCollection cancelling
by Torge Matthies (＠tmatthies) March 28, 2023

March 28, 2023

Some refactoring + implementation of `_StructuredTaskCollection::_Cancel` and `_StructuredTaskCollection::_IsCanceling`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2524

2 6

[PATCH v2 0/8] MR1979: msvcrt: Remaining implementations and stubs for cm3
by Torge Matthies (＠tmatthies) March 28, 2023

March 28, 2023

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v2: msvcr110: Add _Context::_IsSynchronouslyBlocked stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_dtor stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_ctor stub. msvcr100: Implement _StructuredTaskCollection::_IsCanceling. msvcr100: Implement _StructuredTaskCollection canceling. msvcr100: Use enum for _StructuredTaskCollection status bits. msvcr100: Use enum for _StructuredTaskCollection return value. msvcr100: Only wake task collection waiters when finished >= count. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

2 8

[PATCH 0/5] MR1979: msvcrt: Remaining implementations and stubs for cm3
by Torge Matthies (＠tmatthies) March 28, 2023

March 28, 2023

This adds the remaining `_StructuredTaskCollection` functions and other stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

3 15

[PATCH v6 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) March 28, 2023

March 28, 2023

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v6: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. win32u: Set DEVPKEY_Device_BusNumber for GPUs. win32u: Set DEVPKEY_Device_MatchingDeviceId for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

3 6

[PATCH v5 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) March 28, 2023

March 28, 2023

I initially wanted to do the refactoring in a separate merge request, but since my merge request yesterday broke the tests, I decided to add the implementation into this commit as well. -- v5: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. kernelbase: Call create_key() from create_subkey(). kernelbase: Factor creating a subkey out of create_key(). kernelbase: Don't open Wow6432nodes from create_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 6