March 2023 - Wine-GitLab - list.winehq.org

[PATCH v5 0/1] MR2126: ntdll: Print an error if we receive a signal not on the signal stack.
by Zebediah Figura (＠zfigura) March 23, 2023

March 23, 2023

Without this patch the process will silently die. I managed to trigger this while trying to trace Child of Light with Renderdoc, the latter of which crashed in its own "TargetControlServerThread". This, confusingly, manifested in the game restarting itself without the Ubisoft overlay; apparently the game or one of its launchers was capable of recognizing when the process had died and restarting it, but would not try to inject the overlay a second time. I have not investigated the cause of the crash; it is not unlikely that it resulted from the overlay injection (despite the fact that that should only directly affect PE code.) -- v5: ntdll: Print an error if we receive a signal not on the signal stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/2126

3 4

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Mohamad Al-Jaf (＠maljaf) March 23, 2023

March 23, 2023

> Only if you accept that it overflows above the install button, I'm not sure that's better. You're right, it does overflow with some of the translations. This seems like the safest way to add it: ![Screenshot_20230323_190837](/uploads/65da20f990348341c9331a98709a37db/Screenshot_20230323_190837.png) I checked the longest `Install theme` translation, which is Lithuanian, and it doesn't overflow: ![Screenshot_20230323_190610](/uploads/c0af96e1db89d0b9082a77fb778bfad4/Screenshot_20230323_190610.png) Alternatively, the `Color` combo box could be moved to the first row like so: ![Screenshot_20230323_193447](/uploads/8e75a18414ba4f1f29b81bc9a2a4e7f7/Screenshot_20230323_193447.png) Which of these would be most preferable? I'm leaning towards the second one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27712

1 0

[PATCH v5 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) March 23, 2023

March 23, 2023

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v5: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

3 7

[PATCH v3 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) March 23, 2023

March 23, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v3: vkd3d-shader/hlsl: Copy index chain values into synthetic vars. tests: Test indexing of non-loads. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. vkd3d-shader/hlsl: Introduce hlsl_ir_index. tests: Test side effects on indexes. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

3 17

[PATCH v8 0/5] MR2258: winegstreamer: Support WMV DMO decoder.
by Ziqing Hui (＠zhui) March 23, 2023

March 23, 2023

-- v8: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO. winegstreamer: Create wg_transform for WMV decoder. winegstreamer: Ignore framerate of media type for WMV decoder DMO. winegstreamer: Add format field to wmv wg_format. mf/tests: Test time length returned by ProcessOutput. https://gitlab.winehq.org/wine/wine/-/merge_requests/2258

3 6

Re: [PATCH v3 0/6] MR2456: widl: Improve error messages source location. - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2456

1 0

Re: [PATCH v2 0/1] MR2474: include: Add D3D10CalcSubresource(). - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2474

1 0

Re: [PATCH v2 0/1] MR2477: include: Use hexadecimal constants for XAudio flags. - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2477

1 0

Re: [PATCH v3 0/1] MR2479: ntdll: Print correct thread rename trace when using current thread ID with exception method. - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2479

1 0

Re: [PATCH v3 0/11] MR2484: wineps: Initial work on writing ps data in print processor - approved
by Alexandre Julliard (＠julliard) March 23, 2023

March 23, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2484

1 0