March 2023 - Wine-GitLab - list.winehq.org

[PATCH v22 0/5] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v22: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. windows.media.speech: Add Vosk checks to autoconf. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 6

[PATCH v21 0/7] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v21: windows.media.speech: Implement Vosk create and release functions in the unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 8

[PATCH v20 0/7] MR2091: Draft: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v20: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. TEMP: Reconf. windows.media.speech: Add Vosk checks to autoconf. makedep: Better differentiate between compiling and linking commands. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

2 8

[PATCH v19 0/5] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl March 6, 2023

March 6, 2023

Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v19: windows.media.speech: Implement Vosk create and release functions in the unixlib. windows.media.speech/tests: Allow the SpeechRecognizer creation to fail in Wine. windows.media.speech/tests: Get rid of duplicated hresult. windows.media.speech: Add unixlib stub. windows.media.speech: Add Vosk checks to autoconf. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

3 12

[PATCH v2 0/4] MR2334: user32: Add some ActivateKeyboardLayout tests and send WM_INPUTLANGCHANGE.
by Rémi Bernon March 6, 2023

March 6, 2023

-- v2: win32u: Send WM_INPUTLANGCHANGE when activating new layout. win32u: Move window query functions around. user32/tests: Add a WM_INPUTLANGCHANGE message test. user32/tests: Skip tests if layout failed to activate. https://gitlab.winehq.org/wine/wine/-/merge_requests/2334

2 6

[PATCH 0/4] MR2334: user32: Add some ActivateKeyboardLayout tests and send WM_INPUTLANGCHANGE.
by Rémi Bernon March 6, 2023

March 6, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2334

2 5

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about dlls/winewayland.drv/wayland.c: > +{ > + struct wl_display *wl_display_wrapper; > + > + TRACE("wayland=%p wl_display=%p\n", wayland, process_wl_display); > + > + wl_list_init(&wayland->thread_link); > + > + wayland->process_id = GetCurrentProcessId(); > + wayland->thread_id = GetCurrentThreadId(); > + wayland->wl_display = process_wl_display; > + > + if (!wayland->wl_display) > + { > + ERR("Failed to connect to wayland compositor\n"); > + return FALSE; > + } I think that this error condition can never happen, we fail to load the driver if process_wl_display is NULL. Also, if wl_display is always equal to process_wl_display, why do we need to store it in wayland struct? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26192

1 0

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about dlls/winewayland.drv/wayland.c: > + > +/********************************************************************** > + * wayland_init > + * > + * Initialise a wayland instance. > + */ > +BOOL wayland_init(struct wayland *wayland) > +{ > + struct wl_display *wl_display_wrapper; > + > + TRACE("wayland=%p wl_display=%p\n", wayland, process_wl_display); > + > + wl_list_init(&wayland->thread_link); > + > + wayland->process_id = GetCurrentProcessId(); > + wayland->thread_id = GetCurrentThreadId(); Those are redundant for this commit. It's trivial to add when needed and introducing it later would make things much easier to review, because reviewer would need to jump between MR and your branch much less. I would suggest to leave thread_link, thread_id, process_id and initialized out of this MR. (Also, if process_id is always equal to `GetCurrentProcessId()`, I don't think there is much point in storing it). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26191

1 0

Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Jacek Caban (＠jacek) March 6, 2023

March 6, 2023

Jacek Caban (@jacek) commented about configure.ac: > [enable_winex11_drv]) > fi > > +WINE_NOTICE_WITH(wayland, [false], > + [Wayland ${notice_platform}development files not found, the Wayland driver won't be supported.], > + [enable_winewayland_drv]) > + This chunk makes little sense on its own, it could just be added in a commit that introduces wayland-client checks. This commit doesn't really need to modify configure more than what tools/make_makefiles does. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275#note_26190

1 0

[PATCH v5 0/5] MR1543: mmdevapi: Handle process_attach, process_detach and test_connect UNIX driver functions
by Davide Beatrici (＠davidebeatrici) March 6, 2023

March 6, 2023

The goal is to eventually move all interfaces from each driver's `mmdevdrv.c` into `mmdevapi`. -- v5: wine{alsa,coreaudio,oss,pulse}: Move test_connect handling into mmdevapi. mmdevapi: Use UTF-16 for client name in "test_connect_params" and "create_stream_params" structs. winepulse: Move process_attach and process_detach handling into mmdevapi. mmdevapi: Query MemoryWineUnixFuncs virtual memory and store the resulting handle. wine{alsa,coreaudio,oss,pulse}: Return STATUS_SUCCESS for unused unixlib functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1543

3 6