April 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR2713: kernelbase: Add GetCurrentPackageFamilyName stub.
by Etaash Mathamsetty (＠etaash.mathamsetty) April 26, 2023

April 26, 2023

webview2 uses this function to locate media foundation. I also saw the UWP version of FH5 calling this function as well, interestingly. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2713

3 2

[PATCH v2 0/2] MR2571: Some improvements for appwiz.cpl.
by Jactry Zeng (＠jactry) April 26, 2023

April 26, 2023

In the current implementation, the main UI will be blocked after the uninstaller is launched. Put the uninstall process in a thread to avoid that, and popup a message while trying to launch multiple uninstallers. -- v2: appwiz.cpl: Handle WM_CLOSE and WM_COMMAND(IDCANCEL) in the support info dialog. appwiz.cpl: Process messages while waiting for the uninstaller to terminate. https://gitlab.winehq.org/wine/wine/-/merge_requests/2571

3 3

[PATCH 0/1] MR183: vkd3d-shader/hlsl: Always specify resource on intrinsic_tex().
by Francisco Casas (＠fcasas) April 26, 2023

April 26, 2023

Otherwise, in the added test, we get: ``` vkd3d-compiler: vkd3d-shader/hlsl.c:452: hlsl_init_deref_from_index_chain: Assertion `chain' failed. ``` because on the path that triggers the following error: ``` E5002: Wrong type for argument 1 of 'tex3D': expected 'sampler' or 'sampler3D', but got 'sampler2D'. ``` a NULL params.resource is passed to hlsl_new_resource_load() and then to hlsl_init_deref_from_index_chain(). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/183

2 1

[PATCH v3 0/5] MR2676: dxgi, d3d9: Create swapchain textures from wined3d_swapchain_get_back_buffer() instead of using a callback.
by Zebediah Figura (＠zfigura) April 26, 2023

April 26, 2023

-- v3: d3d9: Pass the container to d3d9_surface_create(). d3d9: Create sub-resource surfaces manually. d3d9: Move surface allocation to d3d9_surface_create(). dxgi: Create d3d11 swapchain textures directly from d3d11_swapchain_init(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2676

2 6

[PATCH v2 0/5] MR2676: dxgi, d3d9: Create swapchain textures from wined3d_swapchain_get_back_buffer() instead of using a callback.
by Zebediah Figura (＠zfigura) April 26, 2023

April 26, 2023

-- v2: d3d9: Pass the container to d3d9_surface_create(). d3d9: Create sub-resource surfaces manually. d3d9: Move surface allocation to d3d9_surface_create(). dxgi: Create d3d11 swapchain textures directly from d3d11_swapchain_init(). dxgi: Introduce IWineDXGIDeviceParent::register_swapchain_texture() and use it in IDXGIDevice::CreateSurface(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2676

3 7

[PATCH v5 0/10] MR159: vkd3d-shader/hlsl: Broaden resources support v2, part 2.
by Francisco Casas (＠fcasas) April 26, 2023

April 26, 2023

Mainly comprises support for allocating arrays of resources, and loading from them, for both SM1 and SM4. -- v5: vkd3d-shader/hlsl: Support resource arrays when writting SM4. vkd3d-shader/hlsl: Write resource loads in SM1. vkd3d-shader/hlsl: Write sampler declarations in SM1. vkd3d-shader/hlsl: Track objects sampling dimension. vkd3d-shader/hlsl: Track object components usage and allocate registers accordingly. tests: Test objects as parameters. vkd3d-shader/hlsl: Skip object components when creating input/output copies. vkd3d-shader/hlsl: Add fixme for uniform copies for objects within structs. vkd3d-shader/hlsl: Support multiple-register variables in object regsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159

3 20

[PATCH v4 0/2] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics.
by Ethan Lee (＠flibitijibibo) April 26, 2023

April 26, 2023

SPIR-V already handled DSX/DSY, so only D3DBC/TPF needed new case blocks. You'll notice that there's no test for this one - in addition to being a pretty straightforward translation for all possible formats, this feature uses the render target width/height and I wasn't sure if there was a good way to ensure that the test would always make sense. Instead, I did the test manually, and it's what you'd expect (EDIT: Previously the test used a uniform which always optimized to 0, new test uses VPOS instead): HLSL: ``` float4 main(float4 pos : sv_position) : sv_target { float4 x = ddx(pos.x); float4 y = ddy(pos.y); return x + y; } ``` D3DBC: ``` ps_3_0 dcl_position0 vPos mov r0.xyzw, vPos.xyzw mov r1.x, r0.x dsx r1.x, r1.x mov r0.x, r0.yxxx dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov oC0.xyzw, r0.xyzw ``` DXBC-TPF: ``` ps_4_0 dcl_input_ps_siv linear v0.xyzw, position dcl_output o0.xyzw dcl_temps 2 mov r0.xyzw, v0.xyzw mov r1.x, r0.x dsx r1.x, r1.x mov r0.x, r0.yxxx dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov o0.xyzw, r0.xyzw ret ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=54827 -- v4: tests: Add test for ddx(), ddy() intrinsics https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179

2 3

[PATCH v2 0/2] MR2709: include: Add ISpTTSEngineSite and ISpTTSEngine interfaces.
by Shaun Ren (＠shaunren) April 26, 2023

April 26, 2023

-- v2: include: Add ISpTTSEngineSite and ISpTTSEngine interfaces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2709

3 3

[PATCH v3 0/2] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics.
by Ethan Lee (＠flibitijibibo) April 26, 2023

April 26, 2023

SPIR-V already handled DSX/DSY, so only D3DBC/TPF needed new case blocks. You'll notice that there's no test for this one - in addition to being a pretty straightforward translation for all possible formats, this feature uses the render target width/height and I wasn't sure if there was a good way to ensure that the test would always make sense. Instead, I did the test manually, and it's what you'd expect (EDIT: Previously the test used a uniform which always optimized to 0, new test uses VPOS instead): HLSL: ``` float4 main(float4 pos : sv_position) : sv_target { float4 x = ddx(pos.x); float4 y = ddy(pos.y); return x + y; } ``` D3DBC: ``` ps_3_0 dcl_position0 vPos mov r0.xyzw, vPos.xyzw mov r1.x, r0.x dsx r1.x, r1.x mov r0.x, r0.yxxx dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov oC0.xyzw, r0.xyzw ``` DXBC-TPF: ``` ps_4_0 dcl_input_ps_siv linear v0.xyzw, position dcl_output o0.xyzw dcl_temps 2 mov r0.xyzw, v0.xyzw mov r1.x, r0.x dsx r1.x, r1.x mov r0.x, r0.yxxx dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov o0.xyzw, r0.xyzw ret ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=54827 -- v3: tests: Add test for ddx(), ddy() intrinsics https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179

4 6

[PATCH v5 0/2] MR172: vkd3d-shader/hlsl: Implement SampleBias().
by Nikolay Sivov (＠nsivov) April 26, 2023

April 26, 2023

-- v5: vkd3d-shader/hlsl: Implement SampleBias() method. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/172

6 10

[PATCH v5 0/5] MR136: vkd3d-shader/hlsl: Handle discard statement.
by Nikolay Sivov (＠nsivov) April 26, 2023

April 26, 2023

-- v5: tests: Add a simple test for "discard". tests: Remove rtv clears in Vulkan runner. tests: Remove rtv clears in d3d12 runner. vkd3d-shader/hlsl: Handle discard statement. vkd3d-shader/trace: Add separate id for discard. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/136

6 9

[PATCH 0/2] MR2711: include: Add ISpTTSEngineSite and ISpTTSEngine interfaces.
by Shaun Ren (＠shaunren) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2711

3 4

[PATCH 0/2] MR2709: include: Add ISpTTSEngineSite and ISpTTSEngine interfaces.
by Shaun Ren (＠shaunren) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2709

3 4

[PATCH 0/1] MR2707: threadpoolwinrt: Forward a Release() to a Release() method.
by Michael Stefaniuc (＠mstefani) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2707

3 2

[PATCH 0/11] MR2662: mfplat: Optimize DXGI buffer locking
by Giovanni Mascellani (＠giomasce) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2662

3 14

Re: [PATCH v2 0/4] MR174: Consolidate the TPF and d3dbc handling code.
by Giovanni Mascellani (＠giomasce) April 26, 2023

April 26, 2023

> Yeah, that makes sense. It's just that there are several vkd3d developers rather experienced in design—and also often opinionated—and I was hoping to get at least some thoughts on the matter :-/ I don't consider myself experienced, at least not into IR design. Until little time ago I knew basically nothing about `vkd3d_shader_instruction`, and still now I don't know that much. Among other things, this means that it's still not completely clear to me what you mean by "maximally CISC" or "minimally CISC" (and while I think I sort of get the general idea for the terms, that's not nearly enough to understand options (3) and (4)). Therefore I don't feel I have a definite opinion about the subject. There are just a couple of rather vague points that come to my mind. * In general, I think that code processing should be done in the form of IR passes as much as possible, rather than be embedded in the frontends or backends. This helps modularity and code sharing. I think Conor's patches go into this direction, which makes sense to me. Frontends and backends already care about serialization and deserialization and should not be loaded with excessive other duties. * Currently my understanding is that `vkd3d_shader_instrucion` is basically modeled after SM4. When converting SM4 -> SPIR-V, the SM4 code is basically deserialized to `vkd3d_shader_instruction` and then rewritten to SPIR-V in a rather naive way. The deserialization step is very syntactical, to the point that the original SM4 code can be faithfully disassembled from the IR. If we want `vkd3d_shader_instruction` to be flexible enough to support different frontends and backends, I think it must somehow be unchained from SM4. In particular, SM4 disassembling has to go through a different path. An option is to have an IR specific for SM1/SM4 (which are probably close enough to have the same IR) and another more general IR, that is meant to achieve interoperability for many different shader languages. The SM4-IR would be rather similar to the current `vkd3d_shader_instruction` (so syntactically close to SM4), and the "general" IR could be more like an actual compiler IR (SSA, possibly mor e RISC, if I understand Zeb's terminology). If eventually we want to do some SPIR-V-specific optimizations, there could be the need to a SPIR-V-IR too. The HLSL compiler could emit general-IR (which would be somewhat similar to what's already emitting), which would then be optimized, converted to SM4-IR (that's possibly similar to a direction that was already considered), optimized again (for passes that go not make sense for general-IR) and then emitted (which would be basically serializing). It's quite a lot of work, anyway. As I said, take all of this with a grain of salt. Maybe two grains. Ok, it probably wouldn't hurt to add a cargo ship's worth of salt. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/174#note_31222

1 0

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Alexandre Julliard (＠julliard) April 26, 2023

April 26, 2023

I'm not convinced that this justifies a Wine-specific module. The usual solution for problems with native dlls is "don't do that", i.e. fix the builtin so that native is not required. It's hard to tell without more details, but in this case an app-specific dll override may also be enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31218

1 0

[PATCH v3 0/1] MR2602: mfplat: Fix returned buffer length in dxgi_surface_buffer_lock().
by Paul Gofman (＠gofman) April 26, 2023

April 26, 2023

-- v3: mfplat: Fix returned buffer length in dxgi_surface_buffer_lock(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2602

3 3

Re: [PATCH v2 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Nikolay Sivov (＠nsivov) April 26, 2023

April 26, 2023

How bad would it be to duplicate tests in msxml3/4/6, removing version checks completely? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895#note_31211

1 0

Re: [PATCH v2 0/9] MR895: msxml3/tests: Filter attributes tests by version.
by Nikolay Sivov (＠nsivov) April 26, 2023

April 26, 2023

Nikolay Sivov (@nsivov) commented about dlls/msxml3/tests/domdoc.c: > } > > test = tests; > - while (test->xml) { > + while (test->xml) > + { > + if (test->versions && !(entry->ver & test->versions)) > + { > + test++; > + continue; > + } I don't see "versions" field set anywhere? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/895#note_31210

1 0

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Nikolay Sivov (＠nsivov) April 26, 2023

April 26, 2023

This looks fine to me, if wine-specific modules are a problem, we'll need to build separate modules, increasing build size like @tclem said. But that's not my call. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31209

1 0

[PATCH 0/2] MR2708: Two misc janitorings
by Michael Stefaniuc (＠mstefani) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2708

3 3

[PATCH v4 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) April 26, 2023

April 26, 2023

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- v4: mfreadwrite/tests: Test GetService for MP4 sink writer. https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

3 3

[PATCH 0/3] MR2705: d3dcompiler: D3DAssemble is a private export.
by Stefan Dösinger April 26, 2023

April 26, 2023

This series allows linking of our d3dx9.dll against d3dcompiler.lib from the Windows SDK. It presumably also fixes the d3dcompiler tests, although I didn't bother building them with Visual Studio so far. And yes, I did check, that stringification macro works on MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2705

3 11

[PATCH 0/5] MR2676: dxgi, d3d9: Create swapchain textures from wined3d_swapchain_get_back_buffer() instead of using a callback.
by Zebediah Figura (＠zfigura) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2676

3 7

Re: [PATCH v2 0/1] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics.
by Giovanni Mascellani (＠giomasce) April 26, 2023

April 26, 2023

I think it would be preferable to have to test in the repository, even if it hardcodes the render target size. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179#note_31201

1 0

Re: [PATCH v2 0/1] MR171: Initialize a pointer for MSVC.
by Henri Verbeet (＠hverbeet) April 26, 2023

April 26, 2023

> The other issue I run into - and this is probably a Vulkan SDK thing, not MSVC as such - is that the options I have for GLSL.std.450.h are > > spirv-headers/GLSL.std.450.h spirv_cross/GLSL.std.450.h > > and not spirv/unified1/GLSL.std.450.h or vulkan/GLSL.std.450.h as checked by configure. Has the location changed in newer Vulkan SDK versions, or was this never tested on Windows (with any compiler) to begin with? I've tried building on Windows using MSYS2, and that generally worked fine, though it was some time ago. The vkd3d README does fairly explicitly mention depending on SPIRV-Headers and Vulkan-Headers, and I don't think it mentions the Vulkan SDK anywhere. We could of course add support for building against the Vulkan SDK if someone were to submit the patches... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/171#note_31196

1 0

[PATCH 0/1] MR2205: winspool: Fix crash when dmSize is 0
by Tingzhong Luo (＠tzluo) April 26, 2023

April 26, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2205

4 5

[PATCH v12 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) April 26, 2023

April 26, 2023

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v12: shell32: Fix last parameter behavior in SHBindToFolderIDListParent(). shell32/tests: Test SHBindToParent() last parameter behavior. shell32/tests: Add SHBindToFolderIDListParent() tests. shell32: Implement SHBindToFolderIDListParent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 6

[PATCH v8 0/6] MR2669: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionControl into mmdevapi.
by Davide Beatrici (＠davidebeatrici) April 26, 2023

April 26, 2023

-- v8: winepulse: Use mmdevapi's AudioSessionControl. wineoss: Use mmdevapi's AudioSessionControl. winecoreaudio: Use mmdevapi's AudioSessionControl. winealsa: Use mmdevapi's AudioSessionControl. mmdevapi: Implement AudioSessionControl. https://gitlab.winehq.org/wine/wine/-/merge_requests/2669

3 7

[PATCH v2 0/1] MR170: vkd3d-shader/ir: Emit a shader error if the control point phase id cannot be inserted.
by Conor McCarthy (＠cmccarthy) April 26, 2023

April 26, 2023

A message context in the normaliser will also be needed for the next normalisation patch set. -- v2: vkd3d-shader/ir: Emit a shader error if the control point phase id cannot be inserted. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/170

4 4

[PATCH v2 0/1] MR2710: ntdll: Implement efficiency class reporting for intel hybrid CPUs.
by Torge Matthies (＠tmatthies) April 26, 2023

April 26, 2023

Signed-off-by: Torge Matthies <tmatthies(a)codeweavers.com> -- v2: ntdll: Implement efficiency class reporting for intel hybrid CPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2710

2 2

[PATCH v6 0/11] MR2637: winex11: Use messages instead of user callbacks and handle them in the default IME UI window procedure.
by Rémi Bernon April 26, 2023

April 26, 2023

-- v6: winex11: Use EM_REPLACESEL to set IME composition strings. include: Add some immdev.h definitions. winex11: Always zero terminate XIM composition string. winex11: Compute preedit text buffer sizes in WCHAR units. winex11: Use an IME UI message to set composition status. imm32: Only send GCS_CURSORPOS when cursor position changes. winex11: Use an IME UI message to set cursor pos. winex11: Use an IME UI message to get cursor pos. winex11: Use an IME UI message to set open status. win32u: Keep the builtin IME UI window in win32u struct imc. imm32: Add a struct ime field to track whether IME is builtin. https://gitlab.winehq.org/wine/wine/-/merge_requests/2637

2 19

[PATCH 0/1] MR2710: ntdll: Implement efficiency class reporting for intel hybrid CPUs.
by Torge Matthies (＠tmatthies) April 26, 2023

April 26, 2023

Signed-off-by: Torge Matthies <tmatthies(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2710

2 1

[PATCH v3 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) April 26, 2023

April 26, 2023

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- v3: mfreadwrite/tests: Test GetService for MP4 sink writer. mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

2 2

[PATCH v7 0/4] MR2387: winegstreamer: Use stream format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) April 26, 2023

April 26, 2023

According to the tests in 23b72ad, when we are reading a compressed stream, the type returned by `stream_props_GetMediaType()` should reflect compressed format even if we finnally output uncomressed data. For example, if we use wmvcore reader to read a WMV3 stream and output RGB24, the format information returned by `stream_props_GetMediaType()` should be WMV3, not RGB24. -- v7: winegstreamer: Use stream format in stream_props_GetMediaType. winegstreamer: Implement amt_from_wg_format_video_wmv. winegstreamer: Implement wg_parser_stream_get_codec_format. winegstreamer: Introduce format_is_compressed. https://gitlab.winehq.org/wine/wine/-/merge_requests/2387

2 4

[PATCH v6 0/4] MR2387: winegstreamer: Use codec format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) April 26, 2023

April 26, 2023

According to the tests in 23b72ad, when we are reading a compressed stream, the type returned by `stream_props_GetMediaType()` should reflect compressed format even if we finnally output uncomressed data. For example, if we use wmvcore reader to read a WMV3 stream and output RGB24, the format information returned by `stream_props_GetMediaType()` should be WMV3, not RGB24. This patch set is marked as draft now, because PATCH 2 and PATCH 3 is affected by 3e8936a2 in MR !2258. So I'll submit a newer version of this after !2258 get merged. -- v6: winegstreamer: Use stream format in stream_props_GetMediaType. winegstreamer: Implement amt_from_wg_format_video_wmv. winegstreamer: Implement wg_parser_stream_get_stream_format. winegstreamer: Introduce format_is_compressed. https://gitlab.winehq.org/wine/wine/-/merge_requests/2387

4 9

[PATCH v2 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) April 26, 2023

April 26, 2023

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- v2: mfreadwrite/tests: Test getting media sink immediately after MFCreateSinkWriterFromURL. mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

3 8

[PATCH v2 0/2] MR2698: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence.
by Rémi Bernon April 26, 2023

April 26, 2023

-- v2: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence. winex11: Use a bit mask for event merge actions. https://gitlab.winehq.org/wine/wine/-/merge_requests/2698

2 4

[PATCH 0/1] MR71: Draft: vkd3d: Update Vulkan descriptors only when submitted to a command queue.
by Conor McCarthy (＠cmccarthy) April 26, 2023

April 26, 2023

Unpolished. Raises framerate by around 15% in SotTR because vk_sets_mutex is locked only once for each descriptor heap. It's possible to collate multiple writes for a single vkUpdateDescriptorSets() call as was done in the optimised copying path, but it may not be worth it. A possible complication with this: if it becomes possible to remove the descriptor mutexes after the remaining problems with queue sequencing are fixed, we theoretically may still need them for this. Descriptors should not be updated while binding, but there's no reason more can't be written in another thread while a command list is submitted to a queue. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/71

2 2

[PATCH v7 0/6] MR2669: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionControl into mmdevapi.
by Davide Beatrici (＠davidebeatrici) April 25, 2023

April 25, 2023

-- v7: winepulse: Use mmdevapi's AudioSessionControl. wineoss: Use mmdevapi's AudioSessionControl. winecoreaudio: Use mmdevapi's AudioSessionControl. winealsa: Use mmdevapi's AudioSessionControl. mmdevapi: Implement AudioSessionControl. mmdevapi: Implement empty AudioClient stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2669

2 6

Re: [PATCH v2 0/1] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics. - approved
by Francisco Casas (＠fcasas) April 25, 2023

April 25, 2023

This merge request was approved by Francisco Casas. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179

1 0

Re: [PATCH v6 0/9] MR2691: mshtml: More ref leak fixes. - approved
by Alexandre Julliard (＠julliard) April 25, 2023

April 25, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2691

1 0

Re: [PATCH v2 0/4] MR2702: Radeon - approved
by Alexandre Julliard (＠julliard) April 25, 2023

April 25, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2702

1 0

Re: [PATCH v5 0/5] MR2672: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0. - approved
by Alexandre Julliard (＠julliard) April 25, 2023

April 25, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2672

1 0

Re: [PATCH v2 0/4] MR2703: wineps: default device font, paths drawing and multiple pages document fixes - approved
by Alexandre Julliard (＠julliard) April 25, 2023

April 25, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2703

1 0

Re: [PATCH v3 0/2] MR2697: winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option(). - approved
by Alexandre Julliard (＠julliard) April 25, 2023

April 25, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2697

1 0

Re: [PATCH v3 0/4] MR2695: wine{alsa,coreaudio,oss,pulse}: Use dedicated macros to call interface functions. - approved
by Alexandre Julliard (＠julliard) April 25, 2023

April 25, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2695

1 0

Re: [PATCH v6 0/4] MR156: vkd3d: Use atomic exchange for descriptor writes. - approved
by Alexandre Julliard (＠julliard) April 25, 2023

April 25, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/156

1 0

Re: [PATCH v2 0/1] MR171: Initialize a pointer for MSVC.
by Stefan Dösinger April 25, 2023

April 25, 2023

On Tue Apr 25 20:26:04 2023 +0000, Henri Verbeet wrote: > As an aside, I should note that MSVC is not officially a supported > compiler for vkd3d. I'll happily take patches to make it work provided > they're not too unreasonable, but if it breaks, it breaks. The other issue I run into - and this is probably a Vulkan SDK thing, not MSVC as such - is that the options I have for GLSL.std.450.h are spirv-headers/GLSL.std.450.h spirv_cross/GLSL.std.450.h and not spirv/unified1/GLSL.std.450.h or vulkan/GLSL.std.450.h as checked by configure. Has the location changed in newer Vulkan SDK versions, or was this never tested on Windows (with any compiler) to begin with? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/171#note_31131

1 0

[PATCH 0/1] MR2706: ntdll: Print RPC_S_SERVER_UNAVAILABLE exceptions
by André Zwing April 25, 2023

April 25, 2023

While working on Wine ports or Hangover I sometimes come across exceptions with code=6ba. When I forget about which exception it is, I have a hard time figuring it out, as greping for 6ba shows nothing relevant. Only after conversion to dec (1722) one stumbles across the right exception. So please consider adding it to the list. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2706

1 1

[PATCH 0/1] MR180: vkd3d-shader/hlsl: Partially implement static expressions evaluation.
by Nikolay Sivov (＠nsivov) April 25, 2023

April 25, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/180

3 3

[PATCH v4 0/10] MR159: vkd3d-shader/hlsl: Broaden resources support v2, part 2.
by Francisco Casas (＠fcasas) April 25, 2023

April 25, 2023

Mainly comprises support for allocating arrays of resources, and loading from them, for both SM1 and SM4. -- v4: vkd3d-shader/hlsl: Support resource arrays when writting SM4. vkd3d-shader/hlsl: Write resource loads in SM1. vkd3d-shader/hlsl: Write sampler declarations in SM1. vkd3d-shader/hlsl: Track objects sampling dimension. vkd3d-shader/hlsl: Track object components usage and allocate registers accordingly. tests: Test objects as parameters. vkd3d-shader/hlsl: Skip object components when creating input/output copies. vkd3d-shader/hlsl: Add fixme for uniform copies for objects within structs. vkd3d-shader/hlsl: Support multiple-register variables in object regsets. tests: Add additional texture array register reservation tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159

2 12

[PATCH v5 0/9] MR2691: mshtml: More ref leak fixes.
by Gabriel Ivăncescu April 25, 2023

April 25, 2023

This should finally fix the ref leaks that keep all gecko nsDocuments alive even on the most basic docs. -- v5: mshtml/tests: Fix element leak in elem_fire_event. mshtml: Pass actual node_ccp to ccref_decr for nodes. mshtml: Fix nsChannel's load_info leak. mshtml: Support cycle collection for nsChannel. mshtml: Store minimum compat mode required for events in the ctor table. mshtml: Fix URI leak in NewURI on failure. mshtml: Fix nsIFile dir leak in init_xpcom. mshtml: Fix factory leak in init_nsio. mshtml: Do not release the principal returned by GetPrincipal. https://gitlab.winehq.org/wine/wine/-/merge_requests/2691

2 10

[PATCH 0/4] MR2702: Radeon
by Stefan Dösinger April 25, 2023

April 25, 2023

None -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2702

2 6

[PATCH v4 0/9] MR2691: mshtml: More ref leak fixes.
by Gabriel Ivăncescu April 25, 2023

April 25, 2023

This should finally fix the ref leaks that keep all gecko nsDocuments alive even on the most basic docs. -- v4: mshtml/tests: Fix element leak in elem_fire_event. mshtml: Pass actual node_ccp to ccref_decr for nodes. mshtml: Fix nsChannel's load_info leak. mshtml: Support cycle collection for nsChannel. mshtml: Store minimum compat mode required for events in the ctor table. mshtml: Fix URI leak in NewURI on failure. mshtml: Fix nsIFile dir leak in init_xpcom. mshtml: Fix factory leak in init_nsio. mshtml: Do not release the principal returned by GetPrincipal. https://gitlab.winehq.org/wine/wine/-/merge_requests/2691

2 13

[PATCH v3 0/9] MR2691: mshtml: More ref leak fixes.
by Gabriel Ivăncescu April 25, 2023

April 25, 2023

This should finally fix the ref leaks that keep all gecko nsDocuments alive even on the most basic docs. -- v3: mshtml/tests: Fix element leak in elem_fire_event. mshtml: Pass actual node_ccp to ccref_decr for nodes. mshtml: Fix nsChannel's load_info leak. mshtml: Support cycle collection for nsChannel. mshtml: Store minimum compat mode required for events in the ctor table. mshtml: Fix URI leak in NewURI on failure. mshtml: Fix nsIFile dir leak in init_xpcom. mshtml: Fix factory leak in init_nsio. mshtml: Do not release the principal returned by GetPrincipal. https://gitlab.winehq.org/wine/wine/-/merge_requests/2691

1 10

Re: [PATCH v6 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by Nikolay Sivov (＠nsivov) April 25, 2023

April 25, 2023

Nikolay Sivov (@nsivov) commented about include/shtypes.idl: > SCALE_450_PERCENT = 450, > SCALE_500_PERCENT = 500 > } DEVICE_SCALE_FACTOR; > + > +typedef [v1_enum] enum tagSFBS_FLAGS { > + SFBS_FLAGS_ROUND_TO_NEAREST_DISPLAYED_DIGIT = 0x0001, > + SFBS_FLAGS_TRUNCATE_UNDISPLAYED_DECIMAL_DIGITS = 0x0002 > +} SFBS_FLAGS; I don't see this in current SDK, it's not defined in an idl. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2609#note_31102

1 0

Re: [PATCH v6 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by Nikolay Sivov (＠nsivov) April 25, 2023

April 25, 2023

Nikolay Sivov (@nsivov) commented about dlls/shlwapi/string.c: > + { > + case SFBS_FLAGS_ROUND_TO_NEAREST_DISPLAYED_DIGIT: > + dBytes = round(dBytes / bfFormats[i].dDivisor) / bfFormats[i].dNormaliser; > + break; > + case SFBS_FLAGS_TRUNCATE_UNDISPLAYED_DECIMAL_DIGITS: > + dBytes = floor(dBytes / bfFormats[i].dDivisor) / bfFormats[i].dNormaliser; > + break; > + default: > + return E_INVALIDARG; > + } > > + /* Not sure about the error code. Can't find a way to trigger the error here */ > if (!FormatDouble(dBytes, bfFormats[i].nDecimals, lpszDest, cchMax)) > - return NULL; > + return E_UNEXPECTED; > + E_FAIL is probably more generic. Also comment is not really needed here. I'd also remove documentation comments before function declaration, leaving just function name there. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2609#note_31101

1 0

[PATCH 0/4] MR2703: wineps: default device font, paths drawing and multiple pages document fixes
by Piotr Caban (＠piotr) April 25, 2023

April 25, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2703

4 6

[PATCH v4 0/5] MR2672: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0.
by Mohamad Al-Jaf (＠maljaf) April 25, 2023

April 25, 2023

Needed for Minecraft Legends. -- v4: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0. twinapi.appcore: Add UnregisterAppStateChangeNotification stub. twinapi.appcore: Add RegisterAppStateChangeNotification stub. twinapi.appcore: Add stub DLL. include: Add appnotify.h file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2672

4 7

[PATCH v2 0/6] MR2628: Some more shell32 improvements.
by Jactry Zeng (＠jactry) April 25, 2023

April 25, 2023

-- v2: shell32: Update view mode flags while creating IShellView for IExplorerBrowser. shell32: Reimplement IExplorerBrowser_SetFolderSettings() with support of setting flags. shell32/tests: Move tests of IExplorerBrowser_SetFolderSettings() to a separated function and more tests. shell32: Reimplement IFolderView2_SetCurrentViewMode() with modern behaviours. shell32: Implement IFolderView2_{Get, Set}CurrentFolderFlags(). shell32/tests: Add tests for IFolderView2_{Get, Set}CurrentFolderFlags(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2628

2 7

[PATCH v2 0/2] MR2697: winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option().
by Vova Mshanetskiy (＠vovams) April 25, 2023

April 25, 2023

This is needed for mod.io integration in game "The Entropy Centre". Without support for this option the game hangs when trying to authenticate. Please note that i do not know how Wine works, and have very little understanding of what i am doing. I copied and adjusted code from `connect_query_option()` in the same file. The game does work with this patch though. -- v2: winhttp: Avoid unnecessary cast in connect_query_option(). winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2697

5 6

[PATCH v11 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) April 25, 2023

April 25, 2023

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v11: shell32: Fix last parameter behavior in SHBindToFolderIDListParent(). shell32/tests: Test SHBindToParent() last parameter behavior. shell32/tests: Add SHBindToFolderIDListParent() tests. shell32: Implement SHBindToFolderIDListParent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 7

[PATCH v7 0/13] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) April 24, 2023

April 24, 2023

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- v7: vkd3d-shader/hlsl: Consider duplicated input semantic types equivalent in SM1. vkd3d-shader/hlsl: Handle possibly different types in input semantic var load. vkd3d-shader/hlsl: Error out when a semantic is used with incompatible types. vkd3d-shader/hlsl: Error out when an output semantic is used more than once. vkd3d-shader/hlsl: Support semantics for array types. vkd3d-shader/hlsl: Don't create semantic vars more than once. vkd3d-shader/hlsl: Move get_array_size() and get_array_type() to hlsl.c. tests: Test duplicated semantics. tests: Test array types with semantics. vkd3d-shader/hlsl: Avoid invalid input/output copies for non-numeric types. tests: Map unindentified hrs on compilation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

2 15

[PATCH v2 0/4] MR2695: wine{alsa,coreaudio,oss,pulse}: Use dedicated macros to call interface functions.
by Davide Beatrici (＠davidebeatrici) April 24, 2023

April 24, 2023

-- v2: winepulse: Use dedicated macros to call interface functions. wineoss: Use dedicated macros to call interface functions. winecoreaudio: Use dedicated macros to call interface functions. winealsa: Use dedicated macros to call interface functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/2695

3 5

Re: [PATCH v3 0/2] MR2674: d3d10: Use the vkd3d-shader DXBC API. - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2674

1 0

Re: [PATCH v2 0/1] MR2696: ntdll: Avoid integer overflow in block_get_subheap(). - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2696

1 0

Re: [PATCH v2 0/1] MR2686: ntdll: Mind LFH pending blocks in RtlDestroyHeap(). - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2686

1 0

Re: [PATCH v3 0/1] MR1950: widl: Initialize __frame to a default value (Coverity) - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1950

1 0

Re: [PATCH v6 0/2] MR2618: ntdll: Increment offset by len in build_clr_surrogate_section. - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2618

1 0

Re: [PATCH v2 0/4] MR2694: wine{alsa,coreaudio,oss,pulse}: Implement functions to lock and unlock sessions. - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2694

1 0

Re: [PATCH v2 0/7] MR2693: gdi32: EMF palette recording improvements. - approved
by Alexandre Julliard (＠julliard) April 24, 2023

April 24, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2693

1 0

[PATCH v6 0/12] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) April 24, 2023

April 24, 2023

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- v6: vkd3d-shader/hlsl: Consider duplicated input semantic types equivalent in SM1. vkd3d-shader/hlsl: Handle possibly different types in input semantic var load. vkd3d-shader/hlsl: Error out when a semantic is used with incompatible types. vkd3d-shader/hlsl: Error out when an output semantic is used more than once. vkd3d-shader/hlsl: Support semantics for array types. vkd3d-shader/hlsl: Don't create semantic vars more than once. vkd3d-shader/hlsl: Move get_array_size() and get_array_type() to hlsl.c. tests: Test duplicated semantics. tests: Test array types with semantics. vkd3d-shader/hlsl: Avoid invalid input/output copies for non-numeric types. tests: Allow invalid vertex shader tests. tests: Expect S_OK result on [vertex shader]. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

4 29

[PATCH 0/1] MR2701: ntdll: Decrement thread count from exit_thread and exit the process if needed.
by Tim Clem (＠tclem) April 24, 2023

April 24, 2023

The `nb_threads` counter in ntdll is decremented by `abort_thread` but not `exit_thread`, which is used when `NtTerminateThread` is called on the current thread. That results in `nb_threads` being off by one, so neither `abort_thread` nor `exit_thread` will notice when the final thread is killed or call `abort_process`/`exit_process` of its own volition. In some instances that results in the final thread of a process hanging around and continuing to do work until it's killed by the server's SIGKILL timer. Since most of the process' internal state has been torn down by that point, that usually results in syscall faults or server `write` failures. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2701

2 1

[PATCH v2 0/5] MR176: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 3.
by Zebediah Figura (＠zfigura) April 24, 2023

April 24, 2023

-- v2: vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_resource_store(). vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_resource_load(). vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_loop(). vkd3d-shader/hlsl: Pass an hlsl_block pointer to hlsl_new_loop(). vkd3d-shader/hlsl: Reuse the "init" instruction list if possible in create_loop(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/176

2 5

[PATCH v6 0/2] MR178: vkd3d-shader/hlsl: Add support for sign() intrinsic.
by Ethan Lee (＠flibitijibibo) April 24, 2023

April 24, 2023

This replicates what seems to be happening when using sign() with shader model 3, which is roughly... ``` int pos = (int) (x > 0); int neg = -((int) (x < 0)); int result = pos + neg; ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=54826 -- v6: tests: Add tests for sign() intrinsic. vkd3d-shader/hlsl: Add support for sign() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/178

2 3

[PATCH 0/1] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics.
by Ethan Lee (＠flibitijibibo) April 24, 2023

April 24, 2023

SPIR-V already handled DSX/DSY, so only D3DBC/TPF needed new case blocks. You'll notice that there's no test for this one - in addition to being a pretty straightforward translation for all possible formats, this feature uses the render target width/height and I wasn't sure if there was a good way to ensure that the test would always make sense. Instead, I did the test manually, and it's what you'd expect: HLSL: ``` uniform float f; float4 main() : sv_target { float4 x = ddx(f); float4 y = ddy(f); return x + y; } ``` D3DBC: ``` ps_3_0 mov r0.x, c0.x dsx r1.x, r0.x dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov oC0.xyzw, r0.xyzw ``` DXBC-TPF: ``` ps_4_0 dcl_constantBuffer cb0[1], immediateIndexed dcl_output o0.xyzw dcl_temps 2 mov r0.x, cb0[0].x dsx r0.y, r0.x dsy r0.x, r0.x mov r1.xyzw, r0.y mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov o0.xyzw, r0.xyzw ret ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179

4 4

[PATCH 0/2] MR2692: msi:custom: ok_() takes printf-style arguments.
by Francois Gouget (＠fgouget) April 24, 2023

April 24, 2023

custom.c does not use the test.h and debug.h definitions and presumably has a good reason not to. But this resulted in the printf-format compiler attribute getting lost. So copy it from debug.h to allow proper checks of the ok_() format string. Also fix said format strings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2692

3 4

[PATCH v5 0/2] MR178: vkd3d-shader/hlsl: Add support for sign() intrinsic.
by Ethan Lee (＠flibitijibibo) April 24, 2023

April 24, 2023

This replicates what seems to be happening when using sign() with shader model 3, which is roughly... ``` int pos = (int) (x > 0); int neg = -((int) (x < 0)); int result = pos + neg; ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=54826 -- v5: tests: Add tests for sign() intrinsic. vkd3d-shader/hlsl: Add support for sign() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/178

3 3

[PATCH v3 0/10] MR159: vkd3d-shader/hlsl: Broaden resources support v2, part 2.
by Francisco Casas (＠fcasas) April 24, 2023

April 24, 2023

Mainly comprises support for allocating arrays of resources, and loading from them, for both SM1 and SM4. -- v3: vkd3d-shader/hlsl: Support resource arrays when writting SM4. vkd3d-shader/hlsl: Write resource loads in SM1. vkd3d-shader/hlsl: Write sampler declarations in SM1. vkd3d-shader/hlsl: Track objects sampling dimension. vkd3d-shader/hlsl: Track object components usage and allocate registers accordingly. tests: Test objects as parameters. vkd3d-shader/hlsl: Skip object components when creating input/output copies. vkd3d-shader/hlsl: Add fixme for uniform copies for objects within structs. vkd3d-shader/hlsl: Support multiple-register variables in object regsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/159

3 13

[PATCH v2 0/12] MR2691: mshtml: More ref leak fixes.
by Gabriel Ivăncescu April 24, 2023

April 24, 2023

This should finally fix the ref leaks that keep all gecko nsDocuments alive even on the most basic docs. -- v2: mshtml/tests: Fix element leak in elem_fire_event. mshtml: Pass actual node_ccp to ccref_decr for nodes. mshtml: Fix nsChannel's load_info leak. mshtml: Support cycle collection for nsChannel. mshtml: Ensure SnowWhite objects are cleared when forcing cycle collection. mshtml: Supply dummy logger when forcing cycle collection. mshtml: Flush all gecko thread events after detaching Gecko browser. mshtml: Fix nsProgressEvent leak for pre IE10 modes. mshtml: Fix URI leak in NewURI on failure. mshtml: Fix nsIFile dir leak in init_xpcom. mshtml: Fix factory leak in init_nsio. mshtml: Do not release the principal returned by GetPrincipal. https://gitlab.winehq.org/wine/wine/-/merge_requests/2691

3 19

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Tim Clem (＠tclem) April 24, 2023

April 24, 2023

On Mon Apr 24 17:46:10 2023 +0000, Nikolay Sivov wrote: > Another option is to build separate modules with PARENTSRC. Was it dismissed? Right, sorry, meant to mention that. I was trying to avoid having a multiple-megabyte copy of libxml2 in each msxml*.dll. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31019

1 0

[PATCH v3 0/5] MR2672: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0.
by Mohamad Al-Jaf (＠maljaf) April 24, 2023

April 24, 2023

Needed for Minecraft Legends. -- v3: apisetschema: Add api-ms-win-core-psm-appnotify-l1-1-0. twinapi.appcore: Add UnregisterAppStateChangeNotification stub. twinapi.appcore: Add RegisterAppStateChangeNotification stub. twinapi.appcore: Add stub DLL. include: Add appnotify.h file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2672

5 11

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Nikolay Sivov (＠nsivov) April 24, 2023

April 24, 2023

Another option is to build separate modules with PARENTSRC. Was it dismissed? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31015

1 0

[PATCH 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Tim Clem (＠tclem) April 24, 2023

April 24, 2023

Currently, all the Wine msxml versions point to msxml3. So if there is a native override for msxml3, all the other versions will cease to work, since they expect our msxml3. This change moves the actual implementation to winexml.dll, so that all versions will function even if msxml3 is native. Suggestions welcome. I wasn't quite sure what should end up where, so I took the approach of only moving the absolutely necessary components to winexml. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700

2 2

[PATCH v6 0/10] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon April 24, 2023

April 24, 2023

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v6: ntdll: Avoid writing to invalid memory in i386 unix dispatcher. ntdll: Set %rsp before args in x86_64 call_user_mode_callback. ntdll: Fix incorrect i386 call_user_mode_callback CFI. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. ntdll: Allocate a truly separate stack for the kernel stack. ntdll: Maintain a PE module link map and expose it to GDB. ntdll: Pass a UNICODE_STRING to load_builtin and virtual_map_image. loader: Expose a shadow copy of ld.so link map to GDB. ntdll: Add .cfi_signal_frame to __wine_syscall_dispatcher. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

3 13

[PATCH 0/1] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) April 24, 2023

April 24, 2023

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

3 9

[PATCH 0/1] MR2654: libs/vkd3d: Leave the command queue op mutex locked after a partial flush.
by Giovanni Mascellani (＠giomasce) April 24, 2023

April 24, 2023

All return paths in d3d12_command_queue_flush_ops_locked() must leave the op mutex locked. (cherry-picked from upstream commit e27ceddfb4a89470d5d35ab4391d0a5cf4453ef1) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2654

4 4

[PATCH v5 0/4] MR156: vkd3d: Use atomic exchange for descriptor writes.
by Conor McCarthy (＠cmccarthy) April 24, 2023

April 24, 2023

-- v5: vkd3d: Collect multiple descriptor writes in a buffer and update in one call. vkd3d: Use atomic exchange for descriptor writes. vkd3d: Delay writing Vulkan descriptors until submitted to a queue. vkd3d: Ensure descriptors are pointer aligned. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/156

2 4

[PATCH 0/2] MR2698: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence.
by Rémi Bernon April 24, 2023

April 24, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2698

2 4

[PATCH v2 0/2] MR2674: d3d10: Use the vkd3d-shader DXBC API.
by Henri Verbeet (＠hverbeet) April 24, 2023

April 24, 2023

-- v2: d3d10: Implement parse_fx10_preshader() on top of vkd3d_shader_parse_dxbc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2674

3 4

[PATCH v4 0/4] MR156: vkd3d: Use atomic exchange for descriptor writes.
by Conor McCarthy (＠cmccarthy) April 24, 2023

April 24, 2023

-- v4: vkd3d: Collect multiple descriptor writes in a buffer and update in one call. vkd3d: Use atomic exchange for descriptor writes. vkd3d: Delay writing Vulkan descriptors until submitted to a queue. vkd3d: Ensure descriptors are pointer aligned. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/156

4 6

[PATCH v10 0/2] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) April 24, 2023

April 24, 2023

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v4: Don't reimplement SHBindToParent. -- v10: shell32/tests: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

4 3

[PATCH 0/1] MR2696: ntdll: Avoid integer overflow in block_get_subheap().
by Paul Gofman (＠gofman) April 24, 2023

April 24, 2023

'block->base_offset * REGION_ALIGN' overflows once WORD base_offset value reaches 0x8000, so block_get_subheap() returns wrong address. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2696

3 2

[PATCH 0/1] MR2686: ntdll: Mind LFH pending blocks in RtlDestroyHeap().
by Paul Gofman (＠gofman) April 24, 2023

April 24, 2023

Pending block may be LFH block and freeing it with heap_free_block() crashes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2686

3 2

[PATCH 0/1] MR2697: winhttp: Support WINHTTP_OPTION_PARENT_HANDLE in request_query_option().
by Vova Mshanetskiy (＠vovams) April 24, 2023

April 24, 2023

This is needed for mod.io integration in game "The Entropy Centre". Without support for this option the game hangs when trying to authenticate. Please note that i do not know how Wine works, and have very little understanding of what i am doing. I copied and adjusted code from `connect_query_option()` in the same file. The game does work with this patch though. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2697

3 2

Re: [PATCH v6 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by David Kahurani (＠kahurani) April 24, 2023

April 24, 2023

Hi, It looks like this has stalled. @nsivov Are you okay with this? I made changes to address your comment, just in case you have not looked at them already. @julliard It doesn't look like there's a designated reviewer on this front. Any suggestions on changes I could possibly make to improve the chances of this getting merged? It looks like there's an application using it and more importantly, it looks like someone might be in need of this... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2609#note_30976

1 0

[PATCH v2 0/1] MR1950: widl: Initialize __frame to a default value (Coverity)
by Alistair Leslie-Hughes (＠alesliehughes) April 24, 2023

April 24, 2023

In the generate code, Converity is reporting __frame->code unitilized in the failed case. When we initialize the object, then __f will also point to a fully initizliaed structure. -- v2: widl: Suppress a coverity warning https://gitlab.winehq.org/wine/wine/-/merge_requests/1950

4 4

[PATCH v4 0/4] MR2688: tasklist: Add basic functionality.
by Zhiyi Zhang (＠zhiyi) April 23, 2023

April 23, 2023

Company of Heroes: Battle of Crete needs a functioning tasklist.exe to exit properly. -- v4: tasklist: Partially support '/fi' option. tasklist: Support '/fo' option. tasklist: Support '/nh' option. tasklist: Add basic functionality. https://gitlab.winehq.org/wine/wine/-/merge_requests/2688

3 5