April 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/28] MR2595: include: Add windows.ui.composition.idl file.
by Biswapriyo Nath (＠Biswa96) April 17, 2023

April 17, 2023

On Mon Apr 17 04:50:13 2023 +0000, Mohamad Al-Jaf wrote: > Is the file windows.graphics.directx.idl in mingw updated? It has the > definitions of those enums. Yes, all the IDL files are updated wrt. wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2595#note_30195

1 0

Re: [PATCH v2 0/28] MR2595: include: Add windows.ui.composition.idl file.
by Mohamad Al-Jaf (＠maljaf) April 17, 2023

April 17, 2023

On Mon Apr 17 04:50:14 2023 +0000, Biswapriyo Nath wrote: > The generated header file shows the following compiler warning in clang > mingw-w64 toolchain. > ``` > F:/msys64/clang64/include/windows.ui.composition.h:4919:30: error: ISO > C++ forbids forward references to 'enum' types > enum DirectXAlphaMode *value) = 0; > ^ > F:/msys64/clang64/include/windows.ui.composition.h:4922:30: error: ISO > C++ forbids forward references to 'enum' types > enum DirectXPixelFormat *value) = 0; > ^ > ``` > Is that related to this IDL file in some way? Is the file windows.graphics.directx.idl in mingw updated? It has the definitions of those enums. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2595#note_30194

1 0

Re: [PATCH v2 0/28] MR2595: include: Add windows.ui.composition.idl file.
by Biswapriyo Nath (＠Biswa96) April 17, 2023

April 17, 2023

The generated header file shows the following compiler warning in clang mingw-w64 toolchain. ``` F:/msys64/clang64/include/windows.ui.composition.h:4919:30: error: ISO C++ forbids forward references to 'enum' types enum DirectXAlphaMode *value) = 0; ^ F:/msys64/clang64/include/windows.ui.composition.h:4922:30: error: ISO C++ forbids forward references to 'enum' types enum DirectXPixelFormat *value) = 0; ^ ``` Is that related to this IDL file in some way? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2595#note_30190

1 0

Re: [PATCH v7 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) April 17, 2023

April 17, 2023

On Mon Apr 17 01:22:12 2023 +0000, Biswapriyo Nath wrote: > Apology for hijacking this thread. Would you like to add > windows.graphics.capture.interop.idl please? Required for pywinrt > project. I have tried to add it like you did but get compiler error in > that project. No problem, happy to help. Sure, I took a look and it generates this error: tools/widl/widl -o include/windows.graphics.capture.interop.h -m32 --nostdinc -Ldlls/\* -Iinclude -Iinclude -D__WINESRC__ \ include/windows.graphics.capture.interop.idl include/windows.h:38:1: error: Unable to open include file stdarg.h make[1]: *** [Makefile:163589: include/windows.graphics.capture.interop.h] Error 1 It doesn't seem worth debugging the error so adding in the equivalent .h file should be fine. MR https://gitlab.winehq.org/wine/wine/-/merge_requests/2658 created. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2620#note_30184

1 0

Re: [PATCH v7 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Biswapriyo Nath (＠Biswa96) April 16, 2023

April 16, 2023

Apology for hijacking this thread. Would you like to add windows.graphics.capture.interop.idl please? Required for pywinrt project. I have tried to add it like you did but get compiler error in that project. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2620#note_30181

1 0

[PATCH v3 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Bernhard Übelacker April 15, 2023

April 15, 2023

Without this patch the memory pointed to by context->in_buff gets leaked on each call to GetVolumeInformationByHandleW and the memory usage of winedevice.exe grows. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52322 -- v3: ntoskrnl: Do not leak memory by setting input buffer to NULL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2439

1 2

Re: [PATCH v2 0/1] MR2439: ntoskrnl: Free memory before pointer gets set to NULL.
by Bernhard Übelacker April 15, 2023

April 15, 2023

On Tue Apr 11 18:16:38 2023 +0000, Zebediah Figura wrote: > This seems unrelated and unnecessary. Yes, this was just to make sure not to release the same buffer twice. At least, with this assignment removed, my test program from bugzilla behaves the same. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2439#note_30160

1 0

Re: [PATCH v2 0/7] MR2562: winex11: Preparatory XIM cleanup.
by Jinoh Kang (＠iamahuman) April 15, 2023

April 15, 2023

Jinoh Kang (@iamahuman) commented about dlls/winex11.drv/xim.c: > - XNStatusAttributes, status, > - XNClientWindow, win, > - XNFocusWindow, win, > - XNDestroyCallback, &destroy, > - NULL); > - } > - else > - { > - xic = XCreateIC(xim, > - XNInputStyle, ximStyle, > - XNClientWindow, win, > - XNFocusWindow, win, > - XNDestroyCallback, &destroy, > - NULL); > - } > + preedit = XVaCreateNestedList( 0, XNFontSet, fontSet, Why is this code assuming that `fontSet` is not `NULL`, regardless of `(ximStyle & (XIMPreeditNothing | XIMPreeditNone)) == 0`? It appears to me that the code that actually sets `x11drv_thread_data()->font_set` does so only if the condition is true. (Yes, I'm aware that later commit changes font set handling, but bisection points to this one as the first bad commit.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2562#note_30159

1 0

[PATCH v8 0/1] MR150: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops.
by Nikolay Sivov (＠nsivov) April 14, 2023

April 14, 2023

-- v8: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150

4 3

[PATCH v5 0/1] MR2390: winegstreamer: Cache wg_parser input data.
by Derek Lesho (＠dlesho) April 14, 2023

April 14, 2023

On my Steam Deck, this reduces the time it takes to initialize the wg_parser radically (by around 1 second). This helps in the game WILD HEARTS, which doesn't present while loading help videos during gameplay, causing large stutters. Because GStreamer can randomly access the file with no known pattern on our side, I opted to implement this by buffering 4 chunks so that interleaved reads to different areas of the file don't cause us to discard and reload cached data more than we need to. -- v5: winegstreamer: Cache wg_parser input data. https://gitlab.winehq.org/wine/wine/-/merge_requests/2390

3 3

Re: [PATCH v8 0/7] MR1979: msvcrt: Remaining stubs for cm3 - approved
by Alexandre Julliard (＠julliard) April 14, 2023

April 14, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

1 0

Re: [PATCH v3 0/7] MR2640: winegstreamer: Factor some common helpers between wg_parser and wg_transform. - approved
by Alexandre Julliard (＠julliard) April 14, 2023

April 14, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2640

1 0

Re: [PATCH v3 0/14] MR2653: wineps: Support more spool file records - approved
by Alexandre Julliard (＠julliard) April 14, 2023

April 14, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2653

1 0

Re: [PATCH v4 0/3] MR2642: mmdevapi: Rename mmdevapi.h to mmdevapi_private.h, add missing includes and typedef to that and mmdevdrv.h. - approved
by Alexandre Julliard (＠julliard) April 14, 2023

April 14, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2642

1 0

[PATCH 0/1] MR2571: appwiz.cpl: Launch uninstaller in a thread.
by Jactry Zeng (＠jactry) April 14, 2023

April 14, 2023

In the current implementation, the main UI will be blocked after the uninstaller is launched. Put the uninstall process in a thread to avoid that, and popup a message while trying to launch multiple uninstallers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2571

3 2

[PATCH v7 0/7] MR1979: msvcrt: Remaining stubs for cm3
by Torge Matthies (＠tmatthies) April 14, 2023

April 14, 2023

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v7: msvcr100: Use Context blocking functions in reader_writer_lock class. msvcr100: Add ExternalContextBase::Unblock implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

4 8

[PATCH v6 0/7] MR1979: msvcrt: Remaining stubs for cm3
by Torge Matthies (＠tmatthies) April 14, 2023

April 14, 2023

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v6: msvcr100: Use Context blocking functions in reader_writer_lock class. msvcr100: Add ExternalContextBase::Unblock implementation. msvcr100: Add ExternalContextBase::IsSynchronouslyBlocked() implementation. msvcr100: Add ExternalContextBase::Block() implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

4 10

[PATCH v5 0/7] MR1979: msvcrt: Remaining stubs for cm3
by Torge Matthies (＠tmatthies) April 14, 2023

April 14, 2023

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v5: msvcr100: Use Context blocking functions in reader_writer_lock class. msvcr100: Add ExternalContextBase::Unblock implementation. msvcr100: Add ExternalContextBase::IsSynchronouslyBlocked() implementation. msvcr100: Add ExternalContextBase::Block() implementation. msvcr100: Add Context::Block() implementation. msvcr100: Add missing ExternalContextBase virtual functions stubs. msvcr110: Implement _Context::_IsSynchronouslyBlocked. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

4 10

[PATCH v7 0/2] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) April 14, 2023

April 14, 2023

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v7: winegstreamer: In video_processor, activate a videoflip converter. mf/tests: Add tests about (negative) stride handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

3 11

[PATCH v6 0/1] MR135: vkd3d-shader/hlsl: Add support for sample index argument in Load().
by Nikolay Sivov (＠nsivov) April 14, 2023

April 14, 2023

-- v6: vkd3d-shader/hlsl: Add support for sample index argument in Load(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/135

2 1

[PATCH v2 0/5] MR153: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 1.
by Zebediah Figura (＠zfigura) April 14, 2023

April 14, 2023

The motivation for this is twofold. Firstly, this makes code a little nicer to read, by virtue of removing a ubiquitous &(...)->node. Secondly, and more importantly, this allows for the possibility of constructors returning a different instruction type than intended. The ultimate goal here is to return a preallocated "error" instruction when allocation fails, instead of returning NULL and propagating out-of-memory handling to the caller. -- v2: vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_if(). vkd3d-shader/hlsl: Pass hlsl_block pointers to hlsl_new_if(). vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_float_constant(). vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_cast() and hlsl_new_copy(). vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_bool_constant(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/153

3 10

[PATCH v3 0/2] MR157: vkd3d-shader/hlsl: Add support for any() intrinsic.
by Ethan Lee (＠flibitijibibo) April 14, 2023

April 14, 2023

For now, this is limited to float and bool, scalar and vector. All other types are unsupported. Fixes https://bugs.winehq.org/show_bug.cgi?id=54777 -- v3: tests: Add tests for any() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/157

4 6

[PATCH v2 0/14] MR2653: wineps: Support more spool file records
by Piotr Caban (＠piotr) April 14, 2023

April 14, 2023

-- v2: wineps: Handle EMR_SETTEXTJUSTIFICATION record in spool files. wineps: Handle EMR_SETLAYOUT record in spool files. wineps: Handle EMR_SETPOLYFILLMODE record in spool files. wineps: Handle EMR_SETBKMODE record in spool files. wineps: Handle EMR_SETMAPMODE record in spool files. wineps: Handle EMR_SETMAPPERFLAGS record in spool files. wineps: Silence FIXME message on EMR_EXTFLOODFILL record. wineps: Silence FIXME message on EMR_ALPHABLEND record. wineps: Handle EMR_EXTESCAPE record in spool files. wineps: Handle EMR_RESTOREDC record in spool files. wineps: Handle EMR_SAVEDC in spool files. wineps: Handle EMR_SETBKCOLOR record in spool files. wineps: Handle EMR_SETTEXTCOLOR record in spool files. wineps: Don't store currently selected brush in print processor data. https://gitlab.winehq.org/wine/wine/-/merge_requests/2653

3 16

[PATCH v6 0/2] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) April 14, 2023

April 14, 2023

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v6: winegstreamer: In video_processor, activate a videoflip converter. mf/tests: Add tests about (negative) stride handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

4 17

[PATCH 0/14] MR2653: wineps: Support more spool file records
by Piotr Caban (＠piotr) April 14, 2023

April 14, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2653

2 14

[PATCH v3 0/3] MR2642: mmdevapi: Rename mmdevapi.h to mmdevapi_private.h, add missing includes and typedef to that and mmdevdrv.h.
by Davide Beatrici (＠davidebeatrici) April 14, 2023

April 14, 2023

This should make it clear it's not an external header. It could be confused with `mmdeviceapi.h`, in particular. -- v3: mmdevapi: Add missing includes and typedef to mmdevdrv.h. mmdevapi: Add missing includes to mmdevapi_private.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/2642

3 5

[PATCH v2 0/9] MR2637: winex11: Use messages instead of user callbacks and handle them in the default IME UI window procedure.
by Rémi Bernon April 14, 2023

April 14, 2023

-- v2: winex11: Use the new helper to set COMPOSITIONSTRING text. winex11: Use EM_REPLACESEL to set IME composition strings. winex11: Always zero terminate XIM composition string. winex11: Compute preedit text buffer sizes in WCHAR units. winex11: Use an IME UI message to set composition status. winex11: Use an IME UI message to set cursor pos. winex11: Use an IME UI message to get cursor pos. winex11: Use an IME UI message to set open status. win32u: Keep the IME UI window in win32u struct imc. https://gitlab.winehq.org/wine/wine/-/merge_requests/2637

3 14

[PATCH v4 0/9] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) April 14, 2023

April 14, 2023

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- v4: vkd3d-shader/hlsl: Error out when a semantic is used with multiple types. vkd3d-shader/hlsl: Error out when an output semantic is used more than once. vkd3d-shader/hlsl: Don't create semantic vars more than once. vkd3d-shader/hlsl: Support semantics for array types. vkd3d-shader/hlsl: Move get_array_size() and get_array_type() to hlsl.c. tests: Test array types with semantics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

3 13

[PATCH v2 0/4] MR156: vkd3d: Use atomic exchange for descriptor writes.
by Conor McCarthy (＠cmccarthy) April 14, 2023

April 14, 2023

-- v2: vkd3d: Buffer descriptor writes. vkd3d: Use atomic exchange for descriptor writes. vkd3d: Delay writing Vulkan descriptors until submitted to a queue. vkd3d: Ensure descriptors are pointer aligned. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/156

3 5

[PATCH v2 0/1] MR158: vkd3d-shader: Consistently pass location structure by pointer.
by Nikolay Sivov (＠nsivov) April 14, 2023

April 14, 2023

-- v2: vkd3d-shader: Consistently pass location structure by pointer. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/158

3 3

[PATCH v7 0/1] MR150: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops.
by Nikolay Sivov (＠nsivov) April 14, 2023

April 14, 2023

-- v7: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150

3 3

[PATCH v2 0/2] MR157: vkd3d-shader/hlsl: Add support for any() intrinsic.
by Ethan Lee (＠flibitijibibo) April 13, 2023

April 13, 2023

For now, this is limited to float and bool, scalar and vector. All other types are unsupported. Fixes https://bugs.winehq.org/show_bug.cgi?id=54777 -- v2: tests: Add tests for any() intrinsic. vkd3d-shader/hlsl: Add support for any() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/157

3 4

[PATCH v6 0/1] MR150: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops.
by Nikolay Sivov (＠nsivov) April 13, 2023

April 13, 2023

-- v6: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150

3 2

[PATCH v5 0/1] MR135: vkd3d-shader/hlsl: Add support for sample index argument in Load().
by Nikolay Sivov (＠nsivov) April 13, 2023

April 13, 2023

-- v5: vkd3d-shader/hlsl: Add support for sample index argument in Load(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/135

4 3

[PATCH v2 0/7] MR2640: winegstreamer: Factor some common helpers between wg_parser and wg_transform.
by Rémi Bernon April 13, 2023

April 13, 2023

-- v2: winegstreamer: Introduce new stream_type_from_caps helper. winegstreamer: Introduce new link_src_to_element / link_element_to_sink helpers. winegstreamer: Remove unnecessary unlink in pad-removed callback. winegstreamer: Use append_element to build wg_parser pipeline. winegstreamer: Sync element state with parent in append_element. winegstreamer: Move some wg_parser / wg_transform helpers to unixlib.c. winegstreamer: Introduce a new wg_init_gstreamer unixlib entry. https://gitlab.winehq.org/wine/wine/-/merge_requests/2640

2 10

[PATCH v4 0/1] MR2390: winegstreamer: Cache wg_parser input data.
by Derek Lesho (＠dlesho) April 13, 2023

April 13, 2023

On my Steam Deck, this reduces the time it takes to initialize the wg_parser radically (by around 1 second). This helps in the game WILD HEARTS, which doesn't present while loading help videos during gameplay, causing large stutters. Because GStreamer can randomly access the file with no known pattern on our side, I opted to implement this by buffering 4 chunks so that interleaved reads to different areas of the file don't cause us to discard and reload cached data more than we need to. -- v4: winegstreamer: Cache wg_parser input data. https://gitlab.winehq.org/wine/wine/-/merge_requests/2390

3 6

Re: [PATCH v2 0/1] MR2652: wineps: Fix SetPixel implementation. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2652

1 0

Re: [PATCH v2 0/2] MR2651: gdi32: Handle EMR_TRANSPARENTBLT record in PlayEnhMetaFileRecord. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2651

1 0

Re: [PATCH v2 0/1] MR2646: advapi32/tests: Make the services resume handle traces more informative. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2646

1 0

Re: [PATCH v2 0/1] MR2647: dnsapi/tests: Test how DnsQuery() handles CNAMEs. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2647

1 0

Re: [PATCH v2 0/1] MR2645: user32/tests: Windows 11's notepad has four icons. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2645

1 0

Re: [PATCH v2 0/13] MR2644: imm32: Test and fix some input context getter / setters. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2644

1 0

Re: [PATCH v3 0/14] MR2643: wineps: Support more spool file record types (clipping, paths, gradientfill) - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2643

1 0

Re: [PATCH v7 0/2] MR2620: include: Add windows.ui.composition.interop.idl file. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

1 0

Re: [PATCH v9 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

1 0

Re: [PATCH v3 0/2] MR154: vkd3d-shader/hlsl: Fix numeric offset of object fields. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/154

1 0

Re: [PATCH v5 0/3] MR140: vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/140

1 0

Re: [PATCH v7 0/4] MR89: vkd3d-shader/hlsl: Improve support for logarithmic functions. - approved
by Alexandre Julliard (＠julliard) April 13, 2023

April 13, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/89

1 0

[PATCH 0/1] MR158: vkd3d-shader: Consistently pass location structure by pointer.
by Nikolay Sivov (＠nsivov) April 13, 2023

April 13, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/158

2 1

[PATCH v2 0/4] MR2642: mmdevapi: Rename mmdevapi.h to mmdevapi_private.h, add missing includes and typedef to that and mmdevdrv.h.
by Davide Beatrici (＠davidebeatrici) April 13, 2023

April 13, 2023

This should make it clear it's not an external header. It could be confused with `mmdeviceapi.h`, in particular. -- v2: mmdevapi: Add missing includes and typedef to mmdevdrv.h. mmdevapi: Add missing includes to mmdevapi_private.h. mmdevapi: Swap includes order in mmdevapi_private.h, for consistency. https://gitlab.winehq.org/wine/wine/-/merge_requests/2642

3 5

[PATCH 0/3] MR2650: mshtml: Implement MediaQueryList listeners.
by Gabriel Ivăncescu April 13, 2023

April 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2650

2 4

[PATCH 0/1] MR2652: wineps: Fix SetPixel implementation.
by Piotr Caban (＠piotr) April 13, 2023

April 13, 2023

Without the patch SetPixel produces no output on my printer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2652

3 2

[PATCH 0/3] MR2642: mmdevapi: Rename mmdevapi.h to mmdevapi_private.h, add missing includes and typedef to that and mmdevdrv.h.
by Davide Beatrici (＠davidebeatrici) April 13, 2023

April 13, 2023

This should make it clear it's not an external header. It could be confused with `mmdeviceapi.h`, in particular. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2642

3 10

[PATCH 0/2] MR2651: gdi32: Handle EMR_TRANSPARENTBLT record in PlayEnhMetaFileRecord.
by Piotr Caban (＠piotr) April 13, 2023

April 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2651

3 3

[PATCH 0/2] MR157: vkd3d-shader/hlsl: Add support for any() intrinsic.
by Ethan Lee (＠flibitijibibo) April 13, 2023

April 13, 2023

For now, this is limited to float and bool, scalar and vector. All other types are unsupported. Fixes https://bugs.winehq.org/show_bug.cgi?id=54777 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/157

2 2

[PATCH 0/2] MR2649: wininet/tests: Add constants for DetectAutoProxyUrl() and more proxy tests.
by Francois Gouget (＠fgouget) April 13, 2023

April 13, 2023

--- See also https://bugs.winehq.org/show_bug.cgi?id=54818 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2649

3 3

[PATCH 0/1] MR2646: advapi32/tests: Make the services resume handle traces more informative.
by Francois Gouget (＠fgouget) April 13, 2023

April 13, 2023

--- One of them fails from time to time which is most likely a 'service stop race condition'. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2646

2 2

[PATCH 0/1] MR2647: dnsapi/tests: Test how DnsQuery() handles CNAMEs.
by Francois Gouget (＠fgouget) April 13, 2023

April 13, 2023

--- Inspired by https://bugs.winehq.org/show_bug.cgi?id=54819 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2647

3 2

[PATCH v7 0/5] MR2476: winewayland.drv: part 2: Display configuration enhancements
by Alexandros Frantzis (＠afrantzis) April 13, 2023

April 13, 2023

This second MR in the Wayland series adds display configuration related enhancements, including providing more display information (like a proper/consistent name and position) to Wine and supporting GetCurrentDisplaySettings. To get additional information from the Wayland compositor we need to use a protocol from the wayland-protocols collection, so we introduce support in the build system for protocol .xml files. These changes are introduced on their own commit in the series, but we can squash it with the next commit, where the functionality is first used, if preferred. To be able to provide a consistent view of the display settings across all processes, this MR leverages the win32u CURRENT_SETTINGS storage mechanism (which was previously used only in the null driver). Thanks! -- v7: winewayland.drv: Infer and report Windows monitor positions. winewayland.drv: Basic support for Windows monitor positioning. winewayland.drv: Use the output name reported by the compositor. tools: Support building Wayland protocol source files. winewayland.drv: Handle wl_output objects only in the desktop process. https://gitlab.winehq.org/wine/wine/-/merge_requests/2476

4 14

[PATCH v8 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) April 13, 2023

April 13, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v8: vkd3d-shader/hlsl: Evaluate index before array. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. vkd3d-shader/hlsl: Introduce hlsl_ir_index. tests: Test indexing of non-loads. tests: Test side effects on indexes. tests: Test matrix indexing on the lhs. tests: Test multiple calls to the same function in initializers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

3 10

[PATCH 0/1] MR2645: user32/tests: Windows 11's notepad has four icons.
by Francois Gouget (＠fgouget) April 13, 2023

April 13, 2023

There's the regular application icon and three different styles of close window icons. While there is nothing wrong with that this case is marked as broken() because Wine's notepad only has one icon so only 1 is a valid PrivateExtractIconsA() result in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2645

2 1

[PATCH v2 0/2] MR154: vkd3d-shader/hlsl: Fix numeric offset of object fields.
by Francisco Casas (＠fcasas) April 13, 2023

April 13, 2023

While struct and array fields within a struct always push the next fields numeric offset to the next register boundary, objects alone don't. -- v2: vkd3d-shader/hlsl: Fix numeric offset of object fields. tests: Test numeric offsets with object fields. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/154

5 5

[PATCH v4 0/3] MR140: vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic.
by Nikolay Sivov (＠nsivov) April 13, 2023

April 13, 2023

-- v4: tests: Add a test for SV_IsFrontFace. tests: Disable culling in shader runners. vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/140

3 5

[PATCH v7 0/10] MR124: vkd3d-shader/hlsl: Introduce hlsl_ir_index, part 1/2.
by Francisco Casas (＠fcasas) April 13, 2023

April 13, 2023

This node type is intended for use during parse-time. While we parse an indexing expression such as `a[3]`, we don't know if it will end up as part of an expression (in which case it must be folded into a load) or it is for the lhs of a store (in which case it must be folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access. `hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass. The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly. Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s. -- v7: vkd3d-shader/hlsl: Evaluate index before array. vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs. vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component(). vkd3d-shader/hlsl: Remove add_load_index(). vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access. vkd3d-shader/hlsl: Introduce hlsl_ir_index. tests: Test indexing of non-loads. tests: Test side effects on indexes. tests: Test matrix indexing on the lhs. tests: Test multiple calls to the same function in initializers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124

5 15

[PATCH v5 0/2] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) April 13, 2023

April 13, 2023

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v5: winegstreamer: In video_processor, activate a videoflip converter. mf/tests: Add tests about (negative) stride handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

3 3

[PATCH v4 0/2] MR2471: winegstreamer: In video_processor, activate a videoflip converter.
by eric pouech (＠epo) April 13, 2023

April 13, 2023

The app I'm considering opens a video_processor on its own, with a NV12 format on input and a ARGB32 format on output. Tested on Windows: the samples are flipped vertically. While Wine keeps them untouched. So added a videoflip in the video processor to be activated when needed. Current activation is based on RGB vs non RGB input/output formats. Set as draft as if somehow related to MR!2159. Comments welcomed. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v4: winegstreamer: In video_processor, activate a videoflip converter. mf/tests: Add tests about (negative) stride handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/2471

3 4

[PATCH 0/13] MR2644: imm32: Test and fix some input context getter / setters.
by Rémi Bernon April 13, 2023

April 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2644

1 13

[PATCH v5 0/1] MR150: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops.
by Nikolay Sivov (＠nsivov) April 13, 2023

April 13, 2023

-- v5: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150

3 4

[PATCH v6 0/4] MR89: vkd3d-shader/hlsl: Improve support for logarithmic functions.
by Nikolay Sivov (＠nsivov) April 13, 2023

April 13, 2023

-- v6: vkd3d-shader/hlsl: Support log() intrinsic. vkd3d-shader/hlsl: Support log10() intrinsic. vkd3d-shader/hlsl: Support log2() intrinsic. vkd3d-shader/hlsl: Write 'log' instruction for SM1. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/89

4 10

[PATCH v3 0/3] MR140: vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic.
by Nikolay Sivov (＠nsivov) April 13, 2023

April 13, 2023

-- v3: tests: Add a test for SV_IsFrontFace. tests: Disable culling in shader runners. vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/140

3 4

[PATCH v2 0/14] MR2643: wineps: Support more spool file record types (clipping, paths, gradientfill)
by Piotr Caban (＠piotr) April 13, 2023

April 13, 2023

-- v2: wineps: Handle EMR_WIDENPATH record in spool files. wineps: Handle EMR_FLATTENPATH record in spool files. wineps: Handle EMR_CLOSEFIGURE record in spool files. wineps: Handle EMR_STROKEPATH record in spool files. wineps: Handle EMR_STROKEANDFILLPATH record in spool files. wineps: Handle EMR_FILLPATH record in spool files. wineps: Handle EMR_BEGINPATH record in spool files. wineps: Handle EMR_ABORTPATH record in spool files. wineps: Handle EMR_ENDPATH record in spool files. wineps: Handle EMR_GRADIENTFILL record in spool files. wineps: Fix reporting supported color depths in PSDRV_PutImage. wineps: Handle EMR_EXTSELECTCLIPRGN record in spool files. wineps: Handle EMR_SELECTCLIPPATH in spool files. wineps: Don't write invisible parts of image to decrease output file size. https://gitlab.winehq.org/wine/wine/-/merge_requests/2643

3 16

[PATCH 0/14] MR2643: wineps: Support more spool file record types (clipping, paths, gradientfill)
by Piotr Caban (＠piotr) April 13, 2023

April 13, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2643

2 14

Re: [PATCH v6 0/2] MR2620: include: Add windows.ui.composition.interop.idl file. - approved
by Rémi Bernon April 13, 2023

April 13, 2023

This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

1 0

[PATCH v3 0/13] MR2636: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionManager into mmdevapi.
by Davide Beatrici (＠davidebeatrici) April 13, 2023

April 13, 2023

-- v3: winepulse: Remove AudioSessionManager. wineoss: Remove AudioSessionManager. winecoreaudio: Remove AudioSessionManager. winealsa: Remove AudioSessionManager. mmdevapi: Switch to own AudioSessionManager. mmdevapi: Implement AudioSessionManager. mmdevapi: Import GetAudioSessionWrapper() from driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/2636

4 19

Re: [PATCH v5 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Huw Davies (＠huw) April 13, 2023

April 13, 2023

On Thu Apr 13 02:24:36 2023 +0000, Yeshun Ye wrote: > OK, I see, it's my mistake. > So how can I do the test? I followed the '5 Building and running the > tests on Windows' in the page > https://wiki.winehq.org/Wine_Developer%27s_Guide/Writing_Conformance_Tests#… > but failed. > I run the command: './tools/winapi/msvcmaker --no-wine' and get an error > '.: searching for /^Makefile.in$/Error: Can't open > ./libs/wine/Makefile.in: No such file or directory' > Can you give me a suggestion? Install mingw-w64 and re-run configure, that should then produce PE tests. However you can upload a patch directly to https://testbot.winehq.org/ . -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545#note_29876

1 0

Re: [PATCH v5 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Yeshun Ye (＠yeyeshun) April 13, 2023

April 13, 2023

On Wed Apr 12 09:30:06 2023 +0000, Huw Davies wrote: > That's the run on linux. The above failures are from runs on Windows. OK, I see, it's my mistake. So how can I do the test? I followed the '5 Building and running the tests on Windows' in the page https://wiki.winehq.org/Wine_Developer%27s_Guide/Writing_Conformance_Tests#… but failed. I run the command: './tools/winapi/msvcmaker --no-wine' and get an error '.: searching for /^Makefile.in$/Error: Can't open ./libs/wine/Makefile.in: No such file or directory' Can you give me a suggestion? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2545#note_29871

1 0

Re: [PATCH v6 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) April 13, 2023

April 13, 2023

On Wed Apr 12 06:58:18 2023 +0000, Rémi Bernon wrote: > > In any case, adding in logic to typegen_detect_type seems the easiest way. > Sure but it's incorrect to return `TGT_CTXT_HANDLE_POINTER`, which has > more uses than just these checks. > I think something like that in check_field_common works: > ```C > case TGT_POINTER: > if (type_get_type(type_pointer_get_ref_type(type)) != > TYPE_VOID || > !type->name || strcmp(type->name, "HANDLE")) > { > type = type_pointer_get_ref_type(type); > more_to_do = TRUE; > } > break; > ``` That works, thanks, and thanks for the review. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2620#note_29868

1 0

[PATCH v5 0/2] MR2620: include: Add windows.ui.composition.interop.idl file.
by Mohamad Al-Jaf (＠maljaf) April 13, 2023

April 13, 2023

Needed for mingw Firefox build. The WIDL error points to the wrong function, specifically the one after it. include/windows.ui.composition.interop.idl:35:63: error: parameter 'swapchain' of function 'CreateCompositionSurfaceForHandle' cannot derive from void * HRESULT CreateCompositionSurfaceForSwapChain([in] IUnknown *swapchain, [out, retval] ICompositionSurface **result); ^ make[1]: *** [Makefile:163749: include/windows.ui.composition.interop.h] Error 1 -- v5: include: Add windows.ui.composition.interop.idl file. widl: Add support for WinRT HANDLE parameter type. https://gitlab.winehq.org/wine/wine/-/merge_requests/2620

2 2

[PATCH v3 0/9] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) April 12, 2023

April 12, 2023

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- v3: vkd3d-shader/hlsl: Error out when a semantic is used with multiple types. vkd3d-shader/hlsl: Error out when an output semantic is used more than once. vkd3d-shader/hlsl: Don't create semantic vars more than once. vkd3d-shader/hlsl: Support semantics for array types. vkd3d-shader/hlsl: Move get_array_size() and get_array_type() to hlsl.c. tests: Test array types with semantics. vkd3d-shader/hlsl: Avoid invalid input/output copies for non-numeric types. tests: Allow invalid vertex shader tests. tests: Expect S_OK result on [vertex shader]. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

3 14

Re: [PATCH v2 0/1] MR2641: ws2_32: Skip non-address records in dns_only_query(). - approved
by Alexandre Julliard (＠julliard) April 12, 2023

April 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2641

1 0

Re: [PATCH v3 0/6] MR2633: mshtml: Use new Wine Gecko 2.47.4 features. - approved
by Alexandre Julliard (＠julliard) April 12, 2023

April 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2633

1 0

Re: [PATCH v3 0/5] MR2634: winintest:internet InternetGetConnectedStateEx*() fixes - approved
by Alexandre Julliard (＠julliard) April 12, 2023

April 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2634

1 0

Re: [PATCH v2 0/1] MR2635: wininet/tests: Fix the InternetErrorDlg() tests on Windows 10 1607. - approved
by Alexandre Julliard (＠julliard) April 12, 2023

April 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2635

1 0

Re: [PATCH v2 0/11] MR2639: wineps: Support more spool file records. - approved
by Alexandre Julliard (＠julliard) April 12, 2023

April 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2639

1 0

Re: [PATCH v8 0/1] MR2622: ntdll: Use log-linear bucketing for free lists. - approved
by Alexandre Julliard (＠julliard) April 12, 2023

April 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

1 0

Re: [PATCH v2 0/6] MR155: Minor vkd3d_shader_parser related cleanups. - approved
by Alexandre Julliard (＠julliard) April 12, 2023

April 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/155

1 0

Re: [PATCH v7 0/2] MR141: vkd3d-shader/ir: Normalise hull shader control point phase I/O. - approved
by Alexandre Julliard (＠julliard) April 12, 2023

April 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/141

1 0

[PATCH 0/7] MR2640: winegstreamer: Factor some common helpers between wg_parser and wg_transform.
by Rémi Bernon April 12, 2023

April 12, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2640

3 16

[PATCH v2 0/13] MR2636: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionManager into mmdevapi.
by Davide Beatrici (＠davidebeatrici) April 12, 2023

April 12, 2023

-- v2: winepulse: Remove AudioSessionManager. wineoss: Remove AudioSessionManager. winecoreaudio: Remove AudioSessionManager. winealsa: Remove AudioSessionManager. mmdevapi: Switch to own AudioSessionManager. mmdevapi: Implement AudioSessionManager. mmdevapi: Import GetAudioSessionWrapper() from driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/2636

3 16

[PATCH 0/1] MR2641: ws2_32: Skip non-address records in dns_only_query().
by Hans Leidekker (＠hans) April 12, 2023

April 12, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54819 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2641

2 1

[PATCH 0/10] MR2638: d3dcompiler: Use the vkd3d-shader DXBC API.
by Matteo Bruni (＠Mystral) April 12, 2023

April 12, 2023

Same as !2577 with a few additional patches at the front. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2638

3 11

[PATCH 0/14] MR2636: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionManager into mmdevapi.
by Davide Beatrici (＠davidebeatrici) April 12, 2023

April 12, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2636

4 20

[PATCH v4 0/1] MR150: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops.
by Nikolay Sivov (＠nsivov) April 12, 2023

April 12, 2023

-- v4: vkd3d-shader/hlsl: Ignore "unroll" attribute for loops. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150

5 11

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zebediah Figura (＠zfigura) April 12, 2023

April 12, 2023

On Wed Apr 12 08:55:50 2023 +0000, Zhiyi Zhang wrote: > Does the following help? > ``` > [ > explicit_handle > ] > interface interface-name > { > ... > } > ``` > See https://learn.microsoft.com/en-us/windows/win32/midl/explicit-handle > and https://learn.microsoft.com/en-us/windows/win32/rpc/explicit-binding-handles I think in general, what you want is to add another call to run_client() with a new string, and handle that in client(). In general the flow should look pretty similar: create an RPC binding, run some tests with it [in this case you're using a different interface, so you don't want run_tests()]. You can duplicate the other tests while you're at it [authinfo, test_is_server_listening()] but it doesn't seem necessary. On the server side, you'll need to register the new server interface as well, in server(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29775

1 0

[PATCH v2 0/6] MR2633: mshtml: Use new Wine Gecko 2.47.4 features.
by Gabriel Ivăncescu April 12, 2023

April 12, 2023

-- v2: mshtml/tests: Add tests for non-stringed url() with non-URL characters in CSS. mshtml: Implement ProgressEvent's initProgressEvent method. mshtml: Get rid of dispatch_nsevent_hook. mshtml: Implement `complete` prop for input elements. mshtml: Set dom.ipc.plugins.enabled to FALSE. mshtml: Tell wine-gecko about the IE compat document mode. https://gitlab.winehq.org/wine/wine/-/merge_requests/2633

2 8

[PATCH v2 0/3] MR140: vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic.
by Nikolay Sivov (＠nsivov) April 12, 2023

April 12, 2023

-- v2: tests: Add a test for SV_IsFrontFace. tests: Disable culling in shader runners. vkd3d-shader/hlsl: Handle SV_IsFrontFace semantic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/140

4 8

Re: [PATCH v25 0/4] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Torge Matthies (＠tmatthies) April 12, 2023

April 12, 2023

On Wed Apr 12 12:09:30 2023 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=131819 > Your paranoid android. > === debian11 (32 bit report) === > ntdll: > directory.c:164: Test failed: file L".": expected (null) (10), got 12 > directory.c:164: Test failed: file L"..": expected (null) (10), got 12 > === debian11 (32 bit zh:CN report) === > ntdll: > directory.c:164: Test failed: file L".": expected (null) (10), got 12 > directory.c:164: Test failed: file L"..": expected (null) (10), got 12 > === debian11b (64 bit WoW report) === > ntdll: > directory.c:164: Test failed: file L".": expected (null) (10), got 12 > directory.c:164: Test failed: file L"..": expected (null) (10), got 12 > ``` will fix -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29753

1 0

[PATCH v7 0/1] MR2622: ntdll: Use log-linear bucketing for free lists.
by Tatsuyuki Ishi (＠ishitatsuyuki) April 12, 2023

April 12, 2023

Currently, the free list consists of a "small list" for sizes below 256, which are linearly spaced, and a "large list" which is manually split into a few chunks. This patch replaces it with a single log-linear policy, while expanding the range the large list covers. The old implementation had issues when a lot of large allocations happened. In this case, all the allocations went in the last catch-all bucket in the "large list", and what happens is: 1. The linked list grew in size over time, causing searching cost to skyrocket. 2. With the first-fit allocation policy, fragmentation was also making the problem worse. The new bucketing covers the entire range up until we start allocating large blocks, which will not enter the free list. It also makes the allocation policy closer to best-fit (although not exactly), reducing fragmentation. The increase in number of free lists does incur some cost when it needs to be skipped over, but the improvement in allocation performance outweighs it. For future work, these ideas (mostly from glibc) might or might not benefit performance: - Use an exact best-fit allocation policy. - Add a bitmap for freelist, allowing empty lists to be skipped with a single bit scan. For the benchmark, this drastically improves initial shader loading performance in Overwatch 2. In this workload 78k shaders are passed to DXVK for DXBC -> SPIRV translation, and for each shader a few allocation happens in the 4K – 100K range for the staging buffer. Before this patch, malloc consisted a whooping 43% of overhead. The overhead with log-linear bucketing is drastically lower, resulting in a ~2x improvement in loading time. Overhead for each `FREE_LIST_LINEAR_BITS` is as below: - 0: 7.7% - 1: 2.9% - 2: 1.3% - 3: 0.6% Since performance seems to scale linearly with increase in buckets (up to the point I have tested), I've opted for 3 (8 buckets per doubling) in the current revision of patch. Signed-off-by: Tatsuyuki Ishi <ishitatsuyuki(a)gmail.com> -- v7: ntdll: Use log-linear bucketing for free lists. https://gitlab.winehq.org/wine/wine/-/merge_requests/2622

4 4

[PATCH v4 0/4] MR1979: msvcrt: Remaining stubs for cm3
by Torge Matthies (＠tmatthies) April 12, 2023

April 12, 2023

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v4: msvcr110: Implement _Context::_IsSynchronouslyBlocked. msvcr110: Add _Context::_IsSynchronouslyBlocked stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_dtor stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_ctor stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

2 6

[PATCH v3 0/4] MR1979: msvcrt: Remaining stubs for cm3
by Torge Matthies (＠tmatthies) April 12, 2023

April 12, 2023

Based on !2524. This adds the remaining stubs needed for Crazy Machines 3 to work and decode preview images correctly in online mode. -- v3: msvcr110: Implement _Context::_IsSynchronouslyBlocked. msvcr110: Add _Context::_IsSynchronouslyBlocked stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_dtor stub. msvcr110: Add _Cancellation_beacon::_Cancellation_beacon_ctor stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/1979

3 6