April 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/1] MR2305: rpcrt4: Pass the binding handle to server call function.
by Zhiyi Zhang (＠zhiyi) April 6, 2023

April 6, 2023

Hi Yeshun, you don't need to regularly rebase the MR on top of the latest master. Because this area of code is largely undocumented, to help this MR gets in, you need to add a test, even if it might not be easy. I think you can use some of the example codes in NCALRPC_example. Thanks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2305#note_29113

1 0

Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them. - closed
by Alex Henrie (＠alexhenrie) April 6, 2023

April 6, 2023

This merge request was closed by Alex Henrie. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1746

1 0

Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Alex Henrie (＠alexhenrie) April 6, 2023

April 6, 2023

On Tue Apr 4 19:02:38 2023 +0000, Zebediah Figura wrote: > It's hard for me to feel like this is an improvement, when we are now > adding an extra parameter to every call, and also using some > undocumented Windows functions that, to the reader, might have some > obscure different semantics. Based on that feedback, I am closing this merge request in favor of !2590, which at least gets rid of the duplicate implementation of wcsdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1746#note_29106

1 0

[PATCH v5 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations.
by Alex Henrie (＠alexhenrie) April 6, 2023

April 6, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275 A version of this patch has been in Wine Staging since March 2020. -- v5: winemenubuilder: Skip desktop integration for certain associations. https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

2 2

[PATCH 0/1] MR2553: win32u: Add➕ emoji💯🤣👀 to message✉️.c.
by Zebediah Figura (＠zfigura) April 6, 2023

April 6, 2023

Emoji👌🔥 reflect modern communication🗣️ practices, they'll make Wine🍷 more accessible♿ to young🧒 hackers💻, and they make code⌨️ easier to read📚. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2553

9 12

[PATCH 0/7] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) April 6, 2023

April 6, 2023

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

3 13

Re: [PATCH v2 0/12] MR2589: msvcrt: Use a few more functions from the bundled musl library. - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2589

1 0

Re: [PATCH v2 0/4] MR2586: quartz/vmr9: Clean up IVMRFilterConfig9::SetRenderingMode(). - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2586

1 0

Re: [PATCH v2 0/1] MR2582: kernel32/tests: Workaround broken behavior in Win7 Pro64. - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2582

1 0

Re: [PATCH v2 0/1] MR2583: winedbg: Don't crash when no search path has been set. - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2583

1 0

Re: [PATCH v2 0/6] MR2588: winex11: More XIM integration cleanup. - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2588

1 0

Re: [PATCH v2 0/4] MR2564: winex11: Preparatory IME cleanup. - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2564

1 0

Re: [PATCH v2 0/7] MR2563: winemac: Preparatory IME cleanup. - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2563

1 0

Re: [PATCH v2 0/1] MR2581: winedump: Fix out of bounds access (spotted by GCC13). - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2581

1 0

Re: [PATCH v4 0/5] MR2486: D3D12 swapchain latency semaphore fixes - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2486

1 0

Re: [PATCH v5 0/1] MR137: vkd3d: Leave the command queue op mutex locked after a partial flush. - approved
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/137

1 0

[PATCH 0/5] MR2587: Support MF DXGI device manager in h264 decoder
by Paul Gofman (＠gofman) April 5, 2023

April 5, 2023

The last patch is a huge optimization to what is done in patch 2. Without that the sample is first copied from GPU to CPU each time wg_transform_read_mf() locks the buffer (allocating extra linear buffer on the way) and then copies the data back to GPU. That happens even if there is no sample available from wg_transform. With the last patch there is just one memory copy to the (write-only) locked DXGI surface buffer. And CPU to GPU texture transfer (which would be there anyway in most cases on software path as most of the apps are going to get the image to GPU anyway). In principle we could also skip the explicit staging texture and use _UpdateSubresource instead directly from h264 decoder, but this is currently not supported in wined3d for chroma formats and the overall difference between _UpdateSubresource and explicit mapped staging texture is not that great probably. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2587

4 17

[PATCH v2 0/2] MR2593: Draft: winex11.drv: Use the proper id with the settings handler.
by Alexandros Frantzis (＠afrantzis) April 5, 2023

April 5, 2023

The adapter ids used by the host and settings handlers are not guaranteed to be compatible, so ensure we are using the proper id with each handler. Note that although the possibly incompatible id was already used in `settings_handler.get_modes()` before, the settings handler was ignoring it anyway for `get_modes()` in the case it was really incompatible (e.g., using host handler xrandr 1.4, settings handler xrandr 1.0), . The problem manifests now since we are additionally calling `settings_handler.get_current_mode()` which does check the id value (e.g., in xrandr 1.0 to differentiate primary vs non-primary). Signed-off-by: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Fixes: 4232312dffe1cd115aa6bfd755f5b7c6a403e3fc Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54781 -- v2: winex11.drv: Do not call desktop get_current_mode() from UpdateDisplayDevices. https://gitlab.winehq.org/wine/wine/-/merge_requests/2593

2 2

[PATCH 0/1] MR2593: Draft: winex11.drv: Use the proper id with the settings handler.
by Alexandros Frantzis (＠afrantzis) April 5, 2023

April 5, 2023

The adapter ids used by the host and settings handlers are not guaranteed to be compatible, so ensure we are using the proper id with each handler. Note that although the possibly incompatible id was already used in `settings_handler.get_modes()` before, the settings handler was ignoring it anyway for `get_modes()` in the case it was really incompatible (e.g., using host handler xrandr 1.4, settings handler xrandr 1.0), . The problem manifests now since we are additionally calling `settings_handler.get_current_mode()` which does check the id value (e.g., in xrandr 1.0 to differentiate primary vs non-primary). Signed-off-by: Alexandros Frantzis <alexandros.frantzis(a)collabora.com> Fixes: 4232312dffe1cd115aa6bfd755f5b7c6a403e3fc Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54781 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2593

2 3

Re: [PATCH v23 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

Alexandre Julliard (@julliard) commented about dlls/ntdll/unix/file.c: > -static BOOL is_hidden_file( const UNICODE_STRING *name ) > +static BOOL is_hidden_file( const char *name ) > { > - WCHAR *p, *end; > + const char *p, *end; > > if (show_dot_files) return FALSE; > > - end = p = name->Buffer + name->Length/sizeof(WCHAR); > - while (p > name->Buffer && p[-1] == '\\') p--; > - while (p > name->Buffer && p[-1] != '\\') p--; > - return (p < end && *p == '.'); > + end = p = name + strlen( name ); > + while (p > name && p[-1] == '/') p--; > + while (p > name && p[-1] != '/') p--; > + return (p < end && p + 1 != end && p[0] == '.' && p[1] != '\\' && (p[1] != '.' || (p + 2 != end && p[2] != '\\'))); This doesn't make sense, it's using the wrong slashes and shouldn't be necessary in the first place. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29029

1 0

Re: [PATCH v23 0/6] MR1148: ntdll: Mark created files beginning with a dot as not hidden.
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

Alexandre Julliard (@julliard) commented about dlls/ntdll/tests/threadpool.c: > info2.ticks = 0; > > NtQuerySystemTime( &when ); > - when.QuadPart += (ULONGLONG)250 * 10000; > + when.QuadPart += (ULONGLONG)500 * 10000; > pTpSetTimer(timer2, &when, 0, 0); > - Sleep(50); > - when.QuadPart -= (ULONGLONG)150 * 10000; > - pTpSetTimer(timer1, &when, 0, 75); > + Sleep(100); > + when.QuadPart -= (ULONGLONG)300 * 10000; > + pTpSetTimer(timer1, &when, 0, 150); > > result = WaitForSingleObject(semaphore, 1000); Please don't add unrelated changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1148#note_29028

1 0

[PATCH 0/12] MR2589: msvcrt: Use a few more functions from the bundled musl library.
by Alexandre Julliard (＠julliard) April 5, 2023

April 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2589

3 13

[PATCH v4 0/1] MR1009: winemenubuilder: Skip desktop integration for certain associations.
by Alex Henrie (＠alexhenrie) April 5, 2023

April 5, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=41275 A version of this patch has been in Wine Staging since March 2020. -- v4: winemenubuilder: Skip desktop integration for certain associations. https://gitlab.winehq.org/wine/wine/-/merge_requests/1009

3 3

[PATCH v2 0/1] MR2417: setupapi: Stub in CM_MapCrToWin32Err
by James McDonnell (＠ElementalWarrior) April 5, 2023

April 5, 2023

Stub for affinity photo -- v2: setupapi: Stub in CM_MapCrToWin32Err https://gitlab.winehq.org/wine/wine/-/merge_requests/2417

4 4

[PATCH v4 0/1] MR137: vkd3d: Leave the command queue op mutex locked after a partial flush.
by Conor McCarthy (＠cmccarthy) April 5, 2023

April 5, 2023

All return paths in d3d12_command_queue_flush_ops_locked() must leave the op mutex locked. -- v4: vkd3d: Leave the command queue op mutex locked after a partial flush. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/137

3 4

[PATCH 0/1] MR2591: include: _InterlockedExchangePointer and _InterlockedCompareExchangePointer...
by Stefan Dösinger April 5, 2023

April 5, 2023

include: _InterlockedExchangePointer and _InterlockedCompareExchangePointer are intrinsics in x86 msvc. I fixed this issue in ad05f33d67, but a40973f20 regressed this again. I was carrying a patch for quite a while, feeling dejavu. The msvc ver of 1900 is taken from Boost's interlocked.hpp, which matches MSVC 2015 (toolset version v140). Boost has a comment that claims that in msvc 2012 those functions were defined in intrin.h, but those defines are broken with Microsoft's winnt.h. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2591

2 2

[PATCH 0/1] MR2590: setupapi: Use CRT functions for memory allocation where possible.
by Alex Henrie (＠alexhenrie) April 5, 2023

April 5, 2023

The big win here is getting rid of the reimplementation of wcsdup. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2590

2 1

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Rémi Bernon April 5, 2023

April 5, 2023

On Wed Apr 5 09:07:47 2023 +0000, Byeongsik Jeon wrote: > I tested a bit of code, it appears that fdwInit is also cached during > IME switching. Yeah I'm thinking that the entire `INPUTCONTEXT` is probably switched and kept cached, to avoid sharing its contents with a different IME. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520#note_29002

1 0

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Byeongsik Jeon (＠bsjeon) April 5, 2023

April 5, 2023

On Tue Apr 4 20:55:46 2023 +0000, Rémi Bernon wrote: > I guess maybe we'd have to clear the `fdwInit` flag before calling > `ImeSelect`? As far as I could see in the tests, the `fdwConversion` and > `fdwSentence` fields aren't modified by imm32 and left for the IME to > reset or not. It caused some spurious failures before > 7d03937abe899db810c983779f2566b94d787e8a with the fields keeping the > values from the default (MS) IME. > The tests also suggest that the values are cached between different IME > selections, unlike what Wine is currently doing. I tested a bit of code, it appears that fdwInit is also cached during IME switching. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520#note_29001

1 0

[PATCH v3 0/5] MR2486: D3D12 swapchain latency semaphore fixes
by Giovanni Mascellani (＠giomasce) April 5, 2023

April 5, 2023

-- v3: dxgi/tests: Test the frame latency waitable more thoroughly. https://gitlab.winehq.org/wine/wine/-/merge_requests/2486

4 8

[PATCH 0/1] MR2580: psapi: Test FS redirection wrt. EnumProcessModulesEx.
by eric pouech (＠epo) April 5, 2023

April 5, 2023

To make it short: redirection has no impact on EnumProcessModules*() behavior. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2580

2 2

[PATCH 0/6] MR2588: winex11: More XIM integration cleanup.
by Rémi Bernon April 5, 2023

April 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2588

1 6

[PATCH 0/1] MR2581: winedump: Fix out of bounds access (spotted by GCC13).
by eric pouech (＠epo) April 5, 2023

April 5, 2023

Anyway, it's a pain that we have to maintain two MS symbols demanglers (this one and the one in dlls/msvcrt). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2581

2 2

[PATCH 0/4] MR2564: winex11: Preparatory IME cleanup.
by Rémi Bernon April 5, 2023

April 5, 2023

Same as https://gitlab.winehq.org/wine/wine/-/merge_requests/2563 but on winex11 side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2564

1 5

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Rémi Bernon April 4, 2023

April 4, 2023

On Tue Apr 4 20:42:52 2023 +0000, Byeongsik Jeon wrote: > On a recent review, I realized that I hadn't analyzed this issue > properly, and the problem had already been fixed by another commit. > https://gitlab.winehq.org/wine/wine/-/commit/f6ddd4ca86672fe2739ea7d1701511… > The cause of the problem was that the wrong parameter value(new_context) > was being passed to ImeSelect(). Because of this, ImeSelect() didn't > work properly and kept the fdwConversion value of the wrong value (fdwConversionCaps). > For example, in ImeSelect(), fdwConversion is initialized in the > following routine: > ``` > if ( !( lpIMC->fdwInit & INIT_CONVERSION ) ) > { > lpIMC->fdwConversion = IME_CMODE_NATIVE; > lpIMC->fdwInit |= INIT_CONVERSION; > } > ``` > If the IME follows this initialization routine, the values of > fdwConversion, fdwSentence set in ime_select_ime() will be ignored. I guess maybe we'd have to clear the `fdwInit` flag before calling `ImeSelect`? As far as I could see in the tests, the `fdwConversion` and `fdwSentence` fields aren't modified by imm32 and left for the IME to reset or not. It caused some spurious failures before 7d03937abe899db810c983779f2566b94d787e8a with the fields keeping the values from the default (MS) IME. The tests also suggest that the values are cached between different IME selections, unlike what Wine is currently doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520#note_28984

1 0

[PATCH v2 0/2] MR2496: Draft: Fix hang when a program calls IMFMediaSession_Start with an invalid source.
by Santino Mazza (＠tati1454) April 4, 2023

April 4, 2023

This fixes a bug when the session topology contains an invalid source, which makes the session thread to hang and stop executing commands. -- v2: mf: Handle errors when subscribing to events. mf/tests: Test media session error handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/2496

3 4

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Byeongsik Jeon (＠bsjeon) April 4, 2023

April 4, 2023

On Tue Mar 28 10:35:26 2023 +0000, Byeongsik Jeon wrote: > Saenaru. This is not an MS IME, but a DDK-based open source Korean IME. > I think you can check this in the Wine test code. On a recent review, I realized that I hadn't analyzed this issue properly, and the problem had already been fixed by another commit. https://gitlab.winehq.org/wine/wine/-/commit/f6ddd4ca86672fe2739ea7d1701511… The cause of the problem was that the wrong parameter value(new_context) was being passed to ImeSelect(). Because of this, ImeSelect() didn't work properly and kept the fdwConversion value of the wrong value (fdwConversionCaps). For example, in ImeSelect(), fdwConversion is initialized in the following routine: ``` if ( !( lpIMC->fdwInit & INIT_CONVERSION ) ) { lpIMC->fdwConversion = IME_CMODE_NATIVE; lpIMC->fdwInit |= INIT_CONVERSION; } ``` If the IME follows this initialization routine, the values of fdwConversion, fdwSentence set in ime_select_ime() will be ignored. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520#note_28981

1 0

Re: [PATCH v3 0/5] MR2566: uiautomationcore: Initial default ProviderType_BaseHwnd clientside provider implementation. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2566

1 0

Re: [PATCH v2 0/1] MR2512: wined3d: Rotate vk bind masks in wined3d_swapchain_vk_rotate. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2512

1 0

[PATCH 0/4] MR2586: quartz/vmr9: Clean up IVMRFilterConfig9::SetRenderingMode().
by Zebediah Figura (＠zfigura) April 4, 2023

April 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2586

2 4

Re: [PATCH v7 0/7] MR2568: win32u: Support setting the current mode using gdi_device_manager. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2568

1 0

Re: [PATCH v3 0/1] MR2579: kernel32/debugger: Fix a failing test (on Wine). - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2579

1 0

Re: [PATCH v2 0/1] MR2576: winex11.drv: Fix a typo. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2576

1 0

Re: [PATCH v3 0/1] MR2575: ws2_32/tests: Adjust test results without host IPv6 support. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2575

1 0

Re: [PATCH v3 0/3] MR2573: dinput: Set guidType = GUID_Unknown for HID collections. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2573

1 0

Re: [PATCH v2 0/7] MR2574: imm32: Fix and cleanup ImmTranslateMessage. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2574

1 0

Re: [PATCH v2 0/1] MR2572: wldap32: Skip over the TLS certificate check if not using TLS. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2572

1 0

Re: [PATCH v2 0/11] MR2567: Bundle the musl math library - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2567

1 0

Re: [PATCH v2 0/1] MR2570: winegstreamer: Fix check for non-zero padding in h264 transform. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2570

1 0

Re: [PATCH v2 0/1] MR144: vkd3d-shader: Align the start offset instead of the size in bytecode_put_bytes(). - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/144

1 0

Re: [PATCH v2 0/1] MR143: tests/shader_runner: Return from run_shader_tests_d3d12() if we're unable to create a test context. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/143

1 0

Re: [PATCH v2 0/1] MR142: vkd3d-utils: Export D3D12CreateDevice() once again. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/142

1 0

[PATCH v2 0/1] MR135: vkd3d-shader/hlsl: Add support for sample index argument in Load().
by Nikolay Sivov (＠nsivov) April 4, 2023

April 4, 2023

-- v2: vkd3d-shader/hlsl: Add support for sample index argument in Load(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/135

4 6

Re: [PATCH v5 0/2] MR133: tests: Make test context information nestable. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/133

1 0

Re: [PATCH v8 0/10] MR106: vkd3d-shader/hlsl: packoffset() support. - approved
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

1 0

[PATCH v2 0/5] MR2566: uiautomationcore: Initial default ProviderType_BaseHwnd clientside provider implementation.
by Connor McAdams (＠cmcadams) April 4, 2023

April 4, 2023

-- v2: uiautomationcore: Implement UIA_NamePropertyId for default HWND provider. uiautomationcore: Implement UIA_ClassNamePropertyId for default HWND provider. uiautomationcore: Implement UIA_ProcessIdPropertyId for default HWND provider. https://gitlab.winehq.org/wine/wine/-/merge_requests/2566

3 7

[PATCH 0/80] MR2585: Draft: Release 8.0.1.
by Michael Stefaniuc (＠mstefani) April 4, 2023

April 4, 2023

-- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2585

1 1

[PATCH 0/1] MR2512: wined3d: Rotate vk bind masks in wined3d_swapchain_vk_rotate.
by Stefan Dösinger April 4, 2023

April 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2512

3 4

Re: [PATCH v6 0/2] MR1746: setupapi: Use MultiByteToUnicode and UnicodeToMultiByte instead of reimplementing them.
by Zebediah Figura (＠zfigura) April 4, 2023

April 4, 2023

Zebediah Figura (@zfigura) commented about dlls/setupapi/devinst.c: > { > if (procnameW) > { > - procname = strdupWtoA(procnameW + 1); > + procname = UnicodeToMultiByte(procnameW + 1, CP_ACP); > coinst_proc = (void *)GetProcAddress(module, procname); > - heap_free(procname); > + MyFree(procname); It's hard for me to feel like this is an improvement, when we are now adding an extra parameter to every call, and also using some undocumented Windows functions that, to the reader, might have some obscure different semantics. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1746#note_28895

1 0

[PATCH v2 0/1] MR2575: ws2_32/tests: Adjust test results without host IPv6 support.
by Rémi Bernon April 4, 2023

April 4, 2023

As seen when running the tests in Docker without IPv6 support configured, see for instance https://test.winehq.org/data/64cca153292833151d1adeb185252ca57e2d1625/linux…. -- v2: ws2_32/tests: Adjust test results without host IPv6 support. https://gitlab.winehq.org/wine/wine/-/merge_requests/2575

2 3

[PATCH v2 0/6] MR2577: d3dcompiler: Use the vkd3d-shader DXBC API.
by Henri Verbeet (＠hverbeet) April 4, 2023

April 4, 2023

The main advantage is that this way we're getting valid DXBC checksums for DXBC blobs generated by d3dcompiler. See also https://bugs.winehq.org/show_bug.cgi?id=54464. -- v2: d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_shader_reflection_init(). d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_strip_shader(). d3dcompiler: Use vkd3d_shader_parse_dxbc() in d3dcompiler_get_blob_part(). d3dcompiler: Use vkd3d_shader_serialize_dxbc() in d3dcompiler_strip_shader(). d3dcompiler: Use vkd3d_shader_serialize_dxbc() in d3dcompiler_get_blob_part(). d3dcompiler: Store DXBC sections as vkd3d_shader_dxbc_section_desc structures. https://gitlab.winehq.org/wine/wine/-/merge_requests/2577

3 8

[PATCH 0/1] MR144: vkd3d-shader: Align the start offset instead of the size in bytecode_put_bytes().
by Henri Verbeet (＠hverbeet) April 4, 2023

April 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/144

2 1

[PATCH v6 0/7] MR2568: win32u: Support setting the current mode using gdi_device_manager.
by Alexandros Frantzis (＠afrantzis) April 4, 2023

April 4, 2023

Update the gdi_device_manager API to enable drivers to set the current mode (along with the registry mode if not already set) in UpdateDisplayDevices. This changes also allows us to remove the driver code that manually changes the registry settings. -- v6: wineandroid.drv: Set the current mode using gdi_device_manager. winemac.drv: Set the current mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2568

3 10

[PATCH 0/1] MR2583: winedbg: Don't crash when no search path has been set.
by eric pouech (＠epo) April 4, 2023

April 4, 2023

Note: it's anyway wrong to search source files inside modules' path (a proper fix will require revisiting source file handling). This fix will actually be sufficient when running wine from within its build tree. Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2583

2 1

[PATCH 0/1] MR2582: kernel32/tests: Workaround broken behavior in Win7 Pro64.
by eric pouech (＠epo) April 4, 2023

April 4, 2023

Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2582

2 1

[PATCH v5 0/7] MR2568: win32u: Support setting the current mode using gdi_device_manager.
by Alexandros Frantzis (＠afrantzis) April 4, 2023

April 4, 2023

Update the gdi_device_manager API to enable drivers to set the current mode (along with the registry mode if not already set) in UpdateDisplayDevices. This changes also allows us to remove the driver code that manually changes the registry settings. -- v5: wineandroid.drv: Set the current mode using gdi_device_manager. winemac.drv: Set the current mode using gdi_device_manager. winemac.drv: Extract function to get the current mode. winewayland.drv: Set the current mode using gdi_device_manager. winex11.drv: Set the current mode using gdi_device_manager. winex11.drv: Extract function to check devmode equality. win32u: Support setting the current mode using gdi_device_manager. https://gitlab.winehq.org/wine/wine/-/merge_requests/2568

2 10

[PATCH 0/1] MR2579: kernel32/debugger: Fix a failing test (on Wine).
by eric pouech (＠epo) April 4, 2023

April 4, 2023

The failing test was garbled by remaining debug events from previous test. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2579

2 1

[PATCH v4 0/7] MR2568: win32u: Support setting the current mode using gdi_device_manager.
by Alexandros Frantzis (＠afrantzis) April 4, 2023

April 4, 2023

Update the gdi_device_manager API to enable drivers to set the current mode (along with the registry mode if not already set) in UpdateDisplayDevices. This changes also allows us to remove the driver code that manually changes the registry settings. -- v4: wineandroid.drv: Set the current mode using gdi_device_manager. winemac.drv: Set the current mode using gdi_device_manager. winemac.drv: Extract function to get the current mode. winewayland.drv: Set the current mode using gdi_device_manager. winex11.drv: Set the current mode using gdi_device_manager. win32u: Support setting the current mode using gdi_device_manager. debug.h: Add debugstr_devmodew() helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2568

4 19

[PATCH v3 0/1] MR137: vkd3d: Leave the command queue op mutex locked after a partial flush.
by Conor McCarthy (＠cmccarthy) April 4, 2023

April 4, 2023

All return paths in d3d12_command_queue_flush_ops_locked() must leave the op mutex locked. -- v3: vkd3d: Leave the command queue op mutex locked after a partial flush. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/137

4 6

[PATCH 0/1] MR143: tests/shader_runner: Return from run_shader_tests_d3d12() if we're unable to create a test context.
by Henri Verbeet (＠hverbeet) April 4, 2023

April 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/143

2 1

[PATCH 0/1] MR142: vkd3d-utils: Export D3D12CreateDevice() once again.
by Henri Verbeet (＠hverbeet) April 4, 2023

April 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/142

2 1

[PATCH v4 0/2] MR131: vkd3d: Persistently map host-visible heaps on creation.
by Zebediah Figura (＠zfigura) April 4, 2023

April 4, 2023

-- v4: tests: Add a test for readback map stability. vkd3d: Persistently map host-visible heaps on creation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/131

5 6

[PATCH v4 0/2] MR133: tests: Make test context information nestable.
by Zebediah Figura (＠zfigura) April 4, 2023

April 4, 2023

-- v4: include: Make test context information nestable. tests: Factor out vkd3d_test_printf(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/133

3 3

[PATCH v7 0/10] MR106: vkd3d-shader/hlsl: packoffset() support.
by Francisco Casas (＠fcasas) April 4, 2023

April 4, 2023

Support manually packing constant buffer elements through the `packoffset(·)` syntax. Support not included yet for simultaneously having semantics, `register(·)`, and `packoffset(·)`, for abnormalities such as: ```hlsl Texture2D tex; cbuffer buff { float4 a : packoffset(c0); sampler sam : packoffset(c0) : register(s1) : SEMANTIC; } float4 main() : sv_target { return tex.Sample(sam, float2(0, 0)) + a; } ``` but this motivated the addition of the `hlsl_ir_var.offset_reservation` field instead of reusing `hlsl_ir_var.reg_reservation`. -- v7: vkd3d-shader/hlsl: Consider register() as manual packing for resource fields. tests: Test packoffset() with resources inside cbuffers. vkd3d-shader/hlsl: Ignore packoffset() contents for SM1. vkd3d-shader/hlsl: Don't allow manual and automatic cbuffer offset packing. vkd3d-shader/hlsl: Detect overlaps in cbuffer offsets. vkd3d-shader/hlsl: Support packoffset(). vkd3d-shader/hlsl: Parse packoffset(). vkd3d-shader/hlsl: Rename struct hlsl_reg_reservation fields. tests: Test packoffset(). tests: Test cbuffer element offsets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/106

3 11

[PATCH 0/6] MR2577: d3dcompiler: Use the vkd3d-shader DXBC API.
by Henri Verbeet (＠hverbeet) April 4, 2023

April 4, 2023

The main advantage is that this way we're getting valid DXBC checksums for DXBC blobs generated by d3dcompiler. See also https://bugs.winehq.org/show_bug.cgi?id=54464. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2577

3 8

[PATCH 0/1] MR2467: gitlab: Install X11 utils and some window managers.
by Rémi Bernon April 4, 2023

April 4, 2023

This adds several handy X11 utilities, such as xrandr, and some other window managers, in order to eventually use a different one and avoid fwvm race conditions. I think it would be interesting to test with some different WMs than fvwm, at least because they are more commonly used. Then, I also think that fvwm has some race conditions, and it causes spurious focus loss, as https://bugs.winehq.org/show_bug.cgi?id=54594 for instance. I've been running the same test in a tight loop with any of the other WMs added here (mutter / kwin / openbox) and it is not reproducing. With fvwm the failure reproduces quickly and systematically. The xrandr utility would be useful in the future, but only after the image is updated to a newer xserver-xorg-video-dummy version which would support multiple screens. It will then be possible to set them up with the following commands: ``` xrandr --addmode DUMMY1 1024x768 \ --addmode DUMMY2 1024x768 xrandr --output DUMMY0 --auto \ --output DUMMY1 --right-of DUMMY0 --mode 1024x768 \ --output DUMMY2 --right-of DUMMY1 --mode 1024x768 xrandr # to refresh the settings ``` Then I think it doesn't hurt to have it installed in the meantime. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2467

2 6

[PATCH 0/5] MR2500: wined3d: Move extension checks out of state tables
by Max Figura (＠maxfigura) April 4, 2023

April 4, 2023

Removing extension checks from state tables and moving checks to called functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2500

5 10

[PATCH 0/1] MR2576: winex11.drv: Fix a typo.
by Zhiyi Zhang (＠zhiyi) April 4, 2023

April 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2576

2 1

[PATCH 0/1] MR2575: ws2_32/tests: Adjust test results without host IPv6 support.
by Rémi Bernon April 4, 2023

April 4, 2023

As seen when running the tests in Docker without IPv6 support configured, see for instance https://test.winehq.org/data/64cca153292833151d1adeb185252ca57e2d1625/linux…. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2575

2 2

[PATCH 0/11] MR2567: Bundle the musl math library
by Alexandre Julliard (＠julliard) April 4, 2023

April 4, 2023

The goal is to use the bundling mechanism to share the musl math library code between msvcrt and ntdll, and also with a future FPU emulation library. It should also make it easier to sync with upstream changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2567

4 18

[PATCH v2 0/3] MR2573: dinput: Set guidType = GUID_Unknown for HID collections.
by Florian Will (＠w-flo) April 4, 2023

April 4, 2023

I'm not sure if I'm using the dinput HID test infrastructure correctly. Also, an existing test could be extended instead of adding a whole new test function, saving a couple of source code lines and test execution time, but I wasn't sure which one to extend - feel free to suggest one and I will update the test. Also, maybe the suggested fix is not a great idea. Maybe there are actually some collection objects that are supposed to have a guidType that is not GUID_Unknown? I couldn't find any in the limited number of Windows environments I can access, so I wanted to put it out there for discussion. The issue I'm trying to solve is that Zusi 3 does not appear to check the DIDFT_NODATA bit in dwType, so it just adds most of the objects listed by EnumObjects() to the SetDataFormat() call, maybe filtering out only those that have guidType = GUID_Unknown, or maybe there's an allow-list of GUIDs to add, and that list includes GUID_ZAxis. I haven't seen complaints about joysticks not working in Zusi 3 on Windows, so I guess collections (and DIDFT_NODATA objects in general) rarely/never have a non-Unknown GUID, or maybe Windows simply accepts these collections in SetDataFormat() and that only fails in Wine. -- v2: dinput/tests: Remove unmatched winetest_pop_context(). dinput: Set guidType = GUID_Unknown for HID collections. dinput/tests: Add guidType test for collection objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2573

3 6

[PATCH 0/1] MR2572: wldap32: Skip over the TLS certificate check if not using TLS.
by Alex Henrie (＠alexhenrie) April 4, 2023

April 4, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54772 I could have fixed this in merge request !2533 but unfortunately I was so focused on testing SSL connections that I didn't notice that non-SSL connections were still broken. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2572

4 3

[PATCH 0/2] MR2573: dinput: Set guidType = GUID_Unknown for HID collections.
by Florian Will (＠w-flo) April 4, 2023

April 4, 2023

I'm not sure if I'm using the dinput HID test infrastructure correctly. Also, an existing test could be extended instead of adding a whole new test function, saving a couple of source code lines and test execution time, but I wasn't sure which one to extend - feel free to suggest one and I will update the test. Also, maybe the suggested fix is not a great idea. Maybe there are actually some collection objects that are supposed to have a guidType that is not GUID_Unknown? I couldn't find any in the limited number of Windows environments I can access, so I wanted to put it out there for discussion. The issue I'm trying to solve is that Zusi 3 does not appear to check the DIDFT_NODATA bit in dwType, so it just adds most of the objects listed by EnumObjects() to the SetDataFormat() call, maybe filtering out only those that have guidType = GUID_Unknown, or maybe there's an allow-list of GUIDs to add, and that list includes GUID_ZAxis. I haven't seen complaints about joysticks not working in Zusi 3 on Windows, so I guess collections (and DIDFT_NODATA objects in general) rarely/never have a non-Unknown GUID, or maybe Windows simply accepts these collections in SetDataFormat() and that only fails in Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2573

3 5

[PATCH 0/7] MR2574: imm32: Fix and cleanup ImmTranslateMessage.
by Rémi Bernon April 4, 2023

April 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2574

1 7

[PATCH 0/1] MR2570: winegstreamer: Fix check for non-zero padding in h264 transform.
by Paul Gofman (＠gofman) April 4, 2023

April 4, 2023

IsRectEmpty() doesn't do the right thing as padding is not a rectangle. E. g., for rect (0, 0, 0, 8) IsRectEmpty() will return TRUE while the padding is apparently not empty. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2570

3 2

[PATCH v5 0/1] MR2565: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar'
by Yeshun Ye (＠yeyeshun) April 4, 2023

April 4, 2023

There is an application uses DirectSound to play waves and uses IAudioEndpointVolume to adjust the volume, but there is no effect on the volume adjustment. -- v5: mmdevapi: Implement function 'AEV_SetMasterVolumeLevelScalar' https://gitlab.winehq.org/wine/wine/-/merge_requests/2565

2 1

Re: [PATCH v2 0/7] MR2562: winex11: Preparatory XIM cleanup. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2562

1 0

Re: [PATCH v6 0/1] MR1753: wintrust: Annotate WINTRUST_Alloc with __WINE_(DEALLOC|MALLOC). - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1753

1 0

Re: [PATCH v5 0/5] MR2532: kernebase: Implement GetConsoleOriginalTitleA/W - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2532

1 0

Re: [PATCH v3 0/1] MR2550: wintypes: Declare exported functions in rometadataresolution.h. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2550

1 0

Re: [PATCH v2 0/1] MR2556: po: Update Lithuanian translation. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2556

1 0

Re: [PATCH v4 0/2] MR2561: widl: Add support for composable attribute. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2561

1 0

Re: [PATCH v4 0/1] MR2559: widl: Add support for inherited runtime classes. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2559

1 0

Re: [PATCH v2 0/2] MR2558: wldap32: Allow LDAP_OPT_REFERRALS to be set from a pointer. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2558

1 0

Re: [PATCH v2 0/2] MR2560: dinput: Add test and fix EnumObjects callback return value handling. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2560

1 0

Re: [PATCH v2 0/1] MR134: tests: Use a pixel shader that consumes SV_Position in test_query_pipeline_statistics(). - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/134

1 0

Re: [PATCH v6 0/1] MR129: tests: Read integer uniforms with strtol() and strtoul(). - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/129

1 0

Re: [PATCH v2 0/1] MR128: vkd3d-shader/hlsl: Handle round() for SM1. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/128

1 0

Re: [PATCH v4 0/2] MR127: vkd3d: Add an internal reference to a heap when a resource is placed there. - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/127

1 0

Re: [PATCH v2 0/1] MR121: vkd3d-shader/hlsl: Rename the "type" field of struct hlsl_type to "class". - approved
by Alexandre Julliard (＠julliard) April 3, 2023

April 3, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/121

1 0