April 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/7] MR2712: winewayland.drv: part 3: Handle dynamic wl_output events
by Alexandros Frantzis (＠afrantzis) April 28, 2023

April 28, 2023

This MR introduces the driver mechanisms to handle dynamic events from the Wayland compositor, using wl_output events as the guiding use case (i.e., we want to update the win32u display settings when the host settings change). In this design we create a dedicated thread to read and dispatch Wayland events received from the compositor. If a Wayland event handler wants some code to be run in the context of a particular HWND's thread, it can add an internal event to a custom queue we have for each (GUI enabled) thread. The ProcessEvents driver callback processes internal events from that queue. In order to wake up waiting threads we use a pipe to notify about new internal events, with the read end acting as the thread's host queue fd. This is similar to how winemac.drv works. We use the aforementioned mechanisms to queue win32u display device updates to the desktop window thread. Since there are many pieces that need to fall into place, this MR gradually reaches the final design: 1. We first introduce the dedicated read/dispatch thread and handle events (and also display device updates if in the desktop process) in that thread. 2. We ensure access to Wayland output information is thread-safe and consistent (since in step 3 we will need to access it from a different thread). 3. We finally introduce per-thread internal event queues and, if we are in the desktop process, queue the display device update to the desktop window thread internal event queue. Note that the main portion of the wl_output event code is still handled in the dedicated read/dispatch thread. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2712

3 12

[PATCH v4 0/7] MR181: vkd3d-shader: Normalise signatures and input/output registers to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) April 28, 2023

April 28, 2023

-- v4: vkd3d-shader: Add source information to normaliser errors and warnings. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/181

2 8

[PATCH v3 0/6] MR181: vkd3d-shader: Normalise signatures and input/output registers to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) April 28, 2023

April 28, 2023

-- v3: vkd3d-shader/ir: Normalise signatures and input/output registers to the Shader Model 6 pattern. vkd3d-shader/tpf: Fail parsing if an input/output parameter order is > 2. tests/d3d12: Test register relative addressing in vertex and pixel shaders. vkd3d-shader: Introduce an internal sm6 signature structure. vkd3d-shader/tpf: Return an error from vkd3d_shader_sm4_parser_create() if the parser failed. vkd3d-shader/d3dbc: Return an error from vkd3d_shader_sm1_parser_create() if the parser failed. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/181

2 6

[PATCH v3 0/1] MR180: vkd3d-shader/hlsl: Partially implement static expressions evaluation.
by Nikolay Sivov (＠nsivov) April 28, 2023

April 28, 2023

-- v3: vkd3d-shader/hlsl: Partially implement static expressions evaluation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/180

4 3

[PATCH v2 0/4] MR181: vkd3d-shader: Normalise signatures and input/output registers to the Shader Model 6 pattern.
by Conor McCarthy (＠cmccarthy) April 28, 2023

April 28, 2023

-- v2: vkd3d-shader/ir: Normalise signatures and input/output registers to the Shader Model 6 pattern. vkd3d-shader/tpf: Fail parsing if an input/output parameter order is > 2. tests/d3d12: Test register relative addressing in vertex and pixel shaders. vkd3d-shader: Introduce an internal sm6 signature structure. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/181

2 4

[PATCH v5 0/2] MR184: vkd3d-shader/hlsl: Add support for SampleGrad() method
by Ethan Lee (＠flibitijibibo) April 28, 2023

April 28, 2023

~~This one's marked as a draft, as there seems to be a blocker with the method parameters.~~ ~~The first commit totally works, _if_ the ddx/ddy parameters are literals - they do _not_ work when passing a variable of any kind. The test comes from tests/d3d12.c, so I'm mostly just trying to migrate that to the HLSL test suite, but it currently hits an assert before we get to the resource load (which does eventually work) and I'm not sure what's causing it:~~ ``` vkd3d-compiler: libs/vkd3d-shader/tpf.c:3190: sm4_register_from_node: Assertion `instr->reg.allocated' failed. ``` ~~Seems like it's surprised when we try to load from the constant buffer maybe?~~ Fixed! -- v5: tests: Add a basic compilation test for SampleGrad() method. vkd3d-shader/hlsl: Add support for SampleGrad() method https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/184

2 4

[PATCH v6 0/2] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics.
by Ethan Lee (＠flibitijibibo) April 28, 2023

April 28, 2023

SPIR-V already handled DSX/DSY, so only D3DBC/TPF needed new case blocks. You'll notice that there's no test for this one - in addition to being a pretty straightforward translation for all possible formats, this feature uses the render target width/height and I wasn't sure if there was a good way to ensure that the test would always make sense. Instead, I did the test manually, and it's what you'd expect (EDIT: Previously the test used a uniform which always optimized to 0, new test uses VPOS instead): HLSL: ``` float4 main(float4 pos : sv_position) : sv_target { float4 x = ddx(pos.x); float4 y = ddy(pos.y); return x + y; } ``` D3DBC: ``` ps_3_0 dcl_position0 vPos mov r0.xyzw, vPos.xyzw mov r1.x, r0.x dsx r1.x, r1.x mov r0.x, r0.yxxx dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov oC0.xyzw, r0.xyzw ``` DXBC-TPF: ``` ps_4_0 dcl_input_ps_siv linear v0.xyzw, position dcl_output o0.xyzw dcl_temps 2 mov r0.xyzw, v0.xyzw mov r1.x, r0.x dsx r1.x, r1.x mov r0.x, r0.yxxx dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov o0.xyzw, r0.xyzw ret ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=54827 -- v6: tests: Add tests for ddx(), ddy() intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179

2 3

[PATCH v4 0/2] MR184: vkd3d-shader/hlsl: Add support for SampleGrad() method
by Ethan Lee (＠flibitijibibo) April 28, 2023

April 28, 2023

~~This one's marked as a draft, as there seems to be a blocker with the method parameters.~~ ~~The first commit totally works, _if_ the ddx/ddy parameters are literals - they do _not_ work when passing a variable of any kind. The test comes from tests/d3d12.c, so I'm mostly just trying to migrate that to the HLSL test suite, but it currently hits an assert before we get to the resource load (which does eventually work) and I'm not sure what's causing it:~~ ``` vkd3d-compiler: libs/vkd3d-shader/tpf.c:3190: sm4_register_from_node: Assertion `instr->reg.allocated' failed. ``` ~~Seems like it's surprised when we try to load from the constant buffer maybe?~~ Fixed! -- v4: tests: Add a basic compilation test for SampleGrad() method. vkd3d-shader/hlsl: Add support for SampleGrad() method https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/184

3 4

[PATCH v5 0/2] MR179: vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics.
by Ethan Lee (＠flibitijibibo) April 28, 2023

April 28, 2023

SPIR-V already handled DSX/DSY, so only D3DBC/TPF needed new case blocks. You'll notice that there's no test for this one - in addition to being a pretty straightforward translation for all possible formats, this feature uses the render target width/height and I wasn't sure if there was a good way to ensure that the test would always make sense. Instead, I did the test manually, and it's what you'd expect (EDIT: Previously the test used a uniform which always optimized to 0, new test uses VPOS instead): HLSL: ``` float4 main(float4 pos : sv_position) : sv_target { float4 x = ddx(pos.x); float4 y = ddy(pos.y); return x + y; } ``` D3DBC: ``` ps_3_0 dcl_position0 vPos mov r0.xyzw, vPos.xyzw mov r1.x, r0.x dsx r1.x, r1.x mov r0.x, r0.yxxx dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov oC0.xyzw, r0.xyzw ``` DXBC-TPF: ``` ps_4_0 dcl_input_ps_siv linear v0.xyzw, position dcl_output o0.xyzw dcl_temps 2 mov r0.xyzw, v0.xyzw mov r1.x, r0.x dsx r1.x, r1.x mov r0.x, r0.yxxx dsy r0.x, r0.x mov r1.xyzw, r1.x mov r0.xyzw, r0.x add r0.xyzw, r1.xyzw, r0.xyzw mov o0.xyzw, r0.xyzw ret ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=54827 -- v5: tests: Add test for ddx(), ddy() intrinsics vkd3d-shader/hlsl: Add support for ddx(), ddy() intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/179

4 10

[PATCH v3 0/2] MR184: Draft: vkd3d-shader/hlsl: Add support for SampleGrad() method
by Ethan Lee (＠flibitijibibo) April 28, 2023

April 28, 2023

~~This one's marked as a draft, as there seems to be a blocker with the method parameters.~~ ~~The first commit totally works, _if_ the ddx/ddy parameters are literals - they do _not_ work when passing a variable of any kind. The test comes from tests/d3d12.c, so I'm mostly just trying to migrate that to the HLSL test suite, but it currently hits an assert before we get to the resource load (which does eventually work) and I'm not sure what's causing it:~~ ``` vkd3d-compiler: libs/vkd3d-shader/tpf.c:3190: sm4_register_from_node: Assertion `instr->reg.allocated' failed. ``` ~~Seems like it's surprised when we try to load from the constant buffer maybe?~~ Fixed! -- v3: tests: Add a basic compilation test for SampleGrad() method. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/184

4 11

[PATCH 0/1] MR2699: evr: Don't flip image vertically.
by eric pouech (＠epo) April 28, 2023

April 28, 2023

This is actually fixing two issues: - if we get a negative stride, then the video transform should have already flipped vertically the image, so we don't need to flip it again. (This is another side effect for handling negative strides in wg_transform). - it also fixes a crash in AoEII, as the image source line offsets were incorrectly computed with unsigned arithmetic (while signed arithmetic was expected), resulting in incorrect sign propagation from 32bit to 64bit integers. Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2699

3 4

[PATCH v3 0/5] MR176: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 3.
by Zebediah Figura (＠zfigura) April 28, 2023

April 28, 2023

-- v3: vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_resource_store(). vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_resource_load(). vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_loop(). vkd3d-shader/hlsl: Pass an hlsl_block pointer to hlsl_new_loop(). vkd3d-shader/hlsl: Reuse the "init" instruction list if possible in create_loop(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/176

3 6

[PATCH v10 0/2] MR178: vkd3d-shader/hlsl: Add support for sign() intrinsic.
by Ethan Lee (＠flibitijibibo) April 28, 2023

April 28, 2023

This replicates what seems to be happening when using sign() with shader model 3, which is roughly... ``` int pos = (int) (x > 0); int neg = -((int) (x < 0)); int result = pos + neg; ``` Fixes https://bugs.winehq.org/show_bug.cgi?id=54826 -- v10: tests: Add tests for sign() intrinsic. vkd3d-shader/hlsl: Add support for sign() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/178

3 5

[PATCH 0/4] MR2721: gdi/wineps: Add support for implicitly calling StartPage and for EMRI_DEVMODE spool file record
by Piotr Caban (＠piotr) April 28, 2023

April 28, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2721

3 5

[PATCH v2 0/1] MR2678: win32u: Partially implement NtUserDisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_PREFERRED_MODE).
by Paul Gofman (＠gofman) April 28, 2023

April 28, 2023

win32u: Partially implement NtUserDisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_PREFERRED_MODE). Required for Ghost Recon Breakpoint. -- v2: win32u: Partially implement NtUserDisplayConfigGetDeviceInfo(DISPLAYCONFIG_DEVICE_INFO_GET_TARGET_PREFERRED_MODE). https://gitlab.winehq.org/wine/wine/-/merge_requests/2678

3 8

[PATCH v13 0/4] MR2669: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionControl into mmdevapi.
by Davide Beatrici (＠davidebeatrici) April 28, 2023

April 28, 2023

-- v13: winepulse: Use mmdevapi's AudioSessionControl. wineoss: Use mmdevapi's AudioSessionControl. winecoreaudio: Use mmdevapi's AudioSessionControl. winealsa: Move AudioSessionControl into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2669

3 10

[PATCH v8 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by David Kahurani (＠kahurani) April 28, 2023

April 28, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54733 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v8: shlwapi: Implement StrFormatByteSizeEx https://gitlab.winehq.org/wine/wine/-/merge_requests/2609

3 2

Re: [PATCH v2 0/1] MR2549: winevulkan: Update to VK spec version 1.3.246.
by Georg Lehmann (＠DadSchoorse) April 28, 2023

April 28, 2023

On Fri Apr 28 05:16:50 2023 +0000, Georg Lehmann wrote: > We are not supporting video extension at the moment because > `make_vulkan` wasn't updated to support more than one xml file. VK_NV_displacement_micromap isn't final yet, we don't enable provisional extensions in winevulkan. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2549#note_31470

1 0

Re: [PATCH v2 0/1] MR2549: winevulkan: Update to VK spec version 1.3.246.
by Georg Lehmann (＠DadSchoorse) April 28, 2023

April 28, 2023

On Fri Apr 28 05:16:50 2023 +0000, Oscar Barenys wrote: > sorry for asking here if not appropiate, but just asking: > just compiled a bunch of NV VK samples on Windows and was going to test > on Linux via Wine.. > and noticed the KHR video decode sample: > https://github.com/nvpro-samples/vk_video_samples/tree/main/vk_video_decoder > and also the new DMM sample (VK_NV_displacement_micromap): > https://github.com/nvpro-samples/vk_mini_samples/tree/main/samples/mm_displ… > fail to run under wine.. > any reason for not supporting the "released" KHR video (decoding) exts:? > ``` > VK_KHR_video_decode_queue > VK_KHR_video_queue > VK_KHR_video_decode_h264 > VK_KHR_video_decode_h265 > ``` > and also the new VK_NV_displacement_micromap released with 1.3.245 spec? We are not supporting video extension at the moment because `make_vulkan` wasn't updated to support more than one xml file. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2549#note_31469

1 0

[PATCH v7 0/1] MR2609: shlwapi: Implement StrFormatByteSizeEx
by David Kahurani (＠kahurani) April 28, 2023

April 28, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54733 Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v7: shlwapi: Implement StrFormatByteSizeEx https://gitlab.winehq.org/wine/wine/-/merge_requests/2609

2 1

Re: [PATCH v2 0/1] MR2549: winevulkan: Update to VK spec version 1.3.246.
by Oscar Barenys (＠oscarbg) April 27, 2023

April 27, 2023

sorry for asking here if not appropiate, but just asking: just compiled a bunch of NV VK samples on Windows and was going to test on Linux via Wine.. and noticed the KHR video decode sample: https://github.com/nvpro-samples/vk_video_samples/tree/main/vk_video_decoder and also the new DMM sample (VK_NV_displacement_micromap): https://github.com/nvpro-samples/vk_mini_samples/tree/main/samples/mm_displ… fail to run under wine.. any reason for not supporting the "released" KHR video (decoding) exts:? ``` VK_KHR_video_decode_queue VK_KHR_video_queue VK_KHR_video_decode_h264 VK_KHR_video_decode_h265 ``` and also the new VK_NV_displacement_micromap released with 1.3.245 spec? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2549#note_31463

1 0

[PATCH v12 0/4] MR2669: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionControl into mmdevapi.
by Davide Beatrici (＠davidebeatrici) April 27, 2023

April 27, 2023

-- v12: winepulse: Use mmdevapi's AudioSessionControl. wineoss: Use mmdevapi's AudioSessionControl. winecoreaudio: Use mmdevapi's AudioSessionControl. winealsa: Move AudioSessionControl into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2669

3 5

[PATCH v11 0/4] MR2669: wine{alsa,coreaudio,oss,pulse}: Move AudioSessionControl into mmdevapi.
by Davide Beatrici (＠davidebeatrici) April 27, 2023

April 27, 2023

-- v11: winepulse: Use mmdevapi's AudioSessionControl. wineoss: Use mmdevapi's AudioSessionControl. winecoreaudio: Use mmdevapi's AudioSessionControl. winealsa: Move AudioSessionControl into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/2669

3 11

Re: [PATCH v2 0/2] MR2717: d3d9/tests: AMD GPUs sample the border color of cube textures. - approved
by Alexandre Julliard (＠julliard) April 27, 2023

April 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2717

1 0

Re: [PATCH v2 0/5] MR2704: imm32: More tests and fixes for IMMGWL_IMC and ImmGenerateMessages. - approved
by Alexandre Julliard (＠julliard) April 27, 2023

April 27, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2704

1 0