April 2023 - Wine-GitLab - list.winehq.org

[PATCH v2 0/4] MR2670: uiautomationcore: Implement root element retrieval and add support for cache request normalization.
by Connor McAdams (＠cmcadams) April 18, 2023

April 18, 2023

-- v2: uiautomationcore: Add normalization navigation to UiaGetUpdatedCache. uiautomationcore: Implement conditional NavigateDirection_Parent navigation. https://gitlab.winehq.org/wine/wine/-/merge_requests/2670

3 6

Re: [PATCH v3 0/1] MR499: server: Allow cancelling alerted asyncs.
by Zebediah Figura (＠zfigura) April 18, 2023

April 18, 2023

> I don't think so. `async_terminate()` is currently no-op if the async has already been terminated with a status other than `STATUS_ALERTED`, and the patch maintains this invariant. Right, that's the bit I failed to think through. > It is possible to introduce a new boolean flag, but the flag cannot replace `terminate_status`. `terminate_status` can be any arbitrary value passed to the third parameter of `async_set_timeout`. Ah, and I missed that that was a possibility, although, in my defense, it's not stated in the patch subject either. I.e. this patch doesn't just fix the race where an alerted async is canceled, it also fixes the similar race where it times out. So yes, I think the patch makes sense as is. Maybe a comment to yet again overdocument asyncs wouldn't hurt? I easily see myself looking at code like this and having to ask myself, "when exactly is terminate_status set?" and the answer is "if (and only if?) the async is canceled or times out while it's alerted", which is nice to have documented and not have to puzzle through later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/499#note_30389

1 0

[PATCH 0/4] MR2670: uiautomationcore: Implement root element retrieval and add support for cache request normalization.
by Connor McAdams (＠cmcadams) April 18, 2023

April 18, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2670

3 6

[PATCH v4 0/6] MR2435: Fix activation context switching from SwitchToFiber().
by Jinoh Kang (＠iamahuman) April 18, 2023

April 18, 2023

-- v4: kernelbase: Implement activation context switching for fibers. ntdll: Implement RtlFreeActivationContextStack(). ntdll: Use ActivationContextStackPointer instead of referencing ActivationContextStack directly. ntdll: Store current activation context stack pointer into a local variable. ntdll: Factor out reading current activation context into a helper function. kernel32/tests: Test for activation context switching between fibers. https://gitlab.winehq.org/wine/wine/-/merge_requests/2435

3 9

[PATCH v2 0/2] MR2666: d3dx9_36: Use __VA_ARGS__ instead of GCCs named variadics.
by Stefan Dösinger April 18, 2023

April 18, 2023

MSVC doesn't support "name...". --- msvc also supports __VA_ARGS__ only if /Zc:preprocessor is set to make its preprocessor "standards conformant" instead of doing whatever msvc used to do since aeons. -- v2: d3dx9/tests: Use __VA_ARGS__ instead of GCCs named variadics. d3dx9: Use __VA_ARGS__ instead of GCCs named variadics. https://gitlab.winehq.org/wine/wine/-/merge_requests/2666

2 3

Re: [PATCH v3 0/6] MR2435: Fix activation context switching from SwitchToFiber().
by Jinoh Kang (＠iamahuman) April 18, 2023

April 18, 2023

> I must be missing something, when can dest == src? If `ActivationContextStackPointer` already equals `dest` (fiber data or TEB). I think it's not possible currently, unless the user tinkers with undocumented fields (which we don't need to support right now). > Aren't we always moving from the fiber data to the TEB in ConvertFiberToThread()? Or in the other direction in case of `ConvertThreadToFiber()`, but yes, `dest != src` in that case too. I'll remove the check, since I realized it would not be necessary even if `dest == src` was indeed true. Thank you for your review. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2435#note_30358

1 0

Re: [PATCH v3 0/6] MR2435: Fix activation context switching from SwitchToFiber().
by Jinoh Kang (＠iamahuman) April 18, 2023

April 18, 2023

On Mon Apr 17 21:49:22 2023 +0000, Zebediah Figura wrote: > What's this for? This is a common idiom for suppressing the `-Wunused-parameter` warning. However, Wine doesn't enable it by default, even in maintainer mode. I'll remove this line, since compiling Wine with `-Wunused` would already emit unused parameter warnings. Just an old habit of mine, I guess. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2435#note_30356

1 0

[PATCH 0/3] MR164: vkd3d: Support 1D textures.
by Conor McCarthy (＠cmccarthy) April 18, 2023

April 18, 2023

These show up in games occasionally, and the AMD CACAO demo uses one. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/164

3 4

[PATCH v3 0/7] MR153: hlsl: Return hlsl_ir_node pointers from instruction constructors, part 1.
by Zebediah Figura (＠zfigura) April 18, 2023

April 18, 2023

The motivation for this is twofold. Firstly, this makes code a little nicer to read, by virtue of removing a ubiquitous &(...)->node. Secondly, and more importantly, this allows for the possibility of constructors returning a different instruction type than intended. The ultimate goal here is to return a preallocated "error" instruction when allocation fails, instead of returning NULL and propagating out-of-memory handling to the caller. -- v3: vkd3d-shader/hlsl: Return an hlsl_ir_node pointer from hlsl_new_if(). vkd3d-shader/hlsl: Pass hlsl_block pointers to hlsl_new_if(). vkd3d-shader/hlsl: Initialize the block in clone_block(). vkd3d-shader/hlsl: Introduce a hlsl_block_cleanup() helper. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/153

4 12

[PATCH 0/4] MR152: vkd3d-shader/hlsl: Fixes for sm1 semantics.
by Zebediah Figura (＠zfigura) April 18, 2023

April 18, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/152

5 11