April 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR163: vkd3d: Handle null GPU addresses.
by Conor McCarthy (＠cmccarthy) April 18, 2023

April 18, 2023

Assassin's Creed: Valhalla sets a null index buffer, but Windows allows null for root descriptors too. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/163

3 6

[PATCH 0/2] MR162: vkd3d-shader/hlsl: Handle regset names in register() and packoffset() as case-insensitive.
by Nikolay Sivov (＠nsivov) April 18, 2023

April 18, 2023

See https://bugs.winehq.org/show_bug.cgi?id=34004#c16 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/162

3 3

[PATCH v2 0/2] MR161: vkd3d-shader/hlsl: Implement D3DCOLORtoUBYTE4().
by Nikolay Sivov (＠nsivov) April 18, 2023

April 18, 2023

-- v2: vkd3d-shader/hlsl: Implement D3DCOLORtoUBYTE4() function. vkd3d-shader/hlsl: Partially implement trunc(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/161

5 11

[PATCH v3 0/1] MR158: vkd3d-shader: Consistently pass location structure by pointer.
by Nikolay Sivov (＠nsivov) April 18, 2023

April 18, 2023

-- v3: vkd3d-shader: Consistently pass location structure by pointer. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/158

5 5

[PATCH v4 0/2] MR157: vkd3d-shader/hlsl: Add support for any() intrinsic.
by Ethan Lee (＠flibitijibibo) April 18, 2023

April 18, 2023

For now, this is limited to float and bool, scalar and vector. All other types are unsupported. Fixes https://bugs.winehq.org/show_bug.cgi?id=54777 -- v4: tests: Add tests for any() intrinsic. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/157

6 13

Re: [PATCH v3 0/1] MR499: server: Allow cancelling alerted asyncs.
by Jinoh Kang (＠iamahuman) April 18, 2023

April 18, 2023

> This works but it looks fragile. I haven't actually checked, but is there any other way that the same async can be terminated twice? Yes. Consider the following scenario on `async`: 1. I/O timeout is configured for `async` via an `async_set_timeout()` call. 1. `async` enters alerted state. 2. An application calls `NtCancelIoFileEx` with `async`'s user IOSB. 3. `async_terminate( async, STATUS_CANCELLED )` is called. 4. The timeout expires. 5. `async_terminate( async, async->timeout_status );` is called. (`async->timeout_status` is usually `STATUS_TIMEOUT`.) Furthermore, I/O cancellation and timeout can race with other async termination requests. > If so, is it correct to buffer the second termination (and not, say, buffer a third?) I don't think so. `async_terminate()` is currently no-op if the async has already been terminated with a status other than `STATUS_ALERTED`, and the patch maintains this invariant. > If not, should we make this explicitly a boolean flag ('canceled' I guess?) It is possible to introducing a new boolean flag, but the flag cannot replace `terminate_status`. `terminate_status` can be any arbitrary value passed as the third parameter of `async_set_timeout`. Alternatively, we can rename `terminate_status` to `cancel_status` or `cancellation_status` (may be a bit misleading: is a timeout a cancellation?) > Or at least add some asserts to communicate exactly when this is supposed to happen? Right now I don't see any additional invariants that the new code paths would expect. `terminate_status` simply means the first status that the async was terminated with, other than `STATUS_ALERTED`. Termination can happen regardless of whether the async is in alerted state, but `terminate_status` would be used in `async_set_result` only if `async->alerted`. Can you suggest what the assertions would be? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/499#note_30342

1 0

[PATCH 0/1] MR2666: d3dx9_36: Use __VA_ARGS__ instead of GCCs named variadics.
by Stefan Dösinger April 18, 2023

April 18, 2023

MSVC doesn't support "name...". --- msvc also supports __VA_ARGS__ only if /Zc:preprocessor is set to make its preprocessor "standards conformant" instead of doing whatever msvc used to do since aeons. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2666

2 2

[PATCH 0/1] MR2616: wined3d: Disable shaderTessellationAndGeometryPointSize.
by Zebediah Figura (＠zfigura) April 18, 2023

April 18, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2616

3 2

[PATCH v3 0/2] MR2535: wined3d: Recreate swapchain textures in wined3d_swapchain_resize_buffers().
by Zebediah Figura (＠zfigura) April 18, 2023

April 18, 2023

Stop changing their attributes in place. This is complex, somewhat brittle, and currently broken for the Vulkan backend. Restrict wined3d_texture_update_desc() to changing user memory and pitch. -- v3: https://gitlab.winehq.org/wine/wine/-/merge_requests/2535

3 4

[PATCH 0/1] MR2668: Fix typo in #define
by mjgarton (＠mjgarton) April 18, 2023

April 18, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2668

2 1