April 2023 - Wine-GitLab - list.winehq.org

[PATCH v3 0/2] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) Oct. 22, 2023

Oct. 22, 2023

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- v3: shell32: Increase timeout for long URLs https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 4

[PATCH v10 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon Oct. 20, 2023

Oct. 20, 2023

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. >From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v10: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit from abort_thread. ntdll: Avoid calling abort_thread from the signal stack. ntdll: Use is_inside_syscall more consistently. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

2 9

[PATCH v3 0/8] MR1684: d3d10/effect: Further improvements to expressions support.
by Nikolay Sivov (＠nsivov) Oct. 4, 2023

Oct. 4, 2023

-- v3: d3d10/effect: Add 'ceil' instruction for expressions. d3d10/effect: Add 'dot' instruction support for expressions. d3d10/effect: Add trigonometric instructions support for expressions. d3d10/effect: Add support for shift instructions. d3d10/effect: Add 'or' instruction support for expressions. d3d10/effect: Add more integer instructions for expressions. d3d10/effect: Add signed integer compare instructions for expressions. d3d10/effect: Implement instructions used for signed integer division. https://gitlab.winehq.org/wine/wine/-/merge_requests/1684

3 14

[PATCH 0/1] MR2684: mf: Request more samples for transforms when needed.
by Shaun Ren (＠shaunren) Sept. 29, 2023

Sept. 29, 2023

This avoids stalling the pipeline when upstream nodes have not given enough samples for processing. If there are multiple upstream nodes, request samples in a round-robin fashion. This fixes an issue where the intro audio of the game Airborne Kingdom stops playing after a few seconds. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2684

3 3

[PATCH 0/3] MR2325: d3d10/effect: Implement instructions used for signed integer division.
by Nikolay Sivov (＠nsivov) Sept. 22, 2023

Sept. 22, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2325

4 15

[PATCH 0/2] MR535: Draft: winebus: implement BusQueryContainerID for USB devices when using bus_udev
by Claire (＠ClearlyClaire) Sept. 4, 2023

Sept. 4, 2023

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. While MRs !359 and !360 implement getting the ContainerID of the IMMDevice, this MR implements getting the ContainerID from the HID device. As for !360, I marked this MR as a draft because I understand that the way the ��GUID�� is generated is far from ideal. Furthermore, there is code duplication with !360 in the way the container's sysfspath is found and how a GUID is generated from it, so moving that part elsewhere would make sense. But as for !360, I think I will need help with those tasks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/535

4 4

[PATCH 0/1] MR1809: gdiplus: Use width replace height in GdipCreateBitmapFromHICON.
by caibb2018 (＠caibb2018) Aug. 22, 2023

Aug. 22, 2023

Signed-off-by: caibb2018 <1204611687(a)qq.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1809

4 4

[PATCH v6 0/3] MR2168: win32u: Match second name when enum fonts.
by Keming Liang (＠Keming) Aug. 17, 2023

Aug. 17, 2023

the patch can resolve the issue: https://bugs.winehq.org/show_bug.cgi?id=54483 and can also solve many crashed issue related to font(MS Shell Dlg etc.) -- v6: add a skip log when there is no simsun font in test env. https://gitlab.winehq.org/wine/wine/-/merge_requests/2168

3 5

[PATCH v4 0/3] MR417: riched20: Add font fallback support.
by Jactry Zeng (＠jactry) July 25, 2023

July 25, 2023

Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v4: riched20: Add font fallbacks for CJK. riched20: Add font fallback support. riched20: Use OpenType functions for painting and generating script tags. https://gitlab.winehq.org/wine/wine/-/merge_requests/417

4 9

[PATCH v5 0/1] MR477: d3drm/tests: Show Clear sets background color
by Alistair Leslie-Hughes (＠alesliehughes) July 17, 2023

July 17, 2023

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v5: d3drm/tests: Show Clear sets background color https://gitlab.winehq.org/wine/wine/-/merge_requests/477

4 4