May 2023 - Wine-GitLab - list.winehq.org

[PATCH v10 0/13] MR148: vkd3d-shader/hlsl: Support semantics for array types.
by Francisco Casas (＠fcasas) May 1, 2023

May 1, 2023

This is required by https://bugs.winehq.org/show_bug.cgi?id=54660 . -- v10: vkd3d-shader/hlsl: Consider duplicated input semantic types equivalent in SM1. vkd3d-shader/hlsl: Handle possibly different types in input semantic var load. vkd3d-shader/hlsl: Error out when a semantic is used with incompatible types. vkd3d-shader/hlsl: Error out when an output semantic is used more than once. vkd3d-shader/hlsl: Support semantics for array types. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/148

5 17

[PATCH v5 0/3] MR188: vkd3d-shader/tpf: Add support for emitting sample_l instructions
by Ethan Lee (＠flibitijibibo) May 1, 2023

May 1, 2023

>From what I can tell, the recent work on SampleBias/SampleLevel did all of the work for us, we just need to take the same framework and include the case for the `sample_l` instruction. Tested with some shaders from the native Linux version of Little Racers STREET. -- v5: vkd3d-shader/tpf: For sample_l/sample_b, set lod swizzle to SCALAR. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/188

4 7

Re: [PATCH v2 0/4] MR174: Consolidate the TPF and d3dbc handling code.
by Henri Verbeet (＠hverbeet) May 1, 2023

May 1, 2023

> > In practice I see a number of difficulties: > > > > * Shaders are not just code; they also embed interface information (input and output signatures, uniforms, buffers, object bindings, ...) and other random metadata (for example for the hull shaders). Should this be representable in the common IR? > > We need *some* way to represent that information so it doesn't get lost, at least. I think we don't want side channels, to be clear: I think that there should be a point where all of the information relevant to a shader is represented in v_s_i format, including metadata. > > And contrary to the instructions themselves, I think we want this information to be in a relatively simple and well-designed form. In a sense, it doesn't need to be "complex" like the instructions since we're not doing optimization passes over it \[if that makes sense\]. I think Conor has basically been pushing v_s_i in this direction in order to accommodate sm6 (at least wrt semantics), and given the tribulations I've had to endure to get sm1 to work, I think that's the right approach. Yes, although I don't think that necessarily means storing these as "instructions". The approach I'm personally leaning towards at this point is to rebrand "struct vkd3d_shader_instruction_array" as "struct vkd3d_shader_program" (or something along those lines), and then add the input/output/patch constant signatures and the shader version structure to that structure. I think a similar approach should work for e.g. RDEF as well. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/174#note_31631

1 0

Re: [PATCH v6 0/2] MR2546: winegstreamer: Create extra decodebin to decode compressed stream.
by Rémi Bernon May 1, 2023

May 1, 2023

This is causing several GStreamer-Video-CRITICAL messages to be printed while running the tests: ``` (wine:363): GStreamer-Video-CRITICAL **: 09:01:22.664: gst_video_info_from_caps: assertion 'gst_caps_is_fixed (caps)' failed ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2546#note_31623

1 0

[PATCH v2 0/4] MR2726: wine{alsa,coreaudio,oss,pulse}: Move SimpleAudioVolume into mmdevapi.
by Davide Beatrici (＠davidebeatrici) May 1, 2023

May 1, 2023

Please note that with this MR the following `TRACE()` calls are removed: - `"ALSA does not support volume control\n"` - `"OSS doesn't support setting volume\n"` - `"PulseAudio does not support session volume control\n"` Should I perhaps move them to the specific drivers' unixlib instead? -- v2: winepulse: Use mmdevapi's SimpleAudioVolume. wineoss: Use mmdevapi's SimpleAudioVolume. https://gitlab.winehq.org/wine/wine/-/merge_requests/2726

3 5

[PATCH v3 0/3] MR2727: hrtfapo: Add CreateHrtfApo() stub.
by Mohamad Al-Jaf (＠maljaf) May 1, 2023

May 1, 2023

Needed by Britannia VR: Out of Your Mind. -- v3: hrtfapo: Add CreateHrtfApo() stub. hrtfapo: Add stub DLL. include: Add hrtfapoapi.idl file. https://gitlab.winehq.org/wine/wine/-/merge_requests/2727

4 7

[PATCH 0/9] MR2719: winegstreamer: Cleanup media source streams and add synchronization.
by Rémi Bernon May 1, 2023

May 1, 2023

Mostly a refresh of https://gitlab.winehq.org/wine/wine/-/merge_requests/1278, with a bit of cleanup. More to come. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2719

3 11

[PATCH v8 0/4] MR2387: winegstreamer: Use stream format in stream_props_GetMediaType.
by Ziqing Hui (＠zhui) May 1, 2023

May 1, 2023

According to the tests in 23b72ad, when we are reading a compressed stream, the type returned by `stream_props_GetMediaType()` should reflect compressed format even if we finnally output uncomressed data. For example, if we use wmvcore reader to read a WMV3 stream and output RGB24, the format information returned by `stream_props_GetMediaType()` should be WMV3, not RGB24. -- v8: winegstreamer: Use codec format in stream_props_GetMediaType. https://gitlab.winehq.org/wine/wine/-/merge_requests/2387

3 6

Re: [PATCH v2 0/4] MR174: Consolidate the TPF and d3dbc handling code.
by Zebediah Figura (＠zfigura) May 1, 2023

May 1, 2023

> > > If we want it to be usable for things like disassembly (and assembly), we need v_s_i to be able to express everything that *any* frontend or backend can. > > And I don't think we want it, it would be unmanageable. > > > should v-s IR exist just as a common, "neutral" format, and then we'd have basically frontend- and/or backend-specific IR that we'd do passes over? > > Ideally this would feel a good design to me. Though I would say that it is not a hard requirement for frontends and backends to have their specific IR, even if it is conceivable that past a certain complexity threshold it is difficult to do without. Also, my idea is that you can do passes over {front,back}end specific IRs, but also over the common IR. At least, I'd design the common IR in such a way that they can be done. This is what I originally thought, but I'm having slight second thoughts now. The thing is that the tradeoff is now you need a new IR for every bytecode language you have, which in our case means at least sm1, sm4, and eventually I think sm6. That's a lot of extra support code to add. Consider how much we'd need to add by putting that intermediate step into HLSL -> smX translation. The advantage of making v_s_i the IR is that you don't actually need any of that. It does feel conceptually ugly to have a CISC IR, but looking past that, I'm not sure it's that bad? Some additions (new opcodes, new register types) aren't a problem, since the backends can just vkd3d_shader_error(). Some additions (new source fields, new instruction flags) are worse, though, since now you need to make sure that nothing else cares... It may also not be that much of a concern if the number of languages we have doesn't actually grow that large. It may make sense to start with something underdesigned—which I think means CISC—and if that starts to get actually unwieldy, then we can start overdesigning a RISC IR to mediate. > In practice I see a number of difficulties: > > * Shaders are not just code; they also embed interface information (input and output signatures, uniforms, buffers, object bindings, ...) and other random metadata (for example for the hull shaders). Should this be representable in the common IR? We need *some* way to represent that information so it doesn't get lost, at least. I think we don't want side channels, to be clear: I think that there should be a point where all of the information relevant to a shader is represented in v_s_i format, including metadata. And contrary to the instructions themselves, I think we want this information to be in a relatively simple and well-designed form. In a sense, it doesn't need to be "complex" like the instructions since we're not doing optimization passes over it [if that makes sense]. I think Conor has basically been pushing v_s_i in this direction in order to accommodate sm6 (at least wrt semantics), and given the tribulations I've had to endure to get sm1 to work, I think that's the right approach. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/174#note_31612

1 0

[PATCH v4 0/1] MR180: vkd3d-shader/hlsl: Partially implement static expressions evaluation.
by Nikolay Sivov (＠nsivov) May 1, 2023

May 1, 2023

-- v4: vkd3d-shader/hlsl: Partially implement static expressions evaluation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/180

3 3