June 2023 - Wine-GitLab - list.winehq.org

[PATCH v6 0/2] MR2778: mfmediaengine: Add support for video effects.
by Bernhard Kölbl June 20, 2023

June 20, 2023

The test has a little inspiration from the SDK samples. -- v6: mfmediaengine: Add support for inserting video effects. mfmediaengine/tests: Add tests for video effects. https://gitlab.winehq.org/wine/wine/-/merge_requests/2778

3 17

[PATCH 0/4] MR3115: imm32: Fixes for comp string on character deletion and result commit.
by Rémi Bernon June 20, 2023

June 20, 2023

I believe this fixes some bad behavior, and it includes one fix from https://gitlab.winehq.org/wine/wine/-/merge_requests/2698 to avoid duplicated entries (though doesn't supersedes that MR). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3115

3 7

Re: [PATCH v2 0/1] MR3104: win32u: Add DriverVersion string for GPUs to registry
by Michael Skorokhodov (＠Samsuper) June 20, 2023

June 20, 2023

@julliard Hi! Can you please review this MR? About the purpose of the changes: https://github.com/ValveSoftware/wine/pull/191 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3104#note_36306

1 0

[PATCH v2 0/9] MR3048: Media.speech improvements.
by eric pouech (＠epo) June 20, 2023

June 20, 2023

This series adds a couple of features to WinRT's media.speech: - IVoiceInformation, and synthetizer's options are present (mainly use to store information, not yet to make fully use of it) - add a dummy implementation (1 single voice); that should be extended in future series by using ISpVoice instead - add a couple of more tests to go with implementation (the serie should prevent MS Flight simulator to crash on first connection. Crash is due to exception handling of C# generated exceptions from E_NOTIMPL with some X11 related critical resources). A+ -- v2: windows.media.speech: Implement get/put voice on synthesizer. windows.media.speech: Implement default voice. windows.media.speech: Add more tests about voice selection. windows.media.speech: Finish implement the voice information view. windows.media.speech/tests: Added tests about vector view's content. windows.media.speech: Add basic implementation of IVoiceInformation. windows.media.speech: Add more tests about IVoiceInformation. windows.media.speech: Add basic implementation on synthesizer options. windows.media.speech: Adding a couple of synthesizer's options tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3048

3 10

[PATCH v2 0/2] MR3120: win32u: Move virtual desktop display settings logic from winex11.
by Rémi Bernon June 20, 2023

June 20, 2023

-- v2: win32u: Move virtual desktop display settings logic from winex11. win32u: Split default UpdateDisplayDevices implementation to a helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/3120

1 3

Re: [PATCH v5 0/4] MR3073: Implement FileDispositionInformationEx and FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE - closed
by Joel Holdsworth (＠jhol) June 20, 2023

June 20, 2023

This merge request was closed by Joel Holdsworth. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3073

1 0

[PATCH v2 0/5] MR224: tests: Test coarse and fine derivates and demand less precision from ddx() and ddy().
by Francisco Casas (＠fcasas) June 20, 2023

June 20, 2023

On my Nvidia GeForce GTX 1050 Ti `ddxddy.shader_test` doesn't pass because of considerably different numeric results. As Giovanni pointed out, this is because my GPU uses the fine derivate and not the coarse derivate to implement ddx() and ddy(). For this reason, the result for ddx|ddy() is quantized so that the test passes if the GPU uses either coarse or fine derivates. Additionally, tests for both ddx_coarse|ddy_coarse() and ddx_fine|ddy_fine() are added, that expect a more precise result. -- v2: vkd3d-shader/hlsl: Fine derivates support. vkd3d-shader/hlsl: Coarse derivates support. tests: Quantize ddx() and ddy() test. tests: Make ddx() and ddy() test behave correctly for shader models < 4. tests: Test coarse and fine derivates. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/224

5 11

[PATCH 0/5] MR3118: Implement dbghelp.SymSrvGetFileIndexesInfo().
by eric pouech (＠epo) June 20, 2023

June 20, 2023

Implements SymSrvGetFileIndexesInfo() for PE images. (.dbg and .pdb are still to be done). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3118

2 5

[PATCH v3 0/1] MR3117: loader: Set the visibility of symbols in preloader to "hidden". (#55091)
by Jinoh Kang (＠iamahuman) June 20, 2023

June 20, 2023

Today, the preloader is linked with -fPIE in spite of the fact that the preloader is a non-PIE statically linked binary. This is due to a limitation in tools/makedep that makes it difficult to specify CFLAGS for each individual object file's recipe. This can seemingly cause problems with some GOTPCREL(X) relocations inside the preloader. Since preloader does not link to the system library directly, there is no need for a Global Offset Table (GOT). However, a few extern (non-static) function symbols are declared, the use of which makes GCC emit instructions that references those symbols by indirection through GOT. The linker then tries to optimize such instructions to eliminate GOT references, which can fail due to various reasons. This stands in contradiction with Jinoh Kang's suggestion (in bug 55050) that "-fPIE is harmless even when applied to an object linked into non-PIE executables." The claim is theoretically true since position-independent code can in principle be relocated to any address (fixed or dynamic); however, it fails due to some peculiar practical issues, which is arguably a limitation in the linker's implementation (since it can be worked around with -Wl,--no-relax without issues). Fix this by eliminating GOT usage by setting the default visibility of non-static declarations to "hidden". Assuming GCC's medium code model (-mcmodel=medium; default code model for x86_64), this suppresses any unnecessary PLT or GOT relocations for defined symbols, and provides opportunity for GCC to optimize the code better. Fixes: 78ed343842dcd8ffb95c416420953e121959d40d Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55091 cc/ @epo -- v3: loader: Set the visibility of symbols in preloader to "hidden". https://gitlab.winehq.org/wine/wine/-/merge_requests/3117

2 2

[PATCH 0/1] MR3117: loader: Set the visibility of symbols in preloader to "hidden". (#55095)
by Jinoh Kang (＠iamahuman) June 20, 2023

June 20, 2023

Today, the preloader is linked with -fPIE in spite of the fact that the preloader is a non-PIE statically linked binary. This is due to a limitation in tools/makedep that makes it difficult to specify CFLAGS for each individual object file's recipe. This can seemingly cause problems with some GOTPCREL(X) relocations inside the preloader. Since preloader does not link to the system library directly, there is no need for Global Offset Tables (GOT). However, a few extern (non-static) function symbols are declared, the use of which makes GCC emit instructions that references those symbols by indirection through GOT. The linker then tries to optimize such instructions to eliminate GOT references, which can fail due to various reasons. This stands in contradiction with Jinoh Kang's suggestion (in bug 55050) that "-fPIE is harmless even when applied to an object linked into non-PIE executables." The claim is theoretically true since position-independent code can in principle be relocated to any address (fixed or dynamic); however, it fails due to some peculiar practical issues, which is arguably a limitation in the linker's implementation (since it can be worked around --no-relax without issues). Fix this by eliminating GOT usage by setting the default visibility of non-static declarations to "hidden". Assuming GCC's medium code model (-mcmodel=medium; default code model for x86_64), this suppresses any unnecessary PLT or GOT relocations for defined symbols, and provides opportunity for GCC to optimize the code better. Fixes: 78ed343842dcd8ffb95c416420953e121959d40d Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55095 cc/ @epo -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3117

2 2