June 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR2971: mscms: Fix double free on error path in EnumColorProfilesA (scan-build).
by Alex Henrie (＠alexhenrie) June 5, 2023

June 5, 2023

If fileW is not null, it is freed at the end of the function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2971

3 2

[PATCH 0/1] MR2970: wusa: Fix double free on error path in read_update_package (scan-build).
by Alex Henrie (＠alexhenrie) June 5, 2023

June 5, 2023

If read_identity returns FALSE, it has already called clear_identity. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2970

3 2

Re: [PATCH v2 0/5] MR2901: winegstreamer: Test and fix H264 timestamps and concatenated streams.
by Zebediah Figura (＠zfigura) June 5, 2023

June 5, 2023

> It is not a matter of no-confidence, although I could argue that being told that my statements are non-sensical in several occasions isn't a great way to build confidence. I suspect I know at least one of the occasions you're referring to, and I'd like to apologize for that. It's never been my intent to demean or insult, and I'm sorry for having done so anyway. I will try to be more mindful of my language in the future. > I took maintainership of the wg_transform code, not just because I wrote most of it, but also in order to help with the bandwidth, and avoid bothering two persons on every single change. I believe I have taken every comment into account very carefully, and haven't bypassed your review or Nikolay's for MF related things, on any meaningful change. I appreciate the wish to reduce my workload, and I will gladly agree that my reviews have been acknowledged. As I've stated, though, I would still like the opportunity to perform those reviews on any winegstreamer changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2901#note_34600

1 0

[PATCH 0/1] MR2968: include: Annotate SHAlloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) June 4, 2023

June 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2968

3 2

[PATCH 0/1] MR2969: include: Annotate IoAllocate functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) June 4, 2023

June 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2969

2 1

[PATCH 0/2] MR2967: msvcr100: Use Context blocking functions in critical_section class.
by Piotr Caban (＠piotr) June 4, 2023

June 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2967

2 2

[PATCH v12 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) June 3, 2023

June 3, 2023

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are supported by this patch. -- v12: ws2_32/tests: Add test for AF_UNIX sockets. server: Introduce error when attempting to connect() to abstract AF_UNIX sockets. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ntdll/unix: Add support for AF_UNIX sockets to multiple functions. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

3 11

[PATCH 0/1] MR2964: configure: stash host LDFLAGS when configuring cross-compilers
by Billy Laws (＠bylaws) June 3, 2023

June 3, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2964

2 1

[PATCH 0/1] MR2960: kernelbase: Comment out DECLSPEC_HOTPATCH for ConvertThreadToFiber.
by Rémi Bernon June 3, 2023

June 3, 2023

Should be fixing the constant MR failures, though I don't know how critical DECLSPEC_HOTPATCH is. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2960

4 6

[PATCH v2 0/4] MR2958: mf: Various refcount leak fixes for session.
by Bernhard Kölbl June 3, 2023

June 3, 2023

-- v2: mfmediaengine/tests: Add refcount checks for final release of media engine. https://gitlab.winehq.org/wine/wine/-/merge_requests/2958

2 6