July 2023 - Wine-GitLab - list.winehq.org

[PATCH v2 0/4] MR3297: uiautomationcore: Initial COM event handler support.
by Connor McAdams (＠cmcadams) July 18, 2023

July 18, 2023

-- v2: uiautomationcore: Implement IUIAutomation::RemoveAutomationEventHandler. uiautomationcore: Implement IUIAutomation::RemoveAllEventHandlers. uiautomationcore: Partially implement IUIAutomation::AddAutomationEventHandler. uiautomationcore/tests: Add IUIAutomationEventHandler tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3297

3 8

[PATCH v5 0/6] MR3302: Draft: gdiplus: Fix GdipGetPropertySize and GdipGetAllPropertyItems return values when no properties exist.
by Jeffrey Smith (＠whydoubt) July 18, 2023

July 18, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54748 -- v5: gdiplus: Fix GdipGetAllPropertyItems return value when no properties exist. gdiplus: Fix GdipGetPropertySize return value when no properties exist. gdiplus/tests: Pare down image property tests that are not run for Wine. gdiplus/tests: Use test context for test ran in a loop. gdiplus/tests: Add GIF to image properties tests. gdiplus/tests: Use consistent no-alternate value for image properties. https://gitlab.winehq.org/wine/wine/-/merge_requests/3302

2 7

[PATCH v6 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) July 18, 2023

July 18, 2023

Instead of querying the registry, just calls `GetDpiForWindow`. Winecfg's DPI slider sets `Control Panel\\Desktop\\LogPixels`. See `programs/winecfg/x11drvdlg.c` Notepad queries `Software\\Fonts\\LogPixels`, and so doesn't pick up on the change. I don't believe this changes how Notepad looks to the user, but it is necessary for a further MR I'm working on that adds more information to the status bar. -- v6: notepad: Use GetDpiForWindow() https://gitlab.winehq.org/wine/wine/-/merge_requests/3353

2 1

[PATCH v5 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) July 18, 2023

July 18, 2023

Instead of querying the registry, just calls `GetDpiForWindow`. Winecfg's DPI slider sets `Control Panel\\Desktop\\LogPixels`. See `programs/winecfg/x11drvdlg.c` Notepad queries `Software\\Fonts\\LogPixels`, and so doesn't pick up on the change. I don't believe this changes how Notepad looks to the user, but it is necessary for a further MR I'm working on that adds more information to the status bar. -- v5: notepad: Use GetDpiForWindow() https://gitlab.winehq.org/wine/wine/-/merge_requests/3353

3 3

[PATCH 0/4] MR260: vkd3d: Prepare for buffering of command list commands.
by Conor McCarthy (＠cmccarthy) July 18, 2023

July 18, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/260

4 8

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Jeffrey Smith (＠whydoubt) July 18, 2023

July 18, 2023

On Tue Jul 18 18:38:06 2023 +0000, Brendan Shanks wrote: > Also, the commit title should start with `notepad:`, something like > `notepad: Use GetDpiForWindow()`. While changing the commit title, it might be worth-while to pare down the rest of the commit message. Specifically, while the last paragraph is relevant to the MR, I don't think it will serve any lasting value in the commit history. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39330

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Brendan Shanks (＠bshanks) July 18, 2023

July 18, 2023

Also, the commit title should start with `notepad:`, something like `notepad: Use GetDpiForWindow()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39329

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by David Kahurani (＠kahurani) July 18, 2023

July 18, 2023

With these changes, it doesn't look like `get_dpi` serves any purpose anymore. You might as well refactor it all out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39327

1 0

Re: [PATCH v4 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) July 18, 2023

July 18, 2023

Sorry for all the hullabaloo; I've `git rebased` it to be under my Gitlab account now. (Previously it was inheriting my personal Github account information). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353#note_39321

1 0

[PATCH 0/1] MR3353: Make Notepad properly get the DPI value.
by Petrichor Park (＠petrathekat) July 18, 2023

July 18, 2023

Instead of querying the registry, just calls `GetDpiForWindow`. Winecfg's DPI slider sets `Control Panel\\Desktop\\LogPixels`. See `programs/winecfg/x11drvdlg.c` Notepad queries `Software\\Fonts\\LogPixels`, and so doesn't pick up on the change. I don't believe this changes how Notepad looks to the user, but it is necessary for a further MR I'm working on that adds more information to the status bar. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3353

4 4