August 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/2] MR3372: ole32: Leave the RunningObjectTable Critical Section before unmarshalling object stream
by Lorenzo Ferrillo (＠llde) Sept. 10, 2023

Sept. 10, 2023

In certain circumstances unmarshalling an object stream from the RunningObjectTable can cause the unmarshalling routines to interrogate the same table (maybe to resolve a dependant object?) in a different thread causing a deadlock while getting the critical section lock. Leaving the Critical Section before unmarshalling the object stream solve this problem. Visual Studio 2019 deadlock on start without this. I'm not sure how to test this properly. Signed-off-by: Lorenzo Ferrillo <lorenzofersteam(a)live.it> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3372

4 6

[PATCH 0/1] MR3151: widl: Prevent infinite loop when structure contains array of itself
by Fabian Maurer (＠DarkShadow44) Sept. 9, 2023

Sept. 9, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55115 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3151

3 6

[PATCH v3 0/1] MR3382: winebuild: Zero space between Wine signature and PE header in "builtin" files.
by Konstantin Demin (＠rockdrilla) Sept. 8, 2023

Sept. 8, 2023

Signed-off-by: Konstantin Demin <rockdrilla(a)gmail.com> -- v3: winebuild: Zero space between Wine signature and PE header in "builtin" files. https://gitlab.winehq.org/wine/wine/-/merge_requests/3382

3 8

[PATCH 0/1] MR3535: ntdll: Take LARGE_ADDRESS_AWARE into account for userspace allocation limits.
by Billy Laws (＠bylaws) Sept. 8, 2023

Sept. 8, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3535

3 3

[PATCH v7 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) Sept. 6, 2023

Sept. 6, 2023

-- v7: tests: Add a test for fmod() with vector arguments. vkd3d-shader: Use ternary operator in fmod() implementation. vkd3d-shader/tpf: Use 'movc' to implement ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

5 13

[PATCH 0/2] MR3623: comctl32/edit: Don't use WM_TIMER to update caret position.
by Zhiyi Zhang (＠zhiyi) Sept. 6, 2023

Sept. 6, 2023

An application subclasses edit control and crashes on unexpected WM_TIMER messages. A timer was added a long time ago and it was for auto scrolling the view when the cursor is outside of the client area. However, with a EDIT_EM_ScrollCaret() call in EDIT_WM_MouseMove(), the view can be scrolled to the correct position automatically. So the timer is not necessary at all. This is tested manually with a long text in the edit control with notepad on XP, Win7 and Win10. Before this patch, the caret will move backwards every 100ms when the clicking the left mouse button on the bottom of the text and then dragging the cursor upwards and outside of the client area. After this, the behavior is the same as native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3623

3 3

[PATCH 0/5] MR3686: winewayland.drv: part 6: Handle wl_pointer (mouse) events.
by Alexandros Frantzis (＠afrantzis) Sept. 6, 2023

Sept. 6, 2023

This MR adds support for handling `wl_pointer` devices: 1. Handle enter/leave/(absolute) motion/button/axis events to allow users to interact with applications using such devices, e.g., a mouse. 2. Update the cursor image used for Wayland surfaces based on the Windows cursor bitmap data. A few notes: 1. A single `wl_seat`/`wl_pointer` is supported for now. 2. Many of the input interactions require window management support that hasn't been implemented yet (e.g., popup positioning, resizing, max/fullscreen). 3. There is some potential for bad interactions between the input event dispatching mechanism and the `win32u` flushing logic for `window_surface` , which can lead to visual glitches. Although I don't think this is blocker for this MR, I would like to start a discussion about the problem and mitigation ideas in a comment below. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3686

5 34

[PATCH v3 0/10] MR3211: wined3d: Don't force going through a texture when downloading from renderbuffers.
by Matteo Bruni (＠Mystral) Sept. 6, 2023

Sept. 6, 2023

It can be unnecessary at best and unsupported at worst (e.g. no ARB_texture_multisample). -- v3: wined3d: Don't skip ARB fragment program selection when fog state is dirty. wined3d: Don't force going through a texture when downloading from renderbuffers. wined3d: Handle depth textures in texture2d_read_from_framebuffer(). wined3d: Rename wined3d_context_gl_apply_fbo_state_blit() function. wined3d: Don't setup FBO and draw buffers in wined3d_context_gl_apply_blit_state(). wined3d: Don't call wined3d_texture_load() from wined3d_context_gl_apply_blit_state(). wined3d: Don't bind the FBO to GL_READ_FRAMEBUFFER in wined3d_context_gl_apply_blit_state(). wined3d: Prepare/load the destination resource location in arbfp_blitter_blit(). wined3d: Prepare/load the destination resource location in ffp_blitter_blit(). wined3d: Don't call wined3d_context_gl_apply_blit_state() from texture2d_read_from_framebuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3211

3 17

[PATCH v4 0/3] MR3312: programs/start: Allow Ctrl-C to terminate GUI applications (/exec mode).
by eric pouech (＠epo) Sept. 6, 2023

Sept. 6, 2023

Since dcf0bf1f, one could no longer kill a GUI application launched from unix shell (with start.exe /exec) with ctrl-c. (depends on https://gitlab.winehq.org/wine/wine/-/merge_requests/3310 to be fully functional). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v4: programs/cmd: Better handle ctrl-c events. ntdll,server: Terminate GUI programs launched from unix shell. kernel32/console: Add tests for GenerateConsoleCtrlEvent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3312

3 6

[PATCH v2 0/1] MR3680: d3d9/tests: Wait longer in test_occlusion_query for software renderers.
by Stefan Dösinger Sept. 5, 2023

Sept. 5, 2023

The issue can be reproduced with LIBGL_ALWAYS_SOFTWARE=1 on Mesa. The Gitlab machines are affected. -- v2: d3d9/tests: Skip big test_query loops if the d3d implementation is too slow. https://gitlab.winehq.org/wine/wine/-/merge_requests/3680

4 4