August 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/4] MR312: vkd3d-shader/spirv: Declare descriptors from the scanned descriptor info. - approved
by Alexandre Julliard (＠julliard) Aug. 28, 2023

Aug. 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/312

1 0

Re: [PATCH v3 0/2] MR301: vkd3d-shader/hlsl: Ignore 'inline' modifier for functions. - approved
by Alexandre Julliard (＠julliard) Aug. 28, 2023

Aug. 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/301

1 0

Re: [PATCH v13 0/5] MR225: vkd3d-shader/tpf: Read complete swizzle/mask info from parameter tokens. - approved
by Alexandre Julliard (＠julliard) Aug. 28, 2023

Aug. 28, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/225

1 0

Re: [PATCH v3 0/2] MR1893: increase number of midi ports to 64
by Alexander Chalikiopoulos (＠dreamer) Aug. 28, 2023

Aug. 28, 2023

Is there anything major blocking the merge of this PR? While it would indeed be best to find a proper way to handle midi devices, this PR would at least solve the current behavior of wine in dealing with this which is problematic. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893#note_43592

1 0

Re: [PATCH v3 0/2] MR1893: increase number of midi ports to 64
by Alexander Chalikiopoulos (＠dreamer) Aug. 28, 2023

Aug. 28, 2023

On Mon Aug 28 20:00:42 2023 +0000, Bartosz Kosiorek wrote: > There is also Midi Sources maximum number set to 16: > https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/winealsa.drv/alsamid… > Do you know if it should be also increased? Doesn't that literally use the same definition that I changed in this PR? In which case: it already gets a new value from the current change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893#note_43591

1 0

Re: [PATCH v3 0/2] MR1893: increase number of midi ports to 64
by Bartosz Kosiorek (＠gang65) Aug. 28, 2023

Aug. 28, 2023

On Sat Dec 31 12:29:07 2022 +0000, Alexander Chalikiopoulos wrote: > Agreed, however I don't know the wine code-base at all so wouldn't know > where to start. > Any suggestions on how to properly do this are welcome of course :) There is also Midi Sources maximum number set to 16: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/winealsa.drv/alsamid… Do you know if it should be also increased? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893#note_43590

1 0

Re: [PATCH v2 0/1] MR3611: gdiplus: set Tahoma font in case MS Sans Serif is missing
by Bartosz Kosiorek (＠gang65) Aug. 28, 2023

Aug. 28, 2023

On Wed Aug 23 20:11:56 2023 +0000, Esme Povirk wrote: > Is there a convincing argument that Tahoma is better overall (as opposed > to better for this one launcher)? Except this game, I don't know any benefits of Tahoma. Should I close this Merge Request? @madewokherd Could you please close the bug then? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3611#note_43587

1 0

[PATCH 0/1] MR316: tests: Enable compiler backwards compatibility mode only for shaders that require it.
by Nikolay Sivov (＠nsivov) Aug. 28, 2023

Aug. 28, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/316

5 5

[PATCH v2 0/2] MR3668: cmd: fixed command chaining
by Dmitry Sokolov (＠DmitrySokolov) Aug. 28, 2023

Aug. 28, 2023

Fixed the following code: ```plaintext echo 1. && echo ok || echo failed echo 2. || echo failed && echo --- & echo 3. ``` Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55489 -- v2: cmd: reverted accidentally WCMD_echo change https://gitlab.winehq.org/wine/wine/-/merge_requests/3668

3 3

[PATCH v3 0/1] MR2507: vbscript: Add additional types for stack_pop_bool.
by Jason Millard (＠jsm174) Aug. 28, 2023

Aug. 28, 2023

I have found some scripts where comparisons that use floats and OLECOLOR directly fail. For example: ``` If Light005.State Then ' State is a float V_R4 End If If Light005.Colorfull Then ' Colorfull is an OLECOLOR VT_UI4 End If ``` This is because `stack_pop_bool` does not handle `VT_R4` and `VT_UI4` and returns `E_NOTIMPL`. This adds additional types to `stack_pop_bool` similar to `VARIANT_Coerce`. Fixes https://bugs.winehq.org/show_bug.cgi?id=54731 -- v3: https://gitlab.winehq.org/wine/wine/-/merge_requests/2507

2 1