August 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/5] MR3572: mf: Make session_get_node_object() more robust.
by Nikolay Sivov (＠nsivov) Aug. 18, 2023

Aug. 18, 2023

On Fri Aug 18 02:25:13 2023 +0000, Zhiyi Zhang wrote: > Doesn't the current MR contain only mf changes? Sure, my comment was for initial patchset. I probably finalized comment/review too late, making this confusing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3572#note_42739

1 0

[PATCH 0/13] MR3597: mshtml: Implement Cycle Collection for all mshtml objects (dispex), part 5.
by Gabriel Ivăncescu Aug. 18, 2023

Aug. 18, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3597

2 20

[PATCH v3 0/1] MR3608: mshtml: Check for non-NULL plugin host before trying to hold ref.
by James Beddek (＠telans) Aug. 18, 2023

Aug. 18, 2023

This fixes a regression caused by https://gitlab.winehq.org/wine/wine/-/commit/08dc691dfb410de7115db3f9c34b22… making Robot Battle 1.4 crash on startup. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55457 Signed-off-by: James Beddek <telans(a)posteo.de> -- v3: mshtml: Check for non-NULL plugin host before trying to hold ref. https://gitlab.winehq.org/wine/wine/-/merge_requests/3608

4 4

Re: [PATCH v2 0/1] MR3608: mshtml: check for err before trying to hold plugin host ref
by Gabriel Ivăncescu Aug. 18, 2023

Aug. 18, 2023

Gabriel Ivăncescu (@insn) commented about dlls/mshtml/npplugin.c: > } > > instance->pdata = container->plugin_host; > - IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface); > + if(!err) > + IOleClientSite_AddRef(&container->plugin_host->IOleClientSite_iface); I'd personally check for `container->plugin_host` being non-NULL here instead of checking for err, but it doesn't really matter, depends how Jacek feels about it. Minor nitpick: Please capitalize first word in the commit title (`check`→`Check`) and add a period at the end. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3608#note_42721

1 0

[PATCH v3 0/3] MR3563: server: Symlink CurrentControlSet to ControlSet001
by Torge Matthies (＠tmatthies) Aug. 18, 2023

Aug. 18, 2023

Signed-off-by: Torge Matthies <openglfreak(a)googlemail.com> -- v3: loader: Add Default, Failed, and LastKnownGood values to HKLM\System\Select. server: Create link from HKLM\System\CurrentControlSet to ControlSet001. advapi32/tests: Add test for CurrentControlSet link. https://gitlab.winehq.org/wine/wine/-/merge_requests/3563

2 3

[PATCH 0/5] MR3607: apisetschema: Add ext-ms-win-dxcore-l1-1-0.
by Mohamad Al-Jaf (＠maljaf) Aug. 18, 2023

Aug. 18, 2023

Needed by Affinity Photo. The headers are needed for MinGW. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3607

3 10

[PATCH 0/1] MR3609: wow64: Add BT module thread termination callback.
by Billy Laws (＠bylaws) Aug. 18, 2023

Aug. 18, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3609

2 1

[PATCH v3 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests.
by Alex Henrie (＠alexhenrie) Aug. 18, 2023

Aug. 18, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55450 -- v3: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

3 2

[PATCH 0/1] MR3608: mshtml: check for err before trying to hold plugin host ref
by James Beddek (＠telans) Aug. 18, 2023

Aug. 18, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55457 Signed-off-by: James Beddek <telans(a)posteo.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3608

2 1

[PATCH v9 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Bartosz Kosiorek (＠gang65) Aug. 18, 2023

Aug. 18, 2023

I have covered implementation with additional test cases. -- v9: gdiplus: add support for GdipPathIterNextPathType https://gitlab.winehq.org/wine/wine/-/merge_requests/3581

2 1