August 2023 - Wine-GitLab - list.winehq.org

[PATCH v2 0/3] MR3523: quartz: Fix some more memory leaks.
by Sven Baars (＠sbaars) Aug. 7, 2023

Aug. 7, 2023

-- v2: strmbase: Fix a critical section leak (Valgrind). quartz/tests: Fix some memory leaks in test_add_source_filter() (Valgrind). https://gitlab.winehq.org/wine/wine/-/merge_requests/3523

3 4

[PATCH 0/4] MR299: vkd3d-shader/hlsl: Get SM4 texture allocation order and RDEF bind count for lowered combined samplers right.
by Francisco Casas (＠fcasas) Aug. 7, 2023

Aug. 7, 2023

First, we have to distinguish between the "bind count" and the "allocation size" of variables. The "allocation size" affects the starting register id for the resource to be allocated next, while the "bind count" is determined by the last field actually used. The former may be larger than the latter. Currently we are calling `hlsl_reg.bind_count` to what should be `hlsl_reg.allocation_size`. So it is renamed in 2/4. The proper "bind count" (now computed when needed in 3/4) is important because it is what should appear in the RDEF table and some resource allocation rules depend on it For instance, for this shader: ``` texture2D texs[3]; texture2D tex; float4 main() : sv_target { return texs[0].Load(int3(0, 0, 0)) + tex.Load(int3(0, 0, 0)); } ``` the variable "texs" should show a "bind count" of 1, even though its "allocation size" is 3: ``` // Resource Bindings: // // Name Type Format Dim HLSL Bind Count // ------------------------------ ---------- ------- ----------- -------------- ------ // texs texture float4 2d t0 1 // tex texture float4 2d t3 1 ``` In particular, as shown in the tests in 1/4, textures go in this order: 1. Textures created from SM1-style samples. Those whose "bind count" is larger than 1, in the order of the tex1D/tex2D/tex3D/texCube instructions that create them. 2. Textures created from SM1-style samples. Those whose "bind count" is equal to 1, in the order of the tex1D/tex2D/tex3D/texCube instructions that create them. 3. Regular textures in order of declaration. Note that the difference between 1 and 2 is not given by the "allocation size" but the "bind count". This order is enforced in 4/4. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/299

3 6

Re: [PATCH v5 0/2] MR3473: whoami: Refactor and add more commands.
by Hans Leidekker (＠hans) Aug. 7, 2023

Aug. 7, 2023

On Mon Aug 7 15:46:06 2023 +0000, Maxim Karasev wrote: > Which `whoami` was tested? If it was the current in-tree one, then it > works because it already uses `ConsoleWriteW()`. Yes, I tested current Wine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3473#note_41507

1 0

Re: [PATCH v5 0/2] MR3473: whoami: Refactor and add more commands.
by Maxim Karasev (＠mxkrsv) Aug. 7, 2023

Aug. 7, 2023

On Thu Aug 3 17:58:39 2023 +0000, Hans Leidekker wrote: > I tried a username with non-ascii characters on Windows 10 and Wine and > whoami behaves the same. Non-ascii characters are rendered on the > console. When redirecting output non-ascii characters are replaced with '?'. Which `whoami` was tested? If it was the current in-tree one, then it works because it already uses `ConsoleWriteW()`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3473#note_41503

1 0

[PATCH 0/3] MR3523: quartz: Fix some more memory leaks.
by Sven Baars (＠sbaars) Aug. 7, 2023

Aug. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3523

3 4

[PATCH v2 0/34] MR294: vkd3d: Store command list commands in a buffer until executed.
by Conor McCarthy (＠cmccarthy) Aug. 7, 2023

Aug. 7, 2023

It's no problem to send fewer of these per MR. I have included the complete set because all but the last introduce no functional changes, and upstreaming a smaller set would leave the changes in a half-done state with unnecessary buffering. -- v2: vkd3d: Store command list commands in a buffer until executed. vkd3d: Store WriteBufferImmediate() arguments in a buffer. vkd3d: Store ExecuteIndirect() arguments in a buffer. vkd3d: Store SetPredication() arguments in a buffer. vkd3d: Store ResolveQueryData() arguments in a buffer. vkd3d: Store EndQuery() arguments in a buffer. vkd3d: Store BeginQuery() arguments in a buffer. vkd3d: Store d3d12_command_list_clear_uav() arguments in a buffer. vkd3d: Store ClearRenderTargetView() arguments in a buffer. vkd3d: Store ClearDepthStencilView() arguments in a buffer. vkd3d: Store OMSetRenderTargets() arguments in a buffer. vkd3d: Store SOSetTargets() arguments in a buffer. vkd3d: Store IASetVertexBuffers() arguments in a buffer. vkd3d: Store IASetIndexBuffer() arguments in a buffer. vkd3d: Store d3d12_command_list_set_root_descriptor() arguments in a buffer. vkd3d: Store d3d12_command_list_set_root_cbv() arguments in a buffer. vkd3d: Store d3d12_command_list_set_root_constants() arguments in a buffer. vkd3d: Store d3d12_command_list_set_descriptor_table() arguments in a buffer. vkd3d: Store d3d12_command_list_set_root_signature() arguments in a buffer. vkd3d: Add an internal refcount to struct d3d12_root_signature. vkd3d: Store ResourceBarrier() arguments in a buffer. vkd3d: Store SetPipelineState() arguments in a buffer. vkd3d: Store OMSetStencilRef() arguments in a buffer. vkd3d: Store OMSetBlendFactor() arguments in a buffer. vkd3d: Store RSSetScissorRects() arguments in a buffer. vkd3d: Store RSSetViewports() arguments in a buffer. vkd3d: Store IASetPrimitiveTopology() arguments in a buffer. vkd3d: Store ResolveSubresource() arguments in a buffer. vkd3d: Store CopyResource() arguments in a buffer. vkd3d: Store CopyTextureRegion() arguments in a buffer. vkd3d: Store CopyBufferRegion() arguments in a buffer. vkd3d: Store Dispatch() arguments in a buffer. vkd3d: Store DrawIndexedInstanced() arguments in a buffer. vkd3d: Store DrawInstanced() arguments in a buffer. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/294

1 0

[PATCH v3 0/4] MR3457: wine{alsa,pulse}: Move GetPropValue into mmdevapi.
by Davide Beatrici (＠davidebeatrici) Aug. 7, 2023

Aug. 7, 2023

-- v3: winealsa: Remove GetPropValue. winepulse: Move GetPropValue into mmdevapi. wineoss: Add get_prop_value stub in unixlib. winecoreaudio: Add get_prop_value stub in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3457

3 5

[PATCH v2 0/4] MR3457: wine{alsa,pulse}: Move GetPropValue into mmdevapi.
by Davide Beatrici (＠davidebeatrici) Aug. 7, 2023

Aug. 7, 2023

-- v2: winealsa: Remove GetPropValue. winepulse: Move GetPropValue into mmdevapi. wineoss: Add get_prop_value stub in unixlib. winecoreaudio: Add get_prop_value stub in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3457

3 7

[PATCH v2 0/9] MR3506: Improve headers compatibility
by Vitaly Lipatov (＠lav) Aug. 7, 2023

Aug. 7, 2023

I tried build a real Windows application (mimikatz) and had troubles with some wine headers incompatibility. The patch set improves headers to allow build the foreign application with Wine. -- v2: include: Add standalone LSA_OBJECT_ATTRIBUTES prototype if ntdef.h is not included. include: Add initial activeds.h. include: Add missed PCWCHAR to winnt.h. include: Include ncrypt.h in wincrypt.h. include: Add specstrings_strict.h with some defines. include: Use compatible file guard name (_NTSECAPI_, _NTSECPKG_). include: Add some missed defines. ntdll: Use COMPRESSION_FORMAT_MASK instead of ~COMPRESSION_ENGINE_MAXINUM. https://gitlab.winehq.org/wine/wine/-/merge_requests/3506

4 12

[PATCH v7 0/4] MR585: Improve is_gecko_path() for handling non-ASCII characters.
by Jactry Zeng (＠jactry) Aug. 7, 2023

Aug. 7, 2023

This fixes an issue when the path includes non-ASCII characters. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v7: mshtml: Call UrlUnescapeW() with URL_UNESCAPE_AS_UTF8 in is_gecko_path(). shlwapi/tests: Test UrlUnescapeW() with URL_UNESCAPE_AS_UTF8. https://gitlab.winehq.org/wine/wine/-/merge_requests/585

3 6