September 2023 - Wine-GitLab

[PATCH 0/1] MR3714: cmd: Handle `if exist` with an empty string argument.
by Alex Henrie (＠alexhenrie) Sept. 3, 2023

Sept. 3, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55505 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3714

2 1

[PATCH 0/1] MR3713: uiautomationcore: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Sept. 2, 2023

Sept. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3713

2 1

[PATCH 0/1] MR3712: snmpapi: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Sept. 2, 2023

Sept. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3712

2 1

[PATCH 0/1] MR3711: shlwapi: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Sept. 2, 2023

Sept. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3711

2 1

[PATCH 0/1] MR3710: shcore: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Sept. 2, 2023

Sept. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3710

2 1

[PATCH 0/1] MR3709: msctf: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Sept. 2, 2023

Sept. 2, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3709

2 1

[PATCH v2 0/1] MR3706: loader: Fix address move for TLS initialization in Linux x86-64 preloader.
by Jinoh Kang (＠iamahuman) Sept. 2, 2023

Sept. 2, 2023

Fixes: ac1761d1dae8bf114a05e28ed6886deba6c2c860 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55508 -- v2: loader: Fix calculation of thread_data address in Linux x86-64 preloader. https://gitlab.winehq.org/wine/wine/-/merge_requests/3706

2 1

[PATCH v2 0/1] MR3708: loader: Don't return from __stack_chk_fail() stub (which GCC expects to be noreturn) in preloader.
by Jinoh Kang (＠iamahuman) Sept. 2, 2023

Sept. 2, 2023

GCC expects __stack_chk_fail() to be noreturn[^1]. Returning from __stack_chk_fail() can thus lead to subtle failures. When crashing, use a volatile NULL pointer dereference. Ideally we would like to "abort()" here, but doing so would require two more syscall definitions just for a cold function. After all, the function isn't even used at all if -fno-stack-protector is specified. Also, don't say "stack smashing" (unlike glibc). The preloader currently initializes the stack canary value to a fixed value (0), which serves little value in protecting against actual buffer overrun attacks. [^1]: https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gccint/Stack-Smashing-Protection.h… -- v2: loader: Don't return from __stack_chk_fail() stub in preloader. https://gitlab.winehq.org/wine/wine/-/merge_requests/3708

2 1

[PATCH 0/1] MR3708: loader: Don't return from __stack_chk_fail() stub (which GCC expects to be noreturn) in preloader.
by Jinoh Kang (＠iamahuman) Sept. 2, 2023

Sept. 2, 2023

GCC expects __stack_chk_fail() to be noreturn[^1]. Returning from __stack_chk_fail() can thus lead to subtle failures. When crashing, use a volatile NULL pointer dereference. Ideally we would like to "abort()" here, but doing so would require two more syscall definitions just for a cold function. After all, the function isn't even used at all if -fno-stack-protector is specified. Also, don't say "stack smashing" (unlike glibc). The preloader currently initializes the stack canary value to a fixed value (0), which serves little value in protecting against actual buffer overrun attacks. [^1]: https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gccint/Stack-Smashing-Protection.h… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3708

2 1

[PATCH 0/1] MR3706: loader: Fix address move for TLS initialization in Linux x86-64 preloader.
by Jinoh Kang (＠iamahuman) Sept. 2, 2023

Sept. 2, 2023

Fixes: ac1761d1dae8bf114a05e28ed6886deba6c2c860 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55508 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3706

2 1