September 2023 - Wine-GitLab

Re: [PATCH 0/2] MR356: Release 1.9.
by Henri Verbeet (＠hverbeet) Sept. 20, 2023

Sept. 20, 2023

Holding this for a bit for some last-minute changes from Zeb. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/356#note_46056

1 0

Re: [PATCH 0/5] MR3910: uiautomationcore: More MSAA proxy provider patches. - approved
by Esme Povirk (＠madewokherd) Sept. 20, 2023

Sept. 20, 2023

This merge request was approved by Esme Povirk. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3910

1 0

Re: [PATCH v19 0/16] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) Sept. 20, 2023

Sept. 20, 2023

On Tue Sep 19 18:27:47 2023 +0000, Aidan Khoury wrote: > This is needed in case the `-Wunused-variable` is used with clang > compiler frontend. The Windows Patch API passes this variable - see https://learn.microsoft.com/en-us/previous-versions/bb417345(v=msdn.10)#nor…. > Though it is unused, I would like to keep it to maintain compatibility > with the Windows API. I assume you mean -Wunused-parameter, since -Wunused-variable alone shouldn't warn on parameters. I don't think -Wunused-parameter is reasonable to enable for Wine. The Windows API has far, far too many unused parameters for annotating them all to be worthwhile. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_46053

1 0

Re: [PATCH 0/2] MR3906: dmusic: Keep original instrument patch around. - approved
by Michael Stefaniuc (＠mstefani) Sept. 20, 2023

Sept. 20, 2023

This merge request was approved by Michael Stefaniuc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3906

1 0

Re: [PATCH 0/2] MR3906: dmusic: Keep original instrument patch around.
by Michael Stefaniuc (＠mstefani) Sept. 20, 2023

Sept. 20, 2023

Unrelated test failure in user32/msg.c -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3906#note_46051

1 0

Re: [PATCH 0/4] MR3905: dmime/tests: Test DMUS_PMSG with band and sequence tracks. - approved
by Michael Stefaniuc (＠mstefani) Sept. 20, 2023

Sept. 20, 2023

This merge request was approved by Michael Stefaniuc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3905

1 0

[PATCH 0/1] MR3912: msvcp90: Silence FIXME in _Locinfo::_Locinfo_ctor and _Locinfo::_Locinfo_Addcats functions.
by Piotr Caban (＠piotr) Sept. 20, 2023

Sept. 20, 2023

So far there were no bugs caused by the functions. It's also not clear if there's anything to improve. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3912

2 1

Re: [PATCH 0/5] MR3911: mshtml: Use more dispex vtbl methods instead of the nodes'. - approved
by Jacek Caban (＠jacek) Sept. 20, 2023

Sept. 20, 2023

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3911

1 0

Re: [PATCH v6 0/6] MR3548: windows.applicationmodel: Implement some functions.
by Rémi Bernon Sept. 20, 2023

Sept. 20, 2023

Rémi Bernon (@rbernon) commented about dlls/windows.applicationmodel/tests/model.c: > if (SUCCEEDED(test_register_package( manager, &package ))) > { > test_execute_package( package ); > + test_PackageStatics(); This won't work like that. At this point the test has indeed installed a package (and executed its application), but this code still executes in the context of the normal test executable. You should add the tests in `application.c` if you want to the behavior from within an packaged application. For instance you could have a `test_PackageStatics` there too, which would expect the current package to be always valid. Of course, we don't support running this on Wine yet, because we don't support running packaged applications, so the tests are entirely skipped. But at least it will show us native's behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3548#note_46048

1 0

Re: [PATCH v2 0/1] MR3818: Draft: urlmon: test http with auto redirect disabled, and CreateBinding
by Yuxuan Shui (＠yshui) Sept. 19, 2023

Sept. 19, 2023

On Tue Sep 19 20:06:50 2023 +0000, Yuxuan Shui wrote: > it fails on Windows because I didn't bother to remove that particular > `CHECK_CALLED`. the reason it fails is because Windows' http protocol > _does not_ handle redirect. > And we are trying to figure out how the native urlmon is different, in > that case isn't this kind of test failures _helpful_? And this MR is a > draft, I wasn't expect it to be merged in this form anyway. > I'll reopen this. In addition calling the test "not interesting" because it fails that particular test makes no sense to me. I feel you are being overly dismissive, and I don't know why. Did I do something wrong to upset you? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3818#note_45927

1 0