September 2023 - Wine-GitLab

Re: [PATCH 0/2] MR3906: dmusic: Keep original instrument patch around. - approved
by Michael Stefaniuc (＠mstefani) Sept. 20, 2023

Sept. 20, 2023

This merge request was approved by Michael Stefaniuc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3906

1 0

Re: [PATCH 0/2] MR3906: dmusic: Keep original instrument patch around.
by Michael Stefaniuc (＠mstefani) Sept. 20, 2023

Sept. 20, 2023

Unrelated test failure in user32/msg.c -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3906#note_46051

1 0

Re: [PATCH 0/4] MR3905: dmime/tests: Test DMUS_PMSG with band and sequence tracks. - approved
by Michael Stefaniuc (＠mstefani) Sept. 20, 2023

Sept. 20, 2023

This merge request was approved by Michael Stefaniuc. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3905

1 0

[PATCH 0/1] MR3912: msvcp90: Silence FIXME in _Locinfo::_Locinfo_ctor and _Locinfo::_Locinfo_Addcats functions.
by Piotr Caban (＠piotr) Sept. 20, 2023

Sept. 20, 2023

So far there were no bugs caused by the functions. It's also not clear if there's anything to improve. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3912

2 1

Re: [PATCH 0/5] MR3911: mshtml: Use more dispex vtbl methods instead of the nodes'. - approved
by Jacek Caban (＠jacek) Sept. 20, 2023

Sept. 20, 2023

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3911

1 0

Re: [PATCH v6 0/6] MR3548: windows.applicationmodel: Implement some functions.
by Rémi Bernon Sept. 20, 2023

Sept. 20, 2023

Rémi Bernon (@rbernon) commented about dlls/windows.applicationmodel/tests/model.c: > if (SUCCEEDED(test_register_package( manager, &package ))) > { > test_execute_package( package ); > + test_PackageStatics(); This won't work like that. At this point the test has indeed installed a package (and executed its application), but this code still executes in the context of the normal test executable. You should add the tests in `application.c` if you want to the behavior from within an packaged application. For instance you could have a `test_PackageStatics` there too, which would expect the current package to be always valid. Of course, we don't support running this on Wine yet, because we don't support running packaged applications, so the tests are entirely skipped. But at least it will show us native's behavior. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3548#note_46048

1 0

Re: [PATCH v2 0/1] MR3818: Draft: urlmon: test http with auto redirect disabled, and CreateBinding
by Yuxuan Shui (＠yshui) Sept. 19, 2023

Sept. 19, 2023

On Tue Sep 19 20:06:50 2023 +0000, Yuxuan Shui wrote: > it fails on Windows because I didn't bother to remove that particular > `CHECK_CALLED`. the reason it fails is because Windows' http protocol > _does not_ handle redirect. > And we are trying to figure out how the native urlmon is different, in > that case isn't this kind of test failures _helpful_? And this MR is a > draft, I wasn't expect it to be merged in this form anyway. > I'll reopen this. In addition calling the test "not interesting" because it fails that particular test makes no sense to me. I feel you are being overly dismissive, and I don't know why. Did I do something wrong to upset you? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3818#note_45927

1 0

Re: [PATCH v2 0/1] MR3818: Draft: urlmon: test http with auto redirect disabled, and CreateBinding
by Yuxuan Shui (＠yshui) Sept. 19, 2023

Sept. 19, 2023

On Tue Sep 19 19:01:40 2023 +0000, Jacek Caban wrote: > First of all, your test fails on Windows, so it's not interesting in > current form. I will add more comments in !3725. it fails on Windows because I didn't bother to remove that particular `CHECK_CALLED`. the reason it fails is because Windows' http protocol _does not_ handle redirect. And we are trying to figure out how the native urlmon is different, in that case isn't this kind of test failures _helpful_? And this MR is a draft, I wasn't expect it to be merged in this form anyway. I'll reopen this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3818#note_45926

1 0

[PATCH v10 0/9] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) Sept. 19, 2023

Sept. 19, 2023

This clears up much of the todo list for mspatcha. GetFilePatchSignature* and NormalizeFileForPatchSignature have now been implemented in these changes. These changes bring better support for things like the Adobe Acrobat installer without the need for things like the winetricks mspatcha.dll native dll override. Still needed is support for interleaved streams in the LZXD decompression logic, however this is a great start to better supporting software installers that use the Windows interface for creating and applying patches to files. This is the beginning of the fixes required for bug 12501: https://bugs.winehq.org/show_bug.cgi?id=12501 -- v10: mspatcha: Fix new file buffer local variable assignment https://gitlab.winehq.org/wine/wine/-/merge_requests/3870

3 15

[PATCH v5 0/2] MR3725: urlmon: fix HTTP redirects when auto redirection is disabled
by Yuxuan Shui (＠yshui) Sept. 19, 2023

Sept. 19, 2023

If DISABLEAUTOREDIRECTS is set in BINDINFO options, urlmon does not set HTTP verb to GET when handling redirections. Although HTTP specification is vague on the correct behaviour here, many web servers expect this. This is what's causing the "400 Bad Request" error when user tries to log into GMail accounts using Outlook. -- v5: urlmon: test redirection of POST requests urlmon: fix HTTP redirects when auto redirection is disabled https://gitlab.winehq.org/wine/wine/-/merge_requests/3725

3 3