January 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR4784: dlls/gdiplus: Clean up GdipCloneImageAttributes
by David Kahurani (＠kahurani) Jan. 5, 2024

Jan. 5, 2024

Not sure this is an improvement but it does look like one to me. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4784

3 7

[PATCH v7 0/3] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) Jan. 5, 2024

Jan. 5, 2024

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are parallel discussions on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something for these yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- v7: tests: Use the vulkan runner to run SM1 compilation tests. tests/shader-runner: Call each runner only once. tests/shader-runner: Support reading multiple model range args for qualifiers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

4 12

[PATCH v5 0/2] MR4748: Don't test function directly when reporting GetLastError()
by André Zwing Jan. 5, 2024

Jan. 5, 2024

-- v5: ntoskrnl/tests: Use RtlNtStatusToDosErrorNoTeb() for stateless conversion mscoree/tests: Don't test function directly when reporting GetLastError() https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

2 3

[PATCH v6 0/2] MR4774: msvcrt: Compare environmental variable names case insensitively
by Zsolt Vadász Jan. 5, 2024

Jan. 5, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56134 -- v6: msvcrt/tests: Test case insensitivity of getenv() and _wgetenv() msvcrt: Compare environmental variable names case insensitively https://gitlab.winehq.org/wine/wine/-/merge_requests/4774

3 5

[PATCH v2 0/1] MR536: vkd3d-shader/ir: Revert "Do not merge signature elements which have different interpolation modes."
by Conor McCarthy (＠cmccarthy) Jan. 5, 2024

Jan. 5, 2024

-- v2: vkd3d-shader/ir: Revert "Do not merge signature elements which have different interpolation modes." https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/536

4 5

Re: [PATCH v4 0/5] MR464: vkd3d-shader/spirv: Declare I/O registers from the signature.
by Giovanni Mascellani (＠giomasce) Jan. 5, 2024

Jan. 5, 2024

I discovered a similar instance in `test_shader_eval_attribute()`: ``` VUID-RuntimeSpirv-OpTypeVector-06816(ERROR / SPEC): msgNum: 79036675 - Validation Error: [ VUID-RuntimeSpirv-OpTypeVector-06816 ] Object 0: handle = 0x240000000024, type = VK_OBJECT_TYPE_SHADER_MODULE; Object 1: handle = 0x250000000025, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x4b60103 | vkCreateGraphicsPipelines(): pCreateInfos[0] starting at Location 1 Component 0 the Output (VK_SHADER_STAGE_VERTEX_BIT) has a Vec4 while Input (VK_SHADER_STAGE_FRAGMENT_BIT) as a Vec2. Enable VK_KHR_maintenance4 device extension to allow relaxed interface matching between input and output vectors. The Vulkan spec states: Any OpTypeVector output interface variables must not have a higher Component Count than a matching OpTypeVector input interface variable (https://www.khronos.org/registry/vulkan/specs/1.2/html/vkspec.html#VUID-Run…) ``` Here again two different semantics are merged in the VS but not in the PS, which trigger a similar error. And again this seems to cause a failure in MoltenVK. The difference is that this doesn't seem to be related to 66cb2815f0662713c3255113255cfd7cf5e406fb, it also happened before. But maybe it's useful to know anyway. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/464#note_56768

1 0

[PATCH v9 0/4] MR519: vkd3d-shader/dxil: Support minimum precision.
by Conor McCarthy (＠cmccarthy) Jan. 5, 2024

Jan. 5, 2024

-- v9: vkd3d-shader/dxil: Support 16-bit types. vkd3d-shader/spirv: Introduce HALF and UINT16 types for minimum precision. vkd3d-shader/spirv: Introduce a data_type_is_floating_point() helper function. tests/shader-runner: Add tests for minimum-precision constants. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519

2 4

[PATCH v5 0/1] MR523: vkd3d: Use mutable descriptors if available.
by Conor McCarthy (＠cmccarthy) Jan. 5, 2024

Jan. 5, 2024

-- v5: vkd3d: Use mutable descriptors if available. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/523

2 1

[PATCH v2 0/5] MR533: vkd3d-shader/dxil: SRV/UAV support part 1.
by Conor McCarthy (＠cmccarthy) Jan. 5, 2024

Jan. 5, 2024

-- v2: vkd3d-shader/dxil: Implement DX intrinsic BufferLoad for typed buffers. vkd3d-shader/dxil: Load typed UAV descriptors. vkd3d-shader/dxil: Load typed SRV descriptors. vkd3d-shader/spirv: Do not assert VKD3D_DATA_UINT in spirv_compiler_emit_ld_raw_structured_srv_uav(). vkd3d-shader/dxil: Pass the code block and instruction in a struct to intrinsic handlers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/533

2 5

[PATCH v15 0/2] MR4372: kernel32: impl sync barrier
by quininer (＠quininer) Jan. 5, 2024

Jan. 5, 2024

This is my first time contributing wine and there are a lot of things I'm not sure about, so any comments are welcome. :) -- v15: kernel32: add sync barrier test kernel32: impl sync barrier https://gitlab.winehq.org/wine/wine/-/merge_requests/4372

3 5

[PATCH 0/4] MR4782: include: Add some missing symbols in d3d12video.idl
by Biswapriyo Nath (＠Biswa96) Jan. 5, 2024

Jan. 5, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4782

3 5

[PATCH v5 0/5] MR463: hlsl: Fix some type handling for ternaries.
by Zebediah Figura (＠zfigura) Jan. 5, 2024

Jan. 5, 2024

-- v5: vkd3d-shader/hlsl: Allow non-numeric types in the ternary operator. vkd3d-shader/hlsl: Separate an add_ternary() helper. tests: Add many more tests for ternary expressions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/463

3 7

[PATCH 0/1] MR4786: win32u: Query virtual desktop status from the registry.
by Zhiyi Zhang (＠zhiyi) Jan. 5, 2024

Jan. 5, 2024

Checking flags of the thread desktop to determine whether virtual desktop is on is unreliable. For example, CEF applications create their own desktop and so is_virtual_desktop() could incorrectly report that virtual desktop is off. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55810 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4786

5 8

Re: [PATCH v2 0/1] MR4780: wined3d: Set fixed_function_usage_map to 0 for an sm4 draw without a PS. - approved
by Jan Sikorski (＠jsikorski) Jan. 5, 2024

Jan. 5, 2024

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4780

1 0

[PATCH v19 0/7] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) Jan. 5, 2024

Jan. 5, 2024

-- v19: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten SWITCH/CASE/DEFAULT/ENDSWITCH control flow instructions. vkd3d-shader/ir: Flatten LOOP/BREAK/CONTINUE/ENDLOOP control flow instructions. vkd3d-shader/ir: Flatten IF/ELSE/ENDIF control flow instructions. vkd3d-shader/spirv: Handle RETP in spirv_compiler_handle_instruction(). vkd3d-shader/spirv: Handle DISCARD and TEXKILL in spirv_compiler_handle_instruction(). vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

2 7

Re: [PATCH v4 0/5] MR464: vkd3d-shader/spirv: Declare I/O registers from the signature.
by Zebediah Figura (＠zfigura) Jan. 4, 2024

Jan. 4, 2024

> the PS consumes the COLOR1 but not the COLOR2. Er, correction, it consumes the COLOR2 but not the COLOR1. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/464#note_56737

1 0

Re: [PATCH v4 0/5] MR464: vkd3d-shader/spirv: Declare I/O registers from the signature.
by Zebediah Figura (＠zfigura) Jan. 4, 2024

Jan. 4, 2024

The pipeline in question has a float3 and a float which are COLOR1 and COLOR2 respectively, and they get packed into the same registers. The VS merges the two together, but the PS doesn't. I'm not sure why, but it may have something to do with the fact that the PS consumes the COLOR1 but not the COLOR2. Conor, do you have an immediate idea here? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/464#note_56736

1 0

[PATCH v18 0/7] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) Jan. 4, 2024

Jan. 4, 2024

-- v18: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten SWITCH/CASE/DEFAULT/ENDSWITCH control flow instructions. vkd3d-shader/ir: Flatten LOOP/BREAK/CONTINUE/ENDLOOP control flow instructions. vkd3d-shader/ir: Flatten IF/ELSE/ENDIF control flow instructions. vkd3d-shader/spirv: Handle RETP in spirv_compiler_handle_instruction(). vkd3d-shader/spirv: Handle DISCARD and TEXKILL in spirv_compiler_handle_instruction(). vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

4 11

Re: [PATCH v2 0/1] MR4785: windows.media.speech/tests: Remove obsolete workarounds. - approved
by Alexandre Julliard (＠julliard) Jan. 4, 2024

Jan. 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4785

1 0

Re: [PATCH v3 0/1] MR4757: wined3d: Do not remove invalid BO users from the list when destroying views. - approved
by Alexandre Julliard (＠julliard) Jan. 4, 2024

Jan. 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4757

1 0

Re: [PATCH v2 0/2] MR4783: dmime, dmloader: Avoid leaking track and segment references. - approved
by Alexandre Julliard (＠julliard) Jan. 4, 2024

Jan. 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4783

1 0

Re: [PATCH v3 0/1] MR4756: wined3d: Reference FFP resources in reference_shader_resources(). - approved
by Alexandre Julliard (＠julliard) Jan. 4, 2024

Jan. 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4756

1 0

Re: [PATCH v3 0/1] MR4776: winedbg: Wait for gdb to terminate before exiting (proxy mode). - approved
by Alexandre Julliard (＠julliard) Jan. 4, 2024

Jan. 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4776

1 0

Re: [PATCH v2 0/3] MR540: vkd3d: Recognise some more flags in debug_vk_queue_flags(). - approved
by Alexandre Julliard (＠julliard) Jan. 4, 2024

Jan. 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/540

1 0

Re: [PATCH v2 0/4] MR539: vkd3d-shader/ir: Avoid DWORDs. - approved
by Alexandre Julliard (＠julliard) Jan. 4, 2024

Jan. 4, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/539

1 0