January 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/4] MR4613: Stg handles' flags when inheriting.
by eric pouech (＠epo) Feb. 5, 2024

Feb. 5, 2024

This series' main purpose is to fix the handles' attributes of standard I/O handles in CreateProcess. Needed behavior in CreateProcess is implemented by supporting the DUPLICATE_SAME_ATTRIBUTES option in NtDuplicateObject() and DuplicateHandle(). This option is not documented in SDK, but is in DDK. Manifest constant has been added to DDK header (maybe now Wine's DUPLICATE_MAKE_GLOBAL could be moved here to). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4613

3 8

[PATCH 0/2] MR4967: winsock: Stop racings send forcing async results and reporting socket as not write ready in select().
by Paul Gofman (＠gofman) Feb. 5, 2024

Feb. 5, 2024

When two sends are performed in parallel on a socket the send which came second to server's (socked_send) will always considered blocking if the first send hasn't performed set_async_direct_result() in client's ntdll yet. Similarly, if select() is coming shortly after send() it may report socket as not write ready. We don't care for avoiding a race here because if those two sends or send / select are not synced by app it is unlikely possible for an app to depend on which gets processed first, and the one which was called earlier in wall time now also is not guaranteed to be actually processed first. The patches fix Tekken 8 which gets frequently disconnected from multiplayer matches. The game treats WSAEWOULDBLOCK from send() on its non-blocking UDP socket, as well as the same socket not reported as write ready from select as a disconnection condition. Those conditions normally (outside of actual network problem / contention) only happen due to the races described above (while the game performs send() concurrently from different threads or is racing send with select). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4967

5 9

[PATCH v2 0/7] MR4986: mshtml: MessageEvent improvements and misc.
by Gabriel Ivăncescu Feb. 5, 2024

Feb. 5, 2024

-- v2: mshtml/tests: Test builtin function default value getter with custom mshtml: Expose the IHTMLEventObj5 props to scripts. mshtml: Implement `initMessageEvent` for MessageEvents. mshtml: Implement `origin` prop for MessageEvents. mshtml: Implement `data` getter for MessageEvent objs. mshtml: Implement `source` prop for MessageEvents. mshtml: Use a hook to implement postMessage. https://gitlab.winehq.org/wine/wine/-/merge_requests/4986

2 16

[PATCH 0/6] MR4518: ntdll: Integrate with GDB using systemtap rtld probes.
by Rémi Bernon Feb. 3, 2024

Feb. 3, 2024

Effectively implementing the debugger interface as described in https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/rtld-debugger-interfac… This is an actual attempt at having this upstream, split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074 which people have been finding useful for debugging Wine directly in GDB. This supports everything you would expect, from automatic symbol loading as well as cross-syscall backtraces with the new Python unwinder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4518

2 10

[PATCH 0/7] MR4977: winegstreamer: Allow wg_transform size changes with an explicit attribute.
by Rémi Bernon Feb. 2, 2024

Feb. 2, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4977

2 14

[PATCH 0/3] MR4956: wined3d: Two fixes for SPECULARENABLE.
by Zebediah Figura (＠zfigura) Feb. 2, 2024

Feb. 2, 2024

Found while refactoring FFP code; no known application is affected. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4956

4 6

[PATCH 0/3] MR4955: wined3d: A bit of refactoring around state.c.
by Zebediah Figura (＠zfigura) Feb. 2, 2024

Feb. 2, 2024

I think this is an improvement, but I don't feel too strongly about it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4955

5 7

[PATCH 0/1] MR2902: winex11.drv: Expose GWL_STYLE and GWL_EXSTYLE as X11 properties.
by Joshua Ashton (＠joshua) Feb. 2, 2024

Feb. 2, 2024

As _WINE_HWND_STYLE and _WINE_HWND_EXSTYLE respectively. Gamescope parses these to make smarter decisions about what window to primary focus, or to treat as a dropdown/overlay. This was originally a Proton commit by Remi Bernon, however, it would definitely be nice to have support for Gamescope focusing correctly under upstream Wine as well. Fixes a bunch of games/launchers run with Wine under Gamescope. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2902

6 12

[PATCH v5 0/4] MR4857: Draft: gdi32,win32u: Implement D3DKMTEnumAdapters2.
by Krzysztof Bogacki (＠Saancreed) Feb. 2, 2024

Feb. 2, 2024

An alternative approach to `EnumAdapters2` that does not directly call to GDI driver and therefore does not require GDI driver functions to be expanded. The implementation now lives in `sysparams.c` to make it closer to win32u caches it accesses. It still uses `OpenAdapterFromLuid` internally because that's where adapter handles are actually assigned and to make sure returned handles are usable with other functions that rely on GDI driver being aware of what the handle represents to be able to function correctly (like `QueryVideoMemoryInfo`). See !4791 for some background and why this version might be preferable over the one submitted there. -- v5: win32u: Implement NtGdiDdDDIEnumAdapters2. win32u: Maintain a list of GPUs in cache. gdi32,win32u: Add stubs for D3DKMTEnumAdapters2 and NtGdiDdDDIEnumAdapters2. gdi32/tests: Add D3DKMTEnumAdapters2 tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/4857

3 11

[PATCH 0/5] MR4981: Playback of wave tracks with loops.
by eric pouech (＠epo) Feb. 1, 2024

Feb. 1, 2024

This serie mainly tackles the playback of wave tracks with loops. Current code had to be improved as: - loop playback doesn't require setting the loop start/end points: leaving them at 0 mean playing the whole segment, - moreover, the length (at least for wave tracks) of the segment is not used. Instead, the duration of stamped/posted tracks is used instead. - even forcing a length on segment isn't taken into account (tested locally, but not included in the current tests). - implemented it by creating the graph internal to segment state and gathering relevant information on the fly. There's no indication it's done this exact way on native, but at least tests for time of track playback are identical. Notes: - only changed the track waves, future work will require equivalent testings at least on MIDI sequences. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4981

3 6

[PATCH v3 0/2] MR4985: windows.globalization: Add IIterable_HSTRING impl to IVectorView_HSTRING.
by Helix Graziani (＠TornadoCookie) Feb. 1, 2024

Feb. 1, 2024

Fixes https://bugs.winehq.org/show_bug.cgi?id=55167. -- v3: windows.globalization: Add IIterable_HSTRING impl from windows.media to IVectorView_HSTRING. https://gitlab.winehq.org/wine/wine/-/merge_requests/4985

3 3

[PATCH v11 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Rastislav Stanik (＠rastos) Feb. 1, 2024

Feb. 1, 2024

for details see https://bugs.winehq.org/show_bug.cgi?id=56065 This change adds an implementation of Win32 API function GetAnycastIpAddressTable() that is used by Adoptium OpenJDK 21 and later to initialize Secure Random Generator. This implementation does not return real information, it just says "no entries found". -- v11: iphlpapi: Add stub for GetAnycastIpAddressTable(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4940

2 2

[PATCH v2 0/4] MR616: tests: Improvements for SM1 testing.
by Francisco Casas (＠fcasas) Feb. 1, 2024

Feb. 1, 2024

This is the first part of !608, which I decided to separate to ease review. It consists of improvements to SM1 testing, mainly: - Correctly passing int and bool uniforms as IEEE 754 floats to SM1 profiles. - The introduction of the "only" qualifier to avoid abusing `[require]` blocks in case tests retrieve different results for different shader models. - Allowing some of the tests we already have for SM4/SM6 to run in SM1 after those improvements. -- v2: tests: Remove [require] directives for tests that use int and bool uniforms. tests/shader-runner: Introduce "if" qualifier. tests: Don't ignore SM1 on a non-const-indexing.shader_test test. tests/vkd3d-shader: Set uninitialized uniforms to zero. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/616

3 9

[PATCH v4 0/6] MR607: vkd3d-shader/ir: Introduce a simple CFG structurizer.
by Giovanni Mascellani (＠giomasce) Feb. 1, 2024

Feb. 1, 2024

This goes atop !598 and !603. -- v4: vkd3d-shader/ir: Introduce a simple control flow graph structurizer. vkd3d-shader/ir: Handle PHI nodes when materializing SSA registers. vkd3d-shader/ir: Materialize SSA registers to temporaries. vkd3d-shader/spirv: Support bool TEMP registers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/607

3 8

[PATCH v2 0/1] MR621: vkd3d: Use uint64_t for the size in vkd3d_gpu_va_allocator_allocate.
by Jacek Caban (＠jacek) Feb. 1, 2024

Feb. 1, 2024

Avoids value truncation in 32-bit builds and fixes clang warning: ``` ../libs/vkd3d/libs/vkd3d/device.c:2157:14: warning: result of comparison of constant 4294967296 with expression of type 'size_t' (aka 'unsigned int') is always true [-Wtautological-constant-out-of-range-compare] if (size <= VKD3D_VA_SLAB_SIZE && allocator->free_slab) ~~~~ ^ ~~~~~~~~~~~~~~~~~~ ``` -- v2: vkd3d: Use uint64_t for the size in vkd3d_gpu_va_allocator_allocate. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/621

3 2

Re: [PATCH v2 0/1] MR620: vkd3d: Use debugstr_hresult() in d3d12_device_mark_as_removed(). - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/620

1 0

Re: [PATCH v2 0/12] MR619: vkd3d: Avoid (U)LONGs in resource.c. - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/619

1 0

Re: [PATCH v3 0/3] MR615: vkd3d-shader: Fix a couple of memory leaks. - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/615

1 0

Re: [PATCH v2 0/2] MR614: vkd3d-shader/ir: Pass a struct vsir_program to shader_parser_get_src_params() and shader_parser_get_dst_params(). - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/614

1 0

Re: [PATCH v2 0/1] MR613: vkd3d-shader: Use vkd3d_atomic_increment_u32() in vkd3d_shader_dump_blob(). - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/613

1 0

Re: [PATCH v2 0/1] MR4980: win32u: Only queue a single IME update during ImeProcessKey. - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4980

1 0

Re: [PATCH v2 0/2] MR4979: imm32/tests: Fix some spurious failures with Windows ko_KR IME. - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4979

1 0

[PATCH v4 0/6] MR4906: mf,mfplat: Clang warning fixes.
by Jacek Caban (＠jacek) Jan. 31, 2024

Jan. 31, 2024

-- v4: mfmediaengine: Avoid implicit casts in IMFAttributes_GetUINT32 calls. mfmediaengine/tests: Use MF_MEDIA_ENGINE_CANPLAY type in IMFMediaEngine_CanPlayType call. mfplat: Introduce media_type_get_uint32 helper. mfplat/tests: Use MF_ATTRIBUTE_TYPE type in IMFMediaType_GetItemType call. mfplat: Avoid implicit cast in IMFAttributes_GetUINT32 call. mf: Avoid implicit enum to int pointer casts. https://gitlab.winehq.org/wine/wine/-/merge_requests/4906

3 7

Re: [PATCH v2 0/2] MR4970: advapi32/tests: Add some more EventLog tests. - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4970

1 0

Re: [PATCH v3 0/5] MR4978: vulkan-1/tests: Fix tests and add more with windows in various states. - approved
by Alexandre Julliard (＠julliard) Jan. 31, 2024

Jan. 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4978

1 0