January 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR4972: mfplat/tests: Skip tests that require d3d9 support.
by Nikolay Sivov (＠nsivov) Jan. 30, 2024

Jan. 30, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4972

2 1

[PATCH 0/5] MR4971: comdlg32: Fix item data in resolutions combobox.
by Brendan McGrath (＠redmcg) Jan. 30, 2024

Jan. 30, 2024

This MR fixes a few issues in the printdlg and adds the printer name to stc1. This fixes some of the issues in the Quicken Print Dialog from the tax summary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4971

2 5

Re: [PATCH v9 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Huw Davies (＠huw) Jan. 30, 2024

Jan. 30, 2024

Huw Davies (@huw) commented about dlls/iphlpapi/iphlpapi_main.c: > row->CreationTimeStamp.QuadPart = stat->creation_time; > } > > +DWORD WINAPI GetAnycastIpAddressTable(ADDRESS_FAMILY family, MIB_ANYCASTIPADDRESS_TABLE **table) > +{ > + FIXME( "(%u, %p) stub\n", family, table ); > + if (!table || (family != AF_INET && family != AF_INET6 && family != AF_UNSPEC)) > + return ERROR_INVALID_PARAMETER; > + There are some trailing spaces on this line - please remove (but leave the blank line). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4940#note_59471

1 0

Re: [PATCH v9 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Huw Davies (＠huw) Jan. 30, 2024

Jan. 30, 2024

Huw Davies (@huw) commented about include/netioapi.h: > LARGE_INTEGER CreationTimeStamp; > } MIB_UNICASTIPADDRESS_ROW, *PMIB_UNICASTIPADDRESS_ROW; > > +typedef struct _MIB_ANYCASTIPADDRESS_ROW { Please move the opening brace to the next line. Additionally, let's move this below the unicast table definition below. Further, please add the function prototype (with the others, near the end). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4940#note_59470

1 0

Re: [PATCH v9 0/1] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Huw Davies (＠huw) Jan. 30, 2024

Jan. 30, 2024

Huw Davies (@huw) commented about dlls/iphlpapi/iphlpapi_main.c: > row->CreationTimeStamp.QuadPart = stat->creation_time; > } > > +DWORD WINAPI GetAnycastIpAddressTable(ADDRESS_FAMILY family, MIB_ANYCASTIPADDRESS_TABLE **table) Could you move this so that it doesn't split the Unicast implementation, perhaps below `GetUnicastIpAddressTable()`? Also, please capitalize the first leteter of 'add' in the commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4940#note_59469

1 0

[PATCH 0/2] MR4970: advapi32/tests: Add some more EventLog tests.
by Daniel Lehman (＠dlehman25) Jan. 30, 2024

Jan. 30, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4970

3 3

[PATCH 0/3] MR4969: glu32: Return GL_OUT_OF_MEMORY from gluScaleImage if no context.
by Daniel Lehman (＠dlehman25) Jan. 30, 2024

Jan. 30, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4969

2 3

[PATCH 0/5] MR611: Draft: vkd3d-shader/dxil: Implement DX intrinsic TextureStore.
by Conor McCarthy (＠cmccarthy) Jan. 30, 2024

Jan. 30, 2024

Goes atop !601. The last three commits belong to this MR. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/611

2 5

[PATCH v7 0/4] MR306: vkd3d-shader: Fix UAV coherence.
by Conor McCarthy (＠cmccarthy) Jan. 30, 2024

Jan. 30, 2024

-- v7: vkd3d-shader/spirv: Handle thread group UAV barriers. vkd3d-shader/spirv: Include Uniform in the memory semantics for UAV barriers. vkd3d-shader/spirv: Handle globally coherent UAVs. vkd3d-shader: Introduce a UAV_GLOBALLY_COHERENT descriptor info flag. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/306

2 5

[PATCH 0/8] MR4954: kernelbase: Reimplement UrlCanonicalize().
by Zebediah Figura (＠zfigura) Jan. 30, 2024

Jan. 30, 2024

Normally I am a strong proponent of adjusting implementations one small step at a time, but this is a bit of an extreme case. The current state of UrlCanonicalize() is a prototypical example of "spaghetti code": the implementation has been repeatedly adjusted to fix a new discovered edge case, without properly testing the scope of the new logic, with the effect that the current logic is a scattered mess of conditions that interact in unpredictable ways. To be fair, the actual function is much more complicated than one would anticipate, and the number of new weird edge cases I found while trying to flesh out existing logic was rather exhausting. I initially tried to "fix" the existing implementation one step at a time. After racking up dozens of commits without an end in sight, though, and having to waste time carefully unravelling the broken code in the right order so as to avoid temporary failures, I decided instead to just fix everything at once, effectively rewriting the function from scratch, and this proved to be much more productive. Hopefully the huge swath of new tests is enough to prove that this new implementation really is correct, and has no more spaghetti than what Microsoft made necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4954

3 10