January 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v15 0/2] MR4822: ntdll: Fix: Use pagesize alignment if MEM_REPLACE_PLACEHOLDER is set in flags of NtMapViewOfSection(Ex)
by Alexandre Julliard (＠julliard) Jan. 29, 2024

Jan. 29, 2024

Alexandre Julliard (@julliard) commented about dlls/kernelbase/tests/process.c: > static LPVOID (WINAPI *pVirtualAlloc2)(HANDLE, void *, SIZE_T, DWORD, DWORD, MEM_EXTENDED_PARAMETER *, ULONG); > static LPVOID (WINAPI *pVirtualAlloc2FromApp)(HANDLE, void *, SIZE_T, DWORD, DWORD, MEM_EXTENDED_PARAMETER *, ULONG); > static PVOID (WINAPI *pVirtualAllocFromApp)(PVOID, SIZE_T, DWORD, DWORD); > +static BOOL (WINAPI *pVirtualFree)(LPVOID,SIZE_T,DWORD); This is not necessary. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4822#note_59330

1 0

[PATCH v2 0/1] MR4873: ntdll: Add comment regarding nt_path passed to server for built-in dlls
by Fabian Maurer (＠DarkShadow44) Jan. 29, 2024

Jan. 29, 2024

-- v2: ntdll: Add comment regarding nt_path passed to server for built-in dlls https://gitlab.winehq.org/wine/wine/-/merge_requests/4873

3 3

[PATCH 0/1] MR4959: mfplat/tests: Skip device manager test if d3d11 device can't be created.
by Nikolay Sivov (＠nsivov) Jan. 29, 2024

Jan. 29, 2024

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4959

3 2

[PATCH v3 0/9] MR4946: user32: Rewrite the rawinput buffer tests with keyboard input, and fix GetRawInputBuffer.
by Rémi Bernon Jan. 29, 2024

Jan. 29, 2024

-- v3: server: Fix rawinput buffer sizes and alignment on WoW64. server: Move rawinput message conversion from win32u. server: Stop using hardware_msg_data in rawinput_message. server: Combine HID usage page and usage together. server: Stop using union rawinput in hw_input_t. dinput/tests: Add more tests for HID rawinput buffer. dinput/tests: Add a helper to wait on HID input reads. user32/tests: Rewrite the rawinput buffer test with keyboard input. user32/tests: Run rawinput device tests in the separate desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/4946

2 12

[PATCH 0/2] MR4626: ntdll: Allow ASLR to be disabled via the registry
by Brendan McGrath (＠redmcg) Jan. 29, 2024

Jan. 29, 2024

Setting 'MoveImages' under: HKLM\SYSTEM\CurrentControlSet\Control\Session Manager\Memory Management to a DWORD with the value 0 will disable ASLR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4626

2 4

[PATCH 0/1] MR4957: bcrypt: Stop compile error when gnutls is missing.
by Alistair Leslie-Hughes (＠alesliehughes) Jan. 29, 2024

Jan. 29, 2024

In file included from dlls/bcrypt/gnutls.c:1916: include/windef.h:112:24: error: unknown type name ‘va_list’ 112 | # define __ms_va_list va_list | ^~~~~~~ include/winbase.h:2076:84: note: in expansion of macro ‘__ms_va_list’ 2076 | WINBASEAPI DWORD WINAPI FormatMessageA(DWORD,LPCVOID,DWORD,DWORD,LPSTR,DWORD,__ms_va_list*); -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4957

3 4

[PATCH 0/10] MR607: Draft: vkd3d-shader/ir: Introduce a Böhm-Jacopini structurizer.
by Giovanni Mascellani (＠giomasce) Jan. 29, 2024

Jan. 29, 2024

This goes atop !598 and !603. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/607

3 14

[PATCH v3 0/12] MR4102: Draft: winewayland.drv: Implement keyboard input support.
by Rémi Bernon Jan. 29, 2024

Jan. 29, 2024

@afrantzis Can't seem to be possible to add you as a reviewer, probably you need to request "Access" to the wine/wine project (near the top of the project page). What do you think of something like that? It is very different from the current winex11 code, but I believe it will match keyboard layouts in a much more accurate way, and it's also IMO much simpler. If that works well with Wayland, I think it could be a good hint that it might work as well in X11 and make a case for my other MR to use that approach there. I was a bit annoyed that it doesn't seem possible to retrieve the Xkb "layout:variant" string here, but only the layout description, so I had to use xkbregistry to match it back to the known layouts. It is mostly only there to provide a more accurate HKL value (which should match the layout langid), and scan to vk mapping table, and custom layouts should still work. The lang would be neutral then, and the scan to vk table is QWERTY by default, which is the most common case, and doesn't enforce any vkey -> unicode mapping anyway. So, if the xkbregistry dependency is an issue we could probably make it optional and dynamically loaded, and skip the langid and scan to vk specialized mappings. -- v3: winewayland.drv: Implement Xkb composition using ImeProcessKey. winewayland.drv: Translate Xkb keyboard layouts to KBDTABLES. win32u: Allow KBDTABLES conversion from CTLR + ALT to WCHAR. win32u: Force US layout in ToUnicode when CTRL is pressed. win32u: Introduce KbdLayerDescriptor user driver entry. win32u: Avoid accessing NULL key name string pointer. winewayland.drv: Enumerate Xkb layouts and create matching HKL. winewayland.drv: Handle and parse Xkb keymap events. win32u: Implement opt-in auto-repeat for WM_(SYS)KEYDOWN messages. winewayland.drv: Configure win32u keyboard repeat delay and speed. winewayland.drv: Basic handling of Wayland keyboard events. gitlab: Install libxkbcommon and libxkbregistry dependencies. https://gitlab.winehq.org/wine/wine/-/merge_requests/4102

5 37

[PATCH v2 0/4] MR603: Draft: vkd3d-shader: Use 64 bit swizzles for 64 bit data types in VSIR.
by Giovanni Mascellani (＠giomasce) Jan. 29, 2024

Jan. 29, 2024

The goal here is to be able to convert between SSA and TEMP easily, which will be the second preliminary pass for the CFG structurizer. Ideally I would have added the check in commit 4/4 for TEMPs as well, but typing information from TPF sources is insufficient. This leaves the current validation inconsistent: we check that a register is always used either as a scalar or a vec4, but that "scalar" might be 32 bit in some cases and 64 bit in others. Maybe the right thing to do here is just give up on trying to put some typing on TEMPs and just say they're always 4x32 bit words. I don't know, I'll leave this for when the dust is more settled. -- v2: vkd3d-shader/ir: Check that SSA registers are used with compatible data types. vkd3d-shader: Use 64 bit swizzles for 64 bit data types in VSIR. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/603

3 7

[PATCH v3 0/4] MR601: Draft: vkd3d-shader/dxil: Implement DX intrinsic TextureLoad.
by Conor McCarthy (＠cmccarthy) Jan. 28, 2024

Jan. 28, 2024

Goes atop !583. The last two commits belong to this MR. -- v3: vkd3d-shader/spirv: Emit a vector bitcast if necessary in spirv_compiler_emit_load_ssa_reg(). vkd3d-shader/dxil: Implement DX intrinsic TextureLoad. vkd3d-shader/dxil: Implement DX intrinsic RawBufferLoad. vkd3d-shader/dxil: Load raw/structured buffer SRV/UAV descriptors. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/601

2 4