January 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR4944: dlls/msvcrt: Free previous environment variable when clearing
by David Kahurani (＠kahurani) Jan. 26, 2024

Jan. 26, 2024

Shifting the rest of the variables by one towards indices of lesser value overwrites the variable being cleared and effectively leaks it. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4944

3 2

[PATCH v10 0/5] MR3103: server: Create and use a desktop shared mapping for GetCursorPos.
by Rémi Bernon Jan. 26, 2024

Jan. 26, 2024

First part of Proton shared memory series. The full branch can be seen at https://gitlab.winehq.org/rbernon/wine/-/commits/mr/shared-memories. -- v10: user32: Use the desktop shared data for GetCursorPos(). server: Add a sequence number to the shared data. server: Move the cursor position and last change time to the shared data. server: Use the helper to update the cursor last change time. server: Create a desktop shared mapping. https://gitlab.winehq.org/wine/wine/-/merge_requests/3103

3 10

[PATCH 0/1] MR4561: localspl: Fix a maybe-uninitialized warning in fill_builtin_form_info().
by Aida Jonikienė Jan. 26, 2024

Jan. 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4561

3 8

[PATCH 0/1] MR4941: d3d10/effect: Use bitfields for numeric type descriptions.
by Nikolay Sivov (＠nsivov) Jan. 26, 2024

Jan. 26, 2024

After working on writing side of this, I find it more readable this way. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4941

3 2

[PATCH v3 0/1] MR4930: wineps.drv: Avoid invalid unaligned accesses.
by Martin Storsjö Jan. 26, 2024

Jan. 26, 2024

While armv7 generally tolerates unaligned loads/stores in most cases, the compiler is free to use the ldrd/strd instructions, for loading/storing two consecutive 32 bit registers, and this requires the destination to be aligned to a 4 byte boundary. When packing a number of variable length structures, make sure that each actual struct gets aligned at the right address boundary. This fixes crashes in DllMain of wineps.drv, when built for armv7, since 351e58dc2d0aafe19294cbeaed9cd30ae965d591. Signed-off-by: Martin Storsjö <martin(a)martin.st> -- v3: wineps.drv: Avoid invalid unaligned accesses. https://gitlab.winehq.org/wine/wine/-/merge_requests/4930

3 4

[PATCH v7 0/3] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Rastislav Stanik (＠rastos) Jan. 26, 2024

Jan. 26, 2024

for details see https://bugs.winehq.org/show_bug.cgi?id=56065 This change adds an implementation of Win32 API function GetAnycastIpAddressTable() that is used by Adoptium OpenJDK 21 and later to initialize Secure Random Generator. This implementation does not return real information, it just says "no entries found". -- v7: iphlpapi: try to hammer out linux compilation in winehq gitlab https://gitlab.winehq.org/wine/wine/-/merge_requests/4940

2 3

[PATCH 0/1] MR4509: include: Add windows.system.diagnostics.telemetry.idl file.
by Aida Jonikienė Jan. 26, 2024

Jan. 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4509

2 6

[PATCH v3 0/2] MR4925: winhttp: Get output synchronously whenever possible in WinHttpQueryDataAvailable / WinHttpReadData.
by Paul Gofman (＠gofman) Jan. 26, 2024

Jan. 26, 2024

It looks like when the data is available but the recursion limit is reached Windows (after 7 when WinHttpQueryDataAvailable is concerned) fills the output immediately and only queues completion callback. I hope the updated test should be stable as we should have the server response read during WinHttpSendRequest already (like on Windows). Fixes market window in Black Desert Online. The game depends on WinHttpReadData returning the result synchronously in WINHTTP_CALLBACK_STATUS_DATA_AVAILABLE callback (and doesn't mind WINHTTP_CALLBACK_STATUS_READ_COMPLETE at all). By the time it reaches there through previous callbacks the recursion limit doesn't allow full synchronous return (and after playing with test_recursion() I think at least Windows 10 has the same recursion limit as we do currently). But as the test shows the output of WinHttpReadData / WinHttpQueryDataAvailable is filled in immediately, probably only the callback should be queued asynchronously to break the recursion. -- v3: winhttp: Always return result at once if available in WinHttpReadData(). winhttp: Always return result at once if available in WinHttpQueryDataAvailable(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4925

3 4

[PATCH v6 0/2] MR4940: bug #56065 - add stub for GetAnycastIpAddressTable()
by Rastislav Stanik (＠rastos) Jan. 26, 2024

Jan. 26, 2024

for details see https://bugs.winehq.org/show_bug.cgi?id=56065 This change adds an implementation of Win32 API function GetAnycastIpAddressTable() that is used by Adoptium OpenJDK 21 and later to initialize Secure Random Generator. This implementation does not return real information, it just says "no entries found". -- v6: iphlpapi: fix compilation on linux. https://gitlab.winehq.org/wine/wine/-/merge_requests/4940

2 2

[PATCH 0/1] MR4513: opengl32: Add a FIXME when doing a mapped buffer copy.
by Aida Jonikienė Jan. 26, 2024

Jan. 26, 2024

I should've pushed this shortly after the workaround for the WineD3D WoW64 graphics corruption got upstreamed (which I discovered when messing around) but never got around to MR anything in Wine. The copies of mapped buffers introduce significant performance overhead (I'll add a FIXME so that people don't get surprised when their old games run like a slideshow like for example NFS Most Wanted). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4513

2 3