January 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v18 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) Jan. 22, 2024

Jan. 22, 2024

On Mon Jan 22 19:46:41 2024 +0000, Vijay Kiran Kamuju wrote: > paramsize we get it from `GdipGetEffectParameterSize` as the default > size is always set when creating the specific effect even when without > params being even set at all. Yes, but if params are set then we will get a different value that I don't think should have an effect on the size validation here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58458

1 0

Re: [PATCH v18 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Vijay Kiran Kamuju (＠infyquest) Jan. 22, 2024

Jan. 22, 2024

On Mon Jan 22 18:31:30 2024 +0000, Esme Povirk wrote: > I don't think we can use `paramsize` in this case because it will depend > on whether parameters were already set. paramsize we get it from `GdipGetEffectParameterSize` as the default size is always set when creating the specific effect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58457

1 0

Re: [PATCH v18 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) Jan. 22, 2024

Jan. 22, 2024

On Mon Jan 22 18:49:11 2024 +0000, Vijay Kiran Kamuju wrote: > I will add a check if desc is already allocated or not, if yes then use realloc. I really think you need to pass in void** here, as it looks like desc is meant as an output parameter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58455

1 0

Re: [PATCH v18 0/4] MR4661: gdiplus: Implement Gdiplus effects
by Esme Povirk (＠madewokherd) Jan. 22, 2024

Jan. 22, 2024

On Mon Jan 22 18:40:16 2024 +0000, Vijay Kiran Kamuju wrote: > They can all be combined to one, if we don't use a union and use 'void > *' as member of CGpEffect to store the parameter. I am a bit confused on > how to merge the cases if we use a union. Just pick one. The pointer type doesn't matter if you're going to pass it to memcpy. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4661#note_58454

1 0

[PATCH v3 0/2] MR581: vkd3d-shader/dxil: Handle more semantic kinds.
by Conor McCarthy (＠cmccarthy) Jan. 22, 2024

Jan. 22, 2024

-- v3: vkd3d-shader/dxil: Handle semantic kind ISFRONTFACE. vkd3d-shader/dxil: Handle semantic kind VERTEXID. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/581

4 5

[PATCH v3 0/2] MR580: vkd3d-shader/spirv: Handle UINT32_MAX result for FIRSTBIT_HI and FIRSTBIT_SHI.
by Conor McCarthy (＠cmccarthy) Jan. 22, 2024

Jan. 22, 2024

-- v3: vkd3d-shader/spirv: Handle UINT32_MAX result from FIRSTBIT_HI and FIRSTBIT_SHI instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/580

3 3

[PATCH v4 0/5] MR533: vkd3d-shader/dxil: SRV/UAV support part 1.
by Conor McCarthy (＠cmccarthy) Jan. 22, 2024

Jan. 22, 2024

-- v4: vkd3d-shader/dxil: Implement DX intrinsic BufferLoad for typed buffers. vkd3d-shader/dxil: Load typed UAV descriptors. vkd3d-shader/dxil: Load typed SRV descriptors. vkd3d-shader/spirv: Do not assert VKD3D_DATA_UINT in spirv_compiler_emit_ld_raw_structured_srv_uav(). vkd3d-shader/dxil: Pass the code block and instruction in a struct to intrinsic handlers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/533

3 8

[PATCH v7 0/4] MR559: vkd3d-shader/ir: Validate block-based CF, part 2.
by Giovanni Mascellani (＠giomasce) Jan. 22, 2024

Jan. 22, 2024

~~Other validation stuff I plan to send as soon as !450 and !550 are in.~~ ~~I guess the CI is going to timeout because of too many commits, so I'll preemptively stop it.~~ -- v7: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/559

3 6

[PATCH v4 0/6] MR553: Draft: vkd3d-shader/d3d-asm: Dump the input and output signatures.
by Giovanni Mascellani (＠giomasce) Jan. 22, 2024

Jan. 22, 2024

At some point I would like to have an assembler for TPF, so that it's easier to write and modify tests. This is a first step in that direction, fixing some kind of format for serializing signatures in the comment at the beginning of the assembler code. I'm not decided yet on all details, so take this as an RFC for the moment. -- v4: tests: Test emitting the signature. vkd3d-compiler: Add an option to emit the signature when disassembling. vkd3d-shader/d3d-asm: Support emitting the shader signature. vkd3d-shader/d3d-asm: Refactor dumping a write mask to a dedicated function. vkd3d-shader/d3d-asm: Describe the ASM dialect with a bunch of flags instead of a plain enum. vkd3d-shader/d3d-asm: Do not make a copy of the buffer before returning it. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/553

4 10

[PATCH 0/3] MR4911: dinput: Implement DIPROP_AUTOCENTER.
by Rémi Bernon Jan. 22, 2024

Jan. 22, 2024

Supersedes !4830 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4911

3 5