January 2024 - Wine-GitLab - list.winehq.org

[PATCH v3 0/4] MR4761: ntdll: Implement NtContinueEx()
by Dāvis Mosāns Jan. 13, 2024

Jan. 13, 2024

This MR implements `NtContinueEx(PCONTEXT, PCONTINUE_OPTIONS)` which was added in Windows 10 20H1. Also added basic test reusing existing `test_continue()` (included from !4720) League of Legends game hooks `NtContinue()` and `NtContinueEx()` by putting `jmp` instruction in front of it. Note that LoL doesn't actually use `NtContinueEx()` itself and game will work fine without it but if game doesn't find `NtContinueEx()` it will permanently ban your account due to detecting "scripting program" -- v3: ntdll/tests: Add basic test for NtContinueEx() ntdll: NtContinueEx() handle few error cases ntdll: Implement NtContinueEx() ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4761

2 5

[PATCH v8 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns Jan. 13, 2024

Jan. 13, 2024

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v8: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

2 5

[PATCH v7 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns Jan. 13, 2024

Jan. 13, 2024

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v7: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

2 2

[PATCH 0/2] MR4836: ntdll: Implement SystemFirmwareTable_Enumerate in NtQuerySystemInformation
by Dāvis Mosāns Jan. 13, 2024

Jan. 13, 2024

This MR implements `EnumSystemFirmwareTables()` and `NtQuerySystemInformation(SystemFirmwareTableInformation)` with `SystemFirmwareTable_Enumerate` which are currently not implemented. For more context/background info see !4832 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4836

2 3

Re: [PATCH v3 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Rémi Bernon Jan. 13, 2024

Jan. 13, 2024

On Sat Jan 13 18:12:01 2024 +0000, Tyson Whitehead wrote: > Just a note that I have some more changes coming to this > * set `DIPROP_AUTOCENTER` on at start (currently defaults to off) > * update the tests Only had a quick look so far and it looks okay, so feel free to add these too. Fwiw in general we prefer to add tests first, with todo_wine as needed, and then remove the todo_wine as things are implemented. This better shows the desired behavior which is being implemented. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4830#note_57341

1 0

Re: [PATCH v3 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Tyson Whitehead (＠twhitehead) Jan. 13, 2024

Jan. 13, 2024

Just a note that I have some more changes coming to this * set `DIPROP_AUTOCENTER` on at start (currently defaults to off) * update the tests -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4830#note_57338

1 0

[PATCH 0/1] MR4833: ntdll: Improve NtQuerySystemInformation(SystemCodeIntegrityInformation)
by Dāvis Mosāns Jan. 13, 2024

Jan. 13, 2024

This makes it match more closely how it works on Windows but it's still not a proper implementation. For more context/background info see !4832 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4833

1 1

[PATCH 0/1] MR4831: wing32: Avoid crash in WinGGetDIBPointer when called with NULL bitmap info.
by Bernhard Übelacker Jan. 13, 2024

Jan. 13, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56135 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4831

2 2

[PATCH v2 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Tyson Whitehead (＠twhitehead) Jan. 13, 2024

Jan. 13, 2024

Autocenter is a default effect playing on the device following power up or reset. It is disabled by stopping all effects. On at least some devices (all?) it is a spring effect playing in slot 1. Capturing Windows USB packets reveals it dinput acquire does (1) a reset (this enabled autocenter) and, if autocenter is disabled, (2) a stop all effects (this disabled autocenter). This logic works regardless of whether autocenter is a spring effect playing in slot 1 or not. It does mean autocenter can only be set when the device is not acquired. Testing on Windows reveals setting autocenter properties while acquired returns DIERR_ACQUIRED even if the device is exclusively acquired, so this is consistent. -- v2: dinput: implement DIPROP_AUTOCENTER https://gitlab.winehq.org/wine/wine/-/merge_requests/4830

3 2

[PATCH 0/1] MR4830: dinput: implement DIPROP_AUTOCENTER
by Tyson Whitehead (＠twhitehead) Jan. 13, 2024

Jan. 13, 2024

Autocenter is a default effect playing on the device following power up or reset. It is disabled by stopping all effects. On at least some devices (all?) it is a spring effect playing in slot 1. Capturing Windows USB packets reveals it dinput acquire does (1) a reset (this enabled autocenter) and, if autocenter is disabled, (2) a stop all effects (this disabled autocenter). This logic works regardless of whether autocenter is a spring effect playing in slot 1 or not. It does mean autocenter can only be set when the device is not acquired. Testing on Windows reveals setting autocenter properties while acquired returns DIERR_ACQUIRED even if the device is exclusively acquired, so this is consistent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4830

3 2