October 2024 - Wine-GitLab - list.winehq.org

[PATCH v6 0/43] MR6623: Draft: include/winnt.h: Add support for thread safety annotation attributes.
by Vibhav Pant (＠vibhavp) Oct. 7, 2024

Oct. 7, 2024

This MR introduces support for [thread safety annotations,](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#conditi… currently supported by Clang. The feature is similar to `__WINE_MALLOC` attributes, allowing functions, data members and global variables to be optionally annotated with synchronization details. As a proof of concept, I have annotated `RTL_CRITICAL_SECTION` and `dlls/ntdll`. Because the feature was designed as a C++ extension first, a bit of stubbing is required to annotate struct fields about what lock they are guarded by. The macros `WINE_DECLARE_LOCK_FIELD_STUB` and `WINE_DEFINE_LOCK_FIELD_STUB` take care of that. For instance, in `dlls/ntdll/threadpool.c`: ```c WINE_DECLARE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); struct threadpool_group { LONG refcount; BOOL shutdown; CRITICAL_SECTION cs; /* list of group members, locked via .cs */ struct list members __WINE_FIELD_GUARDED_BY(threadpool_group, cs); }; WINE_DEFINE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); ``` Clang will therefore warn if `members` is accessed without holding `cs`. Note that the analyzer does not support conditional locking. For that reason, functions that hold and release a lock conditionally have been marked with `__WINE_NO_THREAD_SAFETY_ANALYSIS` to pre-empt false positives from Clang. -- v6: dlls/amstream/tests: Disable thread safety analysis for testfilter_wait_state. dlls/winhttp: Add thread safety annotations. dlls/mmdevapi: Add thread safety annotations for session_lock and sessions_unlock. dlls/mfplat: Add thread safety annotations. dlls/msi: Add thread safety annotations for msiobj_lock and msiobj_unlock. dlls/xaudio2_7: Add thread safety annotations. dlls/wmvcore: Add thread safety annotations for async_reader_wait_pts, async_reader_deliver_sample, and callback_thread_run. dlls/wininet: Disable thread safety annotations for HTTPREQ_ReadFile and HTTPREQ_QueryDataAvailable. dlls/winegstreamer: Add thread safety annotation for GST_Seeking_SetPositions. dlls/dwrite: Add thread safety annotations for factory_lock and factory_unlock. dlls/wined3d: Add thread safety annotations. lib/vkd3d: Build with WINE_NO_THREAD_SAFETY_ANALYSIS defined. dlls/d2d1: Add thread safety annotations. dlls/xaudio2_7: Disable thread safety analysis for IXAudio2Impl_CreateSourceVoice. dlls/xinput1_3: Add thread safety annotations for controller_lock and controller_unlock. dlls/ucrtbase/tests: Only release &fp.iobuf->_crit if the previous lock was successful (Clang). dlls/netio.sys: Add thread safety annotations for lock_sock and unlock_socket. dlls/msvcirt/tests: Release &sb.lock only if the previous lock was successful (Clang). dlls/wbemprox: Add thread safety annotations. libs/strmbase: Annotate BaseRenderer_Receive to indicate the caller needs to hold the underlying filter lock. dlls/rpcrt4: Add thread safety annotations for AllocateContextHandle, FindContextHandle, ReleaseContextHandle. dlls/wined3d: Add thread safety annotations for allocator locking helpers. dlls/mfreadwrite: Indicate calling source_reader_read_sample requires holding &reader->cs. dlls/mapi32: Add thread safety annotations for GetValue, AddValue, Lock, Unlock. dlls/kernel32/tests: Add thread safety annotations. dlls/combase: Add thread safety annotations programs/services: Add thread safety annotations. dlls/winmm: Add thread safety annotations. dlls/vcomp: Add thread safety annotations. dlls/user32: Add thread safety annotations. dlls/odbc32: Add thread safety annotations. dlls/krnl386.exe16: Add thread safety annotations. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6623

1 0

[PATCH v5 0/43] MR6623: Draft: include/winnt.h: Add support for thread safety annotation attributes.
by Vibhav Pant (＠vibhavp) Oct. 7, 2024

Oct. 7, 2024

This MR introduces support for [thread safety annotations,](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#conditi… currently supported by Clang. The feature is similar to `__WINE_MALLOC` attributes, allowing functions, data members and global variables to be optionally annotated with synchronization details. As a proof of concept, I have annotated `RTL_CRITICAL_SECTION` and `dlls/ntdll`. Because the feature was designed as a C++ extension first, a bit of stubbing is required to annotate struct fields about what lock they are guarded by. The macros `WINE_DECLARE_LOCK_FIELD_STUB` and `WINE_DEFINE_LOCK_FIELD_STUB` take care of that. For instance, in `dlls/ntdll/threadpool.c`: ```c WINE_DECLARE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); struct threadpool_group { LONG refcount; BOOL shutdown; CRITICAL_SECTION cs; /* list of group members, locked via .cs */ struct list members __WINE_FIELD_GUARDED_BY(threadpool_group, cs); }; WINE_DEFINE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); ``` Clang will therefore warn if `members` is accessed without holding `cs`. Note that the analyzer does not support conditional locking. For that reason, functions that hold and release a lock conditionally have been marked with `__WINE_NO_THREAD_SAFETY_ANALYSIS` to pre-empt false positives from Clang. -- v5: dlls/amstream/tests: Disable thread safety analysis for testfilter_wait_state. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6623

1 0

[PATCH 0/5] MR6613: win32u: Introduce a new NtUserSetRawWindowPos call for the drivers.
by Rémi Bernon Oct. 7, 2024

Oct. 7, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6613

2 7

[PATCH v2 0/1] MR6597: gdiplus: Assign box height when bounding height is higher.
by Santino Mazza (＠tati1454) Oct. 7, 2024

Oct. 7, 2024

When passing a box with a non-zero height that is smaller than the bounding box to GdipMeasureString, it returns a bounding box of 0. In Windows it returns the same height as the box. -- v2: gdiplus: Assign box height when bounding box height is larger. https://gitlab.winehq.org/wine/wine/-/merge_requests/6597

4 4

[PATCH 0/1] MR6626: include: Add windows.security.authorization.appcapabilityaccess.idl.
by Biswapriyo Nath (＠Biswa96) Oct. 7, 2024

Oct. 7, 2024

Required for https://github.com/mozilla/gecko-dev/blob/5717a81fa87a3a4cc1f8cac16e7b0de52… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6626

3 2

[PATCH 0/1] MR6625: include: Add windows.data.xml.dom.idl.
by Biswapriyo Nath (＠Biswa96) Oct. 7, 2024

Oct. 7, 2024

Required for https://github.com/mozilla/gecko-dev/blob/5717a81fa87a3a4cc1f8cac16e7b0de52… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6625

3 2

[PATCH v2 0/8] MR6568: d3dx9: Pixel format handling changes, part 2.
by Connor McAdams (＠cmcadams) Oct. 7, 2024

Oct. 7, 2024

These patches are the last big changes to the pixel_format_desc structure. Patch 2 of this feels like it might be a bit big, but I couldn't really come up with a clean way to split it. :) -- v2: d3dx9: Add support for D3DFMT_A8P8. d3dx9: Add support for D3DFMT_A2W10V10U10. d3dx9: Add support for D3DFMT_X8L8V8U8. d3dx9: Get rid of index_to_rgba callback. d3dx9: Get rid of la_{to,from}_rgba format callbacks. d3dx9: Always align and mask channel bits in format_to_d3dx_color(). d3dx9: Rework pixel_format_desc structure format type value. https://gitlab.winehq.org/wine/wine/-/merge_requests/6568

3 11

[PATCH 0/8] MR6568: d3dx9: Pixel format handling changes, part 2.
by Connor McAdams (＠cmcadams) Oct. 7, 2024

Oct. 7, 2024

These patches are the last big changes to the pixel_format_desc structure. Patch 2 of this feels like it might be a bit big, but I couldn't really come up with a clean way to split it. :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6568

4 17

[PATCH 0/1] MR6624: msiexec: Remove quotes from all filenames.
by Hans Leidekker (＠hans) Oct. 7, 2024

Oct. 7, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57271 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6624

2 1

[PATCH 0/5] MR6619: dplayx: Open() part 7.
by Anton Baskanov (＠baskanov) Oct. 6, 2024

Oct. 6, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6619

4 7