November 2024 - Wine-GitLab

[PATCH v3 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) Dec. 1, 2024

Dec. 1, 2024

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This test has been updated to only allow current Windows behaviour, and `NtQueryDirectoryFile` will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE` as appropriate. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. -- v3: ntdll: Test updated NtQueryDirectoryFile behaviour if scan is reset with a new mask https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

3 4

[PATCH v10 0/1] MR6884: Draft: Iphlpapi.dll: Included SendARP
by Thi Garlet (＠garlett) Dec. 1, 2024

Dec. 1, 2024

Returns MAC address by: - search local interfaces, or - send UDP packed that does not need linux privilege, then search local cache solve https://bugs.winehq.org/show_bug.cgi?id=9418 files updated - /dlls/iphlpapi/iphlpapi_main.c - /dlls/iphlpapi/tests/iphlpapi.c -- v10: iphlpapi.c: Add SendARP https://gitlab.winehq.org/wine/wine/-/merge_requests/6884

4 3

[PATCH 0/3] MR5712: winewayland.drv: Update key state from Wayland information.
by Alexandros Frantzis (＠afrantzis) Dec. 1, 2024

Dec. 1, 2024

Recent changes allowed the Wayland driver to properly deal with numpad keys depending on numlock status. This MR ensures that numlock and other lock state is properly synced, and concludes the fix for https://bugs.winehq.org/show_bug.cgi?id=56397. This MR also syncs the key press state when a window gains keyboard focus, including any modifier press state. Note that we currently ignore the modifier press information from the `modifier` event, since: 1. it doesn't differentiate between left-right keys, 2. mod press state changes will be normally preceded by a matching key event, so we are able to sync properly. However, if we find that we need to handle mod press state changes without corresponding key events, we will need to implement some sensible way to sync these, too. Although I would like for the driver work exclusively in terms of scancodes, I still needed to use vkeys in this case, since this is how wineserver expresses keyboard state at the moment. This means that I had to introduce/duplicate some extra scan->vkey logic in the driver (e.g., numpad keys based on numlock state) to get things right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5712

5 15

[PATCH v2 0/3] MR698: d2d1: Implement transform graph.
by Ziqing Hui (＠zhui) Dec. 1, 2024

Dec. 1, 2024

-- v2: d2d1: Implement nodes connection for ID2D1TransformGraph. d2d1: Implement nodes adding and removal for ID2D1TransformGraph. d2d1/tests: Add more tests for ID2D1TransformGraph. https://gitlab.winehq.org/wine/wine/-/merge_requests/698

2 5

[PATCH 0/1] MR6785: winegstreamer: Don't force codec data length for WMA.
by Ziqing Hui (＠zhui) Dec. 1, 2024

Dec. 1, 2024

This makes us be able to pass custom data in codec data buffer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6785

3 7

[PATCH v8 0/5] MR6924: dlls/bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose.
by Vibhav Pant (＠vibhavp) Nov. 30, 2024

Nov. 30, 2024

-- v8: bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose. https://gitlab.winehq.org/wine/wine/-/merge_requests/6924

2 5

[PATCH v7 0/5] MR6924: dlls/bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose.
by Vibhav Pant (＠vibhavp) Nov. 30, 2024

Nov. 30, 2024

-- v7: bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose. bluetoothapis/tests: Add tests for BluetoothFindRadioClose. bluetoothapis/tests: Add tests for BluetoothFindNextRadio. bluetoothapis/tests: Add tests for BluetoothFindFirstRadio. https://gitlab.winehq.org/wine/wine/-/merge_requests/6924

3 13

[PATCH v3 0/5] MR6924: dlls/bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose.
by Vibhav Pant (＠vibhavp) Nov. 30, 2024

Nov. 30, 2024

-- v3: bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose. bluetoothapis/tests: Add tests for BluetoothFindRadioClose. bluetoothapis/tests: Add tests for BluetoothFindNextRadio. bluetoothapis/tests: Add tests for BluetoothFindFirstRadio. bluetoothapis/tests: Fix potential test failure from memcmp'ing uninitialized bytes. https://gitlab.winehq.org/wine/wine/-/merge_requests/6924

3 7

[PATCH v6 0/5] MR6924: dlls/bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose.
by Vibhav Pant (＠vibhavp) Nov. 30, 2024

Nov. 30, 2024

-- v6: bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose. https://gitlab.winehq.org/wine/wine/-/merge_requests/6924

2 6

[PATCH v2 0/7] MR6924: winebth.sys part 2: dlls/bluetoothapis: Implement BluetoothFindFirstRadio, BluetoothFindNextRadio, BluetoothFindRadioClose.
by Vibhav Pant (＠vibhavp) Nov. 30, 2024

Nov. 30, 2024

-- v2: dlls/bluetoothapis: Implement BluetoothFindRadioClose. dlls/bluetoothapis/tests: Add tests for BluetoothFindRadioClose. dlls/bluetoothapis: Implement BluetoothFindNextRadio. dlls/bluetoothapis/tests: Add tests for BluetoothFindNextRadio. https://gitlab.winehq.org/wine/wine/-/merge_requests/6924

4 20