November 2024 - Wine-GitLab

Re: [PATCH v2 0/2] MR6736: Do not modify audio client buffer size when changing sample rate
by Arek Hiler (＠ivyl) Nov. 26, 2024

Nov. 26, 2024

just a minor nitpick with indent, thanks for improving the implementation! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6736#note_88937

1 0

Re: [PATCH v2 0/2] MR6736: Do not modify audio client buffer size when changing sample rate - approved
by Arek Hiler (＠ivyl) Nov. 26, 2024

Nov. 26, 2024

This merge request was approved by Arek Hiler. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6736

1 0

Re: [PATCH v2 0/2] MR6736: Do not modify audio client buffer size when changing sample rate
by Arek Hiler (＠ivyl) Nov. 26, 2024

Nov. 26, 2024

Arek Hiler (@ivyl) commented about dlls/mmdevapi/tests/render.c: > + ok(hr == S_OK, "SetSampleRate failed: %08lx\n", hr); > + > + /* Wait for frame processing */ > + WaitForSingleObject(event, 1000); > + > + hr = IAudioClient_GetBufferSize(ac, &bufsize); > + ok(bufsize == expected_bufsize, "unexpected bufsize %d expected %d\n", bufsize, expected_bufsize); > + > + hr = IAudioClockAdjustment_SetSampleRate(aca, 22050.00f); > + ok(hr == S_OK, "SetSampleRate failed: %08lx\n", hr); > + > + /* Wait for frame processing */ > + WaitForSingleObject(event, 1000); > + > + hr = IAudioClient_GetBufferSize(ac, &bufsize); > + todo_wine ok(bufsize == expected_bufsize, "unexpected bufsize %d expected %d\n", bufsize, expected_bufsize); bad indent -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6736#note_88936

1 0

[PATCH v10 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) Nov. 26, 2024

Nov. 26, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v10: user32: Send parent BN_CLICKED notification when a radio button get focused. user32/tests: Add tests for radio button WM_SETFOCUS. comctl32: Send parent BN_CLICKED notification when a radio button get focused. comctl32/tests: Add tests for radio button WM_SETFOCUS. https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

4 7

[PATCH v11 0/2] MR419: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Giovanni Mascellani (＠giomasce) Nov. 26, 2024

Nov. 26, 2024

-- v11: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. https://gitlab.winehq.org/wine/wine/-/merge_requests/419

4 5

[PATCH v10 0/2] MR419: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows.
by Giovanni Mascellani (＠giomasce) Nov. 26, 2024

Nov. 26, 2024

-- v10: win32u/window: Ignore changing WS_EX_TOPMOST for message-only windows. user32/tests: Check that message-only windows ignore WS_EX_TOPMOST. https://gitlab.winehq.org/wine/wine/-/merge_requests/419

3 3

[PATCH v2 0/2] MR6898: comctl32: Update combobox dropdown size.
by Orin Varley (＠ovarley1) Nov. 26, 2024

Nov. 26, 2024

When the combobox height is to be set by the application (as the CBS_NOINTEGRALHEIGHT style is on), and when a large size is specified but only a small number of items in the list, the height of the combobox should be set by the number of items rather than the size specified to avoid empty lines. The first commit fixes this and the second is a test for this behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57360 Closes #7 -- v2: comctl32: Make CBS_NOINTEGRALHEIGHT only set minimum combobox height. comctl32/tests: Add tests for a small number of items but big size to the combobox dropdown size tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/6898

2 2

[PATCH v4 0/4] MR6289: dsound: Some 3D fixes.
by Aida Jonikienė Nov. 26, 2024

Nov. 26, 2024

-- v4: dsound: Add non-NaN value tests for SetOrientation(). dsound/tests: Add NaN tests for floating-point 3D functions. dsound: Add an angle check for SetOrientation(). dsound: Handle NaN values in the 3D code. https://gitlab.winehq.org/wine/wine/-/merge_requests/6289

2 9

[PATCH v4 0/6] MR6680: msvcp140: Use current locale to convert path in _Fiopen.
by Daniel Lehman (＠dlehman25) Nov. 26, 2024

Nov. 26, 2024

-- v4: msvcp140: Call into fopen from _Fiopen. ucrtbase: Handle utf-8 in _fsopen. msvcp140/tests: Add tests for _Fiopen. msvcp120/tests: Add tests for _Fiopen. ucrtbase/tests: Add tests for _fsopen. msvcr120/tests: Add tests for _fsopen. https://gitlab.winehq.org/wine/wine/-/merge_requests/6680

4 17

[PATCH 0/2] MR6898: comctl32: Update combobox dropdown size.
by Orin Varley (＠ovarley1) Nov. 26, 2024

Nov. 26, 2024

When the combobox height is to be set by the application (as the CBS_NOINTEGRALHEIGHT style is on), and when a large size is specified but only a small number of items in the list, the height of the combobox should be set by the number of items rather than the size specified to avoid empty lines. The first commit fixes this and the second is a test for this behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57360 Closes #7 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6898

3 9