November 2024 - Wine-GitLab

Re: [PATCH v5 0/1] MR5924: Draft: mfmediaengine: Implement SVR.
by Nikolay Sivov (＠nsivov) Nov. 22, 2024

Nov. 22, 2024

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/video_frame_sink.c: > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFMediaEventGenerator_iface); > +} > + > +static struct video_frame_sink *impl_from_IMFStreamSink(IMFStreamSink *iface) > +{ > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFStreamSink_iface); > +} > + > +static struct video_frame_sink *impl_from_IMFMediaTypeHandler(IMFMediaTypeHandler *iface) > +{ > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFMediaTypeHandler_iface); > +} > + > +static void video_frame_sink_samples_release(struct video_frame_sink *sink) > +{ > + for (int i = 0; i < ARRAYSIZE(sink->sample); i++) ARRAY_SIZE is more common throughout the codebase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5924#note_88682

1 0

Re: [PATCH v2 0/5] MR6879: dplayx: Connection caching. - approved
by Alexandre Julliard (＠julliard) Nov. 22, 2024

Nov. 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6879

1 0

Re: [PATCH v4 0/7] MR6846: winex11: Misc tweaks to the emulated display mode support. - approved
by Alexandre Julliard (＠julliard) Nov. 22, 2024

Nov. 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6846

1 0

Re: [PATCH v4 0/3] MR6882: secur32, urlmon, wininet: Fix some failing tests. - approved
by Alexandre Julliard (＠julliard) Nov. 22, 2024

Nov. 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6882

1 0

Re: [PATCH v3 0/2] MR6868: win32u: Fix a couple of raw monitor DPI issues. - approved
by Alexandre Julliard (＠julliard) Nov. 22, 2024

Nov. 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6868

1 0

Re: [PATCH v2 0/1] MR6880: gitlab: Wait for the fvwm process to start. - approved
by Alexandre Julliard (＠julliard) Nov. 22, 2024

Nov. 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6880

1 0

Re: [PATCH v3 0/1] MR6881: kernel32/tests: Check for the _SW_INVALID bit presence only. - approved
by Alexandre Julliard (＠julliard) Nov. 22, 2024

Nov. 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6881

1 0

Re: [PATCH v4 0/1] MR6523: wtsapi32: Handle WTSSessionInfo class in WTSQuerySessionInformationW(). - approved
by Alexandre Julliard (＠julliard) Nov. 22, 2024

Nov. 22, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6523

1 0

[PATCH v3 0/1] MR6883: msxml3: Add indentation test.
by Orin Varley (＠ovarley1) Nov. 22, 2024

Nov. 22, 2024

Adding a test to make sure the indentation of xml elements is a tab even after moving to another thread. To prevent regressions like the bug bellow. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57325 -- v3: msxml3: Add indentation test. https://gitlab.winehq.org/wine/wine/-/merge_requests/6883

3 2

[PATCH v5 0/5] MR6889: threadpoolwinrt: Implement IAsyncAction and IAsyncInfo.
by Vibhav Pant (＠vibhavp) Nov. 22, 2024

Nov. 22, 2024

This MR adds an implementation for the `IAsyncAction` and `IAsyncInfo` interfaces exported by `Windows.System.Threading`, including support for setting `IAsyncActionCompletedHandler` values for an `IAsyncAction`. It also re-writes (or factors?) the `IAsyncOperation<boolean>` implementation in dlls/cryptowinrt to use `ThreadPoolStatics::RunAsync`, by introducing a type-punning variant of `AsyncOperationCompletedHandler<T>` (similar to `WineAsyncOperationCompletedHandler`), which is a wrapper around the `IAsyncAction` returned by `RunAsync`. The new `IAsyncOperation<T>` implementation is simpler, and if merged, can be exported to other dlls (windows.gaming.input and windows.security.credentials.ui.userconsentverifier for now). -- v5: cryptowinrt: Rewrite IAsyncOperation using Windows.System.Threading. https://gitlab.winehq.org/wine/wine/-/merge_requests/6889

4 8