November 2024 - Wine-GitLab

[PATCH v3 0/13] MR6207: include: Introduce new COM implementation helper macros.
by Rémi Bernon Nov. 18, 2024

Nov. 18, 2024

I think it would be very nice to have something like that to reduce the burden of implementing COM interfaces. This shows for instance on the windows.gaming.input module a 30% LoC reduction (from ~6800 to ~4700), even though the module already had a boilerplate helper macros already. The MR introduces macros to automatically implement each IUnknown method, as well as all of them at once. It also includes a helper to implement IInspectable methods at once, as well as macros to forward both interface methods to a base interface or an outer object. Last, it provides higher-level macros to implement a main interface and any number of sub interfaces and generate IUnknown, forwarding and vtables for all of them at once, with IInspectable support when needed. It uses widl to generate additional per-interface macros, for things like inheritance and vtable generation. The rest of the macros are otherwise shared in a Wine-specific header. The implementation is split to show individual macro being used, although they are later replaced by higher-level macros. The individual helpers are still useful in some corner cases where specific behavior needs to be implemented, or for aggregating classes. -- v3: include: Add a parameter to COM helper END to control QI traces. windows.gaming.input: Use the new COM macros everywhere possible. include: Introduce new macros for COM heritage implementation. widl: Generate some INTERFACE_IMPL/FWD helper macros. include: Introduce new macros for IInspectable WinRT implementation. include: Introduce new macros for COM IUnknown implementation. include: Introduce new macros for COM QueryInterface implementation. widl: Generate some QUERY_INTERFACE helper macros. include: Introduce new macros for COM AddRef/Release implementation. include: Introduce new helper macros for COM implementation. windows.gaming.input: Use the new INTERFACE_VTBL macros. widl: Generate some INTERFACE_VTBL helper macros. windows.gaming.input: Use a separate interface for IAgileObject. https://gitlab.winehq.org/wine/wine/-/merge_requests/6207

4 22

[PATCH v2 0/3] MR6678: jscript/mshtml: Make most global object props configurable and work properly.
by Gabriel Ivăncescu Nov. 18, 2024

Nov. 18, 2024

-- v2: mshtml: Use actual referenced prop flags for window script props. jscript: Make most builtin global objects configurable. jscript: Delete external props before redefining them. https://gitlab.winehq.org/wine/wine/-/merge_requests/6678

2 6

[PATCH 0/2] MR6833: dinput: Only call SetCursorPos if ClipCursor fails.
by Rémi Bernon Nov. 18, 2024

Nov. 18, 2024

Fixes mouse sometimes jumping around in Mechwarrior Online on KDE/Wayland. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6833

1 2

[PATCH 0/7] MR6829: dplayx: Group handling for SUPERENUMPLAYERSREPLY.
by Anton Baskanov (＠baskanov) Nov. 18, 2024

Nov. 18, 2024

This is the first of the 3 remaining MRs required for GTA 2 multiplayer to work. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6829

5 11

[PATCH v29 0/7] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) Nov. 18, 2024

Nov. 18, 2024

-- v29: wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add stubs for IMap<HSTRING, IInspectable *>, IObservableMap<HSTRING, IInspectable *>, IIterable<IKeyValuePair<HSTRING, IInspectable *>> to PropertySet implementation. wintypes: Add stub for Windows.Foundation.Collections.PropertySet. wintypes/tests: Add conformance tests for Windows.Foundation.Collections.PropertySet. include: Add Windows.Foundation.Collections.PropertySet runtime class. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

3 8

[PATCH 0/4] MR6832: winebus: Enable hidraw by default for various HOTAS controllers.
by Rémi Bernon Nov. 18, 2024

Nov. 18, 2024

Based on contributions from Andrew Conrad, Arkadiusz Hiler, Ivo Ivanov, and Kai Krakow. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6832

1 4

[PATCH 0/2] MR6831: winebus: Always return success from PID effect control.
by Rémi Bernon Nov. 18, 2024

Nov. 18, 2024

Fixes some force feedback issues with Forza Horizon 5. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6831

1 2

[PATCH v9 0/6] MR6569: Draft: winex11: Refactor window state/config tracker to fix race conditions.
by Rémi Bernon Nov. 18, 2024

Nov. 18, 2024

This completely refactors the winex11 window state tracking, keeping track of the desired/pending/current window state and config in a fully asynchronous way, and avoiding duplicate requests. I believe this mitigates various race conditions that we're suffering from, solving most spurious event feedback loops when the X11 state is being applied while some win32 state change is being requested, and fixing the spurious d3d/ddraw/user32 test failures. -- v9: winex11: Request window state updates asynchronously. winex11: Update the window client config on window state changes. winex11: Wait for pending ConfigureNotify before updating the client state. winex11: Wait for pending _NET_WM_STATE before updating the client state. winex11: Don't expect WM_STATE events on override-redirect windows. winex11: Listen to PropertyNotify events on the virtual desktop window. https://gitlab.winehq.org/wine/wine/-/merge_requests/6569

1 7

[PATCH 0/2] MR6827: msi: Fix MsiSummaryInfoPersist not saving data to disk
by Fabian Maurer (＠DarkShadow44) Nov. 18, 2024

Nov. 18, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55859 When a db is transacted, we need to call `Commit` to actually save the changes, but tests show this is not how msi works, so I changed `MsiGetSummaryInformationW` to open the db directly instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6827

4 4

[PATCH v8 0/6] MR6569: Draft: winex11: Refactor window state/config tracker to fix race conditions.
by Rémi Bernon Nov. 18, 2024

Nov. 18, 2024

This completely refactors the winex11 window state tracking, keeping track of the desired/pending/current window state and config in a fully asynchronous way, and avoiding duplicate requests. I believe this mitigates various race conditions that we're suffering from, solving most spurious event feedback loops when the X11 state is being applied while some win32 state change is being requested, and fixing the spurious d3d/ddraw/user32 test failures. -- v8: winex11: Request window state updates asynchronously. winex11: Update the window client config on window state changes. winex11: Wait for pending ConfigureNotify before updating the client state. winex11: Wait for pending _NET_WM_STATE before updating the client state. winex11: Don't expect WM_STATE events on override-redirect windows. winex11: Listen to PropertyNotify events on the virtual desktop window. https://gitlab.winehq.org/wine/wine/-/merge_requests/6569

1 6