November 2024 - Wine-GitLab

[PATCH v8 0/47] MR6623: Draft: include/winnt.h: Add support for thread safety annotation attributes.
by Vibhav Pant (＠vibhavp) Nov. 14, 2024

Nov. 14, 2024

This MR introduces support for [thread safety annotations,](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#conditi… currently supported by Clang. The feature is similar to `__WINE_MALLOC` attributes, allowing functions, data members and global variables to be optionally annotated with synchronization details. As a proof of concept, I have annotated `RTL_CRITICAL_SECTION` and `dlls/ntdll`. Because the feature was designed as a C++ extension first, a bit of stubbing is required to annotate struct fields about what lock they are guarded by. The macros `WINE_DECLARE_LOCK_FIELD_STUB` and `WINE_DEFINE_LOCK_FIELD_STUB` take care of that. For instance, in `dlls/ntdll/threadpool.c`: ```c WINE_DECLARE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); struct threadpool_group { LONG refcount; BOOL shutdown; CRITICAL_SECTION cs; /* list of group members, locked via .cs */ struct list members __WINE_FIELD_GUARDED_BY(threadpool_group, cs); }; WINE_DEFINE_LOCK_FIELD_STUB(threadpool_group, CRITICAL_SECTION, cs); ``` Clang will therefore warn if `members` is accessed without holding `cs`. Note that the analyzer does not support conditional locking. For that reason, functions that hold and release a lock conditionally have been marked with `__WINE_NO_THREAD_SAFETY_ANALYSIS` to pre-empt false positives from Clang. -- v8: configure: Enable -Wthread-safety-analysis, -Wthread-safety-attributes warnings. dlls/ntoskrnl.exe: Add thread safety annotations. dlls/combase: Add thread safety annotations. dlls/imm32: Add GUARDED_BY attribute to the struct ime's refcount field. dlls/crypt32: Annotate CRYPT_CollectionAdvanceEnum indicating that the caller should hold the collection store's lock. dlls/amstream/tests: Disable thread safety analysis for testfilter_wait_state. dlls/winhttp: Add thread safety annotations. dlls/mmdevapi: Add thread safety annotations for session_lock and sessions_unlock. dlls/mfplat: Add thread safety annotations. dlls/msi: Add thread safety annotations for msiobj_lock and msiobj_unlock. dlls/xaudio2_7: Add thread safety annotations. dlls/wmvcore: Add thread safety annotations for async_reader_wait_pts, async_reader_deliver_sample, and callback_thread_run. dlls/wininet: Disable thread safety annotations for HTTPREQ_ReadFile and HTTPREQ_QueryDataAvailable. dlls/winegstreamer: Add thread safety annotation for GST_Seeking_SetPositions. dlls/dwrite: Add thread safety annotations for factory_lock and factory_unlock. dlls/wined3d: Add thread safety annotations. lib/vkd3d: Build with WINE_NO_THREAD_SAFETY_ANALYSIS defined. dlls/d2d1: Add thread safety annotations. dlls/xaudio2_7: Disable thread safety analysis for IXAudio2Impl_CreateSourceVoice. dlls/xinput1_3: Add thread safety annotations for controller_lock and controller_unlock. dlls/ucrtbase/tests: Only release &fp.iobuf->_crit if the previous lock was successful (Clang). dlls/netio.sys: Add thread safety annotations for lock_sock and unlock_socket. dlls/msvcirt/tests: Release &sb.lock only if the previous lock was successful (Clang). dlls/wbemprox: Add thread safety annotations. libs/strmbase: Annotate BaseRenderer_Receive to indicate the caller needs to hold the underlying filter lock. dlls/rpcrt4: Add thread safety annotations for AllocateContextHandle, FindContextHandle, ReleaseContextHandle. dlls/wined3d: Add thread safety annotations for allocator locking helpers. dlls/mfreadwrite: Indicate calling source_reader_read_sample requires holding &reader->cs. dlls/mapi32: Add thread safety annotations for GetValue, AddValue, Lock, Unlock. dlls/kernel32/tests: Add thread safety annotations. dlls/combase: Add thread safety annotations programs/services: Add thread safety annotations. dlls/winmm: Add thread safety annotations. dlls/vcomp: Add thread safety annotations. dlls/user32: Add thread safety annotations. dlls/odbc32: Add thread safety annotations. dlls/krnl386.exe16: Add thread safety annotations. dlls/msvcirt: Add thread safety annotations. dlls/msvcp90: Add thread safety annotations. dlls/msvcrt: Add thread safety annotations. dlls/kernelbase: Add thread safety annotations. include/wine/winbase16: Add thread safety annotations for _Enter/LeaveSysLevel dlls/kernelbase: Release console_section in case of an allocation failure in alloc_console. include/winbase.h: Add thread safety annotations for Enter/LeaveCriticalSection, SleepConditionVariableCS and TryEnterCriticalSection. dlls/ntdll: Add thread safety annotations. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/6623

1 1

[PATCH v3 0/7] MR6815: Draft: winex11: Fix dummy ConfigureNotify event generation for embedded windows.
by Rémi Bernon Nov. 14, 2024

Nov. 14, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57370 -- v3: winex11: Always generate ConfigureNotify events for embedded windows. winex11: Generate ConfigureNotify events for the children tree. winex11: Avoid overriding previously received ConfigureNotify events. winex11: Retrieve the HWND for the host window's child window. winex11: Introduce a new host_window_send_configure_events helper. winex11: Reset the window relative position when it gets reparented. winex11: Reset embedded window position to 0x0 before docking it. https://gitlab.winehq.org/wine/wine/-/merge_requests/6815

1 8

Re: [PATCH v5 0/2] MR5633: win32u: Use the first vertical alternates table regardless of script.
by Nikolay Sivov (＠nsivov) Nov. 14, 2024

Nov. 14, 2024

I think the remaining question here is if we want to remove script/lang lookup logic entirely, or instead prioritize. @sgwaki, any idea if it's possible to test that? Testing manually is fine. To be clear, test font should have at least two differing vert features, with second feature being testable with specific script/lang pair, if that is possible to achieve with plain gdi API at all. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633#note_87482

1 0

Re: [PATCH v15 0/1] MR5523: msdelta: Add stubs for ApplyDeltaA() and ApplyDeltaW().
by Alexandre Julliard (＠julliard) Nov. 14, 2024

Nov. 14, 2024

Please don't constantly rebase your MR, it's a waste of CI resources. As far as I can tell it hasn't been confirmed that this actually fixes anything, and it seems unlikely that it would be useful without applying the deltas. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5523#note_87478

1 0

Re: [PATCH v3 0/2] MR4836: ntdll: Implement SystemFirmwareTable_Enumerate in NtQuerySystemInformation
by Alexandre Julliard (＠julliard) Nov. 14, 2024

Nov. 14, 2024

Superseded by 966cec7a634678c4837bbf97f1b42ada3c9523f6 and 6208d61055efa6f9609a4f43cbe7cd74964a27ba. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4836#note_87475

1 0

Re: [PATCH v3 0/2] MR4836: ntdll: Implement SystemFirmwareTable_Enumerate in NtQuerySystemInformation - closed
by Alexandre Julliard (＠julliard) Nov. 14, 2024

Nov. 14, 2024

This merge request was closed by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4836

1 0

[PATCH 0/1] MR6812: server: Don't update cursor pos in (set_window_pos) if windows wasn't moved.
by Paul Gofman (＠gofman) Nov. 14, 2024

Nov. 14, 2024

Fixes a regression introduced by commit db9a4bc66a5ff550a0a25899b6646117f66c50df. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6812

4 4

[PATCH 0/7] MR6815: winex11: Fix dummy ConfigureNotify event generation for embedded windows.
by Rémi Bernon Nov. 14, 2024

Nov. 14, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57370 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6815

1 8

[PATCH 0/1] MR6816: dwrite/layout: Skip to the next typography range when current one has no features.
by Nikolay Sivov (＠nsivov) Nov. 14, 2024

Nov. 14, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57407 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6816

2 1

[PATCH 0/3] MR6814: configure: Use -fms-hotpatch on Clang.
by Jacek Caban (＠jacek) Nov. 14, 2024

Nov. 14, 2024

The `-fms-hotpatch` flag has been available in Clang since version 14, but it was broken before version 18 (e.g., it could crash on some files when using CI’s Clang). Unfortunately, I couldn’t find a reliable way to check for this in configure, hence the convoluted workaround. The flag is supported on both 32-bit and 64-bit x86 architectures. It ensures that the first instruction of a function is at least 2 bytes long at the compiler level and adds additional padding during linking. However, there is a limitation: when the compiler emits multiple functions in a single `.text` section, those functions are not padded. This differs from MSVC, where the compiler handles such padding. Using `-ffunction-sections` mitigates this issue. While we could limit the use of `-ffunction-sections` to specific cases, it appears beneficial overall. It allows the linker to GC unused functions, which is helpful when linking against static libraries that include both used and unused functions in the same file. This is already the default on ARM64EC, so it makes things more consistent across targets. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6814

2 3