November 2024 - Wine-GitLab

[PATCH 0/5] MR6804: win32u: Implement display settings virtualization.
by Rémi Bernon Nov. 12, 2024

Nov. 12, 2024

This completes the implementation of display setting virtualization using DPI scaling, ie: Proton fshack done right. There's various things to tweak still, and this will stay as an experimental feature with X11 (Wayland actually needs it to implement display mode change so it's as experimental as the driver): - Fullscreen windows aren't padded when the display mode aspect ratio doesn't match the physical one. - Dragging a window over another monitor with a different raw DPI is broken, and window dimensions may flicker/break, this will need the winex11 window configure refactoring (ie: https://gitlab.winehq.org/wine/wine/-/merge_requests/6731 and the other changes in https://gitlab.winehq.org/wine/wine/-/merge_requests/6569) to be fixed. - DPI scaling is implemented with NtGdiStretchBlt, which is suboptimal, may not be performing well, and present sync is reportedly broken with GL/VK. - A couple of other more minor tweaks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6804

2 6

[PATCH 0/1] MR6805: winewayland: Fix surface scaling with HiDPI compositor.
by Rémi Bernon Nov. 12, 2024

Nov. 12, 2024

The surface scale is there to match between the Wine DPI and the compositor scaling, not to implement Wine DPI scaling, ie: when compositor scaling is set to 200% and Wine DPI is also set to 192, windows are shown at 1:1 scale, instead of being upscaled twice. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6805

1 1

[PATCH v2 0/4] MR6799: Draft: taskschd: IRepetitionPattern implementation
by Vijay Kiran Kamuju (＠infyquest) Nov. 12, 2024

Nov. 12, 2024

-- v2: taskschd: Implement IRepetitionPattern_get_Duration(). taskschd: Implement IRepetitionPattern_get_Interval(). taskschd: Implement IRepetitionPattern_get_StopAtDurationEnd(). https://gitlab.winehq.org/wine/wine/-/merge_requests/6799

3 5

[PATCH v2 0/6] MR6776: d3dx9: D3DXSaveSurfaceToFileInMemory() refactoring, part 1.
by Connor McAdams (＠cmcadams) Nov. 12, 2024

Nov. 12, 2024

This is the first of 3 planned MRs reworking how `D3DXSaveSurfaceToFileInMemory()` functions, starting with DDS files. -- v2: d3dx9: Add support for saving paletted surfaces to DDS files. d3dx9: Set the DDSCAPS_ALPHA flag when saving DDS files with a pixel format containing an alpha channel. d3dx9: Improve save_dds_surface_to_memory(). d3dx9/tests: Add more tests for saving surfaces as DDS files. d3dx9: Don't attempt to save palettized surfaces in D3DXSaveSurfaceToFileInMemory(). d3dx9/tests: Include ddraw.h in surface.c for DDS header flag definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/6776

3 19

[PATCH v26 0/7] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) Nov. 12, 2024

Nov. 12, 2024

-- v26: wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add stubs for IMap<HSTRING, IInspectable *>, IObservableMap<HSTRING, IInspectable *>, IIterable<IKeyValuePair<HSTRING, IInspectable *>> to PropertySet implementation. wintypes: Add stub for Windows.Foundation.Collections.PropertySet. wintypes/tests: Add conformance tests for Windows.Foundation.Collections.PropertySet. include: Add Windows.Foundation.Collections.PropertySet runtime class. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

3 8

[PATCH v2 0/1] MR6698: wined3d: Check that format_id is >= 0 before assuming it's an index.
by Rémi Bernon Nov. 12, 2024

Nov. 12, 2024

Some FOURCC values such as 0xdeadbeef will en up being negative when cast to the enum type, and may cause a random crash later on. This happens randomly in the ddraw tests, depending on the compiler being used. -- v2: wined3d: Cast format_id when comparing it to the last format index. https://gitlab.winehq.org/wine/wine/-/merge_requests/6698

1 2

[PATCH 0/1] MR6781: dinput: Keep the module around while input thread is running.
by Yuxuan Shui (＠yshui) Nov. 12, 2024

Nov. 12, 2024

So we don't crash if the application unloads dinput. This can only happen if the application didn't release all dinput objects before unloading the module, which we have observed the Yakuza games to do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6781

3 3

[PATCH 0/1] MR6800: winegstreamer: Lock the media source critical section while using the event queue.
by Conor McCarthy (＠cmccarthy) Nov. 12, 2024

Nov. 12, 2024

These changes are the documented way to implement IMFMediaEventGenerator for a media source. Avoiding using a destroyed event queue is the only reason to lock the CS that I can find. On top of !6783 it seems to resolve hanging while switching characters in Killsquad (not decisively proven though). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6800

3 3

[PATCH v25 0/7] MR6766: dlls/wintypes: Add stubs for Windows.Foundation.Collections.PropertySet.
by Vibhav Pant (＠vibhavp) Nov. 12, 2024

Nov. 12, 2024

-- v25: wintypes: Add stubs for IKeyValuePair<HSTRING, IInspectable *>. wintypes: Add stubs for IIterator<IKeyValuePair<HSTRING, IInspectable *>>. wintypes: Add stubs for IMapView<HSTRING, IInspectable *>. wintypes: Add stubs for IMap<HSTRING, IInspectable *>, IObservableMap<HSTRING, IInspectable *>, IIterable<IKeyValuePair<HSTRING, IInspectable *>> to PropertySet implementation. wintypes: Add stub for Windows.Foundation.Collections.PropertySet. wintypes/test: Add conformance tests for Windows.Foundation.Collections.PropertySet. include: Add Windows.Foundation.Collections.PropertySet runtime class. https://gitlab.winehq.org/wine/wine/-/merge_requests/6766

5 19

[PATCH v5 0/4] MR6767: WriteProcessMemory() without PROCESS_QUERY_INFORMATION access right.
by eric pouech (＠epo) Nov. 12, 2024

Nov. 12, 2024

This is an alternate solution to MR 6761 [1] (actually is based on comment in that MR). WriteProcessMemory() should succeed when process handle doesn't have PROCESS_QUERY_INFORMATION access right set (test attached). Plus some additional cleanup in test for ReadProcessMemory(). Feedback from Proton says that this patch solves the reported game issue. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/6761 -- v5: server: Amend process rights mapping. advapi32: Test some other cases of process access rights mapping. advapi32/tests: Fix typo in manifest constant. kernel32/tests: Don't hardcode page size in buffer size. https://gitlab.winehq.org/wine/wine/-/merge_requests/6767

3 6