December 2024 - Wine-GitLab

[PATCH v7 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) Feb. 14, 2025

Feb. 14, 2025

Fixes this bug: https://bugs.winehq.org/show_bug.cgi?id=56068 Note that `is_key_hit` is virtually identical to `_kbhit`, except that the `for` loop runs until `count` instead of `count - 1`. This is needed because otherwise, it misses the last event. Is `_kbhit`'s current behavior intended, or is it a bug? -- v7: timeout: Add new program. https://gitlab.winehq.org/wine/wine/-/merge_requests/5691

5 9

[PATCH v2 0/2] MR6006: dwmapi: Simulate DwmFlush blocking behavior.
by Grazvydas Ignotas (＠notaz) Feb. 14, 2025

Feb. 14, 2025

The documentation states it's a blocking call. There are reports of it being used for WaitForVBlank-like purposes [1]. Without blocking Softube VST plugin logic breaks and they never update their UIs. [1] https://news.ycombinator.com/item?id=34501612 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56935 -- v2: dwmapi: Simulate DwmFlush blocking behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/6006

5 10

[PATCH 0/1] MR6740: include: Add windows.graphics.directx.direct3d11.interop.h
by Biswapriyo Nath (＠Biswa96) Feb. 9, 2025

Feb. 9, 2025

Required for https://webrtc.googlesource.com/src/+/2aad81259ef832172d65aeaba6401fee857a0… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6740

3 4

[PATCH v6 0/5] MR6889: threadpoolwinrt: Implement IAsyncAction and IAsyncInfo.
by Vibhav Pant (＠vibhavp) Feb. 1, 2025

Feb. 1, 2025

This MR adds an implementation for the `IAsyncAction` and `IAsyncInfo` interfaces exported by `Windows.System.Threading`, including support for setting `IAsyncActionCompletedHandler` values for an `IAsyncAction`. It also re-writes (or factors?) the `IAsyncOperation<boolean>` implementation in dlls/cryptowinrt to use `ThreadPoolStatics::RunAsync`, by introducing a type-punning variant of `AsyncOperationCompletedHandler<T>` (similar to `WineAsyncOperationCompletedHandler`), which is a wrapper around the `IAsyncAction` returned by `RunAsync`. The new `IAsyncOperation<T>` implementation is simpler, and if merged, can be exported to other dlls (windows.gaming.input and windows.security.credentials.ui.userconsentverifier for now). -- v6: cryptowinrt: Rewrite IAsyncOperation using Windows.System.Threading. https://gitlab.winehq.org/wine/wine/-/merge_requests/6889

3 9

[PATCH v5 0/1] MR246: Allow renaming a file/directory to a different case of itself
by Gabriel Ivăncescu Jan. 31, 2025

Jan. 31, 2025

-- v5: ntdll: Allow renaming a file/directory to a different case of itself. https://gitlab.winehq.org/wine/wine/-/merge_requests/246

2 9

[PATCH 0/1] MR7084: inetcpl: Make security zone names and descriptions translatable.
by Alex Henrie (＠alexhenrie) Jan. 28, 2025

Jan. 28, 2025

Windows ignores the names and descriptions in the registry when populating the Security tab in Internet Options. Do the same in Wine. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=27245 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7084

4 6

[PATCH v7 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) Jan. 28, 2025

Jan. 28, 2025

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v7: ntdll: Update NtQueryDirectoryFile to purge cache if scan is reset with a new mask ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

5 19

[PATCH 0/1] MR3109: imm32: Don't export internal variables.
by Alex Henrie (＠alexhenrie) Jan. 24, 2025

Jan. 24, 2025

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3109

6 22

[PATCH 0/6] MR6849: quartz: Simplify DirectSound Renderer Filter sample handling.
by Rémi Bernon Jan. 24, 2025

Jan. 24, 2025

This has been in Proton for two years at least, it helped reduce buffer underruns and induced cracking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6849

2 9

[PATCH 0/2] MR6679: winetest: Compress embedded test executables.
by Rémi Bernon Jan. 24, 2025

Jan. 24, 2025

Reducing `winetest.exe` size from ~240MB to ~80MB. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6679

2 6