December 2024 - Wine-GitLab

[PATCH 0/1] MR7025: winex11: Sync gl drawable outside of the win_data mutex.
by Rémi Bernon Dec. 16, 2024

Dec. 16, 2024

Some thread might be destroying a window, calling destroy_client_window from release_gl_drawable, holding the GL context mutex and trying to enter the win_data mutex. At the same time, another thread might be moving its window, calling sync_gl_drawable from X11DRV_WindowPosChanged, holding the win_data mutex and trying to enter the GL context mutex. The deadlock was present before already, although less frequently triggered as sync_gl_drawable was done conditionally if the client window has been moved. This triggers now more frequently in the dxgi:dxgi tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7025

1 1

[PATCH v6 0/2] MR7023: Draft: ntdll: Fix SetCurrentDirectory behaviour on trailing periods
by Lois Gomez (＠loisgomez) Dec. 16, 2024

Dec. 16, 2024

**Context:** Vanguard Saga of Heroes is an MMORPG that was closed years ago by SOE. However the game is still alive in the emulator scene at https://vgoemulator.net/ The game seems to have relied on an old behaviour of the function SetCurrentDirectoryW( LPCWSTR dir ) which currently crashes the game. This patch was derived from a solution discovered by the community at https://vgoemulator.net/phpBB3/viewtopic.php?t=5563 It was previously reported to wine bugzilla in this bug report. https://bugs.winehq.org/show_bug.cgi?id=34285 **Summary of changes:** Updates the function RtlSetCurrentDirectory_U to remove any trailing "." as the documented behaviour of the setCurrentDirectory function is to resolve the trailing period to the directory itself Previously the game will set the current directory as "bin\\." and subsequently crash when trying to access it as it is being returned as "bin\\.Caches". After this change It will correctly set the directory to "bin\Caches" and run successfully **Notes:** This is my first contribution to the project so I might be making a lot of incorrect assumptions on how this might affect other binaries. Please do let me know if there is a better way to implement a change like this in the codebase. Thanks for your help -- v6: add tests for RtlSetCurrentDirectory_U https://gitlab.winehq.org/wine/wine/-/merge_requests/7023

3 3

[PATCH v5 0/1] MR7023: Draft: ntdll: Fix SetCurrentDirectory behaviour on trailing periods
by Lois Gomez (＠loisgomez) Dec. 16, 2024

Dec. 16, 2024

**Context:** Vanguard Saga of Heroes is an MMORPG that was closed years ago by SOE. However the game is still alive in the emulator scene at https://vgoemulator.net/ The game seems to have relied on an old behaviour of the function SetCurrentDirectoryW( LPCWSTR dir ) which currently crashes the game. This patch was derived from a solution discovered by the community at https://vgoemulator.net/phpBB3/viewtopic.php?t=5563 It was previously reported to wine bugzilla in this bug report. https://bugs.winehq.org/show_bug.cgi?id=34285 **Summary of changes:** Updates the function RtlSetCurrentDirectory_U to remove any trailing "." as the documented behaviour of the setCurrentDirectory function is to resolve the trailing period to the directory itself Previously the game will set the current directory as "bin\\." and subsequently crash when trying to access it as it is being returned as "bin\\.Caches". After this change It will correctly set the directory to "bin\Caches" and run successfully **Notes:** This is my first contribution to the project so I might be making a lot of incorrect assumptions on how this might affect other binaries. Please do let me know if there is a better way to implement a change like this in the codebase. Thanks for your help -- v5: kernelbase: Workaound for SetCurrentDirectoryW misuse https://gitlab.winehq.org/wine/wine/-/merge_requests/7023

3 2

[PATCH v3 0/1] MR7023: kernelbase: Workaround for SetCurrentDirectoryW misuse in Vanguard: Saga of Heroes
by Lois Gomez (＠loisgomez) Dec. 16, 2024

Dec. 16, 2024

**Context:** Vanguard Saga of Heroes is an MMORPG that was closed years ago by SOE. However the game is still alive in the emulator scene at https://vgoemulator.net/ The game seems to have relied on an old behaviour of the function SetCurrentDirectoryW( LPCWSTR dir ) which currently crashes the game. This patch was a solution discovered by the community at https://vgoemulator.net/phpBB3/viewtopic.php?t=5563 It was previously reported to wine bugzilla in this bug report. https://bugs.winehq.org/show_bug.cgi?id=34285 **Summary of changes:** Updates the function SetCurrentDirectoryW( LPCWSTR dir ) to remove any trailing "." Previously the game will set the current directory as "bin\\." and subsequently crash when accessing "bin\\.Caches". It will now access "bin\Caches" and run successfully **Notes:** This is my first contribution to the project so I might be making a lot of incorrect assumptions on how this might affect other binaries. Please do let me know if there is a better way to implement a change like this in the codebase. Thanks for your help -- v3: kernelbase: Workaound for SetCurrentDirectoryW misuse https://gitlab.winehq.org/wine/wine/-/merge_requests/7023

3 2

[PATCH v4 0/1] MR7023: ntdll: Fix SetCurrentDirectory behaviour on trailing periods
by Lois Gomez (＠loisgomez) Dec. 16, 2024

Dec. 16, 2024

**Context:** Vanguard Saga of Heroes is an MMORPG that was closed years ago by SOE. However the game is still alive in the emulator scene at https://vgoemulator.net/ The game seems to have relied on an old behaviour of the function SetCurrentDirectoryW( LPCWSTR dir ) which currently crashes the game. This patch was a solution discovered by the community at https://vgoemulator.net/phpBB3/viewtopic.php?t=5563 It was previously reported to wine bugzilla in this bug report. https://bugs.winehq.org/show_bug.cgi?id=34285 **Summary of changes:** Updates the function SetCurrentDirectoryW( LPCWSTR dir ) to remove any trailing "." Previously the game will set the current directory as "bin\\." and subsequently crash when accessing "bin\\.Caches". It will now access "bin\Caches" and run successfully **Notes:** This is my first contribution to the project so I might be making a lot of incorrect assumptions on how this might affect other binaries. Please do let me know if there is a better way to implement a change like this in the codebase. Thanks for your help -- v4: kernelbase: Workaound for SetCurrentDirectoryW misuse https://gitlab.winehq.org/wine/wine/-/merge_requests/7023

2 1

Re: [PATCH v2 0/7] MR6911: ntdll: Add WaitCompletionPacket.
by Zhiyi Zhang (＠zhiyi) Dec. 16, 2024

Dec. 16, 2024

> NtAssociateWaitCompletionPacket() initiates an asynchronous wait on the object handle. When the wait is done (the object is signaled), it queues a completion to the associated I/O completion port. Make sense. I will revisit this MR after the code freeze. > Maybe, in the particular case of React Native, it only uses WaitCompletionPacket on manual reset events or other objects with no-op satisfied()? FWIW I couldn't find any reference to NtAssociateWaitCompletionPacket in https://github.com/facebook/react-native. I am testing a React Native sample application. If I remember correctly, the NtAssociateWaitCompletionPacket() is from some Microsoft DLL, coremessagingxp.dll. I didn't look into the type of object it waits on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6911#note_90563

1 0

[PATCH v6 0/4] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) Dec. 16, 2024

Dec. 16, 2024

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This test has been updated to only allow current Windows behaviour, and `NtQueryDirectoryFile` will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE` as appropriate. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. -- v6: ntdll: Simplify check that unexpected files were not found https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

4 8

Re: [PATCH v2 0/2] MR6990: win32u, server: Fix some window surface shape sometimes not being updated.
by darkblaze69 (＠darkblaze69) Dec. 15, 2024

Dec. 15, 2024

Unfortunately this (ce7b293c5b29111d256f5416bb44a6c77d6ef673) broke some dialogs: https://bugs.winehq.org/show_bug.cgi?id=57551 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6990#note_90561

1 0

[PATCH v2 0/1] MR7023: kernelbase: Workaround for SetCurrentDirectoryW misuse in Vanguard: Saga of Heroes
by Lois Gomez (＠loisgomez) Dec. 15, 2024

Dec. 15, 2024

Context: Vanguard Saga of Heroes is an MMORPG that was closed years ago by SOE. However the game is still alive in the emulator scene at https://vgoemulator.net/ The game seems to have relied on an old behaviour of the function SetCurrentDirectoryW( LPCWSTR dir ) which currently crashes the game. This patch was a solution discovered by the community at https://vgoemulator.net/phpBB3/viewtopic.php?t=5563 It was previously reported to wine bugzilla in this bug report. https://bugs.winehq.org/show_bug.cgi?id=34285 Summary of changes: Updates the function SetCurrentDirectoryW( LPCWSTR dir ) to remove any trailing "." Previously the game will set the current directory as "bin\." and subsequently crash when accessing "bin\.Caches". It will now access "bin\Caches" and run successfully Notes: This is my first contribution to the project so I might be making a lot of incorrect assumptions on how this might affect other binaries. Please do let me know if there is a better way to implement a change like this in the codebase. Thanks for your help -- v2: kernelbase: Workaound for SetCurrentDirectoryW misuse https://gitlab.winehq.org/wine/wine/-/merge_requests/7023

4 4

[PATCH 0/2] MR7024: Disable native titlebar while lacking enough space for SM_CYCAPTION.
by Jactry Zeng (＠jactry) Dec. 15, 2024

Dec. 15, 2024

On Windows, applications can disable titlebar by extending the client rect to a bigger rect which will cover the area of the titlebar from WM_NCCALCSIZE: https://learn.microsoft.com/en-us/windows/win32/dwm/customframe#removing-th… Our current x11 and Mac driver doesn't handle this case. Attached is a test case for reproducing the issue. [hide_caption.c](/uploads/46a725e32569a6a0a929a0f183cf9ed8/hide_caption.c) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7024

3 3