February 2024 - Wine-GitLab

[PATCH v3 0/9] MR4954: kernelbase: Reimplement UrlCanonicalize().
by Zebediah Figura (＠zfigura) Feb. 6, 2024

Feb. 6, 2024

Normally I am a strong proponent of adjusting implementations one small step at a time, but this is a bit of an extreme case. The current state of UrlCanonicalize() is a prototypical example of "spaghetti code": the implementation has been repeatedly adjusted to fix a new discovered edge case, without properly testing the scope of the new logic, with the effect that the current logic is a scattered mess of conditions that interact in unpredictable ways. To be fair, the actual function is much more complicated than one would anticipate, and the number of new weird edge cases I found while trying to flesh out existing logic was rather exhausting. I initially tried to "fix" the existing implementation one step at a time. After racking up dozens of commits without an end in sight, though, and having to waste time carefully unravelling the broken code in the right order so as to avoid temporary failures, I decided instead to just fix everything at once, effectively rewriting the function from scratch, and this proved to be much more productive. Hopefully the huge swath of new tests is enough to prove that this new implementation really is correct, and has no more spaghetti than what Microsoft made necessary. -- v3: shlwapi/tests: Add many more tests for UrlCanonicalize(). kernelbase: Use scheme_is_opaque() in UrlIs(). kernelbase: Reimplement UrlCanonicalize(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4954

4 12

[PATCH 0/2] MR5033: mf/tests: Test missing display aperture attribute on transform output types.
by Rémi Bernon Feb. 6, 2024

Feb. 6, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5033

2 3

[PATCH v2 0/3] MR4956: wined3d: Two fixes for SPECULARENABLE.
by Zebediah Figura (＠zfigura) Feb. 6, 2024

Feb. 6, 2024

Found while refactoring FFP code; no known application is affected. -- v2: wined3d/glsl: Pass through the specular varying when SPECULARENABLE is FALSE. wined3d/glsl: Always set WINED3D_SHADER_CONST_FFP_LIGHTS in FFP constant update masks. d3d8/tests: Add more tests for SPECULARENABLE. https://gitlab.winehq.org/wine/wine/-/merge_requests/4956

4 5

[PATCH 0/3] MR629: vkd3d-shader/dxil: Implement DX intrinsic GetDimensions.
by Conor McCarthy (＠cmccarthy) Feb. 6, 2024

Feb. 6, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/629

3 5

[PATCH v2 0/2] MR5033: mf/tests: Test missing display aperture attribute on transform output types.
by Rémi Bernon Feb. 6, 2024

Feb. 6, 2024

-- v2: mf/tests: Add some tests with video processor aperture handling. mf/tests: Report more transform current type mismatches. https://gitlab.winehq.org/wine/wine/-/merge_requests/5033

1 3

[PATCH 0/3] MR5032: server: Use different structures for hardware input and rawinput messages.
by Rémi Bernon Feb. 6, 2024

Feb. 6, 2024

Mostly split from https://gitlab.winehq.org/wine/wine/-/merge_requests/4946. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5032

1 3

[PATCH 0/1] MR5025: explorer: Don't pop start menu on "minimize all windows" systray command.
by Paul Gofman (＠gofman) Feb. 6, 2024

Feb. 6, 2024

Fixes "True Reporter. Mystery of Mistwood" broken startup from launcher when the launcher wants to minimize all windows (which is probably not strictly necessary) but we instead pop Start menu. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5025

3 2

[PATCH v2 0/2] MR618: vkd3d-shader/dxil: Hyperbolic trigonometry.
by Conor McCarthy (＠cmccarthy) Feb. 6, 2024

Feb. 6, 2024

-- v2: vkd3d-shader/dxil: Handle hyperbolic trigonometric functions in sm6_parser_emit_dx_unary(). tests/shader-runner: Add hyperbolic trigonometry tests. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/618

3 3

[PATCH 0/1] MR5030: wbemprox: Add property 'ClassGuid' to Win32_PnPEntity.
by Louis Lenders (＠xe) Feb. 6, 2024

Feb. 6, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56291 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5030

3 4

[PATCH v2 0/4] MR4613: Std handles' flags when inheriting.
by eric pouech (＠epo) Feb. 6, 2024

Feb. 6, 2024

This series' main purpose is to fix the handles' attributes of standard I/O handles in CreateProcess. Needed behavior in CreateProcess is implemented by supporting the DUPLICATE_SAME_ATTRIBUTES option in NtDuplicateObject() and DuplicateHandle(). This option is not documented in SDK, but is in DDK. Manifest constant has been added to DDK header (maybe now Wine's DUPLICATE_MAKE_GLOBAL could be moved here to). -- v2: server: Preserve handle flags when inheriting a std handle. server: Implement support for DUPLICATE_SAME_ATTRIBUTES in DuplicateHandle(). kernel32/tests: Test DUPLICATE_SAME_ATTRIBUTES flag in DuplicateHandle(). kernel32: Added tests about std handle flags inheritance. https://gitlab.winehq.org/wine/wine/-/merge_requests/4613

2 4