March 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/2] MR5240: winegstreamer: Set AvgTimePerFrame in GetOutputType() for WMV decoder.
by Alfred Agrell (＠Alcaro) March 25, 2024

March 25, 2024

Just ran into this issue in the Proton 9 beta. Thanks for fixing it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5240#note_66059

1 0

Re: [PATCH v2 0/1] MR5396: gdi32/emf: Zero-initialize handles array (Valgrind). - approved
by Alexandre Julliard (＠julliard) March 25, 2024

March 25, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5396

1 0

Re: [PATCH v2 0/3] MR5130: mfmediaengine: Implement IMFMediaEngineEx::SetCurrentTime/Ex(). - approved
by Alexandre Julliard (＠julliard) March 25, 2024

March 25, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5130

1 0

Re: [PATCH v4 0/5] MR5297: evr/mixer: Respect input media type MF_MT_MINIMUM_DISPLAY_APERTURE. - approved
by Alexandre Julliard (＠julliard) March 25, 2024

March 25, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5297

1 0

Re: [PATCH v3 0/1] MR5391: crypt32: Fix CryptBinaryToStringA not adding a separator. - approved
by Alexandre Julliard (＠julliard) March 25, 2024

March 25, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5391

1 0

Re: [PATCH v2 0/1] MR5393: d2d1: Fix a double free on error path (Valgrind). - approved
by Alexandre Julliard (＠julliard) March 25, 2024

March 25, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5393

1 0

Re: [PATCH v2 0/1] MR5395: dwrite/shape: Fully initialize shaping context when getting glyph positions (Valgrind). - approved
by Alexandre Julliard (＠julliard) March 25, 2024

March 25, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5395

1 0

Re: [PATCH v2 0/1] MR5398: configure: Quote ac_cv_lib_soname_MoltenVK when setting SONAME_LIBVULKAN. - approved
by Alexandre Julliard (＠julliard) March 25, 2024

March 25, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5398

1 0

[PATCH v3 0/5] MR5385: winebus: ignore udev events of devices which do not have devnodes
by Tuomas Räsänen March 25, 2024

March 25, 2024

Udev monitor monitors the whole input subsystem, but not all devices in the input subsystem have devnodes associated to them. This MR makes the event processing ignore such devices. All device handling assumes devices have devnodes, so here we just simply ignore all devices which do not have one. They are irrelevant. Previously, udev bus thread aborted when an event for a device without a devnode was processed: ``` 10111.330:0068:0084:trace:hid:process_monitor_event Received action "remove" for udev device (null) 10111.330:0068:0084:warn:hid:bus_main_thread L"UDEV" bus wait returned status 0xc0000005 ``` Just plugging in and out a normal mouse was enough cause this. This was because root input devices (which do not have devnodes) were handled too and `find_device_from_devnode()` choked on NULL argument. -- v3: winebus: change debugging class of an error case from WARN to ERR. winebus: change debugging class of an error case from FIXME to ERR winebus: group local variable declarations winebus: ignore udev events of devices which do not have devnodes winebus: log ERR if find_device_from_devnode() somehow gets called with NULL https://gitlab.winehq.org/wine/wine/-/merge_requests/5385

3 9

[PATCH v2 0/3] MR5385: winebus: ignore udev events of devices which do not have devnodes
by Tuomas Räsänen March 25, 2024

March 25, 2024

Udev monitor monitors the whole input subsystem, but not all devices in the input subsystem have devnodes associated to them. This MR makes the event processing ignore such devices. All device handling assumes devices have devnodes, so here we just simply ignore all devices which do not have one. They are irrelevant. Previously, udev bus thread aborted when an event for a device without a devnode was processed: ``` 10111.330:0068:0084:trace:hid:process_monitor_event Received action "remove" for udev device (null) 10111.330:0068:0084:warn:hid:bus_main_thread L"UDEV" bus wait returned status 0xc0000005 ``` Just plugging in and out a normal mouse was enough cause this. This was because root input devices (which do not have devnodes) were handled too and `find_device_from_devnode()` choked on NULL argument. -- v2: winebus: group local variable declarations https://gitlab.winehq.org/wine/wine/-/merge_requests/5385

3 4