March 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v6 0/5] MR4971: comdlg32: Fix item data in resolutions combobox.
by Brendan McGrath (＠redmcg) March 11, 2024

March 11, 2024

On Fri Mar 8 07:56:39 2024 +0000, Huw Davies wrote: > ```suggestion:-0+0 > } > /* FALLTHROUGH */ > ``` > The commit message could be better, e.g. > ``` > comdlg32: Don't treat cmb1 as the printer list unless in PRINT_SETUP. > This changes WMCommandW to match WMCommandA. > ``` > Essentially swapping the subject with the sentence in the body. Fixed. Thanks Huw. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4971#note_64269

1 0

[PATCH 0/1] MR5225: shell32: Construct the proper path target for UnixFolder.
by Gabriel Ivăncescu March 11, 2024

March 11, 2024

Currently, if you try to parse unix path, it simply crashes. See this test: ```c static void test_desktop_folder(void) { static WCHAR slash[] = { '/',0 }; IShellFolder *psf; ITEMIDLIST *pidl; DWORD eaten; HRESULT hr; hr = SHGetDesktopFolder(&psf); ok(hr == S_OK, "Got %lx\n", hr); hr = IShellFolder_QueryInterface(psf, &IID_IShellFolder, NULL); ok(hr == E_POINTER, "Got %lx\n", hr); hr = IShellFolder_ParseDisplayName(psf, NULL, NULL, slash, &eaten, &pidl, NULL); ok(hr == S_OK /* wine */ || hr == E_INVALIDARG, "IShellFolder::ParseDisplayName returned 0x%08lx\n", hr); if(hr == S_OK) ILFree(pidl); IShellFolder_Release(psf); } ``` I didn't add it to the patch because it has a wine-specific success here, due to unix integration, I'm not sure if that's allowed in tests? I'd be happy to add this as an actual test otherwise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5225

1 2

[PATCH v2 0/1] MR5280: include: Add Windows.UI.ViewManagement.UIViewSettings definitions.
by Vijay Kiran Kamuju (＠infyquest) March 11, 2024

March 11, 2024

-- v2: include: Add Windows.UI.ViewManagement.UIViewSettings definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/5280

3 2

[PATCH v2 0/1] MR703: vkd3d: Enable VK_EXT_fragment_shader_interlock if available.
by Henri Verbeet (＠hverbeet) March 11, 2024

March 11, 2024

-- v2: vkd3d: Enable VK_EXT_fragment_shader_interlock if available. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/703

3 3

[PATCH 0/1] MR702: vkd3d-shader/glsl: Use location information from the current instruction.
by Henri Verbeet (＠hverbeet) March 11, 2024

March 11, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/702

3 3

[PATCH v3 0/5] MR700: tests: Do some housekeeping for Vulkan implementations nobody loves.
by Giovanni Mascellani (＠giomasce) March 11, 2024

March 11, 2024

-- v3: tests: Clear the UAV before testing. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/700

3 6

[PATCH v14 0/4] MR519: vkd3d-shader/dxil: Support minimum precision.
by Conor McCarthy (＠cmccarthy) March 11, 2024

March 11, 2024

-- v14: vkd3d-shader/dxil: Support 16-bit types. vkd3d-shader/spirv: Introduce HALF and UINT16 types for minimum precision. vkd3d-shader/spirv: Introduce a data_type_is_floating_point() helper function. tests/shader-runner: Add tests for minimum-precision constants. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519

3 5

[PATCH v3 0/2] MR4443: Do not release media session topologies until the media session is shutdown.
by Santino Mazza (＠tati1454) March 11, 2024

March 11, 2024

-- v3: mf/test: Check the topologies id's in topo loader. https://gitlab.winehq.org/wine/wine/-/merge_requests/4443

4 12

[PATCH v2 0/4] MR5279: wineserver crash resistance against permanent object deletion, part 1: Implement NtMakePermanentObject.
by Jinoh Kang (＠iamahuman) March 11, 2024

March 11, 2024

Mainly useful for restoring objects marked temporary for test (see MR !5268). -- v2: ntdll: Implement NtMakePermanentObject. server: Generalize server request make_temporary to set_object_permanance. ntdll/tests: Add tests for NtMakeTemporaryObject. ntdll/tests: Add tests for OBJ_PERMANENT object attribute. https://gitlab.winehq.org/wine/wine/-/merge_requests/5279

3 5

[PATCH 0/1] MR5280: include: Add Windows.UI.ViewManagement.UIViewSettings definitions.
by Vijay Kiran Kamuju (＠infyquest) March 11, 2024

March 11, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5280

3 2