April 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/2] MR737: vkd3d-shader/ir: Open a loop when visiting the loop header. - approved
by Henri Verbeet (＠hverbeet) April 3, 2024

April 3, 2024

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/737

1 0

[PATCH v3 0/2] MR743: ci: Run tests on llvmpipe from Mesa 24.0.3.
by Giovanni Mascellani (＠giomasce) April 3, 2024

April 3, 2024

The Mesa version in Debian bookworm (22.3.6) we use for testing is now a bit outdated. While it's valuable to test on older drivers because they might be more representative of what users are running, it's also useful to test on recent drivers, which gives a less noisy signal to developers. For the moment we enable it only for llvmpipe, because RADV is already passing all the tests anyway. And we don't bother with 32 bit here. On llvmpipe using Mesa 24 fixes three shader runner tests. -- v3: ci: Make llvmpipe from Mesa 24.0.3 available in the CI image. ci: Run tests on llvmpipe from Mesa 24.0.3. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/743

2 3

Re: [PATCH v3 0/2] MR737: vkd3d-shader/ir: Open a loop when visiting the loop header. - approved
by Conor McCarthy (＠cmccarthy) April 3, 2024

April 3, 2024

This merge request was approved by Conor McCarthy. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/737

1 0

Re: [PATCH v4 0/2] MR742: vkd3d-shader/fx: Add an option to include empty buffers in the effect binary.
by Giovanni Mascellani (＠giomasce) April 3, 2024

April 3, 2024

> > Would it make sense to start namespacing options that only apply to some shader types or profiles? For example using `--fx-include-empty-buffers` or even `--fx4-include-empty-buffers`. Not necessarily this time, but maybe start thinking about it. Also for HLSL options, for example: `--hlsl-profile` and `--hlsl-semantic-compat-map` instead of what we have now. > > Broadly yes, although I don't think we should just remove the existing options; at best we could deprecate them and remove them from --help. Sure, it wouldn't be appropriate to break command lines that now work, so the current options could be added as aliases of the prefixed ones. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/742#note_66784

1 0

[PATCH v5 0/3] MR722: vkd3d-shader/ir: Synthesize selection constructs from conditional jumps.
by Giovanni Mascellani (＠giomasce) April 3, 2024

April 3, 2024

~~This applies on top of !711, the last three commits belong here.~~ This MR and the following ones will introduce a number of optimization passes on the structured representation of the shader, with the goal of fixing the idiosyncrasies of the code generated by the new structurizer. The general pattern is that we want to recognize when the combination of loops and jumps can be rather written with selection constructs. Ideally that should bring to removing all the synthesized loop intervals, but that cannot be guaranteed in general. We still want to do remove all the loops we can, first to make the generated code easier to read and to recompile, and second because having fewer loops also means that more multilevel jumps become ordinary single level jumps, which do not require overhead to be represented in SPIR-V. -- v5: vkd3d-shader/ir: Synthesize selection constructs from conditional jumps. vkd3d-shader/ir: Remove trailing `continue's. vkd3d-shader/ir: Move `continue's to the false branch when possible. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/722

2 3

[PATCH v4 0/5] MR749: vkd3d-shader/ir: Minimise temp usage.
by Conor McCarthy (＠cmccarthy) April 3, 2024

April 3, 2024

Overall this is simpler, results in less verbose SPIR-V code which is easier to debug, and eliminates stuttering issues in Horizon Zero Dawn when run in an SM 6 dev branch with Gio's cfg4 structuriser branch. -- v4: vkd3d-shader/ir: Materialise SSAs to temps before lowering switch instructions. vkd3d-shader/ir: Convert SSAs to temps only if the block of origin does not dominate all uses. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/749

2 5

[PATCH 0/4] MR5446: d2d1/effect: Implement more builtin transform types.
by Nikolay Sivov (＠nsivov) April 3, 2024

April 3, 2024

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5446

2 4

[PATCH v3 0/3] MR750: vkd3d-shader/dxil: TGSM part 3.
by Conor McCarthy (＠cmccarthy) April 2, 2024

April 2, 2024

-- v3: vkd3d-shader/spirv: Ensure the data register is UINT in spirv_compiler_emit_store_tgsm(). vkd3d-shader/spirv: Bitcast if necessary in spirv_compiler_emit_store_dst_components(). vkd3d-shader/dxil: Support constexpr GEP. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/750

2 3

[PATCH v3 0/5] MR749: vkd3d-shader/ir: Minimise temp usage.
by Conor McCarthy (＠cmccarthy) April 2, 2024

April 2, 2024

Overall this is simpler, results in less verbose SPIR-V code which is easier to debug, and eliminates stuttering issues in Horizon Zero Dawn when run in an SM 6 dev branch with Gio's cfg4 structuriser branch. -- v3: vkd3d-shader/ir: Materialise SSAs to temps before lowering switch instructions. vkd3d-shader/ir: Convert SSAs to temps only if the block of origin does not dominate all uses. vkd3d-shader/spirv: Handle uint2 to double bitcast in spirv_compiler_emit_mov(). vkd3d-shader/spirv: Emit a uint result for RESINFO_UINT if the dst register is SSA. vkd3d-shader/ir: Materialise phis to temps in the incoming blocks. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/749

2 5

[PATCH v2 0/4] MR749: vkd3d-shader/ir: Minimise temp usage.
by Conor McCarthy (＠cmccarthy) April 2, 2024

April 2, 2024

Overall this is simpler, results in less verbose SPIR-V code which is easier to debug, and eliminates stuttering issues in Horizon Zero Dawn when run in an SM 6 dev branch with Gio's cfg4 structuriser branch. -- v2: vkd3d-shader/ir: Materialise SSAs to temps before lowering switch instructions. vkd3d-shader/ir: Convert SSAs to temps only if the block of origin does not dominate all uses. vkd3d-shader/spirv: Emit a uint result for RESINFO_UINT if the dst register is SSA. vkd3d-shader/ir: Materialise phis to temps in the incoming blocks. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/749

2 4