May 2024 - Wine-GitLab - list.winehq.org

[PATCH v5 0/2] MR5392: win32u: Avoid writing past allocated memory in peek_message().
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

-- v5: win32u: Avoid leaking previous buffer in get_buffer_space(). win32u: Avoid writing past allocated memory in peek_message(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5392

3 5

[PATCH v5 0/9] MR5329: ddraw: Support multiple devices per ddraw object.
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

Fixes Sim City 3000 Building Architect. -- v5: ddraw/tests: Add tests for multiple devices. ddraw: Support multiple devices per ddraw object. ddraw: Sync wined3d render target in d3d_device_sync_rendertarget(). ddraw: Store wined3d state in d3d_device. wined3d: Factor out wined3d_texture_set_lod() function. ddraw: Don't apply state in ddraw_surface_blt(). ddraw: Store matrix handle in the global table. ddraw: Store surface handles in the global table. ddraw: Store material handles in the global table. https://gitlab.winehq.org/wine/wine/-/merge_requests/5329

5 13

Re: [PATCH v4 0/2] MR5392: win32u: Avoid writing past allocated memory in peek_message().
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

Do we always reallocate to larger size? It is currently reallocated based on the actual message size returned by the server, while buffer_size in peek_message may be bigger (and it is first allocated to 1024 bytes). Granted, I only reproduced the actual memory corruption with Proton, but it seems to me that in this regard the handling is the same. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5392#note_66132

1 0

Re: [PATCH v4 0/2] MR5392: win32u: Avoid writing past allocated memory in peek_message().
by Jacek Caban (＠jacek) May 28, 2024

May 28, 2024

We only reallocate the buffer to larger size, so I don't see how we can write past the allocated memory. Still, we potentially miss some opportunities to reuse the buffer, so better tracking of the size seems good to me, but the commit message could be adjusted. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5392#note_66130

1 0

[PATCH 0/1] MR5403: wintypes: Report some API contracts as present in...
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

wintypes: Report some API contracts as present in api_information_statics_IsApiContractPresentByMajor(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5403

3 2

Re: [PATCH v4 0/2] MR5392: win32u: Avoid writing past allocated memory in peek_message().
by Jacek Caban (＠jacek) May 28, 2024

May 28, 2024

Jacek Caban (@jacek) commented about dlls/win32u/message.c: > } > > /* make sure that there is space for 'size' bytes in buffer, growing it if needed */ > -static inline void *get_buffer_space( void **buffer, size_t size, size_t prev_size ) > +static inline void *get_buffer_space( void **buffer, size_t size, size_t *prev_size ) This is no longer "prev", `buffer_size` would be a better name after this change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5392#note_66129

1 0

Re: [PATCH v4 0/2] MR5392: win32u: Avoid writing past allocated memory in peek_message().
by Jacek Caban (＠jacek) May 28, 2024

May 28, 2024

Jacek Caban (@jacek) commented about dlls/win32u/message.c: > { > if (*prev_size < size) > { > - *buffer = malloc( size ); > + *buffer = realloc( *buffer, size ); This leaks on error, we could leave the buffer unchanged in that case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5392#note_66128

1 0

Re: [PATCH v2 0/1] MR5402: wmic.exe: Support interactive mode and piped commands
by Hans Leidekker (＠hans) May 28, 2024

May 28, 2024

Creating a new process is inefficient and also visible to applications. You don't need to duplicate the code, it can be factored out in a couple of handlers used in both command line and interactive mode. In interactive mode you'd run a loop that accepts commands and executes them, until you hit 'quit' or 'exit'. wmic not handling spaces in the property list (unless quoted) is a bug, but you should be able to reuse process_property_list(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5402#note_66122

1 0

[PATCH 0/1] MR5402: Draft: wmic.exe: Support interactive mode and piped commands
by Louis Lenders (＠xe) May 28, 2024

May 28, 2024

See also https://bugs.winehq.org/show_bug.cgi?id=56361 This patch makes piped commands work like for example "echo os get version|wmic" or "type file.txt | wmic" where file.txt contains some commands. (probably used by program in aforementioned bugreport) Also support interactive mode (wine wmic.exe) Marked for now as draft. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5402

4 10

[PATCH v5 0/1] MR5385: winebus: ignore udev events of devices which do not have devnodes
by Tuomas Räsänen May 28, 2024

May 28, 2024

Udev monitor monitors the whole input subsystem, but not all devices in the input subsystem have devnodes associated to them. This MR makes the event processing ignore such devices. All device handling assumes devices have devnodes, so here we just simply ignore all devices which do not have one. They are irrelevant. Previously, udev bus thread aborted when an event for a device without a devnode was processed: ``` 10111.330:0068:0084:trace:hid:process_monitor_event Received action "remove" for udev device (null) 10111.330:0068:0084:warn:hid:bus_main_thread L"UDEV" bus wait returned status 0xc0000005 ``` Just plugging in and out a normal mouse was enough cause this. This was because root input devices (which do not have devnodes) were handled too and `find_device_from_devnode()` choked on NULL argument. -- v5: winebus: ignore udev events of devices which do not have devnodes https://gitlab.winehq.org/wine/wine/-/merge_requests/5385

2 4