May 2024 - Wine-GitLab - list.winehq.org

[PATCH v19 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) June 1, 2024

June 1, 2024

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v19: [PATCH] msvcrt: Fix FILE in ucrt which incorrect layout https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 2

[PATCH v17 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) May 31, 2024

May 31, 2024

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v17: [PATCH] msvcrt: Fix FILE in ucrt which incorrect layout https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 3

[PATCH v16 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) May 31, 2024

May 31, 2024

UCRT's FILE struct and fd struct have different layouts, and their locks are different. Implementation in Wine does not match UCRT in Windows, causing ABI issues. see: https://bugs.winehq.org/show_bug.cgi?id=53960 -- v16: [PATCH] msvcrt: Fix FILE in ucrt which incorrect layout https://gitlab.winehq.org/wine/wine/-/merge_requests/5752

3 2

[PATCH v5 0/6] MR5744: winegstreamer: Fix various Cinepak issues
by Alfred Agrell (＠Alcaro) May 31, 2024

May 31, 2024

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56698 -- v5: quartz: Allow concurrent calls to AVI decoder qc_Notify and Receive. https://gitlab.winehq.org/wine/wine/-/merge_requests/5744

4 9

Re: [PATCH v15 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) May 31, 2024

May 31, 2024

On Fri May 31 21:05:42 2024 +0000, Alex Henrie wrote: > Thanks for the patch! Reading and following the instructions at > https://wiki.winehq.org/Submitting_Patches will improve the chances of > it being accepted. > Please use your real name in the Git commit, for example: > ``` > git config --global user.name "Your Name" > git commit --amend --reset-author > git push --force > ``` > Also, drop "See Bug 53960" and "This patch fixes that" from the commit > message, wrap the paragraph of explanation to 72 characters per line, > and add a new line `Wine-Bug: > https://bugs.winehq.org/show_bug.cgi?id=53960` at the end of the commit message. Done :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_71998

1 0

Re: [PATCH v13 0/1] MR5752: msvcrt: [PR53960] Fix ucrt has different struct layout than msvcrt
by cqwrteur (＠trcrsired) May 31, 2024

May 31, 2024

On Fri May 31 20:58:25 2024 +0000, Piotr Caban wrote: > There's lots of changes that look suspicious, please start with adding > some tests. Hi, Piotr Caban. I think the original tests should work here. What kind of extra tests do you need me to test? Does msvcrt/tests/file.c provide tests for both msvcrt and ucrt? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5752#note_71995

1 0

Re: [PATCH v2 0/1] MR5762: user32/tests: Fix ok_sequence succeeding in todo block not giving a test failure - approved
by Alexandre Julliard (＠julliard) May 31, 2024

May 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5762

1 0

Re: [PATCH v4 0/7] MR5754: server: Improve raw input event handling. - approved
by Alexandre Julliard (＠julliard) May 31, 2024

May 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5754

1 0

Re: [PATCH v2 0/3] MR5767: Dump some more minidump information. - approved
by Alexandre Julliard (＠julliard) May 31, 2024

May 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5767

1 0

Re: [PATCH v3 0/7] MR5766: mshtml: Unify window objects IDispatchEx implementation. - approved
by Alexandre Julliard (＠julliard) May 31, 2024

May 31, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5766

1 0