May 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v3 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > If you don't want to go through all the hassle, but still want to go "in > the right direction," please read my first comment. How's this? I don't think I need to translate the the SID itself -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71426

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > The `TOKEN_MANDATORY_LABEL` structure pointed by `ptr`, with length > `len`. This is documented in https://learn.microsoft.com/en-us/windows/win32/api/winnt/ne-winnt-token_in…. > You need to define both `TOKEN_MANDATORY_LEVEL32` (with ULONG in place > of pointers) and `TOKEB_MANDATORY_LABEL` (with actual pointers). > Also, don't assume `ptr` is not "used." Maybe *right now,* but ntdll and > wow64 are still separate components that can get out of sync without tests. If you don't want to go through all the hassle, but still want to go "in the right direction," please read my first comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71423

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Fabian Maurer wrote: > @iamahuman There is no parameters used so what should I translate? The `TOKEN_MANDATORY_LABEL` structure pointed by `ptr`, with length `len`. This is documented in https://learn.microsoft.com/en-us/windows/win32/api/winnt/ne-winnt-token_in…. You need to define both `TOKEN_MANDATORY_LEVEL32` (with ULONG in place of pointers) and `TOKEB_MANDATORY_LABEL` (with actual pointers). Also, don't assume `ptr` is not "used." Maybe *right now,* but ntdll and wow64 are still separate components that can get out of sync without tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71422

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > @DarkShadow44 you also have to translate 32bit struct parameter to 64bit > before passing to native. @iamahuman There is no parameters used so what should I translate? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71421

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Fabian Maurer wrote: > Alright, updated @DarkShadow44 you also have to translate 32bit struct parameter to 64bit before passing to native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71414

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon May 28, 2024

May 28, 2024

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > struct location where; > unsigned int ignore : 1; > unsigned int defined : 1; > + unsigned int defined_in_import : 1; What about decoupling this from the definition status? Something like `is_imported`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71400

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon May 28, 2024

May 28, 2024

Rémi Bernon (@rbernon) commented about tools/widl/typetree.c: > error_loc("type %s already defined at %s:%d\n", type->name, type->where.input_name, type->where.first_line ); > > type->defined = TRUE; > + init_location(&type->where, NULL, NULL); It would be better to pass the explicit token location from the parser instead of relying on the implicit global last location. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71399

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon May 28, 2024

May 28, 2024

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > > struct location where; > > - unsigned int declonly : 1; > + /* Should we define the UDT in this var, when writing a header? */ > + bool define; This is the first and only use of `bool` in widl. Later, you're also introducing a new `unsigned int :1` field elsewhere. I think something like `is_definition` is also more appropriate for an object property. Same below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71398

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon May 28, 2024

May 28, 2024

Rémi Bernon (@rbernon) commented about tools/widl/parser.y: > tVOID { $$ = type_new_void(); } > | base_type { $$ = $1; } > | enumdef { $$ = $1; } > - | tENUM aIDENTIFIER { $$ = type_new_enum($2, current_namespace, FALSE, NULL); } > + | tENUM typename { $$ = type_new_enum($2, current_namespace, FALSE, NULL); } > | structdef { $$ = $1; } > - | tSTRUCT aIDENTIFIER { $$ = type_new_struct($2, current_namespace, FALSE, NULL); } > + | tSTRUCT typename { $$ = type_new_struct($2, current_namespace, FALSE, NULL); } > | uniondef { $$ = $1; } > - | tUNION aIDENTIFIER { $$ = type_new_nonencapsulated_union($2, current_namespace, FALSE, NULL); } > + | tUNION typename { $$ = type_new_nonencapsulated_union($2, current_namespace, FALSE, NULL); } > | tSAFEARRAY '(' type ')' { $$ = make_safearray($3); } > | aKNOWNTYPE { $$ = find_type_or_error(current_namespace, $1); } > ; As you're changing tabs into space, could you fix them in the entire `unqualified_type` rule? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71397

1 0

Re: [PATCH 0/1] MR5720: wineps.drv: Only merge dmDefaultSource member of devmodes when a slot is found.
by Huw Davies (＠huw) May 28, 2024

May 28, 2024

We'll want to keep both copies of `merge_devmode()` in sync, so please combine these two commits into one. Also, the subject of the commit message seems to have word-wrapped - please keep it as a single line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5720#note_71393

1 0