May 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/4] MR5667: winegstreamer: Use GstCaps for wg_parser internal formats.
by Elizabeth Figura (＠zfigura) May 28, 2024

May 28, 2024

> I'm sorry but I've wasted enough time on this. I believe I'm still leaving more than enough time to give some feedback, either commenting on the code or even rejecting the changes for whatever reason you might find appropriate. I'm sorry for not reviewing I find it very difficult to want to review promptly when my review is invariably met with argument, insistence that there is only one correct way to do things, and inability or unwillingness to view things from my perspective. Despite this, I am sorry, and I will try to renew my efforts to review better. If you wish to have me removed as maintainer of winegstreamer, please propose that directly, rather than abusing GitLab to get your patches committed. As far as comment on this patch goes, I'm sorry if this is not quite as baked as I'd like it to be, but: * Renaming "preferred" to "current" is certainly true as far as the functionality of the code is, but it goes against its intent. The point of the "preferred" format is that it should be the one that does not require videoconvert, and therefore offers the best latency. (I know you come at things with a Media Foundation perspective, where the format is pretty much always specified by the application, but for DirectShow it's quite common to plug in a file and autoplug system components up to and including the renderer, so using GStreamer's preferred format is often perfectly feasible.) Hence I would rather see the code fixed so that the "preferred" caps remains what it is, and is not updated. * From what I've understood, getting rid of wg_format by itself does not save that many LoC. I'm still not convinced that it's a desirable change to make. I've already told you my intentions for wg_format, and despite the fact that you dismissed them as false, claiming it's an ad-hoc struct, I still believe that it's a desirable IR. I'm not convinced that the tradeoffs that you're trying to make are good ones. I'm not convinced they're *not*, either, which is part of why I hadn't said anything yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5667#note_71430

1 0

Re: [PATCH 0/2] MR5734: mf: Implement audio capture device enumeration in MFEnumDeviceSources().
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

Squad depends on that to properly fill audio capture device list for voice chat and handle capture device name change. The game uses mmdevapi objects for actual capturing so that fully works with this implementation (which is yet missing the actual media source implementation). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5734#note_71429

1 0

Re: [PATCH v3 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > If you don't want to go through all the hassle, but still want to go "in > the right direction," please read my first comment. How's this? I don't think I need to translate the the SID itself -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71426

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > The `TOKEN_MANDATORY_LABEL` structure pointed by `ptr`, with length > `len`. This is documented in https://learn.microsoft.com/en-us/windows/win32/api/winnt/ne-winnt-token_in…. > You need to define both `TOKEN_MANDATORY_LEVEL32` (with ULONG in place > of pointers) and `TOKEB_MANDATORY_LABEL` (with actual pointers). > Also, don't assume `ptr` is not "used." Maybe *right now,* but ntdll and > wow64 are still separate components that can get out of sync without tests. If you don't want to go through all the hassle, but still want to go "in the right direction," please read my first comment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71423

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Fabian Maurer wrote: > @iamahuman There is no parameters used so what should I translate? The `TOKEN_MANDATORY_LABEL` structure pointed by `ptr`, with length `len`. This is documented in https://learn.microsoft.com/en-us/windows/win32/api/winnt/ne-winnt-token_in…. You need to define both `TOKEN_MANDATORY_LEVEL32` (with ULONG in place of pointers) and `TOKEB_MANDATORY_LABEL` (with actual pointers). Also, don't assume `ptr` is not "used." Maybe *right now,* but ntdll and wow64 are still separate components that can get out of sync without tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71422

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Fabian Maurer (＠DarkShadow44) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Jinoh Kang wrote: > @DarkShadow44 you also have to translate 32bit struct parameter to 64bit > before passing to native. @iamahuman There is no parameters used so what should I translate? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71421

1 0

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) May 28, 2024

May 28, 2024

On Mon May 27 23:57:31 2024 +0000, Fabian Maurer wrote: > Alright, updated @DarkShadow44 you also have to translate 32bit struct parameter to 64bit before passing to native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71414

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon May 28, 2024

May 28, 2024

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > struct location where; > unsigned int ignore : 1; > unsigned int defined : 1; > + unsigned int defined_in_import : 1; What about decoupling this from the definition status? Something like `is_imported`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71400

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon May 28, 2024

May 28, 2024

Rémi Bernon (@rbernon) commented about tools/widl/typetree.c: > error_loc("type %s already defined at %s:%d\n", type->name, type->where.input_name, type->where.first_line ); > > type->defined = TRUE; > + init_location(&type->where, NULL, NULL); It would be better to pass the explicit token location from the parser instead of relying on the implicit global last location. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71399

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon May 28, 2024

May 28, 2024

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > > struct location where; > > - unsigned int declonly : 1; > + /* Should we define the UDT in this var, when writing a header? */ > + bool define; This is the first and only use of `bool` in widl. Later, you're also introducing a new `unsigned int :1` field elsewhere. I think something like `is_definition` is also more appropriate for an object property. Same below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71398

1 0