May 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) May 28, 2024

May 28, 2024

On Tue May 21 09:53:24 2024 +0000, eric pouech wrote: > to be pedantic, native only allows one timeout value and prints error > when two are given using strtol would be better and save you the str_is_number helper -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71008

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) May 28, 2024

May 28, 2024

eric pouech (@epo) commented about programs/timeout/timeout_main.c: > + > + do > + { > + ticks_remaining = end_ticks - GetTickCount64(); > + > + wait_millis = ticks_remaining; > + if (wait_millis > 1000) > + wait_millis = 1000; > + > + printf("\r"); > + pad_number(padded_timeout, (int)roundf(ticks_remaining / 1000.), digits); > + RPRINTF_VA(STRING_WAITING_FOR_SECONDS, padded_timeout); > + > + if (!nobreak) > + { > + if (!printed_action_key) I'd rather see this outside the do/while loop (and moreover, the second count down shall be printed after this message) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71007

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) May 28, 2024

May 28, 2024

why do you need float operations here? (int)(ticks_remaining / 1000) should do -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71006

1 0

Re: [PATCH v5 0/1] MR5691: timeout: Add new program.
by eric pouech (＠epo) May 28, 2024

May 28, 2024

actually, timeout_main.c in a bit redundant as a filename (timeout.c or main.c should be enough) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71005

1 0

[PATCH v3 0/4] MR5674: quartz: AVI decompressor fixes.
by Anton Baskanov (＠baskanov) May 28, 2024

May 28, 2024

-- v3: quartz: Hold the streaming lock while calling ICDecompressEnd. quartz: Use the correct stride when calculating image size in AVIDec. quartz: Get output format from source, not sink in AVIDec. quartz/tests: Use unaligned width in AVIDec tests to expose incorrect stride calculation. https://gitlab.winehq.org/wine/wine/-/merge_requests/5674

3 7

[PATCH 0/1] MR5695: odbc32: Allow null handle for SQLSetEnvAttr.
by Daniel Lehman (＠dlehman25) May 28, 2024

May 28, 2024

can be null for SQL_ATTR_CONNECTION_POOLING -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5695

3 2

Re: [PATCH v4 0/1] MR5691: timeout: Add new program.
by Myah Caron (＠qsniyg) May 28, 2024

May 28, 2024

On Mon May 20 21:34:08 2024 +0000, eric pouech wrote: > agreed (except perhaps for the padding of the N seconds... not that it > would make sense to replicate the padding, but I'm not sure the printf > has a trailing whitespace so that it erases the last visible char when > the width of N is reduced) I've added the padding, and replicated the behavior of the native program by only updating the "Waiting for N seconds" text. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_70991

1 0

Re: [PATCH v2 0/2] MR5662: oleaut32: Handle cases where invoking a get-only property with... - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5662

1 0

Re: [PATCH v2 0/1] MR5693: ntdll: Don't warn on macOS and FreeBSD when xattr doesn't exist. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5693

1 0

Re: [PATCH v3 0/1] MR5664: opengl32: Remove the wglDescribePixelFormat driver entry point. - approved
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5664

1 0