May 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/3] MR5594: winemac.drv: Some display mode fixes
by Tim Clem (＠tclem) May 28, 2024

May 28, 2024

Fixing up some issues seen with display modes reported from the Apple Studio Display: - It has some pairs of modes that differ only in whether they are "usable for desktop." Switching to one of the modes that isn't results in an error. All other things being equal, we should prefer modes that are "usable for desktop" over those that aren't. - display_get_modes was returning multiple identical DEVMODEs. This is because we consider the kDisplayModeValidFlag and kDisplayModeSafeFlag values as making a display mode unique (and thus not comparable to other modes with the same resolution). Like above, the Studio Display has mode pairs that are identical except that one is "unsafe." We should compare modes with the same resolution, regardless of the safe and valid flags, and prefer safe and valid ones over the alternatives. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5594

3 4

[PATCH v4 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu May 28, 2024

May 28, 2024

-- v4: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

2 13

Re: [PATCH v2 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice().
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

Oh, it is probably this one: > xaudio2_8 > xaudio2.c:865: Test failed: CreateSubmixVoice failed: 88960001 > 0a44:xaudio2: unhandled exception c0000005 at 00007FF795004307 Thanks, I will take a look now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588#note_70415

1 0

Re: [PATCH v2 0/1] MR5588: xaudio2: Use FAudioVoice_DestroyVoiceSafeEXT() in destroy_voice().
by Alexandre Julliard (＠julliard) May 28, 2024

May 28, 2024

This is breaking the tests on Windows, could you please have a look? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5588#note_70414

1 0

[PATCH 0/6] MR5626: mfreadwrite: Support MFVideoFormat_ABGR32 output.
by Rémi Bernon May 28, 2024

May 28, 2024

This format is used by many Unity games, with D3D-enabled source reader. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5626

3 9

[PATCH 0/6] MR5642: mshtml: Use DISPEX_IDISPATCH_IMPL macro in more places.
by Jacek Caban (＠jacek) May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5642

4 9

[PATCH 0/1] MR5633: win32u: Fallback to default script if vert/vrt2 is not found.
by Akihiro Sagawa (＠sgwaki) May 28, 2024

May 28, 2024

Also changed to use `DFLT` instead of `dflt` as the default script tag. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56658 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5633

4 4

[PATCH 0/1] MR5637: dinput: Don't include every version of DirectInputCreate in every DLL.
by Alex Henrie (＠alexhenrie) May 28, 2024

May 28, 2024

DirectInputCreate(A|W|Ex) is only needed in dinput.dll, and DirectInput8Create is only needed in dinput8.dll. Excluding the unnecessary functions reduces the size of each DLL by about 4 KB. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5637

4 3

[PATCH v2 0/8] MR5640: odbc32: Add Wow64 thunks
by Hans Leidekker (＠hans) May 28, 2024

May 28, 2024

-- v2: odbc32/tests: Add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/5640

3 10

[PATCH v2 0/2] MR5625: Fixes for GCC 14 warnings (in winedump)
by Aida Jonikienė May 28, 2024

May 28, 2024

The `-Wstringop-overread` fix feels a bit questionable (so I'll add Eric as a reviewer to clarify the MSC structs details) -- v2: winedump: Fail on NULL funcs in dump_dir_exceptions(). winedump: Use offsetof() for string position calculations. https://gitlab.winehq.org/wine/wine/-/merge_requests/5625

4 7