May 2024 - Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/4] MR5600: Second part of cmd engine rewrite.
by Brendan Shanks (＠bshanks) May 28, 2024

May 28, 2024

Brendan Shanks (@bshanks) commented about programs/cmd/wcmd.h: > void WCMD_execute (const WCHAR *orig_command, const WCHAR *redirects, > CMD_LIST **cmdList, BOOL retrycall); > > -void *xalloc(size_t) __WINE_ALLOC_SIZE(1) __WINE_DEALLOC(free) __WINE_MALLOC; > +void *xrealloc(void *, size_t) __WINE_ALLOC_SIZE(2) __WINE_DEALLOC(free) __WINE_MALLOC; `realloc` should not use `__WINE_MALLOC`/`attribute((malloc))`. From [the docs](https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html): "functions like realloc do not have this property, as they may return pointers to storage containing pointers to existing objects" -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5600#note_70159

1 0

[PATCH v21 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) May 28, 2024

May 28, 2024

-- v21: rtworkq: Release cancelled work items. mfplat/tests: Validate MFCancelWorkItem releases the callback. rtworkq: Avoid use-after-free. https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

4 7

[PATCH 0/11] MR5614: mfplat: Test and support FORMAT_MPEGVideo and FORMAT_MPEG2Video.
by Rémi Bernon May 28, 2024

May 28, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5614

2 12

[PATCH 0/5] MR5601: Numpad key handling in winewayland.drv (and more generally for drivers using KBDTABLES)
by Alexandros Frantzis (＠afrantzis) May 28, 2024

May 28, 2024

This MR improves the handling of numpad keys for drivers using KBDTABLES (only the Wayland driver at this point). It achieves this by: 1. Allowing drivers to send only the scancode in keyboard events, with win32u performing the scan->vkey mapping internally. A nice side effect of this change is that it fixes a few user32 input test TODOs. 2. Enhancing wineserver to read extended KBD vkey attributes and perform numpad key mapping depending on modifier state. 3. Providing default VK_NUMPAD* -> WCHAR mappings in win32u. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5601

4 8

[PATCH v2 0/1] MR5603: win32u: Update last message time in NtUserGetRawInputBuffer().
by Paul Gofman (＠gofman) May 28, 2024

May 28, 2024

-- v2: win32u: Update last message time in NtUserGetRawInputBuffer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5603

4 3

[PATCH v2 0/2] MR5611: winegstreamer: Recognize MFAudioFormat_MPEG and MFAudioFormat_MP3.
by Anton Baskanov (＠baskanov) May 28, 2024

May 28, 2024

Fixes: 067d4f047247b39a5866c1d7b22b5f16b5187d5b -- v2: winegstreamer: Add missing format fields to WMA support check. https://gitlab.winehq.org/wine/wine/-/merge_requests/5611

2 3

[PATCH v2 0/1] MR5608: winex11.drv: Increment mode_idx in xrandr10_get_modes.
by Brendan McGrath (＠redmcg) May 28, 2024

May 28, 2024

This fixes a regression introduced in: f74900ad1a580eda8fd4923cbd4881b42b042733 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56655 -- v2: winex11.drv: Increment mode_idx in {xrandr10,xf86vm}_get_modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/5608

3 3

Re: [PATCH v2 0/8] MR5607: Link strmbase modules to msvcrt instead of ucrtbase.
by Elizabeth Figura (＠zfigura) May 28, 2024

May 28, 2024

I thought some Windows modules are built against ucrtbase? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5607#note_70072

1 0

Re: [PATCH v2 0/8] MR5607: Link strmbase modules to msvcrt instead of ucrtbase.
by Nikolay Sivov (＠nsivov) May 28, 2024

May 28, 2024

Not directly related to this MR, but maybe we could switch all modules to msvcrt, like Windows does it? I'm probably missing a point as to why we deliberately differ in this aspect. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5607#note_70068

1 0

[PATCH v2 0/1] MR5599: msvcrt/tests: Add tests for _wcsicmp_l.
by Daniel Lehman (＠dlehman25) May 28, 2024

May 28, 2024

-- v2: msvcrt/tests: Add tests for _wcsicmp_l. https://gitlab.winehq.org/wine/wine/-/merge_requests/5599

3 3